[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. This needs a test. You can either write a python one as the ones in `test/testcases` or a lit-style based as the ones in `lit/`. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp updated this revision to Diff 81. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 Files: lldb/include/lldb/Utility/JSON.h lldb/source/Utility/JSON.cpp lldb/source/Utility/StructuredData.cpp lldb/tools/debugserver/source/JSON

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp created this revision. tetsuo-cpp added a reviewer: xbolva00. tetsuo-cpp added projects: LLVM, LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=39405 alexc@kitty:~/work/wiredtiger/build_posix$ cat breakpoint.json [{"Breakpo

[Lldb-commits] [PATCH] D68174: Allow private-state-thread to call SB API's that take the TargetAPI mutex

jingham added a comment. Note, a better way to do this would be to have some kind of "API/Runlock baton" that could get handed off from the thread that initiated the continue to the private state thread, then handed back when the process stops and returns control to the SB API that initiated th

[Lldb-commits] [PATCH] D68174: Allow private-state-thread to call SB API's that take the TargetAPI mutex

jingham created this revision. jingham added a reviewer: clayborg. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. When we do synchronous process execution in lldb, the call that restarted the target will generally have acquired first the TargetAPI lock, and th

[Lldb-commits] [PATCH] D68173: Report a useful error when a the user mistypes a class name in making a script ThreadPlan

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL373135: Give an error when StepUsingScriptedThreadPlan is passed a bad classname. (authored by jingham, committed by ). He

[Lldb-commits] [lldb] r373135 - Give an error when StepUsingScriptedThreadPlan is passed a bad classname.

Author: jingham Date: Fri Sep 27 17:53:45 2019 New Revision: 373135 URL: http://llvm.org/viewvc/llvm-project?rev=373135&view=rev Log: Give an error when StepUsingScriptedThreadPlan is passed a bad classname. Differential Revision: https://reviews.llvm.org/D68173 Modified: lldb/trunk/include/

[Lldb-commits] [PATCH] D68173: Report a useful error when a the user mistypes a class name in making a script ThreadPlan

jingham created this revision. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. Before this patch if you used SBThread.StepUsingScriptedThreadPlan but mistyped the Python ThreadPlan class name, you wouldn't get any error, and a bogus ThreadPlan would get

[Lldb-commits] [lldb] r373134 - [Core] Remove unused dependency on clangAST

Author: xiaobai Date: Fri Sep 27 17:27:24 2019 New Revision: 373134 URL: http://llvm.org/viewvc/llvm-project?rev=373134&view=rev Log: [Core] Remove unused dependency on clangAST Modified: lldb/trunk/source/Core/CMakeLists.txt lldb/trunk/source/Core/DumpDataExtractor.cpp Modified: lldb/tr

[Lldb-commits] [PATCH] D68171: Remove unused "append" parameter from FindTypes API

aprantl created this revision. aprantl added reviewers: labath, friss, JDevlieghere, jasonmolenda. I noticed that SymbolFileDWARFDebugMap::FindTypes was implementing it incorrectly (passing append=false in a for-loop to recursive calls to FindTypes would yield only the very last set of results),

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm added a comment. > (substituting llvm-mc for as and ld.lld for linker). I was not able to figure out how to generate the object file with llvm-mc correctly. I've tried a few variations of the triple (e.g.: `armv7-eabi`) but I never end up with the same code that I have in the assembly:

[Lldb-commits] [PATCH] D68169: Fix a regression in FindTypes

aprantl created this revision. aprantl added reviewers: friss, JDevlieghere, jasonmolenda. Herald added a project: LLDB. In r368345 I accidentally introduced a regression that would over-report the number of matches found by FIndTypes if the DeclContext Filter was hit. This patch fixes this issu

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 64. lawrence_danna added a comment. rebased, removed duplicate test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h l

[Lldb-commits] [PATCH] D68140: [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in ExternalASTMerger

shafik added inline comments. Comment at: clang/include/clang/AST/ExternalASTMerger.h:92 ImporterTarget Target; + std::shared_ptr SharedState; Can you add a comment explaining what this is and why we need it and how it relates to the `ASTImpoter`. It is n

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

shafik added a comment. In D68130#1686549 , @jingham wrote: > > IIRC, it is because we can't count on which artificial functions get > generated in the debug information in any given CU. It depends on what gets > used. If we write artificial func

[Lldb-commits] [PATCH] D68156: [debugserver] Add --version/-V command line option to debugserver.

aprantl added a comment. Good catch! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68156/new/ https://reviews.llvm.org/D68156 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

jingham added a comment. In D68130#1686530 , @shafik wrote: > So if I look at `ClangASTContext::AddMethodToCXXRecordType(...)` it has the > following: > > if (is_artificial) > return nullptr; // skip everything artificial > > > but why? if I look

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. File::Clear() is an ugly function. It's only used in one place, which is the swig typemaps for FILE*. This patch refactors and renames that function to make it

[Lldb-commits] [PATCH] D68156: [debugserver] Add --version/-V command line option to debugserver.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373127: [debugserver] Add --version/-V command line option to debugserver. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[Lldb-commits] [lldb] r373127 - [debugserver] Add --version/-V command line option to debugserver.

Author: jdevlieghere Date: Fri Sep 27 14:26:44 2019 New Revision: 373127 URL: http://llvm.org/viewvc/llvm-project?rev=373127&view=rev Log: [debugserver] Add --version/-V command line option to debugserver. When not running under a TTY the output is buffered and not flushed before debugserver exit

[Lldb-commits] [PATCH] D68156: [debugserver] Add --version/-V command line option to debugserver.

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Awesome. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68156/new/ https://reviews.llvm.org/D68156 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

shafik added a comment. So if I look at `ClangASTContext::AddMethodToCXXRecordType(...)` it has the following: if (is_artificial) return nullptr; // skip everything artificial but why? if I look at the godbolt w/ an AST dump it is not creating as a global f

[Lldb-commits] [PATCH] D68156: [debugserver] Add --version/-V command line option to debugserver.

JDevlieghere updated this revision to Diff 46. JDevlieghere retitled this revision from "[debugserver] Don't use RNBLog for printing the version" to "[debugserver] Add --version/-V command line option to debugserver.". JDevlieghere edited the summary of this revision. CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D68152: refactor: move IOObject::m_should_close_fd into subclasses

This revision was automatically updated to reflect the committed changes. Closed by commit rG117512715d66: refactor: move IOObject::m_should_close_fd into subclasses (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68152/ne

[Lldb-commits] [lldb] r373126 - refactor: move IOObject::m_should_close_fd into subclasses

Author: lawrence_danna Date: Fri Sep 27 13:43:50 2019 New Revision: 373126 URL: http://llvm.org/viewvc/llvm-project?rev=373126&view=rev Log: refactor: move IOObject::m_should_close_fd into subclasses Summary: m_should_close_fd doesn't need to be in IOObject. It will be useful for my next change

[Lldb-commits] [lldb] r373124 - [Reproducer] Use // in the unit tests

Author: jdevlieghere Date: Fri Sep 27 13:35:55 2019 New Revision: 373124 URL: http://llvm.org/viewvc/llvm-project?rev=373124&view=rev Log: [Reproducer] Use // in the unit tests This should be a valid absolute path on both POSIX and Windows. Modified: lldb/trunk/unittests/Utility/ReproducerTe

[Lldb-commits] [PATCH] D68156: [debugserver] Don't use RNBLog for printing the version

jasonmolenda added a comment. Hm, if the goal is to get -version (an unrecognized cmd line option) to explicitly print to stderr, don't we want to change the lines in show_usage_and_exit? I think this change would result in us not getting the version string in console logs for normal debug ses

[Lldb-commits] [PATCH] D68156: [debugserver] Don't use RNBLog for printing the version

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: LLDB. When not running under a TTY the output is buffered and not flushed before debugserver exits. Repository: rLLDB LLDB https://reviews.llvm.org/D68156 Files: lldb/tools/debugserver/

[Lldb-commits] [lldb] r373114 - [Reproducer] Update the unit tests to specify the path style.

Author: jdevlieghere Date: Fri Sep 27 12:12:18 2019 New Revision: 373114 URL: http://llvm.org/viewvc/llvm-project?rev=373114&view=rev Log: [Reproducer] Update the unit tests to specify the path style. The unit tests started failing on Windows after my recent patch that ensured we always deal with

[Lldb-commits] [PATCH] D68096: ProcessMinidump: inject SIGSTOP on Linux if no thread has a signal

JosephTremoulet updated this revision to Diff 25. JosephTremoulet added a comment. - Use accessor for m_unix_signals_sp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68096/new/ https://reviews.llvm.org/D68096 Files: lldb/source/Plugins/Proce

[Lldb-commits] [PATCH] D68096: ProcessMinidump: inject SIGSTOP on Linux if no thread has a signal

JosephTremoulet marked 2 inline comments as done. JosephTremoulet added inline comments. Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:219-237 + + if (arch.GetTriple().isOSLinux()) { + +SetUnixSignals(UnixSignals::Create(GetArchitecture())); + +if

[Lldb-commits] [lldb] r373112 - [CMake] Depend on clang-tablegen-targets

Author: jdevlieghere Date: Fri Sep 27 12:07:06 2019 New Revision: 373112 URL: http://llvm.org/viewvc/llvm-project?rev=373112&view=rev Log: [CMake] Depend on clang-tablegen-targets The ClangDriverOptions target is not available for standalone builds. Thanks Alex for pointing this out! Modified:

[Lldb-commits] [PATCH] D68096: Add Linux signal support to ProcessMinidump

JosephTremoulet updated this revision to Diff 18. JosephTremoulet added a comment. - Move artificial SIGSTOP injection to RefreshStateAfterStop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68096/new/ https://reviews.llvm.org/D68096 Files: l

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/api/command-return-object/Makefile:1 +MAKE_DSYM := NO + jankratochvil wrote: > labath wrote: > > I'm pretty sure this line is not

[Lldb-commits] [lldb] r373110 - Revert: [lldb] [testsuite] Remove redundant MAKE_DSYM := NO

Author: jankratochvil Date: Fri Sep 27 11:52:34 2019 New Revision: 373110 URL: http://llvm.org/viewvc/llvm-project?rev=373110&view=rev Log: Revert: [lldb] [testsuite] Remove redundant MAKE_DSYM := NO Revert: llvm-svn: 373061 It broke OSX testsuite: https://reviews.llvm.org/D67589#168

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil added a comment. In D67589#1686150 , @shafik wrote: > @jankratochvil it looks like this PR broke the green dragon build: > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/1926/ This PR is not yet checked-in. Let's move this discus

[Lldb-commits] [PATCH] D68152: refactor: move IOObject::m_should_close_fd into subclasses

lawrence_danna created this revision. lawrence_danna added reviewers: labath, JDevlieghere, jasonmolenda. Herald added a project: LLDB. m_should_close_fd doesn't need to be in IOObject. It will be useful for my next change to move it down into File and Socket. Repository: rG LLVM Github Mono

[Lldb-commits] [lldb] r373105 - [CMake] Make Core depend on ClangDriverOptions (NFC)

Author: jdevlieghere Date: Fri Sep 27 10:55:49 2019 New Revision: 373105 URL: http://llvm.org/viewvc/llvm-project?rev=373105&view=rev Log: [CMake] Make Core depend on ClangDriverOptions (NFC) ModuleList.cpp includes clang/Driver/Driver.h which depends on clang/Driver/Options.inc. This patch adds

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm added a comment. > Not everyone has both of these things enabled (particularly having lld is > less common), but they are things that one _can_ enable no matter what is his > host or target architecture, so I am not worried by that. And as tests like > these become more common, I expect

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

vsk added a subscriber: labath. vsk added a comment. Great find. The changes in this patch makes sense to me locally, but I'm having trouble picking up on the context necessary to confidently 'lgtm'. + @JDevlieghere & @labath to get some more experienced people. I'd love to see the big switch i

[Lldb-commits] [lldb] r373102 - [Reproducer] Always use absolute paths for capture & replay.

Author: jdevlieghere Date: Fri Sep 27 10:30:40 2019 New Revision: 373102 URL: http://llvm.org/viewvc/llvm-project?rev=373102&view=rev Log: [Reproducer] Always use absolute paths for capture & replay. The VFS requires files to be have absolute paths. The file collector makes paths relative to the

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

shafik added a comment. @jankratochvil it looks like this PR broke the green dragon build: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/1926/ The specific test that is failing is `TestFunctionStarts.py` see the more detailed log here: http://lab.llvm.org:8080/green/view/LLDB/job/lld

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

wallace abandoned this revision. wallace added a comment. This diff has created a good discussion and I have a better idea of what we should do to move forward:) - I figured out a way to improve the existing process fetching functionality of the lldb-server so that it can show all the nice info

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. @labath, OK sets are now constructors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222190. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. rebased, and converted Set* methods into constructors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/

[Lldb-commits] [PATCH] D68096: Add Linux signal support to ProcessMinidump

JosephTremoulet marked an inline comment as done. JosephTremoulet added a comment. > Fortunately, for the functionality you're testing, I don't think you really > need the executable file, so you can just ignore the elf bit and test with a > plain `lldb -c foo.dmp` (obviously, you won't get the

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373090: remove File::SetStream(), make new files instead. (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 222170. lawrence_danna added a comment. updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 Files: lldb/include/lldb/Core/Debugger.h lldb/

[Lldb-commits] [PATCH] D68140: [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in ExternalASTMerger

teemperor created this revision. teemperor added reviewers: martong, shafik. Herald added subscribers: lldb-commits, JDevlieghere, christof, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: LLDB. teemperor added a comment. Just putting this up as I don't want to merge that bef

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 222168. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. style fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 Files: ll

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna added a comment. fixed style issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D68140: [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in ExternalASTMerger

teemperor added a comment. Just putting this up as I don't want to merge that before the weekend. Patch itself is obvious. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68140/new/ https://reviews.llvm.org/D68140 _

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 222165. lawrence_danna added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 Files: lldb/include/lldb/Core/Debugger.h lldb/include/ll

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

teemperor updated this revision to Diff 222162. teemperor added a comment. - Document dedicated test a bit better. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68130/new/ https://reviews.llvm.org/D68130 Files: lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. yay Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68134/new/ https://reviews.llvm.org/D68134 ___ lldb-commits

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, rnk, compnerd. Herald added subscribers: JDevlieghere, erik.pilkington. Herald added a project: LLDB. I'm unsure if there's any lldb testcase which exercise this directly (I didn't find any); such testcases could be made

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

teemperor updated this revision to Diff 222140. teemperor edited the summary of this revision. teemperor added a comment. - Enabled test on Linux. That's only failing on my box (Thanks Pavel) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68130/new/ https://reviews.llvm.org/D68130 Files

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

This revision was automatically updated to reflect the committed changes. Closed by commit rL373072: Unwind: Add a stack scanning mechanism to support win32 unwinding (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[Lldb-commits] [lldb] r373072 - Unwind: Add a stack scanning mechanism to support win32 unwinding

Author: labath Date: Fri Sep 27 05:10:06 2019 New Revision: 373072 URL: http://llvm.org/viewvc/llvm-project?rev=373072&view=rev Log: Unwind: Add a stack scanning mechanism to support win32 unwinding Summary: Windows unwinding is weird. The unwind rules do not (always) describe the precise layout

[Lldb-commits] [lldb] r373073 - [lldb/cmake] add lldbCore -> clangDriver dependency

Author: labath Date: Fri Sep 27 05:10:12 2019 New Revision: 373073 URL: http://llvm.org/viewvc/llvm-project?rev=373073&view=rev Log: [lldb/cmake] add lldbCore -> clangDriver dependency ModuleList.cpp includes clang/Driver/Driver.h. Reflect that in the build system. Not having this can cause build

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

teemperor created this revision. teemperor added reviewers: aprantl, vsk. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. When we have a artificial constructor DIE, we currently create from that a global function with the name of that class. That ends up causin

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

labath added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2205 +needle.st_section_name_string = ConstString(symbol_section_sp->GetName()); +if (unique_elf_symbols.find(needle) == unique_elf_symbols.end()) { + symtab->AddSymbo

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

labath updated this revision to Diff 222129. labath added a comment. Offline, @markmentovai pointed out that crashpad does actually produce the MemoryInfoList stream, which means there is a fairly large class of use cases where checking the memory permissions will work correctly. Therefore, I am u

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

jankratochvil added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ELFHeader.h:446 +std::size_t h2 = std::hash()(s.st_name_string.AsCString()); +std::size_t h3 = std::hash()(s.st_section_name_string.AsCString()); +return llvm::hash_combine(h1, h2, h3)

[Lldb-commits] [lldb] r373071 - Disable the empty string check in TestDataFormatterStdString

Author: labath Date: Fri Sep 27 04:39:27 2019 New Revision: 373071 URL: http://llvm.org/viewvc/llvm-project?rev=373071&view=rev Log: Disable the empty string check in TestDataFormatterStdString This check was failing since it was added in r372837. It should be possible to re-enable it once D68010

[Lldb-commits] [lldb] r373069 - Fix some swig warnings

Author: labath Date: Fri Sep 27 04:30:16 2019 New Revision: 373069 URL: http://llvm.org/viewvc/llvm-project?rev=373069&view=rev Log: Fix some swig warnings Previously, these were unseen because the wrapper script would swallow them. This fixes the following types of warnings: - methods being decl

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil updated this revision to Diff 222114. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67589/new/ https://reviews.llvm.org/D67589 Files: lldb/include/lldb/API/SBCommandReturnObject.h lldb/packages/Python/lldbsuite/test/api/command-return-object/Ma

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil marked 2 inline comments as done. jankratochvil added a comment. std: Comment at: lldb/packages/Python/lldbsuite/test/api/command-return-object/Makefile:1 +MAKE_DSYM := NO + labath wrote: > I'm pretty sure this line is not needed. Removed in curr

[Lldb-commits] [lldb] r373061 - [lldb] [testsuite] Remove redundant MAKE_DSYM := NO

Author: jankratochvil Date: Fri Sep 27 02:59:53 2019 New Revision: 373061 URL: http://llvm.org/viewvc/llvm-project?rev=373061&view=rev Log: [lldb] [testsuite] Remove redundant MAKE_DSYM := NO According to a comment by Pavel Labath: https://reviews.llvm.org/D67589#inline-612375 Modified:

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

labath added a comment. I think that being able to debug an android device without needing to first copy&run an lldb-server there would be a great feature, and it's something I've wished for many times. Whether that also means ditching the lldb-server platform process is a more complicated ques

[Lldb-commits] [PATCH] D68096: Add Linux signal support to ProcessMinidump

labath added a comment. The functionality is fine, though I'd hope it can be cleaned up a bit. As for testing, yes, yaml2obj has some problems roundtripping complex minidumps (and elf files). Fortunately, for the functionality you're testing, I don't think you really need the executable file, s

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

labath added a comment. This looks fairly ok to me, but it could use a more explicit test of the symbol uniqueing code. Right, now I believe the two tests you added check that the symbols are _not_ uniqued. (They're also a bit hard to follow due to the whole objcopy business). Could you create

[Lldb-commits] [lldb] r373053 - [lldb] Print an error message for an empty subcommand

Author: teemperor Date: Fri Sep 27 01:49:41 2019 New Revision: 373053 URL: http://llvm.org/viewvc/llvm-project?rev=373053&view=rev Log: [lldb] Print an error message for an empty subcommand Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/multiword-commands/TestMultiWordCo

[Lldb-commits] [lldb] r373051 - [lldb][NFC] Actually test which method we call in TestCallOverriddenMethod

Author: teemperor Date: Fri Sep 27 01:21:08 2019 New Revision: 373051 URL: http://llvm.org/viewvc/llvm-project?rev=373051&view=rev Log: [lldb][NFC] Actually test which method we call in TestCallOverriddenMethod Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/expression/call-over

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good to me Comment at: lldb/source/Commands/CommandObjectGUI.cpp:32-33 +File &input = debugger.GetInputFile(); +if (input.GetIsRealTerminal() && +input.

[Lldb-commits] [lldb] r373050 - [lldb][NFC] Test CommandObjectMultiword functionality

Author: teemperor Date: Fri Sep 27 01:18:38 2019 New Revision: 373050 URL: http://llvm.org/viewvc/llvm-project?rev=373050&view=rev Log: [lldb][NFC] Test CommandObjectMultiword functionality A lot of commands are made up of CommandObjectMultiword with subcommands. CommandObjectMultiword actually h

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

labath added a comment. In D68069#1685146 , @aadsm wrote: > > For the test, what would you say to writing that as a lit test instead > > (testing the address class deduction via the disassemble command you > > mentioned)? > > I was actually keen on this

[Lldb-commits] [PATCH] D68106: Fix a crasher due to an assert when two files have the same UUID but different paths.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, modulo the comment about shadowing. Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:115 + lldb::addr_t GetBaseAddress() const { return m_b

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good to me, but please do give a chance for other to look this over too. Thanks for cleaning this up. In D67589#1684847 , @jankratochvil wr