[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223361. lawrence_danna added a comment. fix typemaps to deal with None correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

wallace updated this revision to Diff 223359. wallace added a comment. added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68312/new/ https://reviews.llvm.org/D68312 Files:

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 223358. wallace added a comment. added a basic python test It was a nice learning experience and fortunately there was no need to add any intrusive code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace added a comment. damn, i overwrote this patch lol Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68422: [DWARFASTParserClang] Factor out structure-like type parsing, NFC

vsk updated this revision to Diff 223357. vsk added a comment. - Remove the `log` parameter from `ParseTypeFromDWARF`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68422/new/ https://reviews.llvm.org/D68422 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223355. lawrence_danna added a comment. python2 const fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 223356. wallace added a comment. added a basic python test It was a nice learning experience and fortunately there was no need to add any intrusive code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm created this revision. aadsm added reviewers: clayborg, labath, wallace, espindola. aadsm added a project: LLDB. This is a redo of D68069 because I reverted it due to some concerns that were now addressed along with the new comments that @labath added. I

[Lldb-commits] [PATCH] D68422: [DWARFASTParserClang] Factor out structure-like type parsing, NFC

vsk added a comment. In D68422#1694147 , @labath wrote: > Looks good to me. Thanks for doing this. Personally, I'd just remove the > `Log` argument from the function argument list, and let the function re-fetch > it if needed. I know we sometimes pass

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. I changed my mind about splitting this into another patch.When I first said that I had in mind a much more extensive rewrite of the PythonDataObjects. I think it's fine now as one patch -- though we should still go back later add Expected<> everywhere in

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223352. lawrence_danna added a comment. comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223351. lawrence_danna added a comment. spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1695069 , @labath wrote: > I agree about the separate patch stuff, but it seems to be that this should > be done before this one. After all, all (most?) of the existing code has > already been DataObject-ized

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223350. lawrence_danna added a comment. better integration with PythonObject Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223346. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://reviews.llvm.org/D68442 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt

[Lldb-commits] [lldb] r373804 - [test] Run TestLaunchWithShellExpand with /bin/sh on POSIX.

Author: jdevlieghere Date: Fri Oct 4 15:21:35 2019 New Revision: 373804 URL: http://llvm.org/viewvc/llvm-project?rev=373804=rev Log: [test] Run TestLaunchWithShellExpand with /bin/sh on POSIX. Now that we do shell expansion on POSIX with the user's shel, this test can potentially fail. This

[Lldb-commits] [lldb] r373795 - [debugserver] Don't link against Cocoa, it's not needed.

Author: davide Date: Fri Oct 4 14:51:35 2019 New Revision: 373795 URL: http://llvm.org/viewvc/llvm-project?rev=373795=rev Log: [debugserver] Don't link against Cocoa, it's not needed. Modified: lldb/trunk/tools/debugserver/source/CMakeLists.txt Modified:

[Lldb-commits] [PATCH] D68071: cmake: Link lldb libraries and tools with libclang-cpp.so when CLANG_LINK_LLVM_DYLIB=ON

tstellar added a comment. In D68071#1695396 , @mgorny wrote: > Would it be bad if I said I like mine more? I'm not a fan of implicit logic, > and relying on specific filenames. No, that's fine. I actually started to implement it the same way as your

[Lldb-commits] [PATCH] D68071: cmake: Link lldb libraries and tools with libclang-cpp.so when CLANG_LINK_LLVM_DYLIB=ON

mgorny added a comment. Would it be bad if I said I like mine more? I'm not a fan of implicit logic, and relying on specific filenames. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68071/new/ https://reviews.llvm.org/D68071

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

tstellar added a comment. What about this patch: it's much more simple, though maybe I missed something: https://reviews.llvm.org/D68071 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68456/new/ https://reviews.llvm.org/D68456

[Lldb-commits] [lldb] r373789 - Expand on the qfProcessInfo documentation, add examples from

Author: jmolenda Date: Fri Oct 4 14:01:52 2019 New Revision: 373789 URL: http://llvm.org/viewvc/llvm-project?rev=373789=rev Log: Expand on the qfProcessInfo documentation, add examples from lldb-gdb-remote.txt and text explaining the no-criteria mode. Modified:

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

dblaikie added inline comments. Comment at: lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:291-295 + EntryIterator Absolute = + getAbsoluteLocations( + SectionedAddress{BaseAddr, SectionedAddress::UndefSection}, + LookupPooledAddress) + .begin();

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil added a comment. Had to disable the testcase on Windows: rL373787 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67589/new/ https://reviews.llvm.org/D67589 ___

[Lldb-commits] [lldb] r373787 - [lldb] [testsuite] Mark TestSBCommandReturnObject as failing on Windows

Author: jankratochvil Date: Fri Oct 4 13:49:44 2019 New Revision: 373787 URL: http://llvm.org/viewvc/llvm-project?rev=373787=rev Log: [lldb] [testsuite] Mark TestSBCommandReturnObject as failing on Windows Filed: testsuite: TestSBCommandReturnObject: object has no attribute 'dylibPath'

[Lldb-commits] [lldb] r355402 - Adds property to force enabling of GDB JIT loader for MacOS

Author: yurydelendik Date: Tue Mar 5 06:23:53 2019 New Revision: 355402 URL: http://llvm.org/viewvc/llvm-project?rev=355402=rev Log: Adds property to force enabling of GDB JIT loader for MacOS Summary: Based on https://gist.github.com/thlorenz/30bf0a3f67b1d97b2945#patching-and-rebuilding The

[Lldb-commits] [lldb] r366647 - [lldb] Fix buildbot build fail caused by r366645

Author: yuanfang Date: Sat Jul 20 17:07:39 2019 New Revision: 366647 URL: http://llvm.org/viewvc/llvm-project?rev=366647=rev Log: [lldb] Fix buildbot build fail caused by r366645 Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified:

[Lldb-commits] [lldb] r355413 - [lldb] Disable some of TestJITLoaderGDB.py tests on Windows

Author: yurydelendik Date: Tue Mar 5 09:09:26 2019 New Revision: 355413 URL: http://llvm.org/viewvc/llvm-project?rev=355413=rev Log: [lldb] Disable some of TestJITLoaderGDB.py tests on Windows The test expect sample executable code be built, but fails on Windows. Review comment

[Lldb-commits] [lldb] r340562 - Fix format string issue introduced in r340548

Author: waltl Date: Thu Aug 23 11:26:26 2018 New Revision: 340562 URL: http://llvm.org/viewvc/llvm-project?rev=340562=rev Log: Fix format string issue introduced in r340548 Make format string portable. Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxx.cpp Modified:

[Lldb-commits] [lldb] r352899 - [lldb] Relax libc++ ABI version checking

Author: thomasanderson Date: Fri Feb 1 11:10:39 2019 New Revision: 352899 URL: http://llvm.org/viewvc/llvm-project?rev=352899=rev Log: [lldb] Relax libc++ ABI version checking libc++ has programmable ABI versioning controllable with the _LIBCPP_ABI_VERSION macro. Currently there are at least 3

[Lldb-commits] [lldb] r363362 - [C++20] add Basic consteval specifier

Author: tyker Date: Fri Jun 14 01:56:20 2019 New Revision: 363362 URL: http://llvm.org/viewvc/llvm-project?rev=363362=rev Log: [C++20] add Basic consteval specifier Summary: this revision adds Lexing, Parsing and Basic Semantic for the consteval specifier as specified by

[Lldb-commits] [lldb] r362349 - [COFF, ARM64] Fix CodeView API change for getRegisterNames

Author: tomtan Date: Sun Jun 2 17:48:16 2019 New Revision: 362349 URL: http://llvm.org/viewvc/llvm-project?rev=362349=rev Log: [COFF, ARM64] Fix CodeView API change for getRegisterNames Change rL362280 changed CodeView API getRegisterNames() by adding an input parameter in CPUType. It is called

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik added a comment. In D67994#1692645 , @labath wrote: > Maybe this is my fault since I'm the one who introduced the first bunch of > arguments here IIRC, but anyway, I have a feeling all of these dumping > options are getting out of hand. Looking

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

uweigand added a comment. This makes sense to me (although we don't currently need the options parameter there). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 221931. mbrkusanin added reviewers: echristo, craig.topper, uweigand, tstellar, dylanmckay, petecoup. mbrkusanin added a comment. - rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 Files:

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin added a comment. @echristo @craig.topper @uweigand @tstellar @dylanmckay @petecoup Do you have any comments on the current patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 ___

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin added a comment. Any comment on whether we should split this into two patches? One that adds `MCTargetOptions` to `MCAsmInfo` and another one that just fixes prefixes for Mips. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 222832. mbrkusanin added a comment. - rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 Files: clang/lib/Parse/ParseStmtAsm.cpp clang/tools/driver/cc1as_main.cpp

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Looks good to me but I guess someone else should give the final approval. Comment at: llvm/lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp:25 if

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

atanasyan accepted this revision. atanasyan added a comment. LGTM. But before commit get more approvals. For example, from echristo, code owners of other targets, etc. I would keep the as-is. In that case a target of such huge modifications looks a bit more clear. CHANGES SINCE LAST ACTION

Re: [Lldb-commits] [PATCH] D68140: [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in ExternalASTMerger

Thanks! Fixed in r373327. - Raphael > On 1. Oct 2019, at 13:15, Peter Smith via Phabricator > wrote: > > peter.smith added a comment. > > This change has broken a test in the Arm and AArch64 buildbots. > Specificallyclang/test/Import/cxx-anon-namespace/test.cpp For example >

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 220830. mbrkusanin added a comment. - `MipsMCAsmInfo()` now always reads ABI from `MipsABIInfo` instead of `Triple`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 Files:

[Lldb-commits] [lldb] r367386 - Change '|' to '&' in conditional.

Author: rtrieu Date: Tue Jul 30 21:41:05 2019 New Revision: 367386 URL: http://llvm.org/viewvc/llvm-project?rev=367386=rev Log: Change '|' to '&' in conditional. Bitwise-or with a non-zero constant will always evaluate to true. Switch to bitwise-and which will only evalute to true if the

[Lldb-commits] [lldb] r356672 - Workaround Python's map difference between Python2/3

Author: serge_sans_paille Date: Thu Mar 21 07:44:58 2019 New Revision: 356672 URL: http://llvm.org/viewvc/llvm-project?rev=356672=rev Log: Workaround Python's map difference between Python2/3 When the output of map is not used, using a list comprehension or an explicit call to list looks

[Lldb-commits] [lldb] r371195 - Remove call to obsolete gethostbyname, using getaddrinfo

Author: serge_sans_paille Date: Fri Sep 6 04:06:23 2019 New Revision: 371195 URL: http://llvm.org/viewvc/llvm-project?rev=371195=rev Log: Remove call to obsolete gethostbyname, using getaddrinfo Differential Revision: https://reviews.llvm.org/D67230 Modified:

[Lldb-commits] [PATCH] D66149: [BinaryFormat] Teach identify_magic about Tapi files.

cishida updated this revision to Diff 215174. cishida added a comment. Herald added subscribers: openmp-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits, jdoerfert, asbirlea, Petar.Avramovic, thopre, jsji, jfb, kadircet, rupprecht, arphaman, atanasyan, jkorous, MaskRay, jrtc27,

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219038. kwk added a comment. - Fix spelling error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218930. kwk added a comment. Herald added subscribers: wuzish, rnkovacs. - Fixup - Test for minidebuginfo image dump symtab - Fixed test for corrupted xz blob - Fix test - Added test that runs when no LZMA is configured Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218932. kwk added a comment. - Better names for minidebuginfo files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 220675. mbrkusanin added a comment. Herald added subscribers: lldb-commits, cfe-commits, seiya, lenary, rupprecht, jrtc27, hiraditya. Herald added projects: clang, LLDB. - MCTargetOptions is now always passed to MCAsmInfo (or rather createMCAsmInfo). In

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218929. kwk added a comment. Herald added subscribers: openmp-commits, libcxx-commits, Sanitizers, cfe-commits, seiya, erik.pilkington, asbirlea, ormris, Petar.Avramovic, jsji, mstorsjo, jfb, kadircet, arphaman, jkorous, george.burgess.iv, christof,

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin added a comment. In D66795#1650305 , @atanasyan wrote: > But take a look at `LLVMCreateDisasmCPUFeatures` function from > `Disassembler.cpp`. If we cannot retrieve `MCTargetOptions` right in this > function, we will have to change "LLVM-C"

Re: [Lldb-commits] [lldb] r371882 - Fix error in ProcessLauncherWindows.cpp

Thanks! > On Sep 13, 2019, at 8:50 PM, Adrian McCarthy via lldb-commits > wrote: > > Author: amccarth > Date: Fri Sep 13 11:50:39 2019 > New Revision: 371882 > > URL: http://llvm.org/viewvc/llvm-project?rev=371882=rev > Log: > Fix error in ProcessLauncherWindows.cpp > > Restored missing

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218931. kwk added a comment. - Better names for minidebuginfo files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D66149: [BinaryFormat] Teach identify_magic about Tapi files.

cishida abandoned this revision. cishida added a comment. Ran into issue with pushing update to this middle of stack revision. Will create new clean revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66149/new/

[Lldb-commits] [PATCH] D62732: [WIP][RISCV] Initial port of LLDB for RISC-V

simoncook updated this revision to Diff 205287. simoncook added a comment. - Refactored register tables to match style used in i386/x86_64 - Add enum for RISC-V DWARF numbers - Add F registers (assuming 32-bit, at runtime this seems to be overwritten to 64-bit if D extension is provided) - Add

[Lldb-commits] [PATCH] D62732: [WIP][RISCV] Initial port of LLDB for RISC-V

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp:624-635 +case llvm::Triple::riscv32: +case llvm::Triple::riscv64: + for (auto : m_regs) { +if (strcmp(reg.name, "x1") == 0) +

[Lldb-commits] [lldb] r364614 - Fixing a couple of wrong logical operator bugs.

Author: tamur Date: Thu Jun 27 17:11:26 2019 New Revision: 364614 URL: http://llvm.org/viewvc/llvm-project?rev=364614=rev Log: Fixing a couple of wrong logical operator bugs. Modified: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.h

[Lldb-commits] [lldb] r366478 - [lldb][swig] Fix autodocs flag parsing

Author: rupprecht Date: Thu Jul 18 11:18:51 2019 New Revision: 366478 URL: http://llvm.org/viewvc/llvm-project?rev=366478=rev Log: [lldb][swig] Fix autodocs flag parsing r366471 added "-features autodoc" without a trailing comment, leading to `Unrecognized option -features autodoc-threads` due

[Lldb-commits] [lldb] r367865 - [lldb][clang] Reflect LangStandard.h move to clang/Basic

Author: ro Date: Mon Aug 5 07:00:43 2019 New Revision: 367865 URL: http://llvm.org/viewvc/llvm-project?rev=367865=rev Log: [lldb][clang] Reflect LangStandard.h move to clang/Basic D65562 moves LangStandard.h from clang/Frontend to clang/Basic. This patch

[Lldb-commits] [lldb] r362192 - Fix off-by-one error.

Author: rtrieu Date: Thu May 30 22:06:54 2019 New Revision: 362192 URL: http://llvm.org/viewvc/llvm-project?rev=362192=rev Log: Fix off-by-one error. The created string is one char too large, so it pulls the terminating NULL as the last character of the string. This later causes SocketTest.cpp

[Lldb-commits] [lldb] r362194 - Fix problem with r362192

Author: rtrieu Date: Thu May 30 22:55:07 2019 New Revision: 362194 URL: http://llvm.org/viewvc/llvm-project?rev=362194=rev Log: Fix problem with r362192 The string returned only sometimes ends in NULL. Explicitly check for the NULL and pop off the NULL if it is there. Modified:

[Lldb-commits] [lldb] r356910 - Python 2/3 compat: StringIO

Author: serge_sans_paille Date: Mon Mar 25 08:23:34 2019 New Revision: 356910 URL: http://llvm.org/viewvc/llvm-project?rev=356910=rev Log: Python 2/3 compat: StringIO Differential Revision: https://reviews.llvm.org/D59582 Modified: lldb/trunk/examples/customization/bin-utils/binutils.py

[Lldb-commits] [lldb] r356908 - Python 2/3 compat: str vs basestring

Author: serge_sans_paille Date: Mon Mar 25 08:21:29 2019 New Revision: 356908 URL: http://llvm.org/viewvc/llvm-project?rev=356908=rev Log: Python 2/3 compat: str vs basestring Differential Revision: https://reviews.llvm.org/D59589 Modified: lldb/trunk/examples/summaries/cocoa/CFArray.py

Re: [Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

> > Hello, in a bit of a https://xkcd.com/1172/ moment this breaks the > chromium/android build. We have a list of "resources" (strings, bitmaps, > etc) that we list in an XML file which then generates a header with lots of > "IDR_foo" constants. As it turns out, now all of these resources are

[Lldb-commits] [lldb] r362035 - Use correct format specifier to silence -Wformat warning.

Author: rtrieu Date: Wed May 29 14:25:15 2019 New Revision: 362035 URL: http://llvm.org/viewvc/llvm-project?rev=362035=rev Log: Use correct format specifier to silence -Wformat warning. Modified: lldb/trunk/source/Utility/Timer.cpp Modified: lldb/trunk/source/Utility/Timer.cpp URL:

[Lldb-commits] [lldb] r356909 - Python 2/3 compat: tkinter

Author: serge_sans_paille Date: Mon Mar 25 08:22:41 2019 New Revision: 356909 URL: http://llvm.org/viewvc/llvm-project?rev=356909=rev Log: Python 2/3 compat: tkinter Differential Revision: https://reviews.llvm.org/D59586 Modified: lldb/trunk/examples/python/lldbtk.py Modified:

[Lldb-commits] [lldb] r356995 - python 2/3 compat: commands vs subprocess

Author: serge_sans_paille Date: Tue Mar 26 07:46:15 2019 New Revision: 356995 URL: http://llvm.org/viewvc/llvm-project?rev=356995=rev Log: python 2/3 compat: commands vs subprocess Differential Revision: https://reviews.llvm.org/D59584 Modified: lldb/trunk/examples/python/delta.py

[Lldb-commits] [lldb] r337070 - Update ClangASTContext for the new DependentVector type.

Author: saugustine Date: Fri Jul 13 15:54:41 2018 New Revision: 337070 URL: http://llvm.org/viewvc/llvm-project?rev=337070=rev Log: Update ClangASTContext for the new DependentVector type. https://reviews.llvm.org/D49326 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified:

[Lldb-commits] [lldb] r356904 - Python 2/3 compat: unichr vs chr

Author: serge_sans_paille Date: Mon Mar 25 08:12:48 2019 New Revision: 356904 URL: http://llvm.org/viewvc/llvm-project?rev=356904=rev Log: Python 2/3 compat: unichr vs chr Modified: lldb/trunk/examples/summaries/cocoa/CFString.py Modified: lldb/trunk/examples/summaries/cocoa/CFString.py

[Lldb-commits] [lldb] r356906 - Python 2/3 compat: queue vs Queue

Author: serge_sans_paille Date: Mon Mar 25 08:14:56 2019 New Revision: 356906 URL: http://llvm.org/viewvc/llvm-project?rev=356906=rev Log: Python 2/3 compat: queue vs Queue Differential Revision: https://reviews.llvm.org/D59590 Modified: lldb/trunk/utils/lui/lui.py

[Lldb-commits] [PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 200802. ymandel removed a subscriber: dexonsmith. ymandel added a comment. Replace previous diff which had the wrong base. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/

[Lldb-commits] [lldb] r355629 - [lldb] Fix DW_OP_addrx uses.

Author: tamur Date: Thu Mar 7 11:41:08 2019 New Revision: 355629 URL: http://llvm.org/viewvc/llvm-project?rev=355629=rev Log: [lldb] Fix DW_OP_addrx uses. Summary: DW_OP_GNU_addr_index has been renamed as DW_OP_addrx in the standard. clang produces DW_OP_addrx tags and with this change lldb

[Lldb-commits] [lldb] r337071 - Rollback r337070.

Author: saugustine Date: Fri Jul 13 16:03:15 2018 New Revision: 337071 URL: http://llvm.org/viewvc/llvm-project?rev=337071=rev Log: Rollback r337070. Someone simultaneously fixed the breakage it was designed to fix. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified:

[Lldb-commits] [PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361418: [clang-tidy] Add support for writing a check as a Transformer rewrite rule. (authored by ymandel, committed by ). Changed prior to commit: https://reviews.llvm.org/D61386?vs=200802=200804#toc

[Lldb-commits] [PATCH] D62732: [WIP][RISCV] Initial port of LLDB for RISC-V

clayborg added a comment. Jason, can you take a look at "Thread.cpp" and my inlined comment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732 ___ lldb-commits

[Lldb-commits] [PATCH] D62732: [WIP][RISCV] Initial port of LLDB for RISC-V

xiaobai added subscribers: compnerd, xiaobai. xiaobai added a reviewer: compnerd. xiaobai added a comment. @compnerd You might be interested in this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732

[Lldb-commits] [PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { ilya-biryukov wrote: > ymandel wrote: >

[Lldb-commits] [lldb] r356647 - Use list comprehension instead of map/filter to prepare Python2/3 compat

Author: serge_sans_paille Date: Thu Mar 21 00:19:09 2019 New Revision: 356647 URL: http://llvm.org/viewvc/llvm-project?rev=356647=rev Log: Use list comprehension instead of map/filter to prepare Python2/3 compat Differential Revision: https://reviews.llvm.org/D59579 Modified:

[Lldb-commits] [lldb] r356673 - Workaround items/iteritems difference between Python2 and Python3

Author: serge_sans_paille Date: Thu Mar 21 07:47:40 2019 New Revision: 356673 URL: http://llvm.org/viewvc/llvm-project?rev=356673=rev Log: Workaround items/iteritems difference between Python2 and Python3 Differential Revision: https://reviews.llvm.org/D59588 Modified:

[Lldb-commits] [lldb] r356670 - Portable exception value access across Python 2 / Python 3

Author: serge_sans_paille Date: Thu Mar 21 07:39:55 2019 New Revision: 356670 URL: http://llvm.org/viewvc/llvm-project?rev=356670=rev Log: Portable exception value access across Python 2 / Python 3 Differential Revision: https://reviews.llvm.org/D59583 Modified:

[Lldb-commits] [lldb] r356671 - Portable int/long conversion across Python 2 / Python 3

Author: serge_sans_paille Date: Thu Mar 21 07:41:34 2019 New Revision: 356671 URL: http://llvm.org/viewvc/llvm-project?rev=356671=rev Log: Portable int/long conversion across Python 2 / Python 3 Differential Revision: https://reviews.llvm.org/D59585 Modified:

[Lldb-commits] [PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { ymandel wrote: > ilya-biryukov wrote: > > ymandel wrote: > > >

[Lldb-commits] [PATCH] D61847: [lldb] NFC modernize codebase with modernize-use-nullptr

kwk added a comment. @JDevlieghere I have commit access now. I'm currently working on rebasing my changes and resolving conflicts in these files where my patch wasn't rebaseable. lldb/source/Core/ValueObject.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h

[Lldb-commits] [lldb] r349128 - Remove unused variable.

Author: rtrieu Date: Thu Dec 13 21:40:30 2018 New Revision: 349128 URL: http://llvm.org/viewvc/llvm-project?rev=349128=rev Log: Remove unused variable. Modified: lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp Modified:

[Lldb-commits] [PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

mstorsjo requested changes to this revision. mstorsjo added a comment. This revision now requires changes to proceed. No, I don't think this is a good idea. Like I said, the Windows SDK is not self-consistent, so you cannot use it on a case sensitive file system without other case insensitivity

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791

[Lldb-commits] [lldb] r351760 - Fix test after AST dump output change

Author: steveire Date: Mon Jan 21 11:18:10 2019 New Revision: 351760 URL: http://llvm.org/viewvc/llvm-project?rev=351760=rev Log: Fix test after AST dump output change Modified: lldb/trunk/lit/SymbolFile/NativePDB/function-types-classes.cpp Modified:

[Lldb-commits] [PATCH] D55574: Remove else statements after returns

zturner added inline comments. Comment at: source/Commands/CommandObjectTarget.cpp:2569 + } + StreamString strm; + module_spec.GetUUID().Dump(); aprantl wrote: > Can you manually double-check this one? For large complex cases like

[Lldb-commits] [PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

plotfi updated this revision to Diff 200067. plotfi added a comment. Herald added subscribers: openmp-commits, libcxx-commits, lldb-commits, cfe-commits, lebedev.ri, kadircet, arphaman, jkorous, christof, hiraditya, mgorny, ki.stfu, kubamracek. Herald added a reviewer: jfb. Herald added a

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

tstellar added a comment. This looks good, but could you also add an entry in the ReleaseNotes for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 ___

[Lldb-commits] [lldb] r351733 - Fix test after AST dump output change

Author: steveire Date: Mon Jan 21 01:54:31 2019 New Revision: 351733 URL: http://llvm.org/viewvc/llvm-project?rev=351733=rev Log: Fix test after AST dump output change Modified: lldb/trunk/lit/SymbolFile/NativePDB/function-types-classes.cpp Modified:

[Lldb-commits] [PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

plotfi added a comment. In D62034#1506879 , @mclow.lists wrote: > I have no objection to this; but I'm not really confident that this won't > break more than it solves. Actually, I think the existing VFS overlay would fix this without any changes. So

[Lldb-commits] [PATCH] D61847: [lldb] NFC modernize codebase with modernize-use-nullptr

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. I had a quick glance over the changes and they all look correct. It appears that the spurious formatting changes have been addressed as well. Just to be sure I

[Lldb-commits] [PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

mclow.lists added a comment. I have no objection to this; but I'm not really confident that this won't break more than it solves. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62034/new/ https://reviews.llvm.org/D62034

[Lldb-commits] [PATCH] D61847: [lldb] modernize codebase with modernize-use-nullptr

teemperor added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:76 static constexpr PropertyDefinition g_properties[] = { -{"load-kexts", OptionValue::eTypeBoolean, true, true, NULL, {}, +{"load-kexts", +

[Lldb-commits] [lldb] r351707 - Fix test after AST dump output change

Author: steveire Date: Sun Jan 20 15:46:30 2019 New Revision: 351707 URL: http://llvm.org/viewvc/llvm-project?rev=351707=rev Log: Fix test after AST dump output change Modified: lldb/trunk/lit/SymbolFile/NativePDB/function-types-classes.cpp Modified:

[Lldb-commits] [PATCH] D61847: [lldb] NFC modernize codebase with modernize-use-nullptr

kwk added a comment. @JDevlieghere can you please commit this in my name? I don't have commit access yet. I've filed an email an hope to get it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61847/new/ https://reviews.llvm.org/D61847

[Lldb-commits] [PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

plotfi added a comment. Herald added a subscriber: dexonsmith. In D62034#1506102 , @mstorsjo wrote: > Yes, MinGW headers are all lowercase. > > And the Windows SDK, where the file is spelled with a capital W, isn't > self-consistent (some headers include

[Lldb-commits] [PATCH] D61847: [lldb] modernize codebase with modernize-use-nullptr

kwk added a comment. @teemperor I've addressed all of your comments. Can you please have another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61847/new/ https://reviews.llvm.org/D61847 ___

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL355340: [build] Rename clang-headers to clang-resource-headers (authored by smeenai, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

  1   2   3   4   >