[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna updated this revision to Diff 225775. lawrence_danna added a comment. comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ https://reviews.llvm.org/D69214 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:261-264 void PythonBytes::SetBytes(llvm::ArrayRef bytes) { const char *data = reinterpret_cast(bytes.data()); - PyObject *py_bytes =

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna updated this revision to Diff 225767. lawrence_danna marked 16 inline comments as done. lawrence_danna added a comment. fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ https://reviews.llvm.org/D69214 Files:

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

This revision was automatically updated to reflect the committed changes. Closed by commit rG722b61892454: eliminate nontrivial Reset(...) from TypedPythonObject (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69133/new/

[Lldb-commits] [lldb] 722b618 - eliminate nontrivial Reset(...) from TypedPythonObject

Author: Lawrence D'Anna Date: 2019-10-19T18:43:49Z New Revision: 722b61892454b3217d73ec486e52156c5a92b5b3 URL: https://github.com/llvm/llvm-project/commit/722b61892454b3217d73ec486e52156c5a92b5b3 DIFF: https://github.com/llvm/llvm-project/commit/722b61892454b3217d73ec486e52156c5a92b5b3.diff

[Lldb-commits] [PATCH] D69210: [Disassembler] Simplify MCInst predicates

vsk added a comment. Hm, this patch is bugging me. It looks a bit like instructions are still decoded multiple times in different ways (e.g. in the `Decode` and `CalculateMnemonicOperandsAndComment` methods, which both modify `m_opcode`). Any ideas on whether/how to consolidate these?

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1057 + + // global is protected by the GIL + static PythonScript read_exception(read_exception_script,

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

lawrence_danna updated this revision to Diff 225758. lawrence_danna added a comment. comment on NullTerminated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69133/new/ https://reviews.llvm.org/D69133 Files:

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:154 +class NullTerminated { + const char *str; Actually, could you also write a short blurb about what is the purpose of this class. Repository: rG

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna updated this revision to Diff 225746. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ https://reviews.llvm.org/D69214 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

labath added a comment. No fudnamental issues with this patch (I'm ignoring the CStringArg topic here). I do think that it would be nice to have some more unit tests for the new APIs you're introducing (or elevating to API status). I'm mainly thinking of the PythonScript stuff (a test where we

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

lawrence_danna updated this revision to Diff 225745. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69133/new/ https://reviews.llvm.org/D69133 Files:

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

lawrence_danna added a comment. In D69133#1715544 , @labath wrote: > While I appreciate the desire to reduce "boilerplate", I also think there's a > lot of value in consistency oh, yea somehow I thought going through the twine would still copy the

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

labath added a comment. While I appreciate the desire to reduce "boilerplate", I also think there's a lot of value in consistency. None of the existing APIs in llvm do anything like this, and are perfectly happy to call toNullTerminatedStringRef manually. You've now introduced another

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

labath added a comment. In D68130#1715433 , @teemperor wrote: > Well, I'm fine with x-failing it on Linux, even though I guess at some point > someone (i.e., probably me) has to figure out why this stuff is broken in the > expression parser. I said

[Lldb-commits] [PATCH] D69153: convert LLDBSwigPythonCallTypeScript to ArgInfo::max_positional_args

This revision was automatically updated to reflect the committed changes. Closed by commit rGbdcad0aca0a0: convert LLDBSwigPythonCallTypeScript to ArgInfo::max_positional_args (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

This revision was automatically updated to reflect the committed changes. Closed by commit rG2386537c2469: [LLDB] bugfix: command script add -f doesnt work for some callables (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] bdcad0a - convert LLDBSwigPythonCallTypeScript to ArgInfo::max_positional_args

Author: Lawrence D'Anna Date: 2019-10-19T07:05:39Z New Revision: bdcad0aca0a05145364ee153a8f54af4aea2c445 URL: https://github.com/llvm/llvm-project/commit/bdcad0aca0a05145364ee153a8f54af4aea2c445 DIFF:

[Lldb-commits] [lldb] 2386537 - [LLDB] bugfix: command script add -f doesn't work for some callables

Author: Lawrence D'Anna Date: 2019-10-19T07:05:33Z New Revision: 2386537c2469a97501a305c6b3138231b907a67f URL: https://github.com/llvm/llvm-project/commit/2386537c2469a97501a305c6b3138231b907a67f DIFF:

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

labath added a comment. In D69148#1714785 , @vsk wrote: > The death tests are flaky. I've noticed two issues: > > 1. When run under lit, the DisableExitOnSIGPIPE doesn't actually exit when it > receives SIGPIPE. Dtrace suggests that the unit test process

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I am happy with that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69014/new/ https://reviews.llvm.org/D69014

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

labath added a comment. Cool. I'm glad we could figure this out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 ___ lldb-commits mailing list