[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

aadsm created this revision. aadsm added reviewers: hhb, sgraenitz, xiaobai, smeenai. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. I want to be able to specify which python framework to use for lldb in macos. With python2.7 we could just rely on the MacOS one but

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Seems fine otherwise, I think. Comment at: include/lldb/Symbol/CompileUnit.h:174 + lldb::FunctionSP + FindFunction(llvm::function_ref matching_lambda); +

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

aprantl added inline comments. Comment at: include/lldb/Symbol/CompileUnit.h:172 + /// \return + /// The FunctionSP containing the first matching entry. + lldb::FunctionSP Document what does the bool return value do? Comment at:

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rGe18f4db208ba: [LLDB] Adding caching to libc++ std::function formatter for lookups that… (authored by shafik). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] e18f4db - [LLDB] Adding caching to libc++ std::function formatter for lookups that require scanning symbols

Author: shafik Date: 2019-11-06T16:02:56-08:00 New Revision: e18f4db208baa84800cf304d7e15f2ee7343cd05 URL: https://github.com/llvm/llvm-project/commit/e18f4db208baa84800cf304d7e15f2ee7343cd05 DIFF: https://github.com/llvm/llvm-project/commit/e18f4db208baa84800cf304d7e15f2ee7343cd05.diff LOG:

[Lldb-commits] [lldb] 703c97b - [lldb] Mark ASan & TSan as test dependencies

Author: Jonas Devlieghere Date: 2019-11-06T15:24:49-08:00 New Revision: 703c97be2492dfb0e4f3138e47fc1fe71c91adfa URL: https://github.com/llvm/llvm-project/commit/703c97be2492dfb0e4f3138e47fc1fe71c91adfa DIFF:

[Lldb-commits] [lldb] a6b5daa - [test] Fix apple_simulator_test decorator when simulators are unavailable

Author: Alex Langford Date: 2019-11-06T15:14:01-08:00 New Revision: a6b5daa701d3a276ace90c688f913b96d396bed1 URL: https://github.com/llvm/llvm-project/commit/a6b5daa701d3a276ace90c688f913b96d396bed1 DIFF: https://github.com/llvm/llvm-project/commit/a6b5daa701d3a276ace90c688f913b96d396bed1.diff

[Lldb-commits] [lldb] cfca005 - [lldb] Remove dead code from STLUtils.h

Author: Jonas Devlieghere Date: 2019-11-06T15:06:29-08:00 New Revision: cfca0056f054602dd46d1224c63d2275a4ecd90f URL: https://github.com/llvm/llvm-project/commit/cfca0056f054602dd46d1224c63d2275a4ecd90f DIFF:

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

aadsm added a comment. Yeah, weird. I wonder if this is something cmake does implicitly when the target is defined as `FRAMEWORK`: https://cmake.org/cmake/help/latest/prop_tgt/FRAMEWORK.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 8243918 - Testuite: Support Asan test with remote testing

Author: Fred Riss Date: 2019-11-06T14:28:48-08:00 New Revision: 8243918f43c6eedc2b018c1edc9c6b72fe9b3c1e URL: https://github.com/llvm/llvm-project/commit/8243918f43c6eedc2b018c1edc9c6b72fe9b3c1e DIFF: https://github.com/llvm/llvm-project/commit/8243918f43c6eedc2b018c1edc9c6b72fe9b3c1e.diff

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

friss added inline comments. Comment at: source/Symbol/CompileUnit.cpp:101 + // m_functions_by_uid is filled in lazily but we need all the entries. + symbol_file->ParseFunctions(*this); + friss wrote: > This seems pretty expensive. Can we Force the parsing of

[Lldb-commits] [PATCH] D69738: Fix handling for the clang name mangling extension for block invocations

This revision was automatically updated to reflect the committed changes. shafik marked 2 inline comments as done. Closed by commit rG83393d27af66: [LLDB] Fix handling for the clang name mangling extension for block invocations (authored by shafik). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [lldb] 83393d2 - [LLDB] Fix handling for the clang name mangling extension for block invocations

Author: shafik Date: 2019-11-06T14:20:00-08:00 New Revision: 83393d27af6631d1df5c549feb214abbdd1d6054 URL: https://github.com/llvm/llvm-project/commit/83393d27af6631d1df5c549feb214abbdd1d6054 DIFF: https://github.com/llvm/llvm-project/commit/83393d27af6631d1df5c549feb214abbdd1d6054.diff LOG:

[Lldb-commits] [PATCH] D69871: crashlog.py: Improve regular expressions

aprantl updated this revision to Diff 228139. aprantl added a comment. Added some more tests as suggested by Jason and made the regex slightly more robust by requiring a `/` at the beginning of `img_path`. All crashlogs I found were meeting this requirement. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69871: crashlog.py: Improve regular expressions

aprantl updated this revision to Diff 228141. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69871/new/ https://reviews.llvm.org/D69871 Files: lldb/examples/python/crashlog.py lldb/test/Shell/Python/crashlog.test Index: lldb/test/Shell/Python/crashlog.test

[Lldb-commits] [lldb] 77a60f0 - [lldb] Record framework build path and use it everywhere

Author: Haibo Huang Date: 2019-11-06T14:05:35-08:00 New Revision: 77a60f0df673074a2c9276498f95a9eaadeece56 URL: https://github.com/llvm/llvm-project/commit/77a60f0df673074a2c9276498f95a9eaadeece56 DIFF: https://github.com/llvm/llvm-project/commit/77a60f0df673074a2c9276498f95a9eaadeece56.diff

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

friss added inline comments. Comment at: source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp:274 + vtable_first_entry_resolved.CalculateSymbolContextCompileUnit(); + llvm::StringRef name_to_use = func_to_match; + bool is_lambda =

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

shafik created this revision. shafik added reviewers: jasonmolenda, aam, jingham. Herald added a subscriber: christof. This PR depends on D67111 Performance issues lead to the libc++ std::function formatter to be disabled. We addressed some of those performance

[Lldb-commits] [PATCH] D69904: [arm] Add core definition for armv8l and armv7l

omjavaid created this revision. omjavaid added reviewers: jasonmolenda, labath, clayborg. Herald added a subscriber: kristof.beyls. This patch adds core definitions in lldb ArchSpecs for armv8l and armv7l cores. There is also fix where while merging target and paltform triple we were updating

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

wallace updated this revision to Diff 228078. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69873/new/

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

wallace updated this revision to Diff 228076. wallace added a comment. removed the results limit of 20 because it didn't work and I verified that returning a long list is displayed well on vscode. There's no need for this limit at this point. I also tested the cases that @teemperor mentioned

[Lldb-commits] [PATCH] D69630: [lldb] Record framework build path and use it everywhere

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense to me (sorry about the delay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69630/new/ https://reviews.llvm.org/D69630

[Lldb-commits] [lldb] bcae3b0 - lldb/docs: update the lldb-x86_64-debian bot url

Author: Pavel Labath Date: 2019-11-06T16:02:23+01:00 New Revision: bcae3b04e8740e1a82567471df410a2fd8b72c3f URL: https://github.com/llvm/llvm-project/commit/bcae3b04e8740e1a82567471df410a2fd8b72c3f DIFF: https://github.com/llvm/llvm-project/commit/bcae3b04e8740e1a82567471df410a2fd8b72c3f.diff

Re: [Lldb-commits] [lldb] 2abcf44 - [Reproducer] Add test case for expression evaluation

Thanks Pavel, I’ll investigate today. On Wed, Nov 6, 2019 at 06:54 Pavel Labath wrote: > It seems that this test is very flaky (fails ~10% of time) on linux. > E.g: > < > http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/211/steps/test/logs/stdio > >. > > It always fails on the same

Re: [Lldb-commits] [lldb] 2abcf44 - [Reproducer] Add test case for expression evaluation

It seems that this test is very flaky (fails ~10% of time) on linux. E.g: . It always fails on the same assertion: "Encountered unexpected packet during replay". I've done a bit of digging, and the problems

[Lldb-commits] [lldb] 5840161 - lldb: Skip reproducer+expression evaluation test on linux

Author: Pavel Labath Date: 2019-11-06T15:48:00+01:00 New Revision: 58401612cdc8d2c8e0e8c4103423b5da781199be URL: https://github.com/llvm/llvm-project/commit/58401612cdc8d2c8e0e8c4103423b5da781199be DIFF: https://github.com/llvm/llvm-project/commit/58401612cdc8d2c8e0e8c4103423b5da781199be.diff

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

teemperor added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:948 +actual_column, +0, 20, matches, descriptions); + targets.reserve(matches.GetSize()); max_return_elements isn't implemented, so you can just pass '-1' here. This

[Lldb-commits] [PATCH] D69843: Expression eval lookup - prune methods without parsing

jarin added a comment. Thanks for the feedback! We will experiment with filtering in GetFunctions sometime next week. Regarding the FindTypes patch, it would be really nice to have that for Linux, as well. I see the type pruning (TypeMap::RemoveMismatchedTypes) taking several seconds for some

[Lldb-commits] [lldb] eb12b3b - Silence warning, PyMODINIT_FUNC already contains extern "C"

Author: Benjamin Kramer Date: 2019-11-06T12:27:11+01:00 New Revision: eb12b3b8a3e5f41a6ab84f94dfc85551f92bc2ea URL: https://github.com/llvm/llvm-project/commit/eb12b3b8a3e5f41a6ab84f94dfc85551f92bc2ea DIFF:

[Lldb-commits] [PATCH] D69880: [lldb] Fix exception breakpoint not being resolved when set on dummy target

poya created this revision. poya added a reviewer: jingham. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Ensure that breakpoint ivar is properly set in exception breakpoint resolver so that exception breakpoints set on dummy targets are resolved once real