[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

v.g.vassilev added a comment. https://reviews.llvm.org/D41416 could be relevant. I am not an expert but I think when reading the DWARF you could only register 'lazy' specializations which will be imported only when really required. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69309/ne

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

This revision was automatically updated to reflect the committed changes. Closed by commit rGc671639af6a9: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://rev

[Lldb-commits] [lldb] c671639 - [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

Author: Konrad Kleine Date: 2019-11-28T21:37:31+01:00 New Revision: c671639af6a96c31d3c0e5487051bef28bad1640 URL: https://github.com/llvm/llvm-project/commit/c671639af6a96c31d3c0e5487051bef28bad1640 DIFF: https://github.com/llvm/llvm-project/commit/c671639af6a96c31d3c0e5487051bef28bad1640.diff

[Lldb-commits] [PATCH] D70442: [LLDB] Force message formatting to English

This revision was automatically updated to reflect the committed changes. Closed by commit rGbdad3ec75ab3: [LLDB] On Windows, force error message formatting to English (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70442/new/ ht

[Lldb-commits] [lldb] bdad3ec - [LLDB] On Windows, force error message formatting to English

Author: Alexandre Ganea Date: 2019-11-28T14:15:13-05:00 New Revision: bdad3ec75ab35ade2433b1278689d483dcf9abc4 URL: https://github.com/llvm/llvm-project/commit/bdad3ec75ab35ade2433b1278689d483dcf9abc4 DIFF: https://github.com/llvm/llvm-project/commit/bdad3ec75ab35ade2433b1278689d483dcf9abc4.dif

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

aganea updated this revision to Diff 231455. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70830/new/ https://reviews.llvm.org/D70830 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp Index: l

[Lldb-commits] [PATCH] D70448: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4dfc5508f92: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70448/

[Lldb-commits] [lldb] b4dfc55 - [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

Author: Alexandre Ganea Date: 2019-11-28T14:00:56-05:00 New Revision: b4dfc5508f9239f50a3c44dd64e82a488b698b29 URL: https://github.com/llvm/llvm-project/commit/b4dfc5508f9239f50a3c44dd64e82a488b698b29 DIFF: https://github.com/llvm/llvm-project/commit/b4dfc5508f9239f50a3c44dd64e82a488b698b29.dif

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

aganea created this revision. aganea added reviewers: JDevlieghere, lawrence_danna. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before this patch, when compiling with MSVC 15.9.17 (latest), we would see: F:\llvm-project\lldb\source\Plugins\ScriptInterpreter\Python\Sc

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

kwk planned changes to this revision. kwk added a comment. Running tests locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://reviews.llvm.org/D70774 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

kwk updated this revision to Diff 231440. kwk added a comment. - Fixed logic error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://reviews.llvm.org/D70774 Files: lldb/include/lldb/Symbol/CompileUnit.h lldb/source/API/SBThread.

[Lldb-commits] [PATCH] D70827: [lldb] Remove FileSpec->CompileUnit inheritance

labath updated this revision to Diff 231438. labath added a comment. - add doxygen for the new member - avoid using the magic pointer constructor in SearchFilter.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70827/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

kwk reopened this revision. kwk added a comment. This revision is now accepted and ready to land. Reopening because I did find the logic error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://reviews.llvm.org/D70774

[Lldb-commits] [PATCH] D70827: [lldb] Remove FileSpec->CompileUnit inheritance

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:1196 start_idx_ptr = sc.comp_unit->FindLineEntry( -start_idx_ptr, line_number, sc.comp_unit, exact, &line_entry); +

[Lldb-commits] [PATCH] D70827: [lldb] Remove FileSpec->CompileUnit inheritance

labath created this revision. labath added reviewers: teemperor, JDevlieghere. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:1196

[Lldb-commits] [lldb] c2dd84e - [lldb][NFC] Remove CompilerDeclContext::IsClang

Author: Raphael Isemann Date: 2019-11-28T15:54:11+01:00 New Revision: c2dd84e396d091ca61b06b59c622b444ffc17234 URL: https://github.com/llvm/llvm-project/commit/c2dd84e396d091ca61b06b59c622b444ffc17234 DIFF: https://github.com/llvm/llvm-project/commit/c2dd84e396d091ca61b06b59c622b444ffc17234.dif

[Lldb-commits] [lldb] f39277c - [lldb][NFC] Remove unused variable in ClangASTSource::CompleteType

Author: Raphael Isemann Date: 2019-11-28T15:32:56+01:00 New Revision: f39277c1d370ccbbec2e20a20375ee6fb7281ae4 URL: https://github.com/llvm/llvm-project/commit/f39277c1d370ccbbec2e20a20375ee6fb7281ae4 DIFF: https://github.com/llvm/llvm-project/commit/f39277c1d370ccbbec2e20a20375ee6fb7281ae4.dif

[Lldb-commits] [lldb] e0203b2 - [lldb][NFC] Simplify CompilerDecl and CompilerDeclContext initialization

Author: Raphael Isemann Date: 2019-11-28T15:27:54+01:00 New Revision: e0203b25af92a3388580d6ef4eb386058720449e URL: https://github.com/llvm/llvm-project/commit/e0203b25af92a3388580d6ef4eb386058720449e DIFF: https://github.com/llvm/llvm-project/commit/e0203b25af92a3388580d6ef4eb386058720449e.dif

[Lldb-commits] [lldb] 3cd8ba0 - [lldb][NFC] Remove unused CompilerDecl::IsClang

Author: Raphael Isemann Date: 2019-11-28T15:11:37+01:00 New Revision: 3cd8ba0e37a035a134dc01ce260040f1d57f4d40 URL: https://github.com/llvm/llvm-project/commit/3cd8ba0e37a035a134dc01ce260040f1d57f4d40 DIFF: https://github.com/llvm/llvm-project/commit/3cd8ba0e37a035a134dc01ce260040f1d57f4d40.dif

[Lldb-commits] [PATCH] D70814: [lldb] Simplify and improve FileSpecTest

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1a561d44680: [lldb] Simplify and improve FileSpecTest (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70814/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D70797: [LLDB] Use r11 as frame pointer on Windows on ARM

mstorsjo updated this revision to Diff 231416. mstorsjo edited the summary of this revision. mstorsjo added a comment. Added a testcase using a minidump. I had to add recognition of r11 as a potential frame pointer register in thumb mode in the handling of one instruction, to make it pick up the

[Lldb-commits] [lldb] d1a561d - [lldb] Simplify and improve FileSpecTest

Author: Pavel Labath Date: 2019-11-28T14:31:29+01:00 New Revision: d1a561d446809cc3b5c11c163b9aa5ba4957af68 URL: https://github.com/llvm/llvm-project/commit/d1a561d446809cc3b5c11c163b9aa5ba4957af68 DIFF: https://github.com/llvm/llvm-project/commit/d1a561d446809cc3b5c11c163b9aa5ba4957af68.diff

[Lldb-commits] [lldb] bf716eb - [lldb] Add FileSpec::Equal unit tests

Author: Pavel Labath Date: 2019-11-28T14:31:52+01:00 New Revision: bf716eb807409adf6490cb1cf595fb51efbd3fe6 URL: https://github.com/llvm/llvm-project/commit/bf716eb807409adf6490cb1cf595fb51efbd3fe6 DIFF: https://github.com/llvm/llvm-project/commit/bf716eb807409adf6490cb1cf595fb51efbd3fe6.diff

[Lldb-commits] [lldb] 50e2ffa - Revert "[lldb] NFC: refactor CompileUnit::ResolveSymbolContext"

Author: Raphael Isemann Date: 2019-11-28T14:25:46+01:00 New Revision: 50e2ffa18da4247e4d45f421c3271b58b936c869 URL: https://github.com/llvm/llvm-project/commit/50e2ffa18da4247e4d45f421c3271b58b936c869 DIFF: https://github.com/llvm/llvm-project/commit/50e2ffa18da4247e4d45f421c3271b58b936c869.dif

[Lldb-commits] [lldb] 42c857a - [lldb][NFC] Remove unused STLUtil include and STLUtil.h header

Author: Raphael Isemann Date: 2019-11-28T14:11:35+01:00 New Revision: 42c857aa4783824183d55e8a6ede488d69349806 URL: https://github.com/llvm/llvm-project/commit/42c857aa4783824183d55e8a6ede488d69349806 DIFF: https://github.com/llvm/llvm-project/commit/42c857aa4783824183d55e8a6ede488d69349806.dif

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

This revision was automatically updated to reflect the committed changes. Closed by commit rG373e2a4f69d6: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://rev

[Lldb-commits] [lldb] a54ef8a - [lldb][NFC] Use llvm::StringRef instead of C-strings as multimap key

Author: Raphael Isemann Date: 2019-11-28T14:05:47+01:00 New Revision: a54ef8af89c78f7296bea6ffabb7728ef563bec1 URL: https://github.com/llvm/llvm-project/commit/a54ef8af89c78f7296bea6ffabb7728ef563bec1 DIFF: https://github.com/llvm/llvm-project/commit/a54ef8af89c78f7296bea6ffabb7728ef563bec1.dif

[Lldb-commits] [lldb] 373e2a4 - [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

Author: Konrad Kleine Date: 2019-11-28T14:00:38+01:00 New Revision: 373e2a4f69d623e59329ff801f261d8b299e12d2 URL: https://github.com/llvm/llvm-project/commit/373e2a4f69d623e59329ff801f261d8b299e12d2 DIFF: https://github.com/llvm/llvm-project/commit/373e2a4f69d623e59329ff801f261d8b299e12d2.diff

[Lldb-commits] [PATCH] D70814: [lldb] Simplify and improve FileSpecTest

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70814/new/ https://reviews.llvm.org/D70814 _

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

omjavaid updated this revision to Diff 231408. omjavaid added a comment. Sorry for late response on this. I got side tracked into other issues and wanted performance testing before writing an update. I agree with @labath about making caching for limited to reads only and register writes are wri

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://reviews.llvm.org/D70774

[Lldb-commits] [PATCH] D70814: [lldb] Simplify and improve FileSpecTest

labath created this revision. labath added a reviewer: teemperor. Herald added a project: LLDB. A most of these tests create FileSpecs with a hardcoded style. Add utility functions which create a file spec of a given style to simplify things. While in there add SCOPED_TRACE messages to tests whic

[Lldb-commits] [lldb] 2e3c040 - [lldb][NFC] Remove unused CStringToDIEMap typedef

Author: Raphael Isemann Date: 2019-11-28T13:33:19+01:00 New Revision: 2e3c040ee062741472233c1de2dbf135bcee5c7a URL: https://github.com/llvm/llvm-project/commit/2e3c040ee062741472233c1de2dbf135bcee5c7a DIFF: https://github.com/llvm/llvm-project/commit/2e3c040ee062741472233c1de2dbf135bcee5c7a.dif

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

kwk updated this revision to Diff 231406. kwk added a comment. - Have ResolveSymbolContext not return anything Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://reviews.llvm.org/D70774 Files: lldb/include/lldb/Symbol/CompileUnit.h

[Lldb-commits] [lldb] ee79fea - [lldb][NFC] Remove forward declaration of PrivateAutoCompleteMembers

Author: Raphael Isemann Date: 2019-11-28T12:45:48+01:00 New Revision: ee79feaec3ed44b21654936baf44561f5f726dfc URL: https://github.com/llvm/llvm-project/commit/ee79feaec3ed44b21654936baf44561f5f726dfc DIFF: https://github.com/llvm/llvm-project/commit/ee79feaec3ed44b21654936baf44561f5f726dfc.dif

[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

teemperor added a comment. Yeah, that fixes it. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70796/new/ https://reviews.llvm.org/D70796 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

mstorsjo added a comment. I pushed a commit to add such a REQUIRES line now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70796/new/ https://reviews.llvm.org/D70796 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] 9d26791 - [lldb][NFC] Make GetAsCXXRecordDecl static

Author: Raphael Isemann Date: 2019-11-28T12:24:41+01:00 New Revision: 9d2679152a4bbe892f72802427657bfdca85a63b URL: https://github.com/llvm/llvm-project/commit/9d2679152a4bbe892f72802427657bfdca85a63b DIFF: https://github.com/llvm/llvm-project/commit/9d2679152a4bbe892f72802427657bfdca85a63b.dif

[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

labath added a comment. `REQUIRES: arm` ought to do the trick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70796/new/ https://reviews.llvm.org/D70796 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

mstorsjo added a comment. In D70796#1762774 , @teemperor wrote: > This is failing for me with: > > (lldb) disassemble -b -n entry > error: Unable to find Disassembler plug-in for the 'armv7' architecture. > > > I assume that's because I run with `LLVM_

[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

teemperor added a comment. This is failing for me with: (lldb) disassemble -b -n entry error: Unable to find Disassembler plug-in for the 'armv7' architecture. I assume that's because I run with `LLVM_TARGETS_TO_BUILD:STRING=X86;AArch64` in my CMake configuration. Do we have a way to make t

[Lldb-commits] [lldb] f7e31e0 - [lldb][NFC] Split up DWARFASTParserClang::CompleteTypeFromDWARF

Author: Raphael Isemann Date: 2019-11-28T10:45:29+01:00 New Revision: f7e31e0cfd3b467a21c2ac9a94f5c828f88a9b72 URL: https://github.com/llvm/llvm-project/commit/f7e31e0cfd3b467a21c2ac9a94f5c828f88a9b72 DIFF: https://github.com/llvm/llvm-project/commit/f7e31e0cfd3b467a21c2ac9a94f5c828f88a9b72.dif

[Lldb-commits] [PATCH] D70778: [LLDB] [PECOFF] Factorize mapping section names to types using StringSwitch. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e5bb6d8d944: [LLDB] [PECOFF] Factorize mapping section names to types using StringSwitch. (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D70778?vs=231318&id=231368#toc Repos

[Lldb-commits] [PATCH] D70745: [LLDB] [PECOFF] Look for the truncated ".eh_fram" section name

This revision was automatically updated to reflect the committed changes. Closed by commit rG934c025e9bdd: [LLDB] [PECOFF] Look for the truncated ".eh_fram" section name (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D70745?vs=231212&id=231370#toc Repository: rG LL

[Lldb-commits] [PATCH] D70802: [lldb] Remove debugging code used for LLDB_DWARF_DONT_COMPLETE_TYPENAMES

This revision was automatically updated to reflect the committed changes. Closed by commit rGb44e91a47252: [lldb] Remove debugging code used for LLDB_DWARF_DONT_COMPLETE_TYPENAMES (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5c54f40327b: [LLDB] Always interpret arm instructions as thumb on windows (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70796/new/

[Lldb-commits] [PATCH] D70802: [lldb] Remove debugging code used for LLDB_DWARF_DONT_COMPLETE_TYPENAMES

teemperor added a comment. (I landed this straight away as I'm refactoring the surrounding code right now) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70802/new/ https://reviews.llvm.org/D70802 ___ lldb-commits m

[Lldb-commits] [lldb] b44e91a - [lldb] Remove debugging code used for LLDB_DWARF_DONT_COMPLETE_TYPENAMES

Author: Raphael Isemann Date: 2019-11-28T10:21:58+01:00 New Revision: b44e91a472526f01d67ee9ce5de2561216782330 URL: https://github.com/llvm/llvm-project/commit/b44e91a472526f01d67ee9ce5de2561216782330 DIFF: https://github.com/llvm/llvm-project/commit/b44e91a472526f01d67ee9ce5de2561216782330.dif

[Lldb-commits] [PATCH] D70802: [lldb] Remove debugging code used for LLDB_DWARF_DONT_COMPLETE_TYPENAMES

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I have never used this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70802/new/ https://reviews.llvm.org/D70802 _

[Lldb-commits] [PATCH] D70802: [lldb] Remove debugging code used for LLDB_DWARF_DONT_COMPLETE_TYPENAMES

teemperor created this revision. teemperor added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a reviewer: shafik. Herald added a project: LLDB. teemperor added a comment. I'm fine with keeping this if this feature is actively used by multiple peop

[Lldb-commits] [PATCH] D70802: [lldb] Remove debugging code used for LLDB_DWARF_DONT_COMPLETE_TYPENAMES

teemperor added a comment. I'm fine with keeping this if this feature is actively used by multiple people, otherwise this should probably be downstream. If it is actively used I will refactor this code instead. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D708

[Lldb-commits] [PATCH] D70778: [LLDB] [PECOFF] Factorize mapping section names to types using StringSwitch. NFCI.

labath added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:803-804 + (const_sect_name == g_CODE_sect_name))) { +return eSectionTypeCode; + } else if (sect.flags & llvm::COFF::IMAGE_SCN_CNT_INITIALIZED_DATA && + ((co

[Lldb-commits] [PATCH] D70778: [LLDB] [PECOFF] Factorize mapping section names to types using StringSwitch. NFCI.

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:803-804 + (const_sect_name == g_CODE_sect_name))) { +return eSectionTypeCode; + } else if (sect.flags & llvm::COFF::IMAGE_S

[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

labath added a comment. In D70796#1762526 , @mstorsjo wrote: > And allegedly, in earlier versions, the kernel didn't switch modes correctly > when entering the kernel, so entering the kernel from arm code, would try to > execute the kernel's code in arm