[Lldb-commits] [PATCH] D70797: [LLDB] Use r11 as frame pointer on Windows on ARM

This revision was automatically updated to reflect the committed changes. Closed by commit rG45c843de4eb8: [LLDB] [ARM] Use r11 as frame pointer on Windows on ARM (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D70797?vs=231416=231527#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

teemperor added a comment. This LGTM, but the TODO directly above the change in ClangExpressionDeclMap.cpp worries me a bit. I am not sure how good our test coverage is for calling functions when there are instance methods in scope (e.g., we are in instance method and try to call another

[Lldb-commits] [PATCH] D70851: [lldb] s/FileSpec::Equal/FileSpec::Match

labath created this revision. labath added reviewers: teemperor, JDevlieghere. Herald added a subscriber: emaste. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. The FileSpec class is often used as a sort of a pattern -- one specifies a bare file name to search, and we check if

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

labath added a comment. This needs a test case, though judging by your description it looks like pretty much every test case on affected platforms (I guess, windows) should hit this. Can you check if any of the existing vscode tests which are marked @skipIfWindows start passing now?

[Lldb-commits] [lldb] 8059188 - [lldb][NFC] Remove unused ClangASTContext::GetBasicType(ConstString)

Author: Raphael Isemann Date: 2019-11-29T14:11:25+01:00 New Revision: 8059188c45f049b52b779d6684ea78b6ef8b168c URL: https://github.com/llvm/llvm-project/commit/8059188c45f049b52b779d6684ea78b6ef8b168c DIFF:

[Lldb-commits] [PATCH] D70845: [lldb][NFC] Remove ThreadSafeSTLVector and ThreadSafeSTLMap and their use in ValueObjectSynthetic

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I'm yet to see a non-trivial algorithm, which can be made thread-safe by employing "thread safe" containers. +1 for deleting these and sorting the ValueObjectSynthetic issues later.

[Lldb-commits] [lldb] c214c92 - [lldb][NFC] Remove ClangASTContext::GetBuiltinTypeForEncodingAndBitSize overload

Author: Raphael Isemann Date: 2019-11-29T13:57:02+01:00 New Revision: c214c92f3be7c15abc458f23c7be05a5790e6aed URL: https://github.com/llvm/llvm-project/commit/c214c92f3be7c15abc458f23c7be05a5790e6aed DIFF:

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

labath added a comment. Thanks. I now agree with this change in principle, but I don't think its ready for an LGTM yet. The main thing I'd like to discuss is this `InvalidateAllRegisters` function. I think we should come up with a story of when is this function expected to be called, and

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1763705 , @mstorsjo wrote: > In D70840#1763639 , @labath wrote: > > > Yeah, this is going to be tricky... I don't really know what's the right > > way to do this, but here are

[Lldb-commits] [lldb] bc7f1df - [lldb][NFC] Explicitly ask for a ClangASTContext in ClangASTSource

Author: Raphael Isemann Date: 2019-11-29T13:28:55+01:00 New Revision: bc7f1df6b61a3c8f88f2541ef9ba73f4ee0ee4fe URL: https://github.com/llvm/llvm-project/commit/bc7f1df6b61a3c8f88f2541ef9ba73f4ee0ee4fe DIFF:

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo updated this revision to Diff 231517. mstorsjo edited the summary of this revision. mstorsjo added a comment. Converted the test to .s form, using lld, split out the ObjectFile changes to D70848 (which this change now depends on for the tests).

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

labath added a comment. There's `lldb-shell :: SymbolFile/DWARF/find-basic-function.cpp`, which probably didn't get run for you as you didn't have lld enabled (cmake -DLLVM_ENABLE_PROJECTS=...;lld). You'll need to update that test to match the new behavior, but other than that, I think this is

[Lldb-commits] [PATCH] D70848: [LLDB] Set the right address size on output DataExtractors from ObjectFile

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added a subscriber: aprantl. Herald added a project: LLDB. If filling in a DataExtractor from an ObjectFile, e.g. via the ReadSectionData method, the output DataExtractor gets the address size from the m_data

[Lldb-commits] [lldb] 76016f9 - [lldb][NFC] Early exit in ClangASTContext::CreateInstance

Author: Raphael Isemann Date: 2019-11-29T12:49:33+01:00 New Revision: 76016f9b3a9acdba7728561a7ddfb48b1245dfa7 URL: https://github.com/llvm/llvm-project/commit/76016f9b3a9acdba7728561a7ddfb48b1245dfa7 DIFF:

[Lldb-commits] [lldb] 656a812 - [lldb] Fix windows build for 38870af

Author: Pavel Labath Date: 2019-11-29T12:48:25+01:00 New Revision: 656a8123deed31d2d7aee313e87911dc153fa6d3 URL: https://github.com/llvm/llvm-project/commit/656a8123deed31d2d7aee313e87911dc153fa6d3 DIFF: https://github.com/llvm/llvm-project/commit/656a8123deed31d2d7aee313e87911dc153fa6d3.diff

[Lldb-commits] [lldb] d752b75 - [lldb][NFC] Simplify regex_chars in CommandCompletions

Author: Raphael Isemann Date: 2019-11-29T12:34:23+01:00 New Revision: d752b75d7fce2a77bb7656d33d2aa062372dc014 URL: https://github.com/llvm/llvm-project/commit/d752b75d7fce2a77bb7656d33d2aa062372dc014 DIFF:

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1763639 , @labath wrote: > Yeah, this is going to be tricky... I don't really know what's the right way > to do this, but here are the thoughts I have on this so far: > > - The new DWARFDebugInfoEntry member is going

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

anton.kolesov created this revision. anton.kolesov added a project: LLDB. Herald added a subscriber: lldb-commits. Different architectures may use different target processes, so default "gdb-remote" target process created by lldb-vscode may not work for all targets. This commit changes behaviour

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

PatriosTheGreat created this revision. PatriosTheGreat added reviewers: labath, jarin, aprantl. PatriosTheGreat added a project: LLDB. Herald added a subscriber: arphaman. This change is connected with https://reviews.llvm.org/D69843 In large codebases, we sometimes see Module::FindFunctions

[Lldb-commits] [lldb] d1d6049 - [lldb][NFC] Remove dead logging code from DWARFASTParserClang::CompleteRecordType

Author: Raphael Isemann Date: 2019-11-29T12:13:34+01:00 New Revision: d1d6049e9d6600f28746379290705b02ffb52d4b URL: https://github.com/llvm/llvm-project/commit/d1d6049e9d6600f28746379290705b02ffb52d4b DIFF:

[Lldb-commits] [PATCH] D70845: [lldb][NFC] Remove ThreadSafeSTLVector and ThreadSafeSTLMap and their use in ValueObjectSynthetic

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere, jingham. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ThreadSafeSTLVector and ThreadSafeSTLMap are not useful for achieving any degree of thread safety in LLDB and should be removed before

[Lldb-commits] [PATCH] D70827: [lldb] Remove FileSpec->CompileUnit inheritance

This revision was automatically updated to reflect the committed changes. Closed by commit rG38870af85947: [lldb] Remove FileSpec-CompileUnit inheritance (authored by labath). Changed prior to commit: https://reviews.llvm.org/D70827?vs=231438=231509#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 38870af - [lldb] Remove FileSpec->CompileUnit inheritance

Author: Pavel Labath Date: 2019-11-29T11:44:45+01:00 New Revision: 38870af8594726edf32aa0fd8fd9e8916df333af URL: https://github.com/llvm/llvm-project/commit/38870af8594726edf32aa0fd8fd9e8916df333af DIFF: https://github.com/llvm/llvm-project/commit/38870af8594726edf32aa0fd8fd9e8916df333af.diff

[Lldb-commits] [lldb] a48b5e2 - [lldb][NFC] Fix header guard comment in ThreadSafeDenseMap.h

Author: Raphael Isemann Date: 2019-11-29T11:34:18+01:00 New Revision: a48b5e24747ca83f9f18dff62a4bacb2f7dfd773 URL: https://github.com/llvm/llvm-project/commit/a48b5e24747ca83f9f18dff62a4bacb2f7dfd773 DIFF:

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

labath added reviewers: clayborg, jingham. labath added a comment. Yeah, this is going to be tricky... I don't really know what's the right way to do this, but here are the thoughts I have on this so far: - The new DWARFDebugInfoEntry member is going to substantially increase our memory

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added subscribers: kristof.beyls, aprantl. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. Windows on ARM is always thumb, and contrary to ELF, there's no per-symbol flag to indicate arm vs thumb