[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev created this revision. paolosev added reviewers: labath, clayborg, aprantl, sbc100, teemperor. paolosev added a project: LLDB. Herald added subscribers: lldb-commits, sunfish, aheejin, jgravelle-google, mgorny. paolosev added a comment. What is the best way to test this class? Add a

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev added a comment. What is the best way to test this class? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72751/new/ https://reviews.llvm.org/D72751 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

tejohnson added a comment. From an LTO perspective, this seems fine for the reasons we discussed here. I looked through the patch and have a few comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:818 + if (TM) { +TM->initializeOptionsWithModuleMetadata(*TheModule);

[Lldb-commits] [lldb] 914b551 - [lldb/test] Add test for CMTime data formatter

Author: Jonas Devlieghere Date: 2020-01-14T23:11:15-08:00 New Revision: 914b551eeed159ba6051852c0aa63a1311ac4e40 URL: https://github.com/llvm/llvm-project/commit/914b551eeed159ba6051852c0aa63a1311ac4e40 DIFF:

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

paolosev updated this revision to Diff 238177. paolosev added a comment. Rebasing from D71575 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72650/new/ https://reviews.llvm.org/D72650 Files:

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

paolosev added inline comments. Comment at: lldb/source/Utility/DataExtractor.cpp:914 +/// Extract an unsigned LEB128 number with a specified max value. If the +/// extracted value exceeds "max_value" the offset will be left unchanged and +/// llvm::None will be returned.

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

JDevlieghere updated this revision to Diff 238172. JDevlieghere added a comment. Rebase on top of NFC change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72748/new/ https://reviews.llvm.org/D72748 Files: lldb/include/lldb/Core/Debugger.h lldb/source/Core/Debugger.cpp

[Lldb-commits] [lldb] a6faf85 - [lldb/CommandInterpreter] Remove flag that's always true (NFC)

Author: Jonas Devlieghere Date: 2020-01-14T22:28:49-08:00 New Revision: a6faf851f49c7d50e92b16ff9d2e7c02790dd0f8 URL: https://github.com/llvm/llvm-project/commit/a6faf851f49c7d50e92b16ff9d2e7c02790dd0f8 DIFF:

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

paolosev updated this revision to Diff 238168. paolosev marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71575/new/ https://reviews.llvm.org/D71575 Files: lldb/include/lldb/Utility/ArchSpec.h

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

JDevlieghere added a comment. I didn't get a chance to write a test case yet, but you can reproduce the problem with the following setup: $ echo "script foo = 1" > test.lldb $ lldb ./a.out (lldb) b main (lldb) breakpoint command add -s python

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham, friss. Herald added a subscriber: abidh. Herald added a project: LLDB. JDevlieghere added a comment. I didn't get a chance to write a test case yet, but you can reproduce the problem with the following setup: $

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

paolosev added a comment. In D72650#1819403 , @labath wrote: > The patch looks pretty good. A reasonable way to test this would be again via > `lldb-test object-file` . The command dumps the "unified section list" of the > module, so if the debug info

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

lenary marked 2 inline comments as done. lenary added a comment. In D72624#1817464 , @tejohnson wrote: > Thank you for your feedback! It has been very helpful. > I'm not sure if ThinLTOCodeGenerator.cpp and LTOBackend.cpp were > intentionally left out

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

lenary updated this revision to Diff 238053. lenary added a comment. Herald added subscribers: mgorny, MatzeB. Address some review feedback. This patch remains incomplete with regards to module flags and ThinLTO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

lenary added a comment. One thing to note about my patch, above: I have not made the TargetMachine DataLayout non-const, but I wanted to ensure that this might be possible in future, which is why calling `initializeOptionsWithModuleMetadata` must be done before the first call to

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

dblaikie added a comment. (just a general comment that this code review should be only in service of the design discussion happening on llvm-dev - please don't approve/commit this without closing out the design discussion there if there are actionable conclusions from this review)

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61807 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

tejohnson added a comment. In D72624#1820598 , @dblaikie wrote: > (just a general comment that this code review should be only in service of > the design discussion happening on llvm-dev - please don't approve/commit > this without closing out the

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

tejohnson added a comment. In D72624#1820281 , @lenary wrote: > In D72624#1817464 , @tejohnson wrote: > > > > > > Thank you for your feedback! It has been very helpful. > > > I'm not sure if

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

khchen added a comment. In D72624#1818605 , @khchen wrote: > I think putting the resetTargetDefaultOptions after instance of TargetMachine > is too late. > for example: > ppc >

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

paolosev updated this revision to Diff 238128. paolosev added a comment. Added "lldb-test object-file" test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72650/new/ https://reviews.llvm.org/D72650 Files:

[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

dblaikie accepted this revision. dblaikie added a comment. While the related design discussions continue - the patch itself is good/correct & there's nothing much to be done about the address pool size/relocations increase for now, for GDB at least, which is what I care about. Perhaps it's

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

teemperor added a comment. In D72684#1820486 , @clayborg wrote: > We might also want to move these into lldb/source/Plugins/TypeSystem as well > to complete this refactor? I fully agree but I prefer if we could do this as it's own change. This patch

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

xiaobai added a comment. In D72684#1820486 , @clayborg wrote: > We might also want to move these into lldb/source/Plugins/TypeSystem as well > to complete this refactor? You could move it now, but ValueObject still depends on it (and you would be

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

clayborg added a comment. We might also want to move these into lldb/source/Plugins/TypeSystem as well to complete this refactor? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://reviews.llvm.org/D72684 ___ lldb-commits

[Lldb-commits] [PATCH] D72662: dotest.py: Add option to pass extra lldb settings to dotest

This revision was automatically updated to reflect the committed changes. Closed by commit rGb53d44b17a16: dotest.py: Add option to pass extra lldb settings to dotest (authored by aprantl). Changed prior to commit: https://reviews.llvm.org/D72662?vs=237803=238072#toc Repository: rG LLVM

[Lldb-commits] [lldb] b53d44b - dotest.py: Add option to pass extra lldb settings to dotest

Author: Adrian Prantl Date: 2020-01-14T12:35:24-08:00 New Revision: b53d44b17a1685e405415cd32c4b6eb89cc4c3a1 URL: https://github.com/llvm/llvm-project/commit/b53d44b17a1685e405415cd32c4b6eb89cc4c3a1 DIFF: https://github.com/llvm/llvm-project/commit/b53d44b17a1685e405415cd32c4b6eb89cc4c3a1.diff

[Lldb-commits] [PATCH] D72662: dotest.py: Add option to pass extra lldb settings to dotest

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:52 +# Any overridden settings. +settings = [] + labath wrote: > JDevlieghere wrote: > > To initialize settings to a empty

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

aprantl added a comment. In D72684#1820205 , @davide wrote: > This is very good, go for it. Should we do the same for Swift? cc: @aprantl Yeah, otherwise this is going to be confusing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/

[Lldb-commits] [PATCH] D72662: dotest.py: Add option to pass extra lldb settings to dotest

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:787 +def disabledynamics(): +setSetting('target.prefer-dynamic-value', 'no-dynamic-values') jingham wrote: > labath wrote: > > Maybe you could even put this as the

[Lldb-commits] [PATCH] D72662: dotest.py: Add option to pass extra lldb settings to dotest

jingham added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:787 +def disabledynamics(): +setSetting('target.prefer-dynamic-value', 'no-dynamic-values') labath wrote: > Maybe you could even put this as the default value for the

[Lldb-commits] [lldb] ab72db7 - [lldb/test] test_breakpoints_func_full from TestNamespace.NamespaceBreakpointTestCase is now passing on Windows

Author: Stella Stamenova Date: 2020-01-14T11:15:48-08:00 New Revision: ab72db7fc85266f094cc6b9452dd01f175c04cab URL: https://github.com/llvm/llvm-project/commit/ab72db7fc85266f094cc6b9452dd01f175c04cab DIFF:

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

jingham added a comment. I agree it should be TypeSystemClang, since that's how we name all the plugins. Other that that this seems like a great change. We should do the same for swift to keep things consistent, though that's not relevant to this patch. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

davide added a comment. This is very good, go for it. Should we do the same for Swift? cc: @aprantl For the future, please CC: me directly on these kind of changes if you want my review, as I might miss them otherwise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

xiaobai added a comment. I like this idea quite a bit, but have no preference for `ClangTypeSystem` or `TypeSystemClang`. +1 from me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://reviews.llvm.org/D72684 ___

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

clayborg added a comment. In D71487#1820074 , @probinson wrote: > In D71487#1791824 , @clayborg wrote: > > > BTW: is used to be that both DW_AT_low_pc and DW_AT_high_pc would be set to > > zero when a function was

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

probinson added a comment. In D71487#1791824 , @clayborg wrote: > BTW: is used to be that both DW_AT_low_pc and DW_AT_high_pc would be set to > zero when a function was dead stripped. This was back when both the low and > high pc used DW_FORM_addr (a

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

probinson added a comment. In D69309#1787994 , @friss wrote: > In D69309#1787409 , @labath wrote: > > > In D69309#1787297 , @jarin wrote: > > > > > In D69309#1752738

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor updated this revision to Diff 237981. teemperor added a comment. - Readd test files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72694/new/ https://reviews.llvm.org/D72694 Files:

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

teemperor updated this revision to Diff 237959. teemperor retitled this revision from "[lldb][NFC] Rename ClangASTContext to ClangTypeSystem" to "[lldb][NFC] Rename ClangASTContext to TypeSystemClang". teemperor added a comment. - Revert to original dummy patch. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4b5bc38 - [lldb/DWARF] Move location list sections into DWARFContext

Author: Pavel Labath Date: 2020-01-14T15:19:29+01:00 New Revision: 4b5bc38802dcc7d2c6d7f5af1eca1755bd0fd9cb URL: https://github.com/llvm/llvm-project/commit/4b5bc38802dcc7d2c6d7f5af1eca1755bd0fd9cb DIFF: https://github.com/llvm/llvm-project/commit/4b5bc38802dcc7d2c6d7f5af1eca1755bd0fd9cb.diff

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor updated this revision to Diff 237960. teemperor added a comment. - Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72694/new/ https://reviews.llvm.org/D72694 Files: lldb/packages/Python/lldbsuite/test/commands/expression/completion-crash1/TestCompletionCrash1.py

[Lldb-commits] [PATCH] D72251: [RFC] Support SVE registers access on AArch64 Linux

labath added a comment. This doesn't seem too bad from a quick pass, the thing I'd like to see here is to split this up into several patches (and least client vs. server side) and have proper tests for each part (I'm particularly interested in gdb-client-like tests to give coverage to the

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to ClangTypeSystem

teemperor added a comment. Huh, seems I uploaded to the wrong review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://reviews.llvm.org/D72684 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

labath closed this revision. labath added a comment. Committed as a705cf1ac . It should be worth noting that this actually fixes TestPrintf.py (pr36715), because we no longer end up calling the member printf function. So

[Lldb-commits] [lldb] a705cf1 - Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

Author: Levon Ter-Grigoryan Date: 2020-01-14T14:59:56+01:00 New Revision: a705cf1acbe94498f7fcca4e89be6d4820271227 URL: https://github.com/llvm/llvm-project/commit/a705cf1acbe94498f7fcca4e89be6d4820271227 DIFF:

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

labath added a comment. The patch looks pretty good. A reasonable way to test this would be again via `lldb-test object-file` . The command dumps the "unified section list" of the module, so if the debug info sections show up there, you know the symbol vendor has done it's job. You can look at

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to ClangTypeSystem

teemperor updated this revision to Diff 237953. teemperor added a comment. - Rebased to get rid of shady StringRef -> C-String conversion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://reviews.llvm.org/D72684 Files:

[Lldb-commits] [lldb] 3f944a8 - [lldb][NFC] Make name parameter in AddMethodToCXXRecordType a StringRef

Author: Raphael Isemann Date: 2020-01-14T14:26:29+01:00 New Revision: 3f944a8b8ca895667f04748f62d350f07ee1416b URL: https://github.com/llvm/llvm-project/commit/3f944a8b8ca895667f04748f62d350f07ee1416b DIFF:

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

labath added a subscriber: merge_guards_bot. labath added a comment. In D71575#1814658 , @paolosev wrote: > I apologize for the noob question, but how do I schedule a build for this > diff with Harbormaster? Harbormaster is a red herring. There's no

[Lldb-commits] [PATCH] D72698: [lldb] Add method decls to a CXXRecordDecl only after all their properties are defined

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Calling `addDecl` on a CXXRecordDecl is not a trivial method but is actually inspecting the added declarations to infer properties about the

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

labath added a comment. Sorry for the delay. I was trying to figure out whether I want to get into the whole DataExtractor discussion or not -- I eventually did... :/ Besides that bit, I think this is looking good.. Comment at:

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor added a comment. FWIW this patch makes me realise that we really should have a Sema around when we create the module AST as this would prevent issues like this and saves us from simulating Sema behavior. That's probably yet another large refactoring so I don't have time for that

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor updated this revision to Diff 237948. teemperor added a comment. - Upload correct revision of the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72694/new/ https://reviews.llvm.org/D72694 Files:

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere, aprantl. Herald added a project: LLDB. CXXRecordDecls that have a move constructor but no copy constructor need to have their implicit copy constructor marked as deleted (see

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

labath added a comment. In D72597#1819185 , @SouraVX wrote: > In D72597#1819164 , @labath wrote: > > > I have a high-level question/comment. Are you planning to implement > > debug_macro reading in llvm-dwarfdump?

[Lldb-commits] [PATCH] D71761: [lldb] Add a setting to not install the main executable

danielkiss added a comment. Thanks for the review, I have no push rights, could you please submit it on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71761/new/ https://reviews.llvm.org/D71761

[Lldb-commits] [PATCH] D72510: [lldb/Expression] Improve interpreter error message with a non-running target

This revision was automatically updated to reflect the committed changes. Closed by commit rG877723b7ce81: [lldb/Expression] Improve interpreter error message with a non-running target (authored by mib). Changed prior to commit: https://reviews.llvm.org/D72510?vs=237917=237932#toc Repository:

[Lldb-commits] [lldb] 877723b - [lldb/Expression] Improve interpreter error message with a non-running target

Author: Med Ismail Bennani Date: 2020-01-14T13:06:58+01:00 New Revision: 877723b7ce813d25fc4a358b7d2cb90468733a72 URL: https://github.com/llvm/llvm-project/commit/877723b7ce813d25fc4a358b7d2cb90468733a72 DIFF:

[Lldb-commits] [PATCH] D72510: [lldb/Expression] Improve interpreter error message with a non-running target

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72510/new/ https://reviews.llvm.org/D72510

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX added a comment. In D72597#1819164 , @labath wrote: > I have a high-level question/comment. Are you planning to implement > debug_macro reading in llvm-dwarfdump? Even if you aren't, I am expecting > that you will be asked to do that as a part

[Lldb-commits] [PATCH] D72595: Fix lookup of symbols at the same address with no size vs. size

labath added a comment. > Apparently ARM32 relies on that section symbol to have proper size. I do not > see how Symtab::InitAddressIndexes could handle STT_SECTION in a special way > as that is ELF-type specific Symbol characteristics: Right, so I think that the thing we need to fix is the

[Lldb-commits] [PATCH] D72510: [lldb/Expression] Improve interpreter error message with a non-running target

mib updated this revision to Diff 237917. mib edited the summary of this revision. mib added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72510/new/ https://reviews.llvm.org/D72510 Files:

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX marked 4 inline comments as done. SouraVX added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.cpp:62 +const DWARFDataExtractor _str_offset_data, const DWARFDataExtractor _str_data, const bool offset_is_64_bit,

[Lldb-commits] [PATCH] D72510: [lldb/Expression] Improve interpreter error message with a non-running target

mib updated this revision to Diff 237911. mib retitled this revision from "[lldb/Expression] Improve interpreter error message with a non-running target" to "[lldb/Expression] Improve interpreter error message with a non-running target". mib edited the summary of this revision. mib added a

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

labath added a comment. I have a high-level question/comment. Are you planning to implement debug_macro reading in llvm-dwarfdump? Even if you aren't, I am expecting that you will be asked to do that as a part of testing for your debug_macro generation patch... And in that case, it would be

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX updated this revision to Diff 237909. SouraVX added a comment. Thank you everyone, for taking out time and reviewing this. Addressed @clayborg review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72597/new/ https://reviews.llvm.org/D72597 Files:

[Lldb-commits] [lldb] 9492e9d - [lldb][NFC] Cleanup ClangASTContext::CompleteTagDeclarationDefinition

Author: Raphael Isemann Date: 2020-01-14T12:04:24+01:00 New Revision: 9492e9d8cfd356109276da5aa926b297db0e16db URL: https://github.com/llvm/llvm-project/commit/9492e9d8cfd356109276da5aa926b297db0e16db DIFF:

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to ClangTypeSystem

teemperor added a comment. Both TypeSystemClang and ClangTypeSystem works for me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://reviews.llvm.org/D72684 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to ClangTypeSystem

labath added a comment. `TypeSystemClang` would probably be more consistent with how other lldb classes are named (`SymbolFileDWARF`, `ValueObjectChild`, etc.), but I don't have a big problem with ClangTypeSystem either... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72593: [lldb][NFC] Rewrite python_api/rdar-12481949 test

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8ffd601d523: [lldb][NFC] Rewrite python_api/rdar-12481949 test (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72593/new/

[Lldb-commits] [PATCH] D72662: dotest.py: Add option to pass extra lldb settings to dotest

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems reasonable. Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:52 +# Any overridden settings. +settings = [] + JDevlieghere wrote: > To

[Lldb-commits] [lldb] d8ffd60 - [lldb][NFC] Rewrite python_api/rdar-12481949 test

Author: Raphael Isemann Date: 2020-01-14T10:10:24+01:00 New Revision: d8ffd601d523fa0c0a55e25e62af9ffaa618629d URL: https://github.com/llvm/llvm-project/commit/d8ffd601d523fa0c0a55e25e62af9ffaa618629d DIFF:

[Lldb-commits] [PATCH] D72596: [lldb] Don't defend against internal LLVM errors in IRInterpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rGf18370fe0e75: [lldb] Dont defend against internal LLVM errors in IRInterpreter (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f18370f - [lldb] Don't defend against internal LLVM errors in IRInterpreter

Author: Raphael Isemann Date: 2020-01-14T09:55:34+01:00 New Revision: f18370fe0e7576fb9947e49d66f7a6962c6822ce URL: https://github.com/llvm/llvm-project/commit/f18370fe0e7576fb9947e49d66f7a6962c6822ce DIFF:

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

labath added inline comments. Comment at: lldb/include/lldb/Symbol/TypeSystem.h:201 + virtual llvm::Optional + GetClassName(const CompilerType _type) = 0; + I'm confused by the CompilerType argument here. It seems odd as the CompilerType object already

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to ClangTypeSystem

teemperor added a comment. We are currently after a fresh rebranch downstream so now is a good time to rename this without causing merge-conflict hell later on. It would be useful if could get consensus if and to what we should rename this class soon-ish so that I can make this move as

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to ClangTypeSystem

teemperor created this revision. teemperor added reviewers: LLDB, aprantl, shafik, clayborg. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. This commit renames ClangASTContext to ClangTypeSystem to better reflect what this class is actually supposed to

[Lldb-commits] [PATCH] D72596: [lldb] Don't defend against internal LLVM errors in IRInterpreter

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, I remember being baffled by this in the past... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72596/new/ https://reviews.llvm.org/D72596

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

This revision was automatically updated to reflect the committed changes. Closed by commit rG61b6a4e82653: [lldb] Fix that SBThread.GetStopDescription is returning strings with… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 61b6a4e - [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

Author: Raphael Isemann Date: 2020-01-14T09:34:32+01:00 New Revision: 61b6a4e82653e1209126404d33ad20a268f55db1 URL: https://github.com/llvm/llvm-project/commit/61b6a4e82653e1209126404d33ad20a268f55db1 DIFF:

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

tejohnson added a comment. I'm not sure if ThinLTOCodeGenerator.cpp and LTOBackend.cpp were intentionally left out due to the LTO concerns mentioned in the description? Note if we are just passing in the Module and updating the TM based on that, it wouldn't hit the threading issue I mentioned

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

khchen added a comment. I think putting the resetTargetDefaultOptions after instance of TargetMachine is too late. for example: ppc and mips