Re: [Lldb-commits] [lldb] 9be5c13 - [lldb/Test] Add check-lldb-repro target

On Wed, 22 Jan 2020, Jonas Devlieghere via lldb-commits wrote: Author: Jonas Devlieghere Date: 2020-01-22T17:35:45-08:00 New Revision: 9be5c13538898c7632c2de7300de9479688a2460 URL: https://github.com/llvm/llvm-project/commit/9be5c13538898c7632c2de7300de9479688a2460 DIFF: https://github.com/l

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev updated this revision to Diff 239784. paolosev added a comment. I have verified the logic of the dynamic loader quite carefully, but there are a couple of things to clarify. A Wasm module is loaded at a 64 bit address, where the upper 32 bits are used as module identifier. Let’s say th

[Lldb-commits] [PATCH] D73148: [lldb/Value] Report size of Value as size of underlying data buffer

labath added a comment. In D73148#1834955 , @vsk wrote: > In D73148#1832897 , @clayborg wrote: > > > Actually it would be nice to have a test that will trigger on at least one > > build bot that runs ASAN? > > > I'

[Lldb-commits] [PATCH] D73225: Handle the new objc direct dispatch accelerator functions for uncommonly overridden methods

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp:317 + else +stop_reason = stop_info_sp->GetStopReason(); + jingham wrote: > JDevlieghere wrote: > > ``` >

[Lldb-commits] [lldb] 48490e3 - [lldb/Docs] Document testing strategies for the reproducers

Author: Jonas Devlieghere Date: 2020-01-22T18:02:36-08:00 New Revision: 48490e3247af93eaf576a7bf1c1f6b7450fe6d54 URL: https://github.com/llvm/llvm-project/commit/48490e3247af93eaf576a7bf1c1f6b7450fe6d54 DIFF: https://github.com/llvm/llvm-project/commit/48490e3247af93eaf576a7bf1c1f6b7450fe6d54.d

[Lldb-commits] [PATCH] D73148: [lldb/Value] Report size of Value as size of underlying data buffer

vsk updated this revision to Diff 239753. vsk edited the summary of this revision. This revision is now accepted and ready to land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73148/new/ https://reviews.llvm.org/D73148 Files: lldb/packages/Python/lldbsuite/test/functionalities/dw_op_

[Lldb-commits] [lldb] 9b5a9f2 - [lldb/Test] Fix type in add_lit_testsuite

Author: Jonas Devlieghere Date: 2020-01-22T17:51:58-08:00 New Revision: 9b5a9f2fab17d52debce2cde26e94610deeb034c URL: https://github.com/llvm/llvm-project/commit/9b5a9f2fab17d52debce2cde26e94610deeb034c DIFF: https://github.com/llvm/llvm-project/commit/9b5a9f2fab17d52debce2cde26e94610deeb034c.d

[Lldb-commits] [lldb] 9be5c13 - [lldb/Test] Add check-lldb-repro target

Author: Jonas Devlieghere Date: 2020-01-22T17:35:45-08:00 New Revision: 9be5c13538898c7632c2de7300de9479688a2460 URL: https://github.com/llvm/llvm-project/commit/9be5c13538898c7632c2de7300de9479688a2460 DIFF: https://github.com/llvm/llvm-project/commit/9be5c13538898c7632c2de7300de9479688a2460.d

[Lldb-commits] [lldb] 83a093b - [lldb/Reproducer] Mark some driver tests as unsupported for lldb-repro

Author: Jonas Devlieghere Date: 2020-01-22T17:18:06-08:00 New Revision: 83a093b8ecc8a8e3a4420dc5385dca57e8016109 URL: https://github.com/llvm/llvm-project/commit/83a093b8ecc8a8e3a4420dc5385dca57e8016109 DIFF: https://github.com/llvm/llvm-project/commit/83a093b8ecc8a8e3a4420dc5385dca57e8016109.d

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

shafik updated this revision to Diff 239732. shafik marked 14 inline comments as done. shafik added a comment. Realized that the assert that I was hitting in some cases only reproduced using C++ for example one case we needed to use a class w/ private members. So created a new bit-field test wh

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2393 lldb_private::ClangASTImporter::LayoutInfo &layout_info, -BitfieldInfo &last_field_info) { +FieldInfo &last_bitfield_info, FieldInfo &last_field_info) { Mod

[Lldb-commits] [lldb] c4144ca - [lldb/Reproducer] Disable buffering of stdout during replay

Author: Jonas Devlieghere Date: 2020-01-22T16:17:08-08:00 New Revision: c4144caf9b865a2064e49afcdfff474426fc5d47 URL: https://github.com/llvm/llvm-project/commit/c4144caf9b865a2064e49afcdfff474426fc5d47 DIFF: https://github.com/llvm/llvm-project/commit/c4144caf9b865a2064e49afcdfff474426fc5d47.d

[Lldb-commits] [lldb] 1f45914 - Embed a zero-length /dev/null in darwin-debug for the special section.

Author: Jason Molenda Date: 2020-01-22T15:50:33-08:00 New Revision: 1f45914b4289db7e5ec8d5759707c16e865f02e5 URL: https://github.com/llvm/llvm-project/commit/1f45914b4289db7e5ec8d5759707c16e865f02e5 DIFF: https://github.com/llvm/llvm-project/commit/1f45914b4289db7e5ec8d5759707c16e865f02e5.diff

[Lldb-commits] [PATCH] D73225: Handle the new objc direct dispatch accelerator functions for uncommonly overridden methods

jingham marked 13 inline comments as done. jingham added a comment. Thanks for the suggestions! A couple were not to my taste, but I fixed all the others. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp:317 +

[Lldb-commits] [PATCH] D73225: Handle the new objc direct dispatch accelerator functions for uncommonly overridden methods

jingham updated this revision to Diff 239722. jingham added a comment. Addressed Jonas' review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73225/new/ https://reviews.llvm.org/D73225 Files: lldb/include/lldb/Target/ThreadPlan.h lldb

[Lldb-commits] [lldb] 6ae61f7 - [lldb/Test] Skip script interpreter tests reading from stdin for lldb-repro

Author: Jonas Devlieghere Date: 2020-01-22T15:22:25-08:00 New Revision: 6ae61f7675d65e767662873e87de088b0ae2dc3e URL: https://github.com/llvm/llvm-project/commit/6ae61f7675d65e767662873e87de088b0ae2dc3e DIFF: https://github.com/llvm/llvm-project/commit/6ae61f7675d65e767662873e87de088b0ae2dc3e.d

[Lldb-commits] [PATCH] D73148: [lldb/Value] Report size of Value as size of underlying data buffer

vsk planned changes to this revision. vsk added a comment. In D73148#1832897 , @clayborg wrote: > Actually it would be nice to have a test that will trigger on at least one > build bot that runs ASAN? I'll add an end-to-end test for DW_OP_piece, though

[Lldb-commits] [lldb] 4c2b0a6 - [lldb/Utility] Don't forward directories to the file collector

Author: Jonas Devlieghere Date: 2020-01-22T15:01:53-08:00 New Revision: 4c2b0a63661576c1849862bad3978050fc6a2ff7 URL: https://github.com/llvm/llvm-project/commit/4c2b0a63661576c1849862bad3978050fc6a2ff7 DIFF: https://github.com/llvm/llvm-project/commit/4c2b0a63661576c1849862bad3978050fc6a2ff7.d

[Lldb-commits] [PATCH] D73225: Handle the new objc direct dispatch accelerator functions for uncommonly overridden methods

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp:786 + + m_opt_dispatch_map.insert(std::pair(sym_addr, i)); +} You could simplify this by using `.emplace(sym_addr, i

[Lldb-commits] [lldb] f55b033 - [TestStdModuleSysroot] Only run locally.

Author: Davide Italiano Date: 2020-01-22T13:56:51-08:00 New Revision: f55b033c028019653fed8fc685b1d33bf529b92b URL: https://github.com/llvm/llvm-project/commit/f55b033c028019653fed8fc685b1d33bf529b92b DIFF: https://github.com/llvm/llvm-project/commit/f55b033c028019653fed8fc685b1d33bf529b92b.dif

[Lldb-commits] [PATCH] D73225: Handle the new objc direct dispatch accelerator functions for uncommonly overridden methods

jingham created this revision. jingham added reviewers: friss, JDevlieghere. Herald added subscribers: lldb-commits, aprantl. Herald added a project: LLDB. Clang added a new feature to the ObjC compiler that will translate method calls to commonly un-overridden methods into a function that checks

[Lldb-commits] [lldb] 31662e6 - [lldb/Util] Fix lldb-repro now it doesn't take a path to lldb

Author: Jonas Devlieghere Date: 2020-01-22T13:24:12-08:00 New Revision: 31662e67e089264dabc9d1f915aa1d7b4d51c0a3 URL: https://github.com/llvm/llvm-project/commit/31662e67e089264dabc9d1f915aa1d7b4d51c0a3 DIFF: https://github.com/llvm/llvm-project/commit/31662e67e089264dabc9d1f915aa1d7b4d51c0a3.d

[Lldb-commits] [lldb] 536612d - [lldb/Test] Use lit's capabilities to skip lldb-repro tests.

Author: Jonas Devlieghere Date: 2020-01-22T13:24:12-08:00 New Revision: 536612df4b499c7338719ab8a31973f086bff590 URL: https://github.com/llvm/llvm-project/commit/536612df4b499c7338719ab8a31973f086bff590 DIFF: https://github.com/llvm/llvm-project/commit/536612df4b499c7338719ab8a31973f086bff590.d

[Lldb-commits] [lldb] 89c8866 - Convert AssertTrue( A == B) to AssertEqual(A, B) in TestObjCStepping.py.

Author: Jim Ingham Date: 2020-01-22T13:20:15-08:00 New Revision: 89c8866c0417a415ab546aa870569308f15b0ec8 URL: https://github.com/llvm/llvm-project/commit/89c8866c0417a415ab546aa870569308f15b0ec8 DIFF: https://github.com/llvm/llvm-project/commit/89c8866c0417a415ab546aa870569308f15b0ec8.diff LO

[Lldb-commits] [PATCH] D73119: [lldb/Initializers] Rename plugins to match their entry points

labath added a comment. In D73119#1834279 , @JDevlieghere wrote: > In D73119#1833232 , @labath wrote: > > > As for `AppleObjCRuntime`, I'm not insisting on changing that, though I am > > wondering if that won't ge

[Lldb-commits] [PATCH] D73119: [lldb/Initializers] Rename plugins to match their entry points

JDevlieghere added a comment. In D73119#1833232 , @labath wrote: > As for `AppleObjCRuntime`, I'm not insisting on changing that, though I am > wondering if that won't get it your way when autogenerating the initalizers. > I'm not fully sure what are you

[Lldb-commits] [PATCH] D73206: `DWARFASTParserClang::m_decl_ctx_to_die` `DWARFDIE`->`DIERef` for DWZ

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: aprantl. Herald added a reviewer: shafik. I think this patch is not good. I wrote it to as a solution to @labath's request that `DWARFDIE` should n

[Lldb-commits] [lldb] 9dc9f7c - [lldb/Target] Sort CMakeLists (NFC)

Author: Med Ismail Bennani Date: 2020-01-22T16:38:37+01:00 New Revision: 9dc9f7ca145e7fd5fafbdf071a2e5b5914918c04 URL: https://github.com/llvm/llvm-project/commit/9dc9f7ca145e7fd5fafbdf071a2e5b5914918c04 DIFF: https://github.com/llvm/llvm-project/commit/9dc9f7ca145e7fd5fafbdf071a2e5b5914918c04.

[Lldb-commits] [PATCH] D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646

jankratochvil abandoned this revision. jankratochvil marked an inline comment as done. jankratochvil added a comment. I tried to use `DIERef` instead of `DWARFDIE` everywhere as @labath does not like to increase `DWARFDIE` size from 16 bytes to 24 bytes. But that is not really feasible. For `DI

[Lldb-commits] [PATCH] D73191: Ignore methods in full-name function lookup (with accelerators)

jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added subscribers: lldb-commits, arphaman, aprantl. In the spirit of https://reviews.llvm.org/D70846, we only return non-methods in Apple/DebugNamesDWARFIndex::GetFunction if eFunctionNameTypeFull is

[Lldb-commits] [PATCH] D70645: RFC 1/3: Unify src<->dst DWARFASTParser for CopyUniqueClassMethodTypes()

jankratochvil abandoned this revision. jankratochvil added a comment. This refactorization is no longer needed as I am abandoning D70647 to choose a different way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7064

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

teemperor added a comment. I just went back to the radar we had about the CG crash and this *does* fix that issue (rdar://53932023). I could also not reproduce the CG crash again so I assume that was something else that fiddled around in that area. So LGTM minus the thing with the `last_bitfiel

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

jankratochvil updated this revision to Diff 239571. jankratochvil retitled this revision from "RFC 2/3: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`" to "Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`". jankratochvil edited the summary of this revision. Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D73112: [lldb/DWARF] Remove one more auto-dwo method

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d7177acd751: [lldb/DWARF] Remove one more auto-dwo method (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73112/new/ https://reviews.ll

[Lldb-commits] [lldb] 3d7177a - [lldb/DWARF] Remove one more auto-dwo method

Author: Pavel Labath Date: 2020-01-22T13:03:57+01:00 New Revision: 3d7177acd751704d42278ea78e5353943187045d URL: https://github.com/llvm/llvm-project/commit/3d7177acd751704d42278ea78e5353943187045d DIFF: https://github.com/llvm/llvm-project/commit/3d7177acd751704d42278ea78e5353943187045d.diff

[Lldb-commits] [PATCH] D73125: [lldb/Plugins] Move entry points out of plugin namespace

labath added a comment. A weaker for of that would be to do something like `using ProcessGDBRemote = process_gdb_remote::ProcessGDBRemote`, which would require less changes to existing plugins, but it would still require us to include all the headers... Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [PATCH] D73125: [lldb/Plugins] Move entry points out of plugin namespace

labath added a comment. Some of these plugins are very simple (a single class) and so having the namespace there is not that useful. However, for the not-so-simple plugins, it seems strange to have one part of it be in the namespace, and one part outside. E.g., it's unfortunate that that Proces

[Lldb-commits] [PATCH] D73119: [lldb/Initializers] Rename plugins to match their entry points

labath added a comment. In D73119#1832707 , @JDevlieghere wrote: > I think the remaining discrepancies between the plugin name and the directory > make sense. For example, I don't really see the benefit of renaming > `AppleObjCRuntime` to `LanguageRunti

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

labath added a comment. It took me a while, but I tracked this down to the lack of `%` in front of lldb in the RUN: commands. We don't have an "lldb" substitution, so this ends up running whatever it finds on the path. Normally this does not matter because we add the build dir to the lit path,

[Lldb-commits] [lldb] 889a4f5 - [lldb] s/lldb/%lldb in two tests

Author: Pavel Labath Date: 2020-01-22T11:02:29+01:00 New Revision: 889a4f55c9100d55f9c120b8408c16491d73c7b5 URL: https://github.com/llvm/llvm-project/commit/889a4f55c9100d55f9c120b8408c16491d73c7b5 DIFF: https://github.com/llvm/llvm-project/commit/889a4f55c9100d55f9c120b8408c16491d73c7b5.diff

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

labath added a comment. Thanks. I believe this should be fixed by 0157a74be . I'll check the bot to confirm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71770/new/ https://rev

[Lldb-commits] [lldb] 0157a74 - [lldb] Fix an asan error from 27df2d9f556c

Author: Pavel Labath Date: 2020-01-22T10:14:47+01:00 New Revision: 0157a74bec3d2ef1fac5b874327b97d2ae8e95c8 URL: https://github.com/llvm/llvm-project/commit/0157a74bec3d2ef1fac5b874327b97d2ae8e95c8 DIFF: https://github.com/llvm/llvm-project/commit/0157a74bec3d2ef1fac5b874327b97d2ae8e95c8.diff