[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

xiaobai updated this revision to Diff 240762. xiaobai added a comment. Sort headers via clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72946/new/ https://reviews.llvm.org/D72946 Files: lldb/include/lldb/Symbol/TypeSystemClang.h lld

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

xiaobai added a comment. Note: This makes D69820 unnecessary so I will close that if this goes through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73517/new/ https://reviews.llvm.org/D73517 _

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

xiaobai created this revision. xiaobai added reviewers: teemperor, labath, clayborg, JDevlieghere. Herald added a project: LLDB. This method has exactly one call site, which is only actually executed if `ValueObject::IsBaseClass` returns false. However, the first thing that `ValueObject::GetBaseCl

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

mib updated this revision to Diff 240744. mib marked 2 inline comments as done. mib retitled this revision from "[lldb/Target] Add Abort StackFrame Recognizer" to "[lldb/Target] Add Assert StackFrame Recognizer". mib edited the summary of this revision. mib added a comment. Renamed AbortRecognize

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib marked 9 inline comments as done. mib added inline comments. Comment at: lldb/docs/use/formatting.rst:137 +---+---

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev added a comment. Comments inline... >> In D72751#1835502 , @paolosev wrote: >> >>> The first is that we need to call `Target::SetSectionLoadAddress()` twice, >>> from two different places. First we need to call >>> `Target::SetSectionLoadAddres

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

diazhector98 updated this revision to Diff 240717. diazhector98 marked an inline comment as done. diazhector98 added a comment. changed int to size_t to avoid warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

diazhector98 updated this revision to Diff 240715. diazhector98 edited the summary of this revision. diazhector98 added a comment. int32 to int Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org/D73506 Files: lldb

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev updated this revision to Diff 240711. paolosev added a comment. In D72751#1841498 , @labath wrote: > Thanks. I am glad that we were able to sort that out. > > Now that there's nothing wasm-specific in > `DynamicLoaderWasmDYLD::LoadModuleAtAddress

[Lldb-commits] [PATCH] D73506: Bug fix

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:960 +int commit_points_index = -1; +for (uint32_t breakpoint_index = 0; breakpoint_index < commit_points.size(); breakpoint_index++) { + int breakpoint_position = match.rfind(commit_po

[Lldb-commits] [PATCH] D73506: Bug fix

diazhector98 updated this revision to Diff 240701. diazhector98 added a comment. Uncomment @skipIfDarwin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org/D73506 Files: lldb/packages/Python/lldbsuite/test/tools/l

[Lldb-commits] [PATCH] D73506: Bug fix

diazhector98 updated this revision to Diff 240700. diazhector98 added a comment. Added more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org/D73506 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vsc

[Lldb-commits] [PATCH] D73314: [lldb/Commands] Make column available through _regexp-break

This revision was automatically updated to reflect the committed changes. Closed by commit rG223a209027b4: [lldb/Commands] Make column available through _regexp-break (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73314/new

[Lldb-commits] [PATCH] D73506: Bug fix

diazhector98 updated this revision to Diff 240694. diazhector98 added a comment. 1. Updating D73506 : Bug fix # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended

[Lldb-commits] [PATCH] D73506: Bug fix

diazhector98 updated this revision to Diff 240693. diazhector98 added a comment. 1. Updating D73506 : Bug fix # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended

[Lldb-commits] [lldb] 223a209 - [lldb/Commands] Make column available through _regexp-break

Author: Jonas Devlieghere Date: 2020-01-27T15:11:00-08:00 New Revision: 223a209027b44daeac53508bea154bc29314bddb URL: https://github.com/llvm/llvm-project/commit/223a209027b44daeac53508bea154bc29314bddb DIFF: https://github.com/llvm/llvm-project/commit/223a209027b44daeac53508bea154bc29314bddb.d

[Lldb-commits] [lldb] 94ec56b - [lldb/Test] Use lit.local.cfg to mark whole directory as (un)supported.

Author: Jonas Devlieghere Date: 2020-01-27T15:11:00-08:00 New Revision: 94ec56b6d5e239a76345afeffe1cc3079235a9f6 URL: https://github.com/llvm/llvm-project/commit/94ec56b6d5e239a76345afeffe1cc3079235a9f6 DIFF: https://github.com/llvm/llvm-project/commit/94ec56b6d5e239a76345afeffe1cc3079235a9f6.d

[Lldb-commits] [PATCH] D73506: Bug fix

diazhector98 updated this revision to Diff 240687. diazhector98 added a comment. 1. Updating D73506 : Bug fix # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended

[Lldb-commits] [PATCH] D73024: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Symbol/ClangASTImporter.cpp:1006 +/// Takes a CXXMethodDecl and completes the return type if necessary. This +/// is currently only necessary for

[Lldb-commits] [PATCH] D73506: Bug fix

diazhector98 updated this revision to Diff 240683. diazhector98 added a comment. 1. Updating D73506 : Bug fix # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended

[Lldb-commits] [PATCH] D73506: Bug fix

diazhector98 planned changes to this revision. diazhector98 marked 5 inline comments as done. diazhector98 added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py:122 +self.verify_completions( +

[Lldb-commits] [PATCH] D73506: Bug fix

diazhector98 created this revision. diazhector98 added a reviewer: wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. diazhector98 planned changes to this revision. diazhector98 marked 5 inline comments as done. diazhector98 added inline comments. Com

[Lldb-commits] [PATCH] D73345: [lldb] Don't create duplicate declarations when completing a forward declaration with a definition from another source

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73345/new/ https://reviews.llvm.org/D73345 ___ lldb-commits

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo marked 2 inline comments as done. mstorsjo added inline comments. Comment at: lldb/include/lldb/Expression/DWARFExpression.h:142 + std::pair GetLocationListAddresses() const; + clayborg wrote: > Might be better as two functions? One to get the CU addr

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

clayborg added inline comments. Comment at: lldb/include/lldb/Expression/DWARFExpression.h:142 + std::pair GetLocationListAddresses() const; + Might be better as two functions? One to get the CU address and func address: ``` lldb_private::Address GetCUAddress

[Lldb-commits] [PATCH] D73314: [lldb/Commands] Make column available through _regexp-break

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. lgtm Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73314/new/ https://reviews.llvm.org/D73314 ___ lldb-com

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

JDevlieghere added inline comments. Comment at: lldb/docs/use/formatting.rst:137 +---+

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

clayborg added a comment. In D72751#1835656 , @labath wrote: > [ looping in @aadsm for the svr4 stuff ] > > Thanks for adding the test, and for the detailed writeup. Please find my > comments inline. > > In D72751#1835502

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So it might be better to create a ELF file for a remote platform, then run "obj2yaml" on it. Then the test will run "yaml2obj" on it, there are many test cases that do this, so l

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib updated this revision to Diff 240543. mib marked 12 inline comments as done. mib added a comment. Changed the RecognizedStackFrame and AbortRecognizedStackFrame to add a StopReasonDescription method instead of a StopInfo instance. This way, lldb can show a special stop reason description, fo

Re: [Lldb-commits] [lldb] fcaf5f6 - [LLDB] Fix the handling of unnamed bit-fields when parsing DWARF

Sure, b5cf892651812003e64c4a8f0dbf81f74a499016 On Mon, Jan 27, 2020 at 12:18 AM Raphael Isemann wrote: > > This commit fixes a *very* frequent crash when debugging Clang with LLDB 10. > Could we get that cherry-picked into the 10.x branch? > > I’ve been running the patch since more than a week a

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

anton.kolesov updated this revision to Diff 240533. anton.kolesov added a comment. Added a testcase. Because target's architecture is not directly exposed through an API, test looks at the target triplet - it is empty for targets created without an exe file. Without the patch, triplet remains un

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

labath added a reviewer: aprantl. labath added a comment. Thanks for splitting this off. This looks good except that I wouldn't want to put this under the base `TestingSupport` folder -- the idea there was that this would contain only the basic stuff with no fancy dependencies (so that e.g. Uti

[Lldb-commits] [lldb] 9a952fd - [LLDB] Fix build failures after removing Version from DWARFExpression.

Author: Igor Kudrin Date: 2020-01-27T19:33:34+07:00 New Revision: 9a952fd462774e79d8dc514d71bf43ea0ca7f429 URL: https://github.com/llvm/llvm-project/commit/9a952fd462774e79d8dc514d71bf43ea0ca7f429 DIFF: https://github.com/llvm/llvm-project/commit/9a952fd462774e79d8dc514d71bf43ea0ca7f429.diff L

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a comment. Thanks. I am glad that we were able to sort that out. Now that there's nothing wasm-specific in `DynamicLoaderWasmDYLD::LoadModuleAtAddress`, I have another question. :) The code in that function is a subset of the base `DynamicLoader::LoadModuleAtAddress` method you ar

[Lldb-commits] [PATCH] D69273: ValueObject: Fix a crash related to children address type computation

labath added a comment. Thanks for the update Jim. I'm putting some of my thoughts inline. In D69273#1840029 , @jingham wrote: > Sorry, I've been busy with other things. > > In answer to Pavel's direct question "What did we do about the swift crashes" >

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

jarin added a comment. In D73191#1841372 , @labath wrote: > (I mean, if there is a real benefit to having some queries return only > non-methods, then we can certainly do something like that as well, but that > should be handled differently -- either we

[Lldb-commits] [lldb] a311beb - [lldb][NFC] Give import-std-module tests a more unique file names

Author: Raphael Isemann Date: 2020-01-27T10:55:57+01:00 New Revision: a311bebb53d405597f7c66c86a8df7085ca2695c URL: https://github.com/llvm/llvm-project/commit/a311bebb53d405597f7c66c86a8df7085ca2695c DIFF: https://github.com/llvm/llvm-project/commit/a311bebb53d405597f7c66c86a8df7085ca2695c.dif

[Lldb-commits] [lldb] 785c6b2 - [lldb][NFC] Improve documentation for CompletionRequest

Author: Raphael Isemann Date: 2020-01-27T10:48:41+01:00 New Revision: 785c6b22914fa10455ef1bf349447b874bc1f37a URL: https://github.com/llvm/llvm-project/commit/785c6b22914fa10455ef1bf349447b874bc1f37a DIFF: https://github.com/llvm/llvm-project/commit/785c6b22914fa10455ef1bf349447b874bc1f37a.dif

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

labath added a comment. (I mean, if there is a real benefit to having some queries return only non-methods, then we can certainly do something like that as well, but that should be handled differently -- either we can create a new query mode, or change the behavior (and name?) of eFunctionNameT

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:45 if (name_type_mask & eFunctionNameTypeFull) { -dies.push_back(die); -return; +if (!die.I

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

jarin added a comment. Pavel, could you take another look, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73191/new/ https://reviews.llvm.org/D73191 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

jarin updated this revision to Diff 240480. jarin retitled this revision from "Ignore methods in full-name function lookup (with accelerators)" to "Only match mangled name in full-name function lookup (with accelerators)". jarin edited the summary of this revision. jarin added a comment. Only ma

[Lldb-commits] [PATCH] D73191: Ignore methods in full-name function lookup (with accelerators)

jarin marked an inline comment as done. jarin added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:45 if (name_type_mask & eFunctionNameTypeFull) { -dies.push_back(die); -return; +if (!die.IsMethod() || die.GetMangledName(false) ==