[Lldb-commits] [lldb] a497e1b - [lldb] Use CompletionRequest in REPL::CompleteCode and remove translation code to old API

Author: Raphael Isemann Date: 2020-01-29T08:56:32+01:00 New Revision: a497e1b5ea7a681ef1b40b5c11f411bfe0e807d0 URL: https://github.com/llvm/llvm-project/commit/a497e1b5ea7a681ef1b40b5c11f411bfe0e807d0 DIFF:

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

jasonmolenda added a comment. Looks good, for the --shlib option I would get rid of the "full path or base name" language and just say "name", my two cents. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73589/new/ https://reviews.llvm.org/D73589

[Lldb-commits] [lldb] ede5cd9 - [lldb/API] Fix bogus copy assignment operator

Author: Jonas Devlieghere Date: 2020-01-28T17:11:12-08:00 New Revision: ede5cd9a45bd12c0676da80472e629801faa37bf URL: https://github.com/llvm/llvm-project/commit/ede5cd9a45bd12c0676da80472e629801faa37bf DIFF:

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

amccarth created this revision. amccarth added reviewers: clayborg, jasonmolenda. - [NFC] Renamed local `matching_module_list` to `matching_modules` for conciseness. - [NFC] Eliminated redundant local variable `num_matches` to reduce the risk that changes get it out of sync with

[Lldb-commits] [lldb] 1dfe7b5 - [lldb/API] Implement the copy (assignment) constructor for SBLaunchInfo

Author: Jonas Devlieghere Date: 2020-01-28T16:44:58-08:00 New Revision: 1dfe7b5be63e9d80e2704255dbeb6813cc7f6e57 URL: https://github.com/llvm/llvm-project/commit/1dfe7b5be63e9d80e2704255dbeb6813cc7f6e57 DIFF:

[Lldb-commits] [lldb] 66dc467 - [lldb/API] Implement the copy (assignment) constructor for SBPlatform

Author: Jonas Devlieghere Date: 2020-01-28T16:23:03-08:00 New Revision: 66dc467228789cbe94a125d7fdedf42556052ad3 URL: https://github.com/llvm/llvm-project/commit/66dc467228789cbe94a125d7fdedf42556052ad3 DIFF:

[Lldb-commits] [lldb] 71b022e - [lldb] Remove unused header from ValueObject.cpp

Author: Alex Langford Date: 2020-01-28T16:13:21-08:00 New Revision: 71b022ee55d4bfc5a3c3539f4c1c22c7b308a605 URL: https://github.com/llvm/llvm-project/commit/71b022ee55d4bfc5a3c3539f4c1c22c7b308a605 DIFF: https://github.com/llvm/llvm-project/commit/71b022ee55d4bfc5a3c3539f4c1c22c7b308a605.diff

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

amccarth created this revision. amccarth added a reviewer: aaron.ballman. There were some missing words and awkward syntax. I think this is clearer. https://reviews.llvm.org/D73589 Files: lldb/source/Commands/CommandObjectTarget.cpp Index: lldb/source/Commands/CommandObjectTarget.cpp

[Lldb-commits] [lldb] 9a8d42e - [lldb/Plugin] Fix implicit conversion in GDBRemote

Author: Jonas Devlieghere Date: 2020-01-28T15:16:56-08:00 New Revision: 9a8d42e60803ba0b67b3669630530de04cafc079 URL: https://github.com/llvm/llvm-project/commit/9a8d42e60803ba0b67b3669630530de04cafc079 DIFF:

[Lldb-commits] [lldb] e9326ed - [lldb/Reproducer] s/nullptr_t/std::nullptr_t/

Author: Jonas Devlieghere Date: 2020-01-28T15:15:13-08:00 New Revision: e9326ed9067834dca0a1fe752a55c534ed938f8c URL: https://github.com/llvm/llvm-project/commit/e9326ed9067834dca0a1fe752a55c534ed938f8c DIFF:

[Lldb-commits] [lldb] 19580c3 - Fix implicit conversion in the lldb Python plugin

Author: Benjamin Kramer Date: 2020-01-29T00:07:50+01:00 New Revision: 19580c3755a1dc198005839a73a7bad5c108f203 URL: https://github.com/llvm/llvm-project/commit/19580c3755a1dc198005839a73a7bad5c108f203 DIFF:

[Lldb-commits] [lldb] 620f5fa - [lldb/Reproducer] Include result in recording statements

Author: Jonas Devlieghere Date: 2020-01-28T15:03:13-08:00 New Revision: 620f5faf1f340e594bd9cac39a64d9236a324fb9 URL: https://github.com/llvm/llvm-project/commit/620f5faf1f340e594bd9cac39a64d9236a324fb9 DIFF:

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG5eaf44f99f0a: [lldb] Delete ValueObject::GetBaseClassPath (authored by xiaobai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73517/new/

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

xiaobai closed this revision. xiaobai added a comment. Made obsolete by D73517 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69820/new/ https://reviews.llvm.org/D69820

[Lldb-commits] [lldb] 5eaf44f - [lldb] Delete ValueObject::GetBaseClassPath

Author: Alex Langford Date: 2020-01-28T14:11:53-08:00 New Revision: 5eaf44f99f0a0a3bdfa892892b8aaca841c8dbe0 URL: https://github.com/llvm/llvm-project/commit/5eaf44f99f0a0a3bdfa892892b8aaca841c8dbe0 DIFF: https://github.com/llvm/llvm-project/commit/5eaf44f99f0a0a3bdfa892892b8aaca841c8dbe0.diff

[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

xiaobai closed this revision. xiaobai added a comment. Commit c4f6fbe971351273b19a4a819bf6ceae2b70b37e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72946/new/

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

ted updated this revision to Diff 240985. ted added a comment. Removed the code that sets m_constructor_errors when GetLoadAddressPermissions returns False, as requested by @jingham . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72513/new/ https://reviews.llvm.org/D72513 Files:

[Lldb-commits] [lldb] c4f6fbe - [lldb] Remove ClangASTImporter from Target

Author: Alex Langford Date: 2020-01-28T13:40:49-08:00 New Revision: c4f6fbe971351273b19a4a819bf6ceae2b70b37e URL: https://github.com/llvm/llvm-project/commit/c4f6fbe971351273b19a4a819bf6ceae2b70b37e DIFF: https://github.com/llvm/llvm-project/commit/c4f6fbe971351273b19a4a819bf6ceae2b70b37e.diff

[Lldb-commits] [lldb] 8e21d7b - [lldb/Reproducer] Include deserialized value in log statement

Author: Jonas Devlieghere Date: 2020-01-28T13:24:01-08:00 New Revision: 8e21d7b9249e2e35f12dbbaa18287ce8435dd855 URL: https://github.com/llvm/llvm-project/commit/8e21d7b9249e2e35f12dbbaa18287ce8435dd855 DIFF:

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

ted added a comment. Wow @jingham you posted your comment and I landed the patch at the same time! I'll remove the m_constructor_errors.Printf line as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72513/new/

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I don't think you want to put anything in m_constructor_errors in this case either. It's fine to log something out, but ValidatePlan uses m_constructor_errors to help report a

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG04488c485a88: Dont fail step out if remote server doesnt implement qMemoryRegionInfo (authored by ted). Repository:

[Lldb-commits] [lldb] 04488c4 - Don't fail step out if remote server doesn't implement qMemoryRegionInfo

Author: Ted Woodward Date: 2020-01-28T13:36:06-06:00 New Revision: 04488c485a8875ba4bd6d2d004ac778276ae37e0 URL: https://github.com/llvm/llvm-project/commit/04488c485a8875ba4bd6d2d004ac778276ae37e0 DIFF: https://github.com/llvm/llvm-project/commit/04488c485a8875ba4bd6d2d004ac778276ae37e0.diff

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

clayborg added a comment. Speaking to having the LLVM layer strip things out, this should be an option if it does get added there. If we have a stripped binary and we have no symbols or any other CPU map, and DWARF is the only way to tell if a function was ARM or Thumb by looking at bit zero,

[Lldb-commits] [lldb] 3065ef0 - [lldb/Bindings] Sort headers in headers.swig

Author: Jonas Devlieghere Date: 2020-01-28T10:58:07-08:00 New Revision: 3065ef0bf85a3e4028811fc64344d86a1cd2e1ae URL: https://github.com/llvm/llvm-project/commit/3065ef0bf85a3e4028811fc64344d86a1cd2e1ae DIFF:

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

friss added a comment. This generally looks good. I'm still not fond of registering this in the Target itself. But I don't have a immediately better idea as we don't have a C language runtime. A couple more comments/questions that can be addressed as followups: Comment at:

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:400 +entry->base = arch.GetOpcodeLoadAddress(entry->base); + } + if (frame_base && frame_base->IsLocationList()) { Either way, I am not picky.

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

aykevl added a comment. It's worth noting that I haven't managed to get a line table from a binary produced by LLVM (with my own compiler frontend) and linked by avr-gcc. But I believe that is a bug in the AVR backend of LLVM as a binary built entirely by `avr-gcc` works just fine. CHANGES

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

diazhector98 updated this revision to Diff 240916. diazhector98 marked an inline comment as done. diazhector98 added a comment. Added tests for spaces between member operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/

[Lldb-commits] [lldb] 954d042 - Revert "[lldb/Target] Add Assert StackFrame Recognizer"

Author: Med Ismail Bennani Date: 2020-01-28T18:40:08+01:00 New Revision: 954d04295b9b5447139cb1b9b57b9a2a4dd9b656 URL: https://github.com/llvm/llvm-project/commit/954d04295b9b5447139cb1b9b57b9a2a4dd9b656 DIFF:

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

diazhector98 updated this revision to Diff 240908. diazhector98 added a comment. Simplifying code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org/D73506 Files:

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

This revision was automatically updated to reflect the committed changes. Closed by commit rG03a6b858fde5: [lldb/Target] Add Assert StackFrame Recognizer (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73303/new/

[Lldb-commits] [lldb] 03a6b85 - [lldb/Target] Add Assert StackFrame Recognizer

Author: Med Ismail Bennani Date: 2020-01-28T18:21:29+01:00 New Revision: 03a6b858fde5c644ec16b1fddd8e10aa9ef3f0ad URL: https://github.com/llvm/llvm-project/commit/03a6b858fde5c644ec16b1fddd8e10aa9ef3f0ad DIFF:

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

mib updated this revision to Diff 240899. mib added a comment. Added early return in `AssertFrameRecognizer::RecognizeFrame` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73303/new/ https://reviews.llvm.org/D73303 Files:

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Doesn't look like it's used in the swift fork downstream either. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73517/new/

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:155 + + most_relevant_frame_sp = thread_sp->GetStackFrameAtIndex( + std::min(frame_index + 1, last_frame_index)); JDevlieghere

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

jhenderson requested review of this revision. jhenderson added a comment. In D72158#1844534 , @labath wrote: > If I understand this correctly, this will cause lldb to continue to read the > parsed line table contribution after encountering some errors in

[Lldb-commits] [lldb] c4267b7 - Revert "[lldb/PDB] Use the new line table constructor"

Author: Pavel Labath Date: 2020-01-28T17:15:44+01:00 New Revision: c4267b7b1371cc3ffaf6d4e701ab90c082ef18dd URL: https://github.com/llvm/llvm-project/commit/c4267b7b1371cc3ffaf6d4e701ab90c082ef18dd DIFF: https://github.com/llvm/llvm-project/commit/c4267b7b1371cc3ffaf6d4e701ab90c082ef18dd.diff

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with one inline comment, but let's give the other reviewers a chance to take another look before landing this. Comment at:

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

labath added a comment. If I understand this correctly, this will cause lldb to continue to read the parsed line table contribution after encountering some errors in the prologue, whereas previously we would stop straight away. That sounds reasonable if now or in the future we will be able to

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

aykevl updated this revision to Diff 240857. aykevl added a comment. Herald added subscribers: MaskRay, emaste. Herald added a reviewer: espindola. @labath Thank you for the quick review! I have added a test per your suggestions. I'm not very familiar with lldb but this passes the tests.

Re: [Lldb-commits] [lldb] 2046d72 - build: improve python checks for Windows

Should https://llvm.org/docs/GettingStarted.html#requirements and https://llvm.org/docs/CMake.html#quick-start be updated to reflect the new requirement? And maybe a release note? On Sun, Dec 22, 2019 at 2:01 PM Saleem Abdulrasool via lldb-commits wrote: > > > Author: Saleem Abdulrasool > Date:

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

jhenderson reopened this revision. jhenderson added a comment. This revision is now accepted and ready to land. Could somebody please look at the LLDB change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72158/new/ https://reviews.llvm.org/D72158

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

jhenderson updated this revision to Diff 240852. jhenderson added a reviewer: labath. jhenderson added a comment. Herald added subscribers: lldb-commits, emaste. Herald added a reviewer: espindola. Herald added a project: LLDB. Fix LLD test + fix LLDB build. I'm uncertain if the LLDB fix is the

[Lldb-commits] [lldb] bb73210 - [lldb/PDB] Use the new line table constructor

Author: Pavel Labath Date: 2020-01-28T15:09:14+01:00 New Revision: bb73210ba9f16c1516f564235c86cbddccd1bd6d URL: https://github.com/llvm/llvm-project/commit/bb73210ba9f16c1516f564235c86cbddccd1bd6d DIFF: https://github.com/llvm/llvm-project/commit/bb73210ba9f16c1516f564235c86cbddccd1bd6d.diff

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

labath added a comment. In D70840#1844318 , @mstorsjo wrote: > In D70840#1844279 , @labath wrote: > > > This is something that probably should be discussed with the llvm dwarf > > owners too (though most of them

[Lldb-commits] [PATCH] D70646: Move non-DWARF code: `DWARFUnit` -> `SymbolFileDWARF`

labath added a reviewer: JDevlieghere. labath added a comment. This moves a lot of lldb-specific stuff out of low-level dwarf code, and as such, I think this is a great step towards the parser unification. I'd just like to squeeze one interface tweak to function we are moving around, but

Re: [Lldb-commits] [lldb] fcaf5f6 - [LLDB] Fix the handling of unnamed bit-fields when parsing DWARF

Cherry-picked that in 54b022d344412fc9f1dfe37ee05de934a01e1ea4 Thanks! On Tue, Jan 28, 2020 at 1:12 AM Raphael Isemann wrote: > > Quick follow up: apparently Pavel fixed some nondeterminism in the testing > code that had made the test fail on some systems. Could you also cherry-pick >

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

labath added a subscriber: teemperor. labath added a comment. I've had to revert this because of some failures on macos (http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/7109/testReport/). @jarin, are you able to run the test suite on a mac to investigate. @teemperor, all of the

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1844279 , @labath wrote: > Right, your answer implicitly assumes (and I do agree with you) that the > answer is that `getSubroutineForAddress` should return the function that > address is in. That is not unreasonable

[Lldb-commits] [lldb] d8de349 - Revert "[lldb/DWARF] Only match mangled name in full-name function lookup (with accelerators)"

Author: Pavel Labath Date: 2020-01-28T13:46:43+01:00 New Revision: d8de349951c275af86d67eb3e9c7b1f554531a9b URL: https://github.com/llvm/llvm-project/commit/d8de349951c275af86d67eb3e9c7b1f554531a9b DIFF: https://github.com/llvm/llvm-project/commit/d8de349951c275af86d67eb3e9c7b1f554531a9b.diff

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

labath added a comment. In D70840#1838249 , @mstorsjo wrote: > In D70840#1838186 , @labath wrote: > > > The thing that I am not sure we have fully explored is whether there is any > > need for this `&~1` business

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

labath added a comment. Thanks for the patch, and in particular for starting with a small increment instead of a giant implement-all patch. Could you please add a simple test case that runs `yaml2obj | lldb-test object-file` and verifies that the avr object file is parsed properly. (The

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

aykevl created this revision. aykevl added reviewers: dylanmckay, deepak2427, Andrzej, clayborg, labath. Herald added subscribers: lldb-commits, Jim, aprantl. Herald added a project: LLDB. Add bare-metal AVR support to lldb. Loading a binary works, but little else. Things that work: $

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b1276688300: [lldb/DWARF] Only match mangled name in full-name function lookup (with… (authored by jarin, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1b12766 - [lldb/DWARF] Only match mangled name in full-name function lookup (with accelerators)

Author: Jaroslav Sevcik Date: 2020-01-28T12:16:02+01:00 New Revision: 1b12766883006b8aa9d1ff744e57317647aa052a URL: https://github.com/llvm/llvm-project/commit/1b12766883006b8aa9d1ff744e57317647aa052a DIFF:

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

teemperor added a comment. I don't really know the vscode plugin code but I pointed out when this was implemented that the whole token replacement mechanism that LLDB's completion API uses is really hard to get right. If you're at it, you might

[Lldb-commits] [lldb] 00efeae - [lldb][NFC] Simplify Materializer/Dematerializer constructors

Author: Raphael Isemann Date: 2020-01-28T11:31:02+01:00 New Revision: 00efeae34f22e81ccbcf8cf9b46f314d8101063b URL: https://github.com/llvm/llvm-project/commit/00efeae34f22e81ccbcf8cf9b46f314d8101063b DIFF:

[Lldb-commits] [lldb] 243f52b - [lldb] Cut off unused suffix in CompletionRequest::GetRawLine

Author: Raphael Isemann Date: 2020-01-28T11:12:22+01:00 New Revision: 243f52b58bcefab68fdebefc6d64f7f0c182c0fe URL: https://github.com/llvm/llvm-project/commit/243f52b58bcefab68fdebefc6d64f7f0c182c0fe DIFF:

Re: [Lldb-commits] [lldb] fcaf5f6 - [LLDB] Fix the handling of unnamed bit-fields when parsing DWARF

Quick follow up: apparently Pavel fixed some nondeterminism in the testing code that had made the test fail on some systems. Could you also cherry-pick 77cedb0cdb8623ff9eb22dbf3b9302ee4d9f8a20 ? Thanks again! > On 27. Jan 2020, at 15:10, Hans Wennborg wrote: > > Sure,

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

labath added a comment. Thanks for the patch. I don't know much about the LSP protocol, but I see opportunities for simplifying the string chopping code. See the inline comment for what /I think/ should be the equivalent code. It has also occurred to me that this may break for expressions