[Lldb-commits] [lldb] 477c090 - [lldb][NFC] Remove eCustomCompletion mode

Author: Raphael Isemann Date: 2020-02-12T08:34:02+01:00 New Revision: 477c09043e654bc154fce6e6b013f8f91fb96f05 URL: https://github.com/llvm/llvm-project/commit/477c09043e654bc154fce6e6b013f8f91fb96f05 DIFF: https://github.com/llvm/llvm-project/commit/477c09043e654bc154fce6e6b013f8f91fb96f05.dif

[Lldb-commits] [lldb] 346cb7b - [lldb] Remove skipIfFreeBSD from TestCompletion

Author: Raphael Isemann Date: 2020-02-12T07:14:46+01:00 New Revision: 346cb7b50f7f892b33b46313742eef86bfde7943 URL: https://github.com/llvm/llvm-project/commit/346cb7b50f7f892b33b46313742eef86bfde7943 DIFF: https://github.com/llvm/llvm-project/commit/346cb7b50f7f892b33b46313742eef86bfde7943.dif

[Lldb-commits] [lldb] d797e33 - [TestConstVariable] Clean-up XFAIL lists.

Author: Davide Italiano Date: 2020-02-11T20:31:09-08:00 New Revision: d797e33cc083c186103e0cb9aeb016913b96fd08 URL: https://github.com/llvm/llvm-project/commit/d797e33cc083c186103e0cb9aeb016913b96fd08 DIFF: https://github.com/llvm/llvm-project/commit/d797e33cc083c186103e0cb9aeb016913b96fd08.dif

[Lldb-commits] [PATCH] D74451: [lldb/Plugins] Have one initializer per ABI plugin

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added subscribers: jsji, abidh, atanasyan, mgorny, nemanjai, sdardis. Herald added a project: LLDB. After the recent change that grouped some of the ABI plugins together, those plugins ended up with multiple initial

[Lldb-commits] [lldb] 413307d - [lldb/Plugins] Rename OSPython plugin to OperatingSystemPython (NFC)

Author: Jonas Devlieghere Date: 2020-02-11T16:32:08-08:00 New Revision: 413307d4560441b47261ced5db5f8e29c8811277 URL: https://github.com/llvm/llvm-project/commit/413307d4560441b47261ced5db5f8e29c8811277 DIFF: https://github.com/llvm/llvm-project/commit/413307d4560441b47261ced5db5f8e29c8811277.d

[Lldb-commits] [lldb] f9fdd11 - Rewrite default "could not attach" msg to point to hints

Author: Jason Molenda Date: 2020-02-11T16:18:49-08:00 New Revision: f9fdd1172c8b326126463f1efcfee721e5222334 URL: https://github.com/llvm/llvm-project/commit/f9fdd1172c8b326126463f1efcfee721e5222334 DIFF: https://github.com/llvm/llvm-project/commit/f9fdd1172c8b326126463f1efcfee721e5222334.diff

[Lldb-commits] [lldb] 2d3ecad - [lldb/Plugins] Move PlatformRemoteiOS into PlatformMacOSX (NFCI)

Author: Jonas Devlieghere Date: 2020-02-11T15:54:36-08:00 New Revision: 2d3ecade3892fb0d0713350e06522a94734733b7 URL: https://github.com/llvm/llvm-project/commit/2d3ecade3892fb0d0713350e06522a94734733b7 DIFF: https://github.com/llvm/llvm-project/commit/2d3ecade3892fb0d0713350e06522a94734733b7.d

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

clayborg added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73665/new/ https://reviews.llvm.org/D73665 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Very nice, just need to add a VSCode::SetTarget(...) as detailed in inlined comments and this will be good to go. Comment at: lldb/tools/lldb-vscode/lldb-vscod

[Lldb-commits] [lldb] f65f9d3 - [lldb][NFC] Test ModuleCompletion mode by completing the target modules load argument

Author: Raphael Isemann Date: 2020-02-11T20:38:21+01:00 New Revision: f65f9d3bc5ab9444a9fcde17bca490bfc1f425b7 URL: https://github.com/llvm/llvm-project/commit/f65f9d3bc5ab9444a9fcde17bca490bfc1f425b7 DIFF: https://github.com/llvm/llvm-project/commit/f65f9d3bc5ab9444a9fcde17bca490bfc1f425b7.dif

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat updated this revision to Diff 243932. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-server/registers-target-xml-reading/Makefile lldb/packages/Python/lldbsuite/test/tool

[Lldb-commits] [lldb] 8888992 - [lldb][NFC] Test SourceFileCompletion by completing the target line-table argument

Author: Raphael Isemann Date: 2020-02-11T19:59:21+01:00 New Revision: 992dee3706d3e84d3533d506c7e971a66382 URL: https://github.com/llvm/llvm-project/commit/992dee3706d3e84d3533d506c7e971a66382 DIFF: https://github.com/llvm/llvm-project/commit/992dee3706d3e84d3533d506c7e971a66382.dif

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

labath added a comment. > Does this approach sound reasonable? I think this is ok, in principle. It might be nice to include some numbers, like how much this increases the jThreadsInfo packet size vs. how much time or packets does this save us. > How do we test this? I am imagining a two-pr

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG99451b445368: [lldb][test] Remove symlink for API tests. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D71151?vs=232658&id=243908#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 6217468 - [lldb][NFC] Remove support file searching from SourceFileCompleter

Author: Raphael Isemann Date: 2020-02-11T18:50:25+01:00 New Revision: 62174682a039efce2ce7606d5416d2450ff42dab URL: https://github.com/llvm/llvm-project/commit/62174682a039efce2ce7606d5416d2450ff42dab DIFF: https://github.com/llvm/llvm-project/commit/62174682a039efce2ce7606d5416d2450ff42dab.dif

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

jingham added a comment. In D74136#1869622 , @kwk wrote: > @labath @jingham to summarize from what I read here and what I chatted about > with @labath , the following is a possible way to go for now, right? > > 1. We're not going to introduce my flag. >

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

labath added a comment. I think this is looking pretty good overall. I just have a bunch of stylistic remarks... Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/registers-target-xml-reading/main.cpp:1 +#include + I don't think the choice of

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk added a comment. @labath @jingham to summarize from what I read here and what I chatted about with @labath , the following is a possible way to go for now, right? 1. We're not going to introduce my flag. 2. You're both not perfectly happy with the way things are documented at the moment an

[Lldb-commits] [lldb] 98c940b - [NFC] [lldb] Remove unused declaration

Author: Jan Kratochvil Date: 2020-02-11T14:59:52+01:00 New Revision: 98c940bf515831420b8b53489dd4f9a4fc8a40ad URL: https://github.com/llvm/llvm-project/commit/98c940bf515831420b8b53489dd4f9a4fc8a40ad DIFF: https://github.com/llvm/llvm-project/commit/98c940bf515831420b8b53489dd4f9a4fc8a40ad.diff

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds parts of the stack that should be useful for unwinding to the jThreadsInfo reply from lldb-server. We return the top of the stack (12 words), and we

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

anton.kolesov updated this revision to Diff 243828. anton.kolesov retitled this revision from "[lldb] Set executable module when adding modules to the Target" to "[lldb-vscode] Ensure that target matches the executable file". anton.kolesov edited the summary of this revision. anton.kolesov added

[Lldb-commits] [lldb] e8e7cf8 - [lldb][NFC] Remove the CppVirtualMadness test

Author: Raphael Isemann Date: 2020-02-11T14:09:58+01:00 New Revision: e8e7cf810c11697c99c8ed75f925c600c7df014f URL: https://github.com/llvm/llvm-project/commit/e8e7cf810c11697c99c8ed75f925c600c7df014f DIFF: https://github.com/llvm/llvm-project/commit/e8e7cf810c11697c99c8ed75f925c600c7df014f.dif

[Lldb-commits] [lldb] 9dfd4e2 - [lldb][NFC] Remove ConstString -> const char * -> StringRef conversions when calling Stream::Indent

Author: Raphael Isemann Date: 2020-02-11T13:51:41+01:00 New Revision: 9dfd4e260bd4f9f1d9d0fce343ed645fdd331261 URL: https://github.com/llvm/llvm-project/commit/9dfd4e260bd4f9f1d9d0fce343ed645fdd331261 DIFF: https://github.com/llvm/llvm-project/commit/9dfd4e260bd4f9f1d9d0fce343ed645fdd331261.dif

[Lldb-commits] [lldb] 65ac68e - [lldb] Add test for multiple inheritance

Author: Raphael Isemann Date: 2020-02-11T13:31:34+01:00 New Revision: 65ac68ec3419abd98731e0c434229239e1563045 URL: https://github.com/llvm/llvm-project/commit/65ac68ec3419abd98731e0c434229239e1563045 DIFF: https://github.com/llvm/llvm-project/commit/65ac68ec3419abd98731e0c434229239e1563045.dif

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath accepted this revision. labath added a comment. yeah, go for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72751/new/ https://reviews.llvm.org/D72751 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

This revision was automatically updated to reflect the committed changes. Closed by commit rG363f05b83d9c: [lldb] Delete the SharingPtr class (authored by labath). Changed prior to commit: https://reviews.llvm.org/D74153?vs=242974&id=243808#toc Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [lldb] 651936e - [lldb][NFC] Remove Stream::Indent(const char *) overload in favor of the StringRef version

Author: Raphael Isemann Date: 2020-02-11T13:29:32+01:00 New Revision: 651936e5b62a6a06b1aca1cd976503f5b2991051 URL: https://github.com/llvm/llvm-project/commit/651936e5b62a6a06b1aca1cd976503f5b2991051 DIFF: https://github.com/llvm/llvm-project/commit/651936e5b62a6a06b1aca1cd976503f5b2991051.dif

[Lldb-commits] [lldb] 363f05b - [lldb] Delete the SharingPtr class

Author: Pavel Labath Date: 2020-02-11T13:23:18+01:00 New Revision: 363f05b83d9cf207e1b024ca105b8d55526178b8 URL: https://github.com/llvm/llvm-project/commit/363f05b83d9cf207e1b024ca105b8d55526178b8 DIFF: https://github.com/llvm/llvm-project/commit/363f05b83d9cf207e1b024ca105b8d55526178b8.diff

[Lldb-commits] [PATCH] D74388: [lldb/test] Add alternate symbol to StackFrame Recognizer

mib added a comment. This patch landed in commit cb0c4ee3ebfe55809c9d0be72726b05668028fc4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74388/new/ https://reviews.llvm.org/D7438

[Lldb-commits] [lldb] cb0c4ee - [lldb/test] Add alternate symbol to StackFrame Recognizer

Author: Med Ismail Bennani Date: 2020-02-11T11:44:37+01:00 New Revision: cb0c4ee3ebfe55809c9d0be72726b05668028fc4 URL: https://github.com/llvm/llvm-project/commit/cb0c4ee3ebfe55809c9d0be72726b05668028fc4 DIFF: https://github.com/llvm/llvm-project/commit/cb0c4ee3ebfe55809c9d0be72726b05668028fc4.

[Lldb-commits] [lldb] 6909c2e - [lldb] Add test for calling overloaded virtual functions

Author: Raphael Isemann Date: 2020-02-11T11:36:26+01:00 New Revision: 6909c2e88d0b60e608237f55149bc09d74be47c5 URL: https://github.com/llvm/llvm-project/commit/6909c2e88d0b60e608237f55149bc09d74be47c5 DIFF: https://github.com/llvm/llvm-project/commit/6909c2e88d0b60e608237f55149bc09d74be47c5.dif

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat updated this revision to Diff 243579. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-server/registers-target-xml-reading/Makefile lldb/packages/Python/lldbsuite/test/tool

[Lldb-commits] [PATCH] D74388: [lldb/test] Add alternate symbol to StackFrame Recognizer

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. > This patch reverts commit 6b2979c12300b90a1e69791d43ee9cff14f4265e > The patch is already reverted, this p

[Lldb-commits] [lldb] 5b61f78 - [lldb] Add test for lldb_private::Stream's indentation functionality

Author: Raphael Isemann Date: 2020-02-11T11:12:54+01:00 New Revision: 5b61f78ad5e0f96b0c21ad9a634fc1b26601a00a URL: https://github.com/llvm/llvm-project/commit/5b61f78ad5e0f96b0c21ad9a634fc1b26601a00a DIFF: https://github.com/llvm/llvm-project/commit/5b61f78ad5e0f96b0c21ad9a634fc1b26601a00a.dif

[Lldb-commits] [lldb] 70fb447 - [lldb] Add test for C++ constructor calls from the expression evaluator

Author: Raphael Isemann Date: 2020-02-11T10:47:42+01:00 New Revision: 70fb447ca012728dbfa49a82136554630e188229 URL: https://github.com/llvm/llvm-project/commit/70fb447ca012728dbfa49a82136554630e188229 DIFF: https://github.com/llvm/llvm-project/commit/70fb447ca012728dbfa49a82136554630e188229.dif

[Lldb-commits] [PATCH] D74388: [lldb/test] Add alternate symbol to StackFrame Recognizer

mib added a comment. Hi @jankratochvil, Could you let me know if this works on your end ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74388/new/ https://reviews.llvm.org/D74388 ___ lldb-com

[Lldb-commits] [PATCH] D74388: [lldb/test] Add alternate symbol to StackFrame Recognizer

mib created this revision. mib added reviewers: jankratochvil, teemperor. mib added a project: LLDB. Herald added a subscriber: lldb-commits. mib added a comment. Hi @jankratochvil, Could you let me know if this works on your end ? Thanks! This patch reverts commit 6b2979c12300b90a1e69791d43ee

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

teemperor added inline comments. Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:152 +ConstString func_name = sym_ctx.GetFunctionName(); +if (func_name == ConstString(function_name) || +alternate_function_name.empty() || JDevlieghere wrot

[Lldb-commits] [lldb] 642bc15 - [lldb][NFC] Remove several inefficient ConstString -> const char * -> StringRef conversions

Author: Raphael Isemann Date: 2020-02-11T09:14:41+01:00 New Revision: 642bc15dd7186a6317510cf961a8dc3d35e5b713 URL: https://github.com/llvm/llvm-project/commit/642bc15dd7186a6317510cf961a8dc3d35e5b713 DIFF: https://github.com/llvm/llvm-project/commit/642bc15dd7186a6317510cf961a8dc3d35e5b713.dif