[Lldb-commits] [PATCH] D74585: Don't prefix error message from process launch with "process launch failed:" boilerplate in Target::Launch

2020-02-13 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is fine. I added a "gdb client" test for an attach failure error message a while back, so I was curious if the same thing can be done for launches -- it can and 65e843c9

[Lldb-commits] [lldb] 65e843c - [lldb] Add a test for launch failure and its error message

2020-02-13 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-02-14T08:43:03+01:00 New Revision: 65e843c9e0b91d5ac156130f61b378bad2e8e2fd URL: https://github.com/llvm/llvm-project/commit/65e843c9e0b91d5ac156130f61b378bad2e8e2fd DIFF: https://github.com/llvm/llvm-project/commit/65e843c9e0b91d5ac156130f61b378bad2e8e2fd.diff

Re: [Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

2020-02-13 Thread Raphael “Teemperor” Isemann via lldb-commits
Thanks, I thought I fixed that before committing (that was the one change that Pavel missed IIRC). > On 14. Feb 2020, at 07:53, Jonas Devlieghere via Phabricator > wrote: > > JDevlieghere added a comment. > > Yup, looks like that was it, the bot is green again: > http://lab.llvm.org:8011/bui

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

2020-02-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Yup, looks like that was it, the bot is green again: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13740 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74475/new/ https://reviews.llvm.org/D74475 __

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

2020-02-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D74475#1874860 , @stella.stamenova wrote: > Either this change or D74243 broke the > windows bot and I do suspect D74243 but > have not confirmed it yet

[Lldb-commits] [lldb] 16bf892 - [lldb/Test] Partially revert assertTrue change

2020-02-13 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-02-13T21:55:48-08:00 New Revision: 16bf89267e5ac01d2b512ce784f23640a82de821 URL: https://github.com/llvm/llvm-project/commit/16bf89267e5ac01d2b512ce784f23640a82de821 DIFF: https://github.com/llvm/llvm-project/commit/16bf89267e5ac01d2b512ce784f23640a82de821.d

[Lldb-commits] [PATCH] D74451: [lldb/Plugins] Have one initializer per ABI plugin

2020-02-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf10e2df7bc19: [lldb/Plugins] Have one initializer per ABI plugin (authored by JDevlieghere). Herald added subscribers: jrtc27, aheejin. Changed prior to commit: https://reviews.llvm.org/D74451?vs=244205

[Lldb-commits] [lldb] f10e2df - [lldb/Plugins] Have one initializer per ABI plugin

2020-02-13 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-02-13T21:49:38-08:00 New Revision: f10e2df7bc19a3f05038387d77addd16ab058e06 URL: https://github.com/llvm/llvm-project/commit/f10e2df7bc19a3f05038387d77addd16ab058e06 DIFF: https://github.com/llvm/llvm-project/commit/f10e2df7bc19a3f05038387d77addd16ab058e06.d

[Lldb-commits] [PATCH] D74585: Don't prefix error message from process launch with "process launch failed:" boilerplate in Target::Launch

2020-02-13 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda created this revision. jasonmolenda added reviewers: jingham, clayborg, labath. jasonmolenda added a project: LLDB. Herald added a subscriber: krytarowski. I wanted to put this up as a phab to collect any reactions instead of just landing it, I think it's not controversial but I coul

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

2020-02-13 Thread walter erquinigo via Phabricator via lldb-commits
wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py:26 @skipIfWindows -@skipIfDarwin # Skip this

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

2020-02-13 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244547. diazhector98 added a comment. Squashing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/com

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-02-13 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. To be honest, I'm thinking of stealing your idea of sending the $fp - $sp memory region for frame 0 in debugserver, at least for the currently selected thread. I might add a check that it's not a huge amount of bytes in case there's a giant buffer or something tha

[Lldb-commits] [lldb] 4570f2c - Add a test for debugserver handling threads suspended from within a program.

2020-02-13 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2020-02-13T15:48:38-08:00 New Revision: 4570f2c7cf35388d8b3ab9cc5cdcad4971e31cf2 URL: https://github.com/llvm/llvm-project/commit/4570f2c7cf35388d8b3ab9cc5cdcad4971e31cf2 DIFF: https://github.com/llvm/llvm-project/commit/4570f2c7cf35388d8b3ab9cc5cdcad4971e31cf2.diff LO

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

2020-02-13 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik abandoned this revision. shafik added a comment. I am going to abandon this change b/c the consensus seems to be that we want a different solution and I don't know how much work would require ATM but I may revisit another time, I will note that we do currently have a lot of these and the

[Lldb-commits] [PATCH] D74579: Creating environment variable test for lldbd

2020-02-13 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244531. diazhector98 added a comment. Creating env tes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vsc

[Lldb-commits] [PATCH] D74579: Creating environment variable test for lldbd

2020-02-13 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74579 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py lldb/packages/

[Lldb-commits] [lldb] 14d6863 - Small reformat to avoid tripping up possible formatting.

2020-02-13 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2020-02-13T13:06:44-08:00 New Revision: 14d686309a1ac9cc41522b00da7a751db592ef6e URL: https://github.com/llvm/llvm-project/commit/14d686309a1ac9cc41522b00da7a751db592ef6e DIFF: https://github.com/llvm/llvm-project/commit/14d686309a1ac9cc41522b00da7a751db592ef6e.diff

[Lldb-commits] [lldb] 1287977 - Document third option to python synthetic type summary

2020-02-13 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2020-02-13T13:04:51-08:00 New Revision: 1287977b9edd86a4983542b50a082dd0996ae67e URL: https://github.com/llvm/llvm-project/commit/1287977b9edd86a4983542b50a082dd0996ae67e DIFF: https://github.com/llvm/llvm-project/commit/1287977b9edd86a4983542b50a082dd0996ae67e.diff

[Lldb-commits] [PATCH] D74551: [lldb/dotest] Remove the "exclusive test subdir" concept

2020-02-13 Thread Vedant Kumar via Phabricator via lldb-commits
vsk accepted this revision. vsk added a comment. Thanks. 'exclusive_test_dir' used to be set in dotest.py, but now no longer is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74551/new/ https://reviews.llvm.org/D74551 ___

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

2020-02-13 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. Either this change or D74243 broke the windows bot and I do suspect D74243 but have not confirmed it yet: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13719 Repository: r

[Lldb-commits] [PATCH] D74243: [lldb] Introduce "RegInfoBasedABI"

2020-02-13 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. Either this change or D74475 broke the windows bot and I suspect it's not D74475 : http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13719 Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

2020-02-13 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. If we still see the info using `-R` then I am happy but Jim's concerns are valid, they won't match the bracktrace. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

2020-02-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. I wonder if it wouldn't be better to assert in GetBreakpoint. Except when you are making the resolver, you should never have a breakpoint resolver without a valid breakpoint. And there's no point in calling GetBreakpoint when you know you haven't set it yet. You asse

[Lldb-commits] [PATCH] D74558: [lldb] Make shared_from_this-related code safer

2020-02-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Targets and Breakpoints should only ever be managed by SP in lldb, so enforcing that seems like a good cleanup. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D74551: [lldb/dotest] Remove the "exclusive test subdir" concept

2020-02-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Neat, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74551/new/ https://reviews.llvm.org/D74551 __

[Lldb-commits] [PATCH] D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

2020-02-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/include/lldb/Breakpoint/Breakpoint.h:573 + // target - primarily from the dummy target to prime new targets. + static lldb::BreakpointSP CopyFromBreakpoint(Target& new_target, + cons

[Lldb-commits] [PATCH] D74566: Fix lldb-vscode logging and enable logging for all lldb-vscode tests.

2020-02-13 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:136 + << json_str << std::endl; + } + I had this chunk in a local patch, thanks. Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

2020-02-13 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:152 +ConstString func_name = sym_ctx.GetFunctionName(); +if (func_name == ConstString(function_name) || +alternate_function_name.empty() || JDevlieghere wrote:

[Lldb-commits] [PATCH] D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

2020-02-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74556/new/ https://reviews.llvm.org/D74556 ___ lldb-commi

[Lldb-commits] [PATCH] D74566: Fix lldb-vscode logging and enable logging for all lldb-vscode tests.

2020-02-13 Thread Greg Clayton via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7202d1c2f6c8: Fix lldb-vscode logging and enable logging for all lldb-vscode tests. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D745

[Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

2020-02-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. The only hesitation I have about this is if we are still printing this noise in demangled names, then the name of the type you see for a variable will be different from what you see when a method of that type ends up in a backtrace. That might be confusing. OTOH, the

[Lldb-commits] [lldb] 7202d1c - Fix lldb-vscode logging and enable logging for all lldb-vscode tests.

2020-02-13 Thread Greg Clayton via lldb-commits
Author: Greg Clayton Date: 2020-02-13T09:58:30-08:00 New Revision: 7202d1c2f6c83e989979bb76a61cbe1d0c859420 URL: https://github.com/llvm/llvm-project/commit/7202d1c2f6c83e989979bb76a61cbe1d0c859420 DIFF: https://github.com/llvm/llvm-project/commit/7202d1c2f6c83e989979bb76a61cbe1d0c859420.diff

[Lldb-commits] [PATCH] D74566: Fix lldb-vscode logging and enable logging for all lldb-vscode tests.

2020-02-13 Thread walter erquinigo via Phabricator via lldb-commits
wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74566/new/ https://reviews.llvm.org/D74566 _

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

2020-02-13 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Disabled the new breakpoint event test unless being run on Darwin to keep the buidbots happy until I can figure out what is going wrong: commit c84a0bd9adb3ad699cd6bd4bf865d8b1ea76f2b0 (HEAD -> mast

[Lldb-commits] [lldb] c84a0bd - Fix buildbots by disabling this new test until I can fix it.

2020-02-13 Thread Greg Clayton via lldb-commits
Author: Greg Clayton Date: 2020-02-13T09:32:19-08:00 New Revision: c84a0bd9adb3ad699cd6bd4bf865d8b1ea76f2b0 URL: https://github.com/llvm/llvm-project/commit/c84a0bd9adb3ad699cd6bd4bf865d8b1ea76f2b0 DIFF: https://github.com/llvm/llvm-project/commit/c84a0bd9adb3ad699cd6bd4bf865d8b1ea76f2b0.diff

[Lldb-commits] [lldb] cecc185 - Add REQUIRES: x86 so this won't be run if x86 is not available.

2020-02-13 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2020-02-13T11:17:27-06:00 New Revision: cecc185166c03945f1c06f8d3e1993720f3d3c1a URL: https://github.com/llvm/llvm-project/commit/cecc185166c03945f1c06f8d3e1993720f3d3c1a DIFF: https://github.com/llvm/llvm-project/commit/cecc185166c03945f1c06f8d3e1993720f3d3c1a.diff

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin

2020-02-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D73067#1873779 , @labath wrote: > This looks like a bad upload -- based on some earlier version of this patch > and not master.. Yup, you're right, forgot to squash the commits. CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin

2020-02-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 244455. JDevlieghere added a comment. Squash commits into single diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73067/new/ https://reviews.llvm.org/D73067 Files: lldb/include/lldb/Core/PluginManager.h lldb/source/API/SystemInitializerF

[Lldb-commits] [PATCH] D74566: Fix lldb-vscode logging and enable logging for all lldb-vscode tests.

2020-02-13 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Here is an example of where these files end up after running tests: $ cd lldb-test-build.noindex/ $ find . -name vscode.txt ./tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.test_breakpoint_events/vscode.txt ./tools/lldb-vscode/launch/TestVSCode

[Lldb-commits] [PATCH] D74377: [lldb-vscode] fix logging

2020-02-13 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. you might want to abandon this in favor of my patch: https://reviews.llvm.org/D74566 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74377/new/ https://reviews.llvm.org/D74377

[Lldb-commits] [PATCH] D74566: Fix lldb-vscode logging and enable logging for all lldb-vscode tests.

2020-02-13 Thread Greg Clayton via Phabricator via lldb-commits
clayborg created this revision. clayborg added reviewers: labath, aadsm, serhiy.redko, jankratochvil, xiaobai, wallace. Herald added a project: LLDB. clayborg added a comment. Here is an example of where these files end up after running tests: $ cd lldb-test-build.noindex/ $ find . -name vsc

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

2020-02-13 Thread Tatyana Krasnukha via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG21d09ccf268d: [lldb-vscode] Ensure that target matches the executable file (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D708

[Lldb-commits] [lldb] 21d09cc - [lldb-vscode] Ensure that target matches the executable file

2020-02-13 Thread Tatyana Krasnukha via lldb-commits
Author: Tatyana Krasnukha Date: 2020-02-13T19:34:01+03:00 New Revision: 21d09ccf268dc071d452b0207a3dd91228a51da3 URL: https://github.com/llvm/llvm-project/commit/21d09ccf268dc071d452b0207a3dd91228a51da3 DIFF: https://github.com/llvm/llvm-project/commit/21d09ccf268dc071d452b0207a3dd91228a51da3.d

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

2020-02-13 Thread Greg Clayton via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9cb227f561f4: Stop emitting a breakpoint for each location in a breakpoint when responding to… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] 9cb227f - Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

2020-02-13 Thread Greg Clayton via lldb-commits
Author: Greg Clayton Date: 2020-02-13T08:23:19-08:00 New Revision: 9cb227f561f4e5491840694580abbe7c0123b358 URL: https://github.com/llvm/llvm-project/commit/9cb227f561f4e5491840694580abbe7c0123b358 DIFF: https://github.com/llvm/llvm-project/commit/9cb227f561f4e5491840694580abbe7c0123b358.diff

[Lldb-commits] [PATCH] D73782: [lldb/DWARF] Don't hold a unique SymbolFileDWARFDwo in a DWARFUnit

2020-02-13 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM, sorry for the delay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73782/new/ https://reviews.llvm.org/D73782 _

[Lldb-commits] [PATCH] D74558: [lldb] Make shared_from_this-related code safer

2020-02-13 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, teemperor. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, abidh. The idea is: the fewer classes make an assumption that a target object is already managed by a shared_ptr -

[Lldb-commits] [PATCH] D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

2020-02-13 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, teemperor. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. Some implementations (BreakpointResolverScripted) try calling the breakpoint's shared_from_this(), that makes LLDB

[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

2020-02-13 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, teemperor. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. This prevents calling Breakpoint::shared_from_this of an object that is not owned by any shared_ptr. The patch is

[Lldb-commits] [lldb] 7a0e98b - [llvm][lldb] Update links to ABI for the Arm Architecture. [NFC]

2020-02-13 Thread Francesco Petrogalli via lldb-commits
Author: Francesco Petrogalli Date: 2020-02-13T14:57:53Z New Revision: 7a0e98bc74a11b160c3eb0b5a52e9925c7038e3e URL: https://github.com/llvm/llvm-project/commit/7a0e98bc74a11b160c3eb0b5a52e9925c7038e3e DIFF: https://github.com/llvm/llvm-project/commit/7a0e98bc74a11b160c3eb0b5a52e9925c7038e3e.dif

[Lldb-commits] [PATCH] D74243: [lldb] Introduce "RegInfoBasedABI"

2020-02-13 Thread Pavel Labath via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG12e32d32d393: [lldb] Introduce "RegInfoBasedABI" (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [lldb] 12e32d3 - [lldb] Introduce "RegInfoBasedABI"

2020-02-13 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-02-13T15:29:12+01:00 New Revision: 12e32d32d39332a678b6a7b88f2c5bd8eb70bd69 URL: https://github.com/llvm/llvm-project/commit/12e32d32d39332a678b6a7b88f2c5bd8eb70bd69 DIFF: https://github.com/llvm/llvm-project/commit/12e32d32d39332a678b6a7b88f2c5bd8eb70bd69.diff

[Lldb-commits] [PATCH] D74551: [lldb/dotest] Remove the "exclusive test subdir" concept

2020-02-13 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: vsk, JDevlieghere. Herald added a project: LLDB. This was added in 2018 (r339929), when we were still using the hand-rolled test runner. It does not seem to be relevant anymore. In fact as far as I can tell, it's a big no-op now as the exclusi

[Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

2020-02-13 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D74478#1873581 , @shafik wrote: > I can see how stripping `__1` would be nice but I seeing `(anonymous > namespace)` may be useful to know especially b/c it effects visibility and > linkage. It would be nicer if could make t

[Lldb-commits] [lldb] 91e0c25 - [lldb] Fix lldb-dotest

2020-02-13 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-02-13T14:31:08+01:00 New Revision: 91e0c258c2e80b180c0c99af322cb6bf09df86d4 URL: https://github.com/llvm/llvm-project/commit/91e0c258c2e80b180c0c99af322cb6bf09df86d4 DIFF: https://github.com/llvm/llvm-project/commit/91e0c258c2e80b180c0c99af322cb6bf09df86d4.diff

[Lldb-commits] [lldb] 5d3926a - [lldb] Clean up ProcessGDBRemote::DidLaunchOrAttach

2020-02-13 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-02-13T10:32:15+01:00 New Revision: 5d3926a5a287618fea772c5be689f6c9fc2f6fc3 URL: https://github.com/llvm/llvm-project/commit/5d3926a5a287618fea772c5be689f6c9fc2f6fc3 DIFF: https://github.com/llvm/llvm-project/commit/5d3926a5a287618fea772c5be689f6c9fc2f6fc3.diff

[Lldb-commits] [PATCH] D73782: [lldb/DWARF] Don't hold a unique SymbolFileDWARFDwo in a DWARFUnit

2020-02-13 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Do you have any more comments on this patch, Greg? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73782/new/ https://reviews.llvm.org/D73782 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D74451: [lldb/Plugins] Have one initializer per ABI plugin

2020-02-13 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/API/SystemInitializerFull.cpp:27-34 +LLDB_PLUGIN_DECLARE(ABIAArch64); +LLDB_PLUGIN_DECLARE(ABIARM); LLDB_PLUGIN_DECLARE(ABISysV_arc); LLDB_PLUGI

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin

2020-02-13 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. This looks like a bad upload -- based on some earlier version of this patch and not master.. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73067/new/ https://reviews.llvm.org/D73067 ___ lld

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

2020-02-13 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good now. Thanks for your patience. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.py:68 +

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-02-13 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. BTW, a the `lldb/examples/python/gdbremote.py` script for these kinds of things measurements. It takes a lldb log file produced like so: `log enable gdb-remote packets -T -f /tmp/gdb.log`, and it gives you some statistics about the various packets present there: #

[Lldb-commits] [lldb] cb6c9f7 - [lldb] Make gdbremote.py utility py2and3 compatible

2020-02-13 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-02-13T09:18:55+01:00 New Revision: cb6c9f731b657807124bcb5a6c1f8aecf25f120b URL: https://github.com/llvm/llvm-project/commit/cb6c9f731b657807124bcb5a6c1f8aecf25f120b DIFF: https://github.com/llvm/llvm-project/commit/cb6c9f731b657807124bcb5a6c1f8aecf25f120b.diff