[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate updated this revision to Diff 248088. MrHate edited the summary of this revision. MrHate added a comment. Removed individual execution context updating. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 Files:

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl updated this revision to Diff 248036. aprantl added a comment. Address feedback from Shafik. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75488/new/ https://reviews.llvm.org/D75488 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/include/lldb/Symbol/TypeSystem.h

[Lldb-commits] [PATCH] D75493: [lldb] Remove some #ifdef LLDB_CONFIGURATION_DEBUG around asserts

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Core/Section.cpp:271 -#ifdef LLDB_CONFIGURATION_DEBUG // For debug builds, ensure that there are no orphaned (i.e., moduleless) //

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

aprantl updated this revision to Diff 248024. aprantl added a comment. Document layout. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75562/new/ https://reviews.llvm.org/D75562 Files: lldb/include/lldb/Symbol/Type.h lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp

Re: [Lldb-commits] [lldb] b6b3fcd - [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

> On Mar 2, 2020, at 3:47 PM, Davide Italiano via lldb-commits > wrote: > > > >> On Mar 2, 2020, at 15:44, Raphael “Teemperor” Isemann >> wrote: >> >> I was just grepping for unordered data structures (e.g. ’std::set<‘) that >> use pointers/pointer-like objects (e.g. CompilerType with

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl updated this revision to Diff 248011. aprantl added a comment. Add C++ tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75488/new/ https://reviews.llvm.org/D75488 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/include/lldb/Symbol/TypeSystem.h

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

xiaobai added a comment. Thanks for working to make LLDB more language-agnostic! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75562/new/ https://reviews.llvm.org/D75562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

shafik added inline comments. Comment at: lldb/include/lldb/Symbol/CompilerType.h:236 // type is valid and the type system supports typedefs, else return an - // invalid type. + // invalid type. The payload argument is the typesystem-specific Type payload. CompilerType

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl updated this revision to Diff 248009. aprantl added a comment. Factored out NFC changes into separate reviews. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75488/new/ https://reviews.llvm.org/D75488 Files: lldb/include/lldb/Symbol/CompilerType.h

[Lldb-commits] [lldb] a7fa8b0 - Doxygenify CompilerType.h (NFC)

Author: Adrian Prantl Date: 2020-03-03T13:43:25-08:00 New Revision: a7fa8b022f0e9873c61e23f5f493bd413b69f4d0 URL: https://github.com/llvm/llvm-project/commit/a7fa8b022f0e9873c61e23f5f493bd413b69f4d0 DIFF: https://github.com/llvm/llvm-project/commit/a7fa8b022f0e9873c61e23f5f493bd413b69f4d0.diff

[Lldb-commits] [lldb] e566dd7 - [lldb] Delete some commented out code in ClangASTSource.cpp

Author: Alex Langford Date: 2020-03-03T13:17:21-08:00 New Revision: e566dd733d642052cf261c20e0e82f18b8e3d6fe URL: https://github.com/llvm/llvm-project/commit/e566dd733d642052cf261c20e0e82f18b8e3d6fe DIFF: https://github.com/llvm/llvm-project/commit/e566dd733d642052cf261c20e0e82f18b8e3d6fe.diff

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

aprantl created this revision. aprantl added reviewers: teemperor, shafik, jingham. This hides the language-specific flags and lets each language define its own fields in the opaquer storage. https://reviews.llvm.org/D75562 Files: lldb/include/lldb/Symbol/Type.h

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl updated this revision to Diff 247992. aprantl retitled this revision from "RFC: Preserve the owning module information from DWARF in the synthesized AST" to "Preserve the owning module information from DWARF in the synthesized AST". aprantl added a comment. Now with a more comprehensive

[Lldb-commits] [lldb] 13fd50c - Revert "Revert "[lldb/Docs] Mark both Python 3.6 and 3.8 as supported on Windows""

Author: Stefan Stipanovic Date: 2020-03-03T20:43:16+01:00 New Revision: 13fd50cc26401a64e9e7379d4f9adaa4c54c5f55 URL: https://github.com/llvm/llvm-project/commit/13fd50cc26401a64e9e7379d4f9adaa4c54c5f55 DIFF:

[Lldb-commits] [lldb] 78a734e - Revert "[lldb/Docs] Mark both Python 3.6 and 3.8 as supported on Windows"

Author: Stefan Stipanovic Date: 2020-03-03T20:41:18+01:00 New Revision: 78a734e2792061921ab7fb8f9059d1fb673e158f URL: https://github.com/llvm/llvm-project/commit/78a734e2792061921ab7fb8f9059d1fb673e158f DIFF:

[Lldb-commits] [lldb] 3270ea9 - [lldb/Docs] Mark both Python 3.6 and 3.8 as supported on Windows

Author: Jonas Devlieghere Date: 2020-03-03T11:26:00-08:00 New Revision: 3270ea9042eaa2bf9ab12d4a6ceefaae73c5152a URL: https://github.com/llvm/llvm-project/commit/3270ea9042eaa2bf9ab12d4a6ceefaae73c5152a DIFF:

[Lldb-commits] [PATCH] D75496: [lldb][NFC] Remove some commented out code in TypeSystemClang

This revision was automatically updated to reflect the committed changes. Closed by commit rG531515198e47: [lldb][NFC] Remove some commented out code in TypeSystemClang (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D75418: tab completion for process signal

jingham added a comment. I think this is just a bug in argument completion. The CommandInterpreter needs to sync up with the currently selected target/process/thread/frame before running commands. It COULD do that by having every API that changes the selected T/P/T/F above notify the

[Lldb-commits] [lldb] 5315151 - [lldb][NFC] Remove some commented out code in TypeSystemClang

Author: Raphael Isemann Date: 2020-03-03T10:50:48-08:00 New Revision: 531515198e477eedd2416d65c913d54e3779387e URL: https://github.com/llvm/llvm-project/commit/531515198e477eedd2416d65c913d54e3779387e DIFF:

[Lldb-commits] [PATCH] D75488: RFC: Preserve the owning module information from DWARF in the synthesized AST

aprantl updated this revision to Diff 247948. aprantl added a comment. Here is an updated version the makes do without the CompilerDeclContext trickery. New is the `m_payload` field in `lldb::Type`. This is needed to convey the ownership information to typedefs, which are completed

[Lldb-commits] [PATCH] D73016: [lldb/CMake] Make it possible to disable plugins at configuration time

JDevlieghere updated this revision to Diff 247947. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73016/new/ https://reviews.llvm.org/D73016 Files: lldb/cmake/caches/Apple-lldb-macOS.cmake lldb/cmake/modules/AddLLDB.cmake lldb/packages/Python/lldbsuite/test/test_categories.py

[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. You mean for BreakpointResolverScripted::CreateImplementationIfNeeded? Passing in the BreakpointSP is fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74557/new/

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

tatyana-krasnukha updated this revision to Diff 247928. tatyana-krasnukha added a comment. Moved settings clearing to the separate patch D75537 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74903/new/ https://reviews.llvm.org/D74903 Files:

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: labath. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. tatyana-krasnukha added a parent revision: D74903: [lldb][testsuite] Create a SBDebugger instance for each test.

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

labath added a comment. Overall, I don't have any big issues with this patch, but overall I see at least two distinct issues being handled here: a) changing how the platform selection works; and b) auto-clearing of settings. Please split those up into separate patches. Repository: rLLDB

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

tatyana-krasnukha updated this revision to Diff 247908. tatyana-krasnukha added a comment. Clear all settings during a test's setUp Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74903/new/ https://reviews.llvm.org/D74903 Files:

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

tatyana-krasnukha planned changes to this revision. tatyana-krasnukha added a comment. As Pavel wrote, there are global properties that all debuggers share. That's why this approach doesn't work for me. I'm going to add `settings clear` mode without arguments that will revert all the settings

[Lldb-commits] [lldb] 573e077 - [lldb] Add detailed tests for the "disassemble" command

Author: Pavel Labath Date: 2020-03-03T16:40:27+01:00 New Revision: 573e0776996425dd0567448d4a1f805a1f613e6d URL: https://github.com/llvm/llvm-project/commit/573e0776996425dd0567448d4a1f805a1f613e6d DIFF: https://github.com/llvm/llvm-project/commit/573e0776996425dd0567448d4a1f805a1f613e6d.diff

[Lldb-commits] [lldb] 1d6fa41 - [lldb] Have Disassembler::ParseInstructions take a Target

Author: Pavel Labath Date: 2020-03-03T13:58:56+01:00 New Revision: 1d6fa41f40da5f5a615497eac818623779c46556 URL: https://github.com/llvm/llvm-project/commit/1d6fa41f40da5f5a615497eac818623779c46556 DIFF: https://github.com/llvm/llvm-project/commit/1d6fa41f40da5f5a615497eac818623779c46556.diff

[Lldb-commits] [lldb] 221641b - [lldb] Add lldbTarget -> llvmMC dependency

Author: Pavel Labath Date: 2020-03-03T13:10:44+01:00 New Revision: 221641be0219d45018105cc04e5589c61bae7171 URL: https://github.com/llvm/llvm-project/commit/221641be0219d45018105cc04e5589c61bae7171 DIFF: https://github.com/llvm/llvm-project/commit/221641be0219d45018105cc04e5589c61bae7171.diff

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

tatyana-krasnukha updated this revision to Diff 247842. tatyana-krasnukha retitled this revision from "[lldb][test] Add two wrapper functions to manage settings in test-suite" to "[lldb][testsuite] Create a SBDebugger instance for each test". tatyana-krasnukha edited the summary of this

[Lldb-commits] [PATCH] D75454: [lldb] Make sure we don't drop asynchronous output when sourcing files

This revision was automatically updated to reflect the committed changes. Closed by commit rG4deea65249d5: [lldb] Make sure we dont drop asynchronous output when sourcing files (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

tatyana-krasnukha added a comment. @jingham Is it Ok with you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74557/new/ https://reviews.llvm.org/D74557 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

This revision was automatically updated to reflect the committed changes. Closed by commit rG6304368818a1: [lldb] Treat RangeDataVector as an augmented binary search tree (authored by unnar, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 6304368 - [lldb] Treat RangeDataVector as an augmented binary search tree

Author: Unnar Freyr Erlendsson Date: 2020-03-03T11:28:16+01:00 New Revision: 6304368818a1e9883b694b9d8c21ef568176168d URL: https://github.com/llvm/llvm-project/commit/6304368818a1e9883b694b9d8c21ef568176168d DIFF:

[Lldb-commits] [lldb] 4deea65 - [lldb] Make sure we don't drop asynchronous output when sourcing files

Author: Pavel Labath Date: 2020-03-03T11:18:41+01:00 New Revision: 4deea65249d5df2965d4df90ec9cf221bcf9a13e URL: https://github.com/llvm/llvm-project/commit/4deea65249d5df2965d4df90ec9cf221bcf9a13e DIFF: https://github.com/llvm/llvm-project/commit/4deea65249d5df2965d4df90ec9cf221bcf9a13e.diff

[Lldb-commits] [PATCH] D75418: tab completion for process signal

labath added subscribers: jingham, labath. labath added a comment. In D75418#1902266 , @MrHate wrote: > In order to process completion successfully whenever we've got a valid > process, I will update the current execution context both in `m_interpreter`

[Lldb-commits] [PATCH] D75454: [lldb] Make sure we don't drop asynchronous output when sourcing files

labath added a subscriber: kuhnel. labath added a comment. In D75454#1901394 , @clayborg wrote: > check remote build failure to be sure! That looks like an infrastructure problem. I've seen that on all lldb patches. I think that lldb is just not

[Lldb-commits] [lldb] 916be8f - Revert abb00753 "build: reduce CMake handling for zlib" (PR44780)

Author: Hans Wennborg Date: 2020-03-03T11:03:09+01:00 New Revision: 916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e URL: https://github.com/llvm/llvm-project/commit/916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e DIFF: https://github.com/llvm/llvm-project/commit/916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e.diff