[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

2020-03-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Thanks for doing this, it will be useful! I'll let Jonas comment on whether the Reproducer bindings are right, though it looks fine to me. One of the very common uses of an

[Lldb-commits] [lldb] 57da8f7 - Add support for XFAILing a test based on a setting.

2020-03-12 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2020-03-12T19:26:24-07:00 New Revision: 57da8f720ce18100c5c6fb5c2247109e1ef963b5 URL: https://github.com/llvm/llvm-project/commit/57da8f720ce18100c5c6fb5c2247109e1ef963b5 DIFF: https://github.com/llvm/llvm-project/commit/57da8f720ce18100c5c6fb5c2247109e1ef963b5.diff

[Lldb-commits] [PATCH] D76080: Adjust error_msg handling for expect_expr in lldbtest.py

2020-03-12 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik abandoned this revision. shafik added a comment. After discussing this @teemperor in some detail it looks like getting the `error_msg` case to work well is not a trivial task. So for these cases we should revert to just using `expect`. I think the plan is that he will remove the feature

[Lldb-commits] [lldb] a9682cc - Convert settings list into a tuple so it can be matched by the decorator.

2020-03-12 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2020-03-12T17:51:15-07:00 New Revision: a9682ccb7e70a036bd3acbbe97ed8ab74a7732d3 URL: https://github.com/llvm/llvm-project/commit/a9682ccb7e70a036bd3acbbe97ed8ab74a7732d3 DIFF: https://github.com/llvm/llvm-project/commit/a9682ccb7e70a036bd3acbbe97ed8ab74a7732d3.diff

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

2020-03-12 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 250108. wallace added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76111/new/ https://reviews.llvm.org/D76111 Files: lldb/bindings/headers.swig lldb/bindings/interface/SBEnvironment.i

[Lldb-commits] [PATCH] D76105: [lldb/settings] Reset the inferior environment when target.inherit-env is toggled

2020-03-12 Thread Frederic Riss via Phabricator via lldb-commits
friss added a comment. In D76105#1920633 , @jingham wrote: > If I'm following the logic correctly, if you run a target with inherit-env > off, and then do: > > env VAR_IN_ENVIRONMENT=NOT_THE_ENVIRONMENTS_VALUE > > > > then turn inherit-env on, we

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

2020-03-12 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Inspired by https://reviews.llvm.org/D74636, I'm introducing a basic version of Environment in the API. More functionalities can be added as

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

2020-03-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. In D75711#1920642 , @clayborg wrote: > Everything looks good, just a question in inlined comment about having a > thread plan hold onto a pointer to a thread. Seems dangerous The way the ThreadPlanStacks will get used, every

[Lldb-commits] [lldb] af7fc8c - [lldb] Remove unused and too strict error_msg parameter from expect_expr

2020-03-12 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-03-13T00:45:43+01:00 New Revision: af7fc8c1bbcb380610451be59c022595bd7ba4bd URL: https://github.com/llvm/llvm-project/commit/af7fc8c1bbcb380610451be59c022595bd7ba4bd DIFF:

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

2020-03-12 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Everything looks good, just a question in inlined comment about having a thread plan hold onto a pointer to a thread. Seems dangerous Comment at: lldb/include/lldb/Target/ThreadPlan.h:601 + Thread *m_thread; ThreadPlanKind m_kind;

[Lldb-commits] [PATCH] D75761: [lldb] Fix to get the AST we generate for function templates to be closer to what clang generates and expects

2020-03-12 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. FWIW, I don't think the error cases should use expect_expr as it currently doesn't have a reasonable way to handle errors (the error_msg thing is really too strict and didn't land on purpose. That was more of a side effect of all the refactoring that went into the

[Lldb-commits] [PATCH] D76105: [lldb/settings] Reset the inferior environment when target.inherit-env is toggled

2020-03-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. If I'm following the logic correctly, if you run a target with inherit-env off, and then do: env VAR_IN_ENVIRONMENT=NOT_THE_ENVIRONMENTS_VALUE then turn inherit-env on, we will preserve the value you set it to, not the environment value, because you pass in false

[Lldb-commits] [PATCH] D76080: Adjust error_msg handling for expect_expr in lldbtest.py

2020-03-12 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. In D76080#1920483 , @teemperor wrote: > - All of the asserts should print a useful error when failing (i.e., one that > allows us to directly write a fix). You could do assertIn which is clearer > than `find(...)` and

[Lldb-commits] [PATCH] D76045: [lldb/API] Make Launch(Simple) use args and env from target properties

2020-03-12 Thread Frederic Riss via Phabricator via lldb-commits
friss added a comment. This is somewhat useless without D76009 because the default LaunchInfo doesn't get populated with the environment without it. I'll wait for a resolution there before landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D76080: Adjust error_msg handling for expect_expr in lldbtest.py

2020-03-12 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik updated this revision to Diff 250083. shafik added a comment. Moving to using `assertIn` as suggest in comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76080/new/ https://reviews.llvm.org/D76080 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py Index:

[Lldb-commits] [PATCH] D76105: [lldb/settings] Reset the inferior environment when target.inherit-env is toggled

2020-03-12 Thread Frederic Riss via Phabricator via lldb-commits
friss created this revision. friss added reviewers: labath, jingham. Herald added a project: LLDB. Allow the target.env-vars property to be recomputed when the target.inherit-env property changes. This allows to change the value of the property between runs and get a meaningful behavior.

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

2020-03-12 Thread Frederic Riss via Phabricator via lldb-commits
friss added a comment. I put up a "fix" for the inherit-env issue mentioned here: https://reviews.llvm.org/D76105 It is mostly orthogonal to this patch as Jim showed the behavior today is already broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76080: Adjust error_msg handling for expect_expr in lldbtest.py

2020-03-12 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. - All of the asserts should print a useful error when failing (i.e., one that allows us to directly write a fix). You could do assertIn which is clearer than `find(...)` and

[Lldb-commits] [lldb] 2411f56 - [lldb/Host] Fix the Windows build

2020-03-12 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-03-12T15:31:09-07:00 New Revision: 2411f56bfd1c36f30239c832b75e094d927ee219 URL: https://github.com/llvm/llvm-project/commit/2411f56bfd1c36f30239c832b75e094d927ee219 DIFF:

[Lldb-commits] [PATCH] D76004: [lldb] Add YAML traits for ArchSpec and ProcessInstanceInfo

2020-03-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0ce3b710b49c: [lldb] Add YAML traits for ArchSpec and ProcessInstanceInfo (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D76004?vs=249657=250069#toc Repository: rG

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

2020-03-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Is this one okay as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75711/new/ https://reviews.llvm.org/D75711 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 0ce3b71 - [lldb] Add YAML traits for ArchSpec and ProcessInstanceInfo

2020-03-12 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-03-12T14:38:37-07:00 New Revision: 0ce3b710b49c7b9ab837d220547aec92564dd78d URL: https://github.com/llvm/llvm-project/commit/0ce3b710b49c7b9ab837d220547aec92564dd78d DIFF:

[Lldb-commits] [lldb] 638b06c - [lldb/Utility] Replace ProcessInstanceInfoList with std::vector. (NFCI)

2020-03-12 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-03-12T14:10:25-07:00 New Revision: 638b06cf298bc622c3ffd93dc4715c6f806de5b5 URL: https://github.com/llvm/llvm-project/commit/638b06cf298bc622c3ffd93dc4715c6f806de5b5 DIFF:

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

2020-03-12 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha added a comment. `platform.module-cache-directory` should be fixed by rGfe74df01a909 . Regarding `script-lang`, its default value is `eScriptLanguagePython` in CoreProperties.td and I'm not sure that I

[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

2020-03-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham marked an inline comment as done. jingham added a comment. Removed Update till the next patch, and fixed a bug in PushPlan that preparing the next patch uncovered. Comment at: lldb/include/lldb/Target/ThreadPlanStack.h:126-130 +auto result =

[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

2020-03-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham updated this revision to Diff 250025. jingham marked 6 inline comments as done. jingham added a comment. Removed ThreadPlanStackMap::Update, fixed a bug in PushPlan (can't std::move the ThreadPlan, THEN log it...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76080: Adjust error_msg handling for expect_expr in lldbtest.py

2020-03-12 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik updated this revision to Diff 250021. shafik added a comment. Incorporate feedback on how to verify the results. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76080/new/ https://reviews.llvm.org/D76080 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py Index:

[Lldb-commits] [PATCH] D76080: Adjust error_msg handling for expect_expr in lldbtest.py

2020-03-12 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. In D76080#1919862 , @jingham wrote: > > I'm on the fence about using a "find" not a strict string compare. The only > reason you'd be passing in an error_msg is that you want to test that you got > the error string you were

[Lldb-commits] [lldb] fe74df0 - [lldb] Specify default value for platform.module-cache-directory

2020-03-12 Thread Tatyana Krasnukha via lldb-commits
Author: Tatyana Krasnukha Date: 2020-03-12T22:08:12+03:00 New Revision: fe74df01a909fb02528e83e90124f1b706176ddd URL: https://github.com/llvm/llvm-project/commit/fe74df01a909fb02528e83e90124f1b706176ddd DIFF:

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

2020-03-12 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. The original intention of this is to have any working environment, as quite often complex programs require many environment variables that are common to most processes. Having the user specify each of those is a bit too much to ask for, and they are complaining because

[Lldb-commits] [PATCH] D76080: Adjust error_msg handling for expect_expr in lldbtest.py

2020-03-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. The result from EvaluateExpression is pretty much always going to be valid, since the result holds the error. The correct way to do the first check is: self.assertTrue(eval_result.GetError().Fail(), "Unexpected success...") though you probably also want to make sure

[Lldb-commits] [PATCH] D76002: [lldb] Add YAML traits for ConstString and FileSpec

2020-03-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbc9b6b33a0d5: [lldb/Utility] Add YAML traits for ConstString and FileSpec. (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D76002?vs=249650=249986#toc Repository: rG

[Lldb-commits] [PATCH] D76080: Adjust error_msg handling for expect_expr in lldbtest.py

2020-03-12 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik created this revision. shafik added reviewers: teemperor, labath, aprantl. shafik added a comment. I am open to suggestions on alternative approaches, for some context I ran into this trying to add a failing test to D75761 as was suggested. I was

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

2020-03-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. BTW, don't worry about the `OS_ACTIVITY_DT_MODE` env var. That's something you have to set when debugging or the Foundation loggging method (NSLog) will go to the system console not to the current terminal, so we force it on all processes on macOS... Repository:

[Lldb-commits] [PATCH] D76080: Adjust error_msg handling for expect_expr in lldbtest.py

2020-03-12 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. I am open to suggestions on alternative approaches, for some context I ran into this trying to add a failing test to D75761 as was suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76080/new/

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

2020-03-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. In D76009#1919554 , @friss wrote: > In D76009#1919103 , @labath wrote: > > > Actually, hang on. > > > > > One existing test had to be modified, because the initialization of > > > the

[Lldb-commits] [lldb] bc9b6b3 - [lldb/Utility] Add YAML traits for ConstString and FileSpec.

2020-03-12 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-03-12T10:28:21-07:00 New Revision: bc9b6b33a0d5760370e72ae06c520c25aa8d61c6 URL: https://github.com/llvm/llvm-project/commit/bc9b6b33a0d5760370e72ae06c520c25aa8d61c6 DIFF:

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

2020-03-12 Thread Hsiangkai Wang via Phabricator via lldb-commits
HsiangKai marked 2 inline comments as done. HsiangKai added inline comments. Comment at: llvm/include/llvm/Support/ELFAttributes.h:32 + bool HasTagPrefix = true); +Optional attrTypeFromString(StringRef Tag, TagNameMap Map); + jhenderson

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-12 Thread David Stenberg via Phabricator via lldb-commits
dstenb added a comment. In D73534#1918940 , @dstenb wrote: > In D73534#1918890 , @manojgupta > wrote: > > > Hi, > > > > I see another crash with this change when building gdb. > > > > Reduced test case: > >

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

2020-03-12 Thread Igor Kudrin via Phabricator via lldb-commits
ikudrin updated this revision to Diff 249939. ikudrin added a comment. - Use values for clashing identifiers proposed by @dblaikie. - Convert all unknown section identifiers into a special value, `DW_SECT_EXT_unknown`; Use an optional parallel array to keep the raw values of unknown

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-12 Thread David Stenberg via Phabricator via lldb-commits
dstenb added a comment. In D73534#1918890 , @manojgupta wrote: > Hi, > > I see another crash with this change when building gdb. > > Reduced test case: > struct type *a(type *, type *, long, long); > enum b {}; > static int empty_array(type *, int c) {

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

2020-03-12 Thread Hsiangkai Wang via Phabricator via lldb-commits
HsiangKai updated this revision to Diff 249854. HsiangKai added a comment. Fix unit test errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files: lld/ELF/InputFiles.cpp

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-12 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta added a comment. Hi, I see another crash with this change when building gdb. Reduced test case: struct type *a(type *, type *, long, long); enum b {}; static int empty_array(type *, int c) { type *d = a(__null, d, c, c - 1); } long e; b f() { empty_array(0, e); } Repros with: clang

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-12 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a comment. In D73534#1918818 , @djtodoro wrote: > In D73534#1916309 , @djtodoro wrote: > > > In D73534#1916291 , @djtodoro > > wrote: > > > > > Thanks for

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

2020-03-12 Thread Hsiangkai Wang via Phabricator via lldb-commits
HsiangKai updated this revision to Diff 249845. HsiangKai added a comment. - Specify underlying type for AttrType. - Update unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files:

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

2020-03-12 Thread Frederic Riss via Phabricator via lldb-commits
friss added a comment. In D76009#1919103 , @labath wrote: > Actually, hang on. > > > One existing test had to be modified, because the initialization of > > the environment properties now take place at the time the target is > > created, not at the

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

2020-03-12 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Fixed in 352f16db87f583ec7f55f8028647b5fd8616111f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537

[Lldb-commits] [lldb] 352f16d - [lldb] Let OptionValueRegex::Clear set to value to the default and not an empty regex

2020-03-12 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-03-12T16:12:14+01:00 New Revision: 352f16db87f583ec7f55f8028647b5fd8616111f URL: https://github.com/llvm/llvm-project/commit/352f16db87f583ec7f55f8028647b5fd8616111f DIFF:

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

2020-03-12 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Sure, I can take care of it. It seems `OptionValueRegex::Clear` is always resetting to an empty regex. I guess the same goes for the other option values that are failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

2020-03-12 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha added a comment. Thank you for details, I'm looking at these failures, however, I'm not able to debug on the macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

2020-03-12 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. I guess now all the shady hacks are coming out. The following settings change their value after calling settings clear after startup in the test: target.process.thread.step-avoid-regexp (regex) -> from '^std::' to empty string platform.module-cache-directory

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

2020-03-12 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Somehow this broke the macOS LLDB bot: Failing Tests (2): lldb-api :: functionalities/inline-stepping/TestInlineStepping.py lldb-api :: lang/cpp/std-function-step-into-callable/TestStdFunctionStepIntoCallable.py Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] e3fc6b3 - [lldb][NFC] Fix unsigned/signed comparison warning in SymbolFileDWARFTest.cpp

2020-03-12 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-03-12T15:30:11+01:00 New Revision: e3fc6b3c346f583adbdb38b0935cc73439aaad99 URL: https://github.com/llvm/llvm-project/commit/e3fc6b3c346f583adbdb38b0935cc73439aaad99 DIFF:

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

2020-03-12 Thread Tatyana Krasnukha via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdf90a15b1ac9: [lldb] Clear all settings during a tests setUp (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/

[Lldb-commits] [lldb] df90a15 - [lldb] Clear all settings during a test's setUp

2020-03-12 Thread Tatyana Krasnukha via lldb-commits
Author: Tatyana Krasnukha Date: 2020-03-12T16:30:26+03:00 New Revision: df90a15b1ac938559a8c3af12126559c1e1e9558 URL: https://github.com/llvm/llvm-project/commit/df90a15b1ac938559a8c3af12126559c1e1e9558 DIFF:

[Lldb-commits] [PATCH] D75925: [lldb] reject `.debug_arange` sections with nonzero segment size

2020-03-12 Thread Luke Drummond via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0fa3320931e9: [lldb] reject `.debug_arange` sections with nonzero segment size (authored by ldrumm). Changed prior to commit: https://reviews.llvm.org/D75925?vs=249663=249913#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

2020-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Awesome, thanks. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 ___

[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

2020-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good to me, though I can't say I'm that familiar with thread plan intricacies. Comment at: lldb/include/lldb/Target/ThreadPlanStack.h:118 + + void

[Lldb-commits] [lldb] 0fa3320 - [lldb] reject `.debug_arange` sections with nonzero segment size

2020-03-12 Thread Luke Drummond via lldb-commits
Author: Luke Drummond Date: 2020-03-12T12:22:50Z New Revision: 0fa3320931e93d658f68c1f19eb45b922158b61e URL: https://github.com/llvm/llvm-project/commit/0fa3320931e93d658f68c1f19eb45b922158b61e DIFF: https://github.com/llvm/llvm-project/commit/0fa3320931e93d658f68c1f19eb45b922158b61e.diff

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

2020-03-12 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha updated this revision to Diff 249902. tatyana-krasnukha added a comment. Addressed comments Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] [PATCH] D76045: [lldb/API] Make Launch(Simple) use args and env from target properties

2020-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. sounds reasonable. Comment at: lldb/include/lldb/API/SBTarget.h:130-132 + /// The environment array. If this isn't provided, the default + /// environment values

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

2020-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D74636#1918110 , @clayborg wrote: > In D74636#1916356 , @labath wrote: > > > There's a `target.inherit-env` setting in lldb (which I believe also works > > correctly for remote

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

2020-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath removed a reviewer: labath. labath added a comment. This revision now requires review to proceed. Actually, hang on. > One existing test had to be modified, because the initialization of > the environment properties now take place at the time the target is > created, not at the first

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

2020-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Another option might be to make TargetProperties a member instead of a base class. I don't think the current setup makes for a particularly clean design. If `TargetProperties` is among the

[Lldb-commits] [PATCH] D75925: [lldb] reject `.debug_arange` sections with nonzero segment size

2020-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, just run clang-format before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75925/new/ https://reviews.llvm.org/D75925

[Lldb-commits] [PATCH] D76004: [lldb] Add YAML traits for ArchSpec and ProcessInstanceInfo

2020-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. The mapping vs sequence traits thingy is not that important, but since we do have the "dump" command, it may be worthwhile to spent a bit of time implementing a slightly more

[Lldb-commits] [PATCH] D76002: [lldb] Add YAML traits for ConstString and FileSpec

2020-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:401 protected: + template friend struct llvm::yaml::MappingTraits; + BTW, you can also friend a specific template instantiation: `friend struct llvm::yaml::MappingTraits`.

[Lldb-commits] [PATCH] D76002: [lldb] Add YAML traits for ConstString and FileSpec

2020-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks fine, we just need to avoid ODR violations Comment at: lldb/include/lldb/Utility/FileSpec.h:444 +namespace yaml { +template <> struct ScalarEnumerationTraits { +

[Lldb-commits] [PATCH] D75979: [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame

2020-03-12 Thread Anton Kolesov via Phabricator via lldb-commits
anton.kolesov updated this revision to Diff 249844. anton.kolesov retitled this revision from "[lldb] Implement StackFrame::BehavesLikeZerothFrame" to "[lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame". anton.kolesov edited the summary of this revision. anton.kolesov added a