[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

shafik created this revision. shafik added reviewers: aprantl, labath, jingham. shafik added a comment. My fix in `ConsumeOperator()` is not proper but if everyone feels this is correct approach I will create member functions to deal with this cleanly. Other approaches could be modifying

[Lldb-commits] [PATCH] D75761: [lldb] Fix to get the AST we generate for function templates to be closer to what clang generates and expects

shafik updated this revision to Diff 250327. shafik marked 8 inline comments as done. shafik added a comment. Addressing comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75761/new/ https://reviews.llvm.org/D75761 Files:

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

shafik added a comment. My fix in `ConsumeOperator()` is not proper but if everyone feels this is correct approach I will create member functions to deal with this cleanly. Other approaches could be modifying `ExtractTokens()` to detect this case and generate two `tok::less`in place of

[Lldb-commits] [PATCH] D76167: [lldb/Utils] Use PYTHON_EXECUTABLE to configurelldb-dotest's shebang

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Yes, that's in the spirit of this script. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76167/new/ https://reviews.llvm.org/D76167

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

clayborg added inline comments. Comment at: lldb/bindings/interface/SBPlatform.i:197-198 +lldb::SBEnvironment +GetEnvironment(); + What does it mean to get the environment from a platform? Fetching it from the remote platform as what ever binary was

[Lldb-commits] [PATCH] D76167: [lldb/Utils] Use PYTHON_EXECUTABLE to configurelldb-dotest's shebang

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, labath. Herald added a subscriber: abidh. JDevlieghere updated this revision to Diff 250323. JDevlieghere added a comment. aprantl accepted this revision. This revision is now accepted and ready to land. Context aprantl

[Lldb-commits] [PATCH] D76167: [lldb/Utils] Use PYTHON_EXECUTABLE to configurelldb-dotest's shebang

JDevlieghere updated this revision to Diff 250323. JDevlieghere added a comment. Context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76167/new/ https://reviews.llvm.org/D76167 Files: lldb/utils/lldb-dotest/lldb-dotest.in Index: lldb/utils/lldb-dotest/lldb-dotest.in

[Lldb-commits] [PATCH] D76163: [lldb/Reproducers] Decode run-length encoding in GDB replay server.

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. lgtm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76163/new/ https://reviews.llvm.org/D76163 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D76163: [lldb/Reproducers] Decode run-length encoding in GDB replay server.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jasonmolenda. Herald added a subscriber: abidh. JDevlieghere updated this revision to Diff 250305. JDevlieghere added a comment. Share RLE-decoding logic. The GDB replay server sanity-checks that every packet it receives

[Lldb-commits] [PATCH] D76163: [lldb/Reproducers] Decode run-length encoding in GDB replay server.

JDevlieghere updated this revision to Diff 250305. JDevlieghere added a comment. Share RLE-decoding logic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76163/new/ https://reviews.llvm.org/D76163 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

thakis added a comment. This makes clang crash, repro at https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c4 I'll revert for now. I'm also seeing timeouts and use-after-frees on other bots; maybe they're related (or maybe not). CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

thakis added a comment. Reduced repro at https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c7 Scrolling up, it looks like this was reverted yesterday already. I'm confused why this wasn't reverted yesterday; all work I did in bisecting and creducing was a duplicate of what

[Lldb-commits] [PATCH] D75975: [lldb] Copy m_behaves_like_zeroth_frame on stack frame update

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good to me, nice catch. Thanks for writing a test dase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75975/new/

[Lldb-commits] [lldb] f82b32a - Revert "Reland "[DebugInfo] Enable the debug entry values feature by default""

Author: Nico Weber Date: 2020-03-13T15:37:44-04:00 New Revision: f82b32a51e22cc56d20f695772797127d3f9d85a URL: https://github.com/llvm/llvm-project/commit/f82b32a51e22cc56d20f695772797127d3f9d85a DIFF: https://github.com/llvm/llvm-project/commit/f82b32a51e22cc56d20f695772797127d3f9d85a.diff

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace added a comment. Thanks a lot for the feedback! I was thinking about adding features to this class as needed, but definitely I should make this API be more like a map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76111/new/

[Lldb-commits] [PATCH] D76105: [lldb/settings] Reset the inferior environment when target.inherit-env is toggled

jingham added a comment. In D76105#1921273 , @labath wrote: > In D76105#1920753 , @friss wrote: > > > Yeah, this shortcoming was pretty obvious while writing the patch. I don't > > like it very much, it seems like

[Lldb-commits] [lldb] 01387c4 - [lldb/Test] Temporarily skip TestReproducerAttach on Linux

Author: Jonas Devlieghere Date: 2020-03-13T10:07:15-07:00 New Revision: 01387c44d05287bd330e67af68fc265f01b8d2ed URL: https://github.com/llvm/llvm-project/commit/01387c44d05287bd330e67af68fc265f01b8d2ed DIFF:

[Lldb-commits] [lldb] 20e36f3 - [lldb/Host] s/FindProcesses/FindProcessesImpl/ in windows/Host.cpp

Author: Jonas Devlieghere Date: 2020-03-13T10:07:15-07:00 New Revision: 20e36f31dfc1bb079dc6e6db5f692a4e90aa0c9d URL: https://github.com/llvm/llvm-project/commit/20e36f31dfc1bb079dc6e6db5f692a4e90aa0c9d DIFF:

[Lldb-commits] [lldb] 17bdb7a - [lldb/Test] Convert stdout to str by calling decode('utf-8') on it.

Author: Jonas Devlieghere Date: 2020-03-13T09:50:41-07:00 New Revision: 17bdb7a17912bb4d961cf292c035b08c9d0c13ba URL: https://github.com/llvm/llvm-project/commit/17bdb7a17912bb4d961cf292c035b08c9d0c13ba DIFF:

[Lldb-commits] [PATCH] D75877: [lldb/Reproducers] Fix replay for process attach workflows

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG2451cbf07bbc: [lldb/Reproducers] Intercept the FindProcesses API (authored by JDevlieghere). Changed prior to commit:

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:224 +if (auto *rd = llvm::dyn_cast(tag_decl)) + for (auto *f : rd->fields()) +TypeSystemClang::SetOwningModule(f,

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

jingham added a comment. Yes, a key/value approach would be a better API. Looks like the Environment class would make that pretty easy to wrap up, as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76111/new/ https://reviews.llvm.org/D76111

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:224 +if (auto *rd = llvm::dyn_cast(tag_decl)) + for (auto *f : rd->fields()) +TypeSystemClang::SetOwningModule(f,

[Lldb-commits] [lldb] 2451cbf - [lldb/Reproducers] Intercept the FindProcesses API

Author: Jonas Devlieghere Date: 2020-03-13T09:31:35-07:00 New Revision: 2451cbf07bbc500718c30a9e9447385f7235707b URL: https://github.com/llvm/llvm-project/commit/2451cbf07bbc500718c30a9e9447385f7235707b DIFF:

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

labath added a comment. In D76009#1920548 , @friss wrote: > I put up a "fix" for the inherit-env issue mentioned here: > https://reviews.llvm.org/D76105 > It is mostly orthogonal to this patch as Jim showed the behavior today is > already broken.

[Lldb-commits] [PATCH] D75877: [lldb/Reproducers] Fix replay for process attach workflows

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/functionalities/reproducers/attach/TestReproducerAttach.py:35 + +reproducer_patch = tempfile.NamedTemporaryFile().name +

[Lldb-commits] [PATCH] D76105: [lldb/settings] Reset the inferior environment when target.inherit-env is toggled

labath added a comment. In D76105#1920753 , @friss wrote: > Yeah, this shortcoming was pretty obvious while writing the patch. I don't > like it very much, it seems like the inherit behavior should be handled > closer to the point we launch, Or at least

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

labath added a comment. I'm not sure that this is the right API to represent an environment. The environment is more like a dictionary/map than an array. (The internal Environment object *is* a map, though this does not immediately mean the SB one should be too). Even for your most immediate

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

jhenderson added a comment. I'm not really up to speed with the .debug_*_index sections, so I haven't looked really at the overall approach. I've just provided some basic stylistic comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:22 +// Pre-standard

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin added a comment. In D75929#1920691 , @dblaikie wrote: > > This is almost what you are doing right now -- the only difference is that > > the "internal" enum would no longer be internal -- it would actually match > > the on-disk format of a v5

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

dblaikie added a comment. > This is almost what you are doing right now -- the only difference is that > the "internal" enum would no longer be internal -- it would actually match > the on-disk format of a v5 index. This v5 enum would contain the official > DWARFv5 constants as well as the new

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

labath added a comment. In D75711#1920425 , @jingham wrote: > Is this one okay as well? All my concerns have been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75711/new/