[Lldb-commits] [PATCH] D76341: [lldb/MemoryHistoryAsan] Fix address resolution for recorded backtraces

friss created this revision. friss added reviewers: jasonmolenda, kubamracek. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: LLDB. The memory history plugin for Asan creates a HistoryThread with the recorded PC values provided by the Asan runtime. In other cases,

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl updated this revision to Diff 250971. aprantl marked an inline comment as done. aprantl added a comment. Address review feedback from Raphael. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75488/new/ https://reviews.llvm.org/D75488 Files:

[Lldb-commits] [PATCH] D76337: [lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address

jasonmolenda added a comment. Nice fix, this looks good to me but I haven't been following this area of code too closely before now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76337/new/ https://reviews.llvm.org/D76337 ___ lldb-commits

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace added a comment. As we discussed privately, some remote connections use a mutiplexor socket that doesn't die when the debug session ends. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314

[Lldb-commits] [PATCH] D76337: [lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address

vsk created this revision. vsk added reviewers: aprantl, jasonmolenda, friss. lldb currently guesses the address to use when creating an artificial frame (i.e., a frame constructed by determining the sequence of (tail) calls which must have happened). Guessing the address creates problems -- use

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

jarin updated this revision to Diff 250951. jarin added a comment. - Added a test that checks consistency of thread info's memory chunks with the actual memory. - Using DataExtractor to extract pointers with the right endian-ness and the right size. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

clayborg added a comment. Does this have something to do with a multiplexor that funnels traffic through one tunnel? I am curious as to why the ReadJSON() doesn't exit after the other side closes down? LGTM, but needs a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] a11b330 - [lldb/Bindings] Check that process isn't None before calling is_alive.

Author: Jonas Devlieghere Date: 2020-03-17T17:06:04-07:00 New Revision: a11b330418819d9cc9c4f0ecd31acdc2e0bbb703 URL: https://github.com/llvm/llvm-project/commit/a11b330418819d9cc9c4f0ecd31acdc2e0bbb703 DIFF:

[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

aprantl updated this revision to Diff 250941. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75626/new/ https://reviews.llvm.org/D75626 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangExternalASTSourceCallbacks.cpp

[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

aprantl updated this revision to Diff 250938. aprantl marked 5 inline comments as done. aprantl added a comment. Addressed review feedback and made the whole thing more type-safe. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75626/new/ https://reviews.llvm.org/D75626 Files:

[Lldb-commits] [lldb] 3829d85 - [lldb/PlatformDarwin] Return POSIX path from FindXcodeContentsDirectoryInPath

Author: Jonas Devlieghere Date: 2020-03-17T15:57:34-07:00 New Revision: 3829d85cc615ec9a855ce96e4555820e5dd4ae51 URL: https://github.com/llvm/llvm-project/commit/3829d85cc615ec9a855ce96e4555820e5dd4ae51 DIFF:

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG7aa28995e87f: [lldb/PlatformDarwin] Be more robust in computing the SDK path with xcrun (authored by JDevlieghere). Herald added a project: LLDB. Changed

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1998 + g_xcode_contents_path = FileSpec(xcode_contents_dir); + return; +} aprantl

[Lldb-commits] [lldb] 7aa2899 - [lldb/PlatformDarwin] Be more robust in computing the SDK path with xcrun

Author: Jonas Devlieghere Date: 2020-03-17T14:41:45-07:00 New Revision: 7aa28995e87f6cec2e02608c978885cf01dcc65d URL: https://github.com/llvm/llvm-project/commit/7aa28995e87f6cec2e02608c978885cf01dcc65d DIFF:

[Lldb-commits] [PATCH] D76316: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles

jankratochvil updated this revision to Diff 250903. jankratochvil added a comment. With the former patch these both skeleton files: tools/lldb/test/SymbolFile/DWARF/Output/debug-types-expressions.test.tmp4dwo tools/lldb/test/SymbolFile/DWARF/Output/debug-types-expressions.test.tmp5dwo were

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1998 + g_xcode_contents_path = FileSpec(xcode_contents_dir); + return; +

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

JDevlieghere updated this revision to Diff 250890. JDevlieghere marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76261/new/ https://reviews.llvm.org/D76261 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1362 + case SDKType::AppleTVSimulator: return version >= llvm::VersionTuple(8); + default: aprantl wrote: > The corresponding watchOS and tvOS numbers

[Lldb-commits] [PATCH] D76316: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles

jankratochvil created this revision. jankratochvil added reviewers: labath, JDevlieghere. jankratochvil added a project: LLDB. jankratochvil edited the summary of this revision. D63643 added these testfiles but some of the `%t4dwo` and `%t5dwo` builds are the

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace created this revision. wallace added reviewers: clayborg, aadsm, kusmour. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kusmour accepted this revision. This revision is now accepted and ready to land. On Linux, when executing lldb-vscode on a remote machine,

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1949 + std::string xcrun_cmd = + "xcrun --show-sdk-path -sdk " + GetSDKNameForType(type).str(); + `--sdk` for symmetry? Or is that the correct option?

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1362 + case SDKType::AppleTVSimulator: return version >= llvm::VersionTuple(8); + default: The corresponding watchOS and tvOS numbers for iOS 8 should be

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

mib updated this revision to Diff 250868. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76188/new/ https://reviews.llvm.org/D76188 Files: lldb/include/lldb/Target/StackFrameRecognizer.h lldb/packages/Python/lldbsuite/test/lldbutil.py

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

jingham added inline comments. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:880 auto func = -RegularExpressionSP(new RegularExpression(m_options.m_function)); +RegularExpressionSP(new RegularExpression(m_options.m_symbols.front()));

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

mib updated this revision to Diff 250864. mib marked an inline comment as done. mib added a reviewer: jingham. mib added a comment. Updated `frame recognizer add` help description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76188/new/

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

mib marked 4 inline comments as done. mib added inline comments. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:880 auto func = -RegularExpressionSP(new RegularExpression(m_options.m_function)); +RegularExpressionSP(new

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1433 FileSpec PlatformDarwin::GetSDKDirectoryForModules(SDKType sdk_type) { FileSpec sdks_spec = GetXcodeContentsPath(); aprantl wrote: > Not your fault

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

JDevlieghere updated this revision to Diff 250847. JDevlieghere marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76261/new/ https://reviews.llvm.org/D76261 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1273 +"macosx","iphonesimulator", "iphoneos", "appletvsimulator", +"appletvos", "watchsimulator", "watchos", "linux"}; How about hard-coding this in

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

jingham added inline comments. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:880 auto func = -RegularExpressionSP(new RegularExpression(m_options.m_function)); +RegularExpressionSP(new RegularExpression(m_options.m_symbols.front()));

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

mib updated this revision to Diff 250840. mib added a comment. Added error when passing multiple symbols with `--regex` flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76188/new/ https://reviews.llvm.org/D76188 Files:

[Lldb-commits] [PATCH] D75761: [lldb] Remove template parameters from FunctionTemplateDecl names

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e2715aaacaa: [lldb] Remove template parameters from FunctionTemplateDecl names (authored by shafik). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

aprantl updated this revision to Diff 250829. aprantl added a comment. Address feedback from Pavel and add the payload to the constructor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75562/new/ https://reviews.llvm.org/D75562 Files: lldb/include/lldb/Symbol/Type.h

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:880 auto func = -RegularExpressionSP(new RegularExpression(m_options.m_function)); +RegularExpressionSP(new

[Lldb-commits] [lldb] 9e2715a - [lldb] Remove template parameters from FunctionTemplateDecl names

Author: shafik Date: 2020-03-17T11:00:23-07:00 New Revision: 9e2715aaacaa3087933b5575d23563751b54843b URL: https://github.com/llvm/llvm-project/commit/9e2715aaacaa3087933b5575d23563751b54843b DIFF: https://github.com/llvm/llvm-project/commit/9e2715aaacaa3087933b5575d23563751b54843b.diff LOG:

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

aprantl updated this revision to Diff 250825. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75562/new/ https://reviews.llvm.org/D75562 Files: lldb/include/lldb/Symbol/Type.h lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

JDevlieghere updated this revision to Diff 250821. JDevlieghere added a comment. Add unit test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76261/new/ https://reviews.llvm.org/D76261 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

jingham added inline comments. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:880 auto func = -RegularExpressionSP(new RegularExpression(m_options.m_function)); +RegularExpressionSP(new RegularExpression(m_options.m_symbols.front()));

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

JDevlieghere updated this revision to Diff 250810. JDevlieghere added a comment. New approach. Test is coming but upload the patch so Adrian can take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76261/new/ https://reviews.llvm.org/D76261 Files:

[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

aprantl added inline comments. Comment at: lldb/unittests/Platform/PlatformMacOSXTest.cpp:25 + "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/" + "Developer/SDKs/MacOSX10.15.sdk"); + EXPECT_FALSE(static_cast(standard)); This

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:880 auto func = -RegularExpressionSP(new RegularExpression(m_options.m_function)); +RegularExpressionSP(new RegularExpression(m_options.m_symbols.front()));

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

jhenderson added a comment. Thanks. My comments have all been addressed. I'm happy once somebody else looks at the more technical aspects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75929/new/ https://reviews.llvm.org/D75929 ___

[Lldb-commits] [PATCH] D76216: Improve step over performance

jarin added a comment. Thanks for all the clarifications, this is very useful. I have always wanted to learn about thread plans, and this was a nice opportunity to do that. The extra background from you guys is a nice bonus. Regarding the patch itself, is there anything preventing an LGTM?

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin updated this revision to Diff 250731. ikudrin marked 8 inline comments as done. ikudrin added a comment. - Fixed messages in `llvm-dwp.cpp`. - Fixed comments in the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75929/new/ https://reviews.llvm.org/D75929 Files:

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin added inline comments. Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:614 +if (CUIndex.getVersion() != 2) + return make_error("Unsupported cu_index version"); jhenderson wrote: > jhenderson wrote: > > I see the above error message starts with a

[Lldb-commits] [lldb] f955418 - [lldb] Tighten checks in TestStats.py

Author: Raphael Isemann Date: 2020-03-17T14:12:13+01:00 New Revision: f95541839cb25c883dc530928232105af87c75dc URL: https://github.com/llvm/llvm-project/commit/f95541839cb25c883dc530928232105af87c75dc DIFF:

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rG0818e6cf1d30: [LLDB] Add support for AVR breakpoints (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74255/new/

[Lldb-commits] [lldb] 7c6e52a - [lldb] Ptrs->refs in CommandObjectExpression::EvaluateExpression parameters

Author: Raphael Isemann Date: 2020-03-17T13:23:16+01:00 New Revision: 7c6e52ac0ce5a6879331bc3c322dd20bfec3bf14 URL: https://github.com/llvm/llvm-project/commit/7c6e52ac0ce5a6879331bc3c322dd20bfec3bf14 DIFF:

[Lldb-commits] [lldb] 0818e6c - [LLDB] Add support for AVR breakpoints

Author: Ayke van Laethem Date: 2020-03-17T13:17:48+01:00 New Revision: 0818e6cf1d30dcac1fc4dcde60e01f8389e725f9 URL: https://github.com/llvm/llvm-project/commit/0818e6cf1d30dcac1fc4dcde60e01f8389e725f9 DIFF:

[Lldb-commits] [lldb] f5e0f8b - [lldb] Add test for importing ObjC modules in a non-ObjC target

Author: Raphael Isemann Date: 2020-03-17T12:49:48+01:00 New Revision: f5e0f8b10ab95e94b5ffb32e380f95d21415c3e8 URL: https://github.com/llvm/llvm-project/commit/f5e0f8b10ab95e94b5ffb32e380f95d21415c3e8 DIFF:

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:880 auto func = -RegularExpressionSP(new RegularExpression(m_options.m_function)); +RegularExpressionSP(new

[Lldb-commits] [lldb] 06489ea - [lldb] [Host/NetBSD] Rename Host.cpp to HostNetBSD.cpp

Author: Michał Górny Date: 2020-03-17T11:42:39+01:00 New Revision: 06489eaa92162c6b01a767124f3fcdada99bb2f1 URL: https://github.com/llvm/llvm-project/commit/06489eaa92162c6b01a767124f3fcdada99bb2f1 DIFF: https://github.com/llvm/llvm-project/commit/06489eaa92162c6b01a767124f3fcdada99bb2f1.diff

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

jhenderson added inline comments. Comment at: llvm/test/DebugInfo/X86/dwp-v5-cu-index.s:1 +## The test checks that we can parse and dump a CU index section that compliant +## to the DWARFv5 standard. that is compliant Comment at:

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

labath added a comment. In D76188#1924840 , @mib wrote: > @labath Do you object if I land this patch to revert our CIs to green and > work on matching the symbol by address instead of name on a separate one ? I think this is fine -- a vector is