[Lldb-commits] [PATCH] D77369: Augment the symbol type classification for dyld trie exports with more detail

jasonmolenda created this revision. jasonmolenda added reviewers: labath, clayborg. jasonmolenda added a project: LLDB. My patch to augment the symbol table in Mach-O files with the dyld trie exports data structure only categorized symbols as code or data, but Greg Clayton had a patch to do

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl added a comment. > Yeah, it seems acceptable. The "sdk type" argument still seems somewhat > redundant. Theoretically we could pass in just the triple component out the > xcodesdk object, but that would just mean the individual platforms would have > to reconstruct the XcodeSDK object,

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl updated this revision to Diff 254696. aprantl marked 7 inline comments as done. aprantl added a comment. Renamed SDK -> XcodeSDK where applicable. Sorry I missed this earlier. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76471/new/ https://reviews.llvm.org/D76471 Files:

[Lldb-commits] [PATCH] D77347: Have lldb-vscode update the currently selecte thread and frame when it receives a "scopes" request.

clayborg added a comment. commit 5998aceda9fdca04db4d9ee390cec660896bf0bf (HEAD -> master, origin/master, origin/HEAD) Author: Greg Clayton Date: Thu Apr 2 16:30:33 2020 -0700 Have lldb-vscode update the currently

[Lldb-commits] [PATCH] D77347: Have lldb-vscode update the currently selecte thread and frame when it receives a "scopes" request.

clayborg updated this revision to Diff 254670. clayborg added a comment. Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77347/new/ https://reviews.llvm.org/D77347 Files: lldb/test/API/tools/lldb-vscode/console/Makefile

[Lldb-commits] [lldb] 5998ace - Have lldb-vscode update the currently selecte thread and frame when it receives a "scopes" request.

Author: Greg Clayton Date: 2020-04-02T18:35:17-07:00 New Revision: 5998aceda9fdca04db4d9ee390cec660896bf0bf URL: https://github.com/llvm/llvm-project/commit/5998aceda9fdca04db4d9ee390cec660896bf0bf DIFF: https://github.com/llvm/llvm-project/commit/5998aceda9fdca04db4d9ee390cec660896bf0bf.diff

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham updated this revision to Diff 254664. jingham added a comment. I changed target.process.plugin-reports-all-threads to target.experimental.os-plugin-reports-all-threads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76814/new/

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

aprantl added a comment. In D77326#1958082 , @shafik wrote: > I feel like this should have been split in two. It feels like there are > straight forward obviously correct changes and a several others that require > some thinking about but look correct.

[Lldb-commits] [PATCH] D77351: [lldb/Support] Treat empty FileSpec as an invalid file.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor. LLDB relies on empty FileSpecs being invalid files, for example, they don't exists. Currently this assumption does not always hold during reproducer replay, because we pass the result of `GetPath` to the VFS.

[Lldb-commits] [PATCH] D77347: Have lldb-vscode update the currently selecte thread and frame when it receives a "scopes" request.

wallace added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/console/TestVSCode_console.py:20 +def check_lldb_command(self, lldb_command, contains_string, assert_msg): +response = self.vscode.request_evaluate('`%s' % (lldb_command)) +output =

[Lldb-commits] [PATCH] D77347: Have lldb-vscode update the currently selecte thread and frame when it receives a "scopes" request.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. I agree with the implementation. I also find no way notify the IDE that the user has switched to a different thread or frame in the console, and I actually think it's better this way.

[Lldb-commits] [PATCH] D77347: Have lldb-vscode update the currently selecte thread and frame when it receives a "scopes" request.

clayborg created this revision. clayborg added reviewers: labath, aadsm, wallace, JDevlieghere. Herald added a project: LLDB. wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. I agree with the implementation. I also find no way notify the

[Lldb-commits] [PATCH] D77295: [lldb/Core] Fix a race in the Communication class

clayborg added inline comments. Comment at: lldb/source/Core/Communication.cpp:318 bool done = false; + bool disconnect = false; while (!done && comm->m_read_thread_enabled) { Can we just init "disconnect" right here?: ``` const bool disconnect =

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd updated this revision to Diff 254631. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 Files: lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp lldb/source/Plugins/Platform/Windows/PlatformWindows.h Index:

[Lldb-commits] [PATCH] D77337: [lldb/Symbol] Reimplement Symbols::FindSymbolFileInBundle to use the VFS

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda, labath. This reimplements Symbols::FindSymbolFileInBundle to use the VFS-aware recursive directory iterator. This is needed for reproducer replay. Repository: rLLDB LLDB https://reviews.llvm.org/D77337

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2387 // dsymutil. - if (num_die_matches < max_matches) { + if (types.GetSize() < max_matches) {

[Lldb-commits] [PATCH] D77336: Findtypes -gmodules fix

jankratochvil created this revision. jankratochvil added reviewers: labath, kwk. jankratochvil added a project: LLDB. A little fixup so that D77327 can be called NFC. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77336 Files:

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

shafik added a comment. I feel like this should have been split in two. It feels like there are straight forward obviously correct changes and a several others that require some thinking about but look correct. Comment at:

[Lldb-commits] [PATCH] D77327: [lldb] [almost-nfc] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 254617. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 254616. jankratochvil marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326 Files:

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 6 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2014 -if (!method_die_offsets.empty()) { - DWARFDebugInfo _info = dwarf->DebugInfo();

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

aprantl added a comment. I am generally very okay with this change, though some changes look suspicious, as @kwk noted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

kwk added a comment. Overall looks good to me except for one larger logic change. Maybe a your comment can clarify this. The code was in a very bad shape before, given the countless amounts of shortcuts you could take. Comment at:

[Lldb-commits] [PATCH] D77327: [lldb] [almost-nfc] 2/2: Introduce DWARF callbacks

jankratochvil marked 3 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:134 + m_map.begin(), m_map.end(), unique_cstr, Compare( + if (callback(entry.value)) +return true;

[Lldb-commits] [PATCH] D77328: [intel-mpx] Delete an unnecessary license header

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. @labath mentioned to me that test files shouldn't have a license header. I saw this one some days ago, so I'm doing some cleaning. Repository: rG

[Lldb-commits] [PATCH] D77326: [nfc] [lldb] Unindent code

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added subscribers: arphaman, aprantl. Herald added a reviewer: jdoerfert. Herald added a reviewer: shafik. It removes some needless deep indentation and some redundant

[Lldb-commits] [PATCH] D77327: [lldb] [almost-nfc] 2/2: Introduce DWARF callbacks

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added subscribers: arphaman, aprantl. Herald added a reviewer: shafik. As requested by @labath in https://reviews.llvm.org/D73206#1949516 (D73206

[Lldb-commits] [PATCH] D77324: [source maps] Fix remove, insert-after and replace

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, mgrang. Herald added a project: LLDB. wallace updated this revision to Diff 254576. wallace added a comment. fix typos I think the quarantine is reducing my IQ overall... In this

[Lldb-commits] [PATCH] D77324: [source maps] Fix remove, insert-after and replace

wallace updated this revision to Diff 254576. wallace added a comment. fix typos I think the quarantine is reducing my IQ overall... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77324/new/ https://reviews.llvm.org/D77324 Files:

[Lldb-commits] [lldb] b78157c - [intel-pt] Implement a basic test case

Author: Walter Erquinigo Date: 2020-04-02T11:36:05-07:00 New Revision: b78157c88b327f4a683f2cdfe3d4f331492576a5 URL: https://github.com/llvm/llvm-project/commit/b78157c88b327f4a683f2cdfe3d4f331492576a5 DIFF:

[Lldb-commits] [PATCH] D76729: Convert for loops to entry-based iteration

This revision was automatically updated to reflect the committed changes. Closed by commit rG51b38746295f: Convert for loops to entry-based iteration (authored by shivammittal99, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 51b3874 - Convert for loops to entry-based iteration

Author: Shivam Mittal Date: 2020-04-02T18:56:29+02:00 New Revision: 51b38746295fc18664f766fe6cb7974b862c28eb URL: https://github.com/llvm/llvm-project/commit/51b38746295fc18664f766fe6cb7974b862c28eb DIFF: https://github.com/llvm/llvm-project/commit/51b38746295fc18664f766fe6cb7974b862c28eb.diff

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd added a comment. Thanks for the hint about the string conversion, however, I think that it's going to complicate things as the string is going to be a mixture of UTF-8 and UTF-16 content. As to the testing, `functionalities/load_using_paths/TestLoadUsingPaths.py` is not applicable to

[Lldb-commits] [PATCH] D76955: [lldb/Test] Decode stdout and stderr in case it contains UTF-8

JDevlieghere abandoned this revision. JDevlieghere added a comment. After looking at `util.py` I'm convinced that this should never happen, unless there's a bug in the `to_string` implementation in which case we'd need to fix it there. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

kwk added a comment. In D77108#1952039 , @labath wrote: > In D77108#1951997 , @kwk wrote: > > > In D77108#1951879 , @labath wrote: > > > > > Most DW_OP cases check their

[Lldb-commits] [PATCH] D77302: [DebugInfo] Rename getOffset() to getContribution(). NFC.

ikudrin created this revision. ikudrin added reviewers: jhenderson, dblaikie, probinson, aprantl. ikudrin added projects: LLVM, debug-info. Herald added subscribers: lldb-commits, arphaman, hiraditya. Herald added a project: LLDB. The old name was a bit misleading because the functions actually

[Lldb-commits] [PATCH] D77302: [DebugInfo] Rename getOffset() to getContribution(). NFC.

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77302/new/ https://reviews.llvm.org/D77302

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

dblaikie accepted this revision. dblaikie added a comment. In D75929#1954443 , @labath wrote: > Thanks for doing this. This looks fine to me. @dblaikie, @jhenderson, do you > have any additional comments? nah, nothing dire that comes to mind - thanks

[Lldb-commits] [lldb] 183fba6 - Add OMPIterator case in switch statement to silence warnings

Author: scentini Date: 2020-04-02T16:16:11+02:00 New Revision: 183fba635d5ece8466af3085c2e831f9a93ee775 URL: https://github.com/llvm/llvm-project/commit/183fba635d5ece8466af3085c2e831f9a93ee775 DIFF: https://github.com/llvm/llvm-project/commit/183fba635d5ece8466af3085c2e831f9a93ee775.diff

[Lldb-commits] [PATCH] D77241: update eArgTypeScriptLang description to mention lua

This revision was automatically updated to reflect the committed changes. Closed by commit rG55e32e92cda7: [lldb] update eArgTypeScriptLang description to mention lua (authored by emaste). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

jarin added a comment. Pavel, could you land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74398/new/ https://reviews.llvm.org/D74398 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 55e32e9 - [lldb] update eArgTypeScriptLang description to mention lua

Author: Ed Maste Date: 2020-04-02T09:43:01-04:00 New Revision: 55e32e92cda79a9eb4487ea8e4ec1b968fac5145 URL: https://github.com/llvm/llvm-project/commit/55e32e92cda79a9eb4487ea8e4ec1b968fac5145 DIFF: https://github.com/llvm/llvm-project/commit/55e32e92cda79a9eb4487ea8e4ec1b968fac5145.diff

[Lldb-commits] [PATCH] D76729: Convert for loops to entry-based iteration

shivammittal99 added a comment. Can you please commit this for me? I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76729/new/ https://reviews.llvm.org/D76729 ___

[Lldb-commits] [lldb] 451741a - [lldb] Change Communication::SetConnection to take a unique_ptr

Author: Pavel Labath Date: 2020-04-02T14:42:25+02:00 New Revision: 451741a9d778a260ceee608a26b5fdf2d9926982 URL: https://github.com/llvm/llvm-project/commit/451741a9d778a260ceee608a26b5fdf2d9926982 DIFF: https://github.com/llvm/llvm-project/commit/451741a9d778a260ceee608a26b5fdf2d9926982.diff

[Lldb-commits] [PATCH] D77295: [lldb/Core] Fix a race in the Communication class

labath created this revision. labath added reviewers: clayborg, JDevlieghere. Herald added a subscriber: mgorny. Herald added a project: LLDB. Communication::SynchronizeWithReadThread is called whenever a process stops to ensure that we process all of its stdout before we report the stop. If the

[Lldb-commits] [PATCH] D77044: Extend max register size to accommodate AArch64 SVE vector regs

omjavaid updated this revision to Diff 254479. omjavaid added a comment. Posting full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77044/new/ https://reviews.llvm.org/D77044 Files: lldb/include/lldb/Utility/RegisterValue.h

[Lldb-commits] [PATCH] D77044: Extend max register size to accommodate AArch64 SVE vector regs

omjavaid marked 2 inline comments as done. omjavaid added a comment. In D77044#1954685 , @labath wrote: > Sounds fairly noncontroversial. I don't think we have too many of these > objects floating around, but if it turns out we do, we could switch to a

[Lldb-commits] [PATCH] D77045: Add invalidate list to primary regs in arm64 register infos

omjavaid marked an inline comment as done. omjavaid added a comment. In D77045#1954690 , @labath wrote: > This sounds like it could use a test case. Adding a testcase would be tricky as these register overlap in memory and we store them with

[Lldb-commits] [lldb] 62be834 - Recommit "[lldb] Fix TestSettings.test_pass_host_env_vars on windows"

Author: Pavel Labath Date: 2020-04-02T11:52:56+02:00 New Revision: 62be83463a3713612bd85cfa45140ef92c130d57 URL: https://github.com/llvm/llvm-project/commit/62be83463a3713612bd85cfa45140ef92c130d57 DIFF: https://github.com/llvm/llvm-project/commit/62be83463a3713612bd85cfa45140ef92c130d57.diff

[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

labath added a comment. We have some existing tests (`functionalities/load_using_paths/TestLoadUsingPaths.py`) for this functionality, but they are are all skipped on windows. Can you check if they work now, or create a new test for the subset of functionality which does work? > Ideally,

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath added a comment. Ok, I think we have converged onto something here. I just think it would be good to rename some functions/variables to make it clear they are working with an xcode sdk, and not some generic entity. In D76471#1955908 , @aprantl

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

labath added inline comments. Comment at: lldb/source/Target/TargetProperties.td:183 Desc<"A path to a python OS plug-in module file that contains a OperatingSystemPlugIn class.">; + def PluginReportsAllThreads: Property<"plugin-reports-all-threads", "Boolean">, +

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

labath added a comment. In D77153#1955829 , @friss wrote: > I was checking whether there is a way to catch null pointer before a type > summary is even chosen. And found out that such logic exists, but only for > Objective-C. Languages have a

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid added a comment. In D77047#1954696 , @labath wrote: > > There is no physical hardware currently available to test SVE and we make > > use of QEMU for the purpose of testing this feature. > > Are these registers presented in core files in any

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid updated this revision to Diff 254454. omjavaid added a comment. Posting full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files: lldb/source/Plugins/Process/Linux/LinuxPTraceDefines_arm64sve.h

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid added a comment. In D77043#1954672 , @labath wrote: > I am still thinking this over, but for now I have two comments. First, could > you re-upload the diff with full context (e.g. `git show -U`). That would > make it a lot easier to review

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

labath added a comment. In D77186#1955640 , @wallace wrote: > Thanks for the heads up. I think I got a false impression of how comments > after accept vs requesting changes work in this repo. The rules on that are somewhat fuzzy, but there has been a

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid updated this revision to Diff 25. omjavaid added a comment. Posting full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77043/new/ https://reviews.llvm.org/D77043 Files: lldb/docs/lldb-gdb-remote.txt lldb/include/lldb/Host/common/NativeRegisterContext.h

Re: [Lldb-commits] [lldb] c911cc6 - [intel-pt] Implement a basic test case

Walter, you were already told to write more informative messages when reverting and recommiting patches. If you're reverting a patch, please give a short explanation of the reason (does it fail on the bots? which ones? what fails?). When recommiting a patch, please give a summary of what has