[Lldb-commits] [PATCH] D77295: [lldb/Core] Fix a race in the Communication class

2020-04-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D77295#1996337 , @labath wrote: > In D77295#1995077 , @JDevlieghere > wrote: > > > Hi Pavel, > > > > After this landed I started seeing a bunch of reproducers fail with > > `SIGPIP

[Lldb-commits] [lldb] b424b0b - [lldb/Target] Avoid race between Communication::Disconnect calls.

2020-04-22 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-04-22T16:56:42-07:00 New Revision: b424b0bf731d1fb338180553a86f912746f640ad URL: https://github.com/llvm/llvm-project/commit/b424b0bf731d1fb338180553a86f912746f640ad DIFF: https://github.com/llvm/llvm-project/commit/b424b0bf731d1fb338180553a86f912746f640ad.d

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

2020-04-22 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid requested changes to this revision. omjavaid added a comment. This revision now requires changes to proceed. I have temporarily reverted this change to turn buildbot green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://r

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

2020-04-22 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG478619cf9a24: Revert "get rid of PythonInteger::GetInteger()" (authored by omjavaid). Changed prior to commit: https:

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

2020-04-22 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This causes multiple test failures on LLDB AArch64 Linux buildbot. http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/3695 Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [lldb] 478619c - Revert "get rid of PythonInteger::GetInteger()"

2020-04-22 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2020-04-23T04:38:32+05:00 New Revision: 478619cf9a24ad8eac806959ca6a289a9beb71ae URL: https://github.com/llvm/llvm-project/commit/478619cf9a24ad8eac806959ca6a289a9beb71ae DIFF: https://github.com/llvm/llvm-project/commit/478619cf9a24ad8eac806959ca6a289a9beb71

[Lldb-commits] [PATCH] D78489: [lldb/DWARF] Trust CU DW_AT_low/high_pc information when building address tables

2020-04-22 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. In D78489#1996834 , @labath wrote: > In D78489#1995837 , @clayborg wrote: > > > Sounds like a win then, as

[Lldb-commits] [PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

2020-04-22 Thread Aleksei Sidorin via Phabricator via lldb-commits
a_sidorin accepted this revision. a_sidorin added a comment. Hello Shafik! The patch looks good, I only have a few stylish nits. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5964 + new SourceWithCompletedTagList(CompletedTags); + clang::ASTContext &context = FromTU

[Lldb-commits] [PATCH] D78337: [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool

2020-04-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe57361c055d7: [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D78337?vs

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

2020-04-22 Thread Christopher Tetreault via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2dea3f129878: [SVE] Add new VectorType subclasses (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

2020-04-22 Thread Louis Dionne via Phabricator via lldb-commits
ldionne created this revision. Herald added subscribers: libcxx-commits, openmp-commits, lldb-commits, Sanitizers, cfe-commits, frgossen, grosul1, jvesely, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini, lebedev.ri, de

[Lldb-commits] [PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

2020-04-22 Thread Louis Dionne via Phabricator via lldb-commits
ldionne added a comment. This review is for the upcoming CMake upgrade once we branch off the LLVM 11 release branch. I won't apply it until after the branch has been created, which is around July. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D786

[Lldb-commits] [lldb] e57361c - [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool

2020-04-22 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-04-22T09:17:49-07:00 New Revision: e57361c055d7617ee25cdac8167625000d098ef5 URL: https://github.com/llvm/llvm-project/commit/e57361c055d7617ee25cdac8167625000d098ef5 DIFF: https://github.com/llvm/llvm-project/commit/e57361c055d7617ee25cdac8167625000d098ef5.d

[Lldb-commits] [PATCH] D78588: [lldb/Core] Check that ArchSpec is valid.

2020-04-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D78588#1996222 , @labath wrote: > The presence of `llvm_unreachable` here is questionable, but I am surprised > that this comes up in the context of reproducers. If the reproducers cause > this function to be called with

[Lldb-commits] [lldb] 2dea3f1 - [SVE] Add new VectorType subclasses

2020-04-22 Thread Christopher Tetreault via lldb-commits
Author: Christopher Tetreault Date: 2020-04-22T08:59:01-07:00 New Revision: 2dea3f129878e929e5d1f00b91a622eb1ec8be4e URL: https://github.com/llvm/llvm-project/commit/2dea3f129878e929e5d1f00b91a622eb1ec8be4e DIFF: https://github.com/llvm/llvm-project/commit/2dea3f129878e929e5d1f00b91a622eb1ec8be

[Lldb-commits] [PATCH] D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE

2020-04-22 Thread Jan Kratochvil via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd482fe2add95: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D77970?vs=258921&id=259303#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE

2020-04-22 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. Thanks for the review and I have learned a new use case for `llvm::function_ref`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77970/new/ https://reviews.llvm.org/D77970 __

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

2020-04-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Where does the option which I proposed fit in? It sounds like it would be something like 1a), where we don't actually modify the "invalidate" numbers stored within lldb-server, but we just do the conversion at the protocol level. That way the "invalidate" numbers keep th

[Lldb-commits] [lldb] d482fe2 - [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE

2020-04-22 Thread Jan Kratochvil via lldb-commits
Author: Jan Kratochvil Date: 2020-04-22T17:11:50+02:00 New Revision: d482fe2add95c38691edb2c91d0f5681bebcd81d URL: https://github.com/llvm/llvm-project/commit/d482fe2add95c38691edb2c91d0f5681bebcd81d DIFF: https://github.com/llvm/llvm-project/commit/d482fe2add95c38691edb2c91d0f5681bebcd81d.diff

[Lldb-commits] [PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

2020-04-22 Thread Gabor Marton via Phabricator via lldb-commits
martong accepted this revision. martong added a comment. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78000/new/ https://reviews.llvm.org/D78000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D78489: [lldb/DWARF] Trust CU DW_AT_low/high_pc information when building address tables

2020-04-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D78489#1995837 , @clayborg wrote: > Sounds like a win then, as long as we don't get slower I am fine with this. I > was guessing that line tables might be faster because it is generally very > compressed and compact compared to

[Lldb-commits] [PATCH] D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE

2020-04-22 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, just please write more explanatory commit message than what's present in this patch description. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

2020-04-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D75750#1993990 , @jankratochvil wrote: > In D75750#1991873 , @labath wrote: > > > In D75750#1988694 , @jankratochvil > > wrote: > > > > > The cur

[Lldb-commits] [PATCH] D78337: [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool

2020-04-22 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. I'm not sure how useful is the `TaskMapOverInt` function in this new world (if I was writing this from scratch, I don't think I would create a function for that), but it doesn't hurt tha

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

2020-04-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D77047#1996198 , @omjavaid wrote: > This update includes core file register access for SVE registers. Register > descriptions can now be tested with core dump. Cool. Could you please split off the stuff necessary for making co

[Lldb-commits] [PATCH] D77295: [lldb/Core] Fix a race in the Communication class

2020-04-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D77295#1995077 , @JDevlieghere wrote: > Hi Pavel, > > After this landed I started seeing a bunch of reproducers fail with > `SIGPIPE`. I ignored the signal and added a check for `EPIPE` to the > `::write` call in `PipePosix.cp

[Lldb-commits] [PATCH] D77793: Fix LLDB elf core dump register access for ARM/AArch64

2020-04-22 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. LGTM, assuming the checked-in core files are of a "reasonable" (~ several tens of KB) size. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCor

[Lldb-commits] [PATCH] D78603: remove unused function LLDBSwigPython_GetIndexOfChildWithName

2020-04-22 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78603/new/ https://reviews.llvm.org/D78603 ___

[Lldb-commits] [PATCH] D78588: [lldb/Core] Check that ArchSpec is valid.

2020-04-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. The presence of `llvm_unreachable` here is questionable, but I am surprised that this comes up in the context of reproducers. If the reproducers cause this function to be called with a different ArchSpec, then it sounds like there are bigger problems that need to be solv

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

2020-04-22 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. Also about licensing issues of included macros I am in contact with original authors from ARM and I hope they will be able to help sign off this patch for LLVM submission. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D7704

[Lldb-commits] [PATCH] D77793: Fix LLDB elf core dump register access for ARM/AArch64

2020-04-22 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid updated this revision to Diff 259182. omjavaid added a comment. Updated diff after implementing core file using assembly code. Also removed the redundant register info is null condition. LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77793/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

2020-04-22 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.cpp:47-62 + DataBufferHeap buffer(size, 0); + m_exe_ctx_ref.GetProcessSP()->ReadMemory(addr, buffer.GetBytes(), size, + error); + if (error.Fail())

[Lldb-commits] [lldb] a53874b - [lldb] Fix modules build by adding missing include

2020-04-22 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-04-22T09:14:09+02:00 New Revision: a53874b7e4c82416b8eb48bbd45b5cb93f1e09d3 URL: https://github.com/llvm/llvm-project/commit/a53874b7e4c82416b8eb48bbd45b5cb93f1e09d3 DIFF: https://github.com/llvm/llvm-project/commit/a53874b7e4c82416b8eb48bbd45b5cb93f1e09d3.dif