[Lldb-commits] [PATCH] D78791: [lldb][NFC][CallSite] Remove CallSite use

This revision was automatically updated to reflect the committed changes. Closed by commit rG5948dafc694b: [lldb][NFC][CallSite] Remove CallSite use (authored by mtrofin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78791/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D78791: [lldb][NFC][CallSite] Remove CallSite use

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78791/new/ https://reviews.llvm.org/D78791 ___

[Lldb-commits] [lldb] 5948daf - [lldb][NFC][CallSite] Remove CallSite use

Author: Mircea Trofin Date: 2020-04-23T22:24:23-07:00 New Revision: 5948dafc694b5f8cb239b65f33727263d1a0bef6 URL: https://github.com/llvm/llvm-project/commit/5948dafc694b5f8cb239b65f33727263d1a0bef6 DIFF: https://github.com/llvm/llvm-project/commit/5948dafc694b5f8cb239b65f33727263d1a0bef6.diff

[Lldb-commits] [PATCH] D78791: [lldb][NFC][CallSite] Remove CallSite use

mtrofin created this revision. mtrofin added reviewers: dblaikie, craig.topper. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78791 Files: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRunt

[Lldb-commits] [PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

This revision was automatically updated to reflect the committed changes. Closed by commit rGdef7c7f60205: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...) (authored by shafik). Herald added projects: clang, LLDB. Changed prior to commit: https://reviews.llvm.org/D7800

[Lldb-commits] [lldb] def7c7f - [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

Author: shafik Date: 2020-04-23T15:18:48-07:00 New Revision: def7c7f6020530ef2deb64f786d28775b5d0e47f URL: https://github.com/llvm/llvm-project/commit/def7c7f6020530ef2deb64f786d28775b5d0e47f DIFF: https://github.com/llvm/llvm-project/commit/def7c7f6020530ef2deb64f786d28775b5d0e47f.diff LOG: [

[Lldb-commits] [PATCH] D78588: [lldb/Core] Don't crash in GetSoftwareBreakpointTrapOpcode for unknown triples

JDevlieghere updated this revision to Diff 259728. JDevlieghere retitled this revision from "[lldb/Core] Check that ArchSpec is valid." to "[lldb/Core] Don't crash in GetSoftwareBreakpointTrapOpcode for unknown triples". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78588/new/ https://r

[Lldb-commits] [PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

shafik updated this revision to Diff 259703. shafik marked 2 inline comments as done. shafik added a comment. Capitalization fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78000/new/ https://reviews.llvm.org/D78000 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTI

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 259700. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files: lldb/bindings/python/python-typemaps.swig lldb/binding

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna added a comment. @omjavaid sorry I didn't catch that on pre-submit testing. `PyLong_AsLongLong` and friends do not automatically convert on python2 like they do on python3. It's fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 259659. lawrence_danna added a comment. fix python2 projblems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D78489: [lldb/DWARF] Trust CU DW_AT_low/high_pc information when building address tables

dblaikie added a comment. In D78489#1993806 , @clayborg wrote: > One thing to think about that my flawed example above did show: dead stripped > functions cause problems for debug info. Both in DW_AT_ranges on the compile > unit and in all of the DWARF b

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

mib updated this revision to Diff 259608. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78712/new/ https://reviews.llvm.org/D78712 Files: lldb/include/lldb/Host/FileSystem.h lldb/source/Commands/CommandObjectTarget.cpp lldb/source/Host/common/

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/source/Host/common/FileSystem.cpp:504 + FileSpec file(file_path.getSingleStringRef()); + return Readable(file_path) && Instance().Open(file, File::eOpenOptionRead); +} shafik wrot

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

mib updated this revision to Diff 259606. mib marked an inline comment as done. mib added a comment. Address Shafik's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78712/new/ https://reviews.llvm.org/D78712 Files: lldb/include/lldb/Host

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

shafik added inline comments. Comment at: lldb/source/Host/common/FileSystem.cpp:504 + FileSpec file(file_path.getSingleStringRef()); + return Readable(file_path) && Instance().Open(file, File::eOpenOptionRead); +} Since `file` is a `FileSpec` can't we just use

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

teemperor added a comment. LGTM now beside some minor request for the test. Thanks for the patch! Comment at: lldb/test/API/lang/cpp/typedef/TestCppTypedef.py:33 +expr_result = frame.EvaluateExpression("(SF)s") +self.assertTrue(expr_result.IsValid(), "Can't eval

[Lldb-commits] [PATCH] D77295: [lldb/Core] Fix a race in the Communication class

labath added a comment. Cool, I've also pushed 9321255b that fixes up other occurrences of this pattern, and adds an assertion to prevent it from happening again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [lldb] c2fec2f - [lldb] Make RNBSocketTest compile again after socket modernization

Author: Raphael Isemann Date: 2020-04-23T17:00:02+02:00 New Revision: c2fec2fb17787c14e7860a57ef4f03e085cd3a7b URL: https://github.com/llvm/llvm-project/commit/c2fec2fb17787c14e7860a57ef4f03e085cd3a7b DIFF: https://github.com/llvm/llvm-project/commit/c2fec2fb17787c14e7860a57ef4f03e085cd3a7b.dif

[Lldb-commits] [lldb] 9321255 - [lldb/Core] Avoid more Communication::Disconnect races

Author: Pavel Labath Date: 2020-04-23T16:36:21+02:00 New Revision: 9321255b8825d9165b2884204348a353af36d212 URL: https://github.com/llvm/llvm-project/commit/9321255b8825d9165b2884204348a353af36d212 DIFF: https://github.com/llvm/llvm-project/commit/9321255b8825d9165b2884204348a353af36d212.diff

[Lldb-commits] [PATCH] D78489: [lldb/DWARF] Trust CU DW_AT_low/high_pc information when building address tables

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cfa74fc6948: [lldb/DWARF] Trust CU DW_AT_low/high_pc information when building address tables (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

mib created this revision. mib added reviewers: JDevlieghere, labath. mib added a project: LLDB. Herald added subscribers: lldb-commits, emaste. mib marked an inline comment as done. mib added inline comments. mib edited the summary of this revision. Comment at: lldb/test/API/com

[Lldb-commits] [PATCH] D78489: [lldb/DWARF] Trust CU DW_AT_low/high_pc information when building address tables

labath added a comment. Thanks for the review. In D78489#1998060 , @clayborg wrote: > In D78489#1996834 , @labath wrote: > > > I've done a similar benchmark to the last one, but measured memory usage > > ("RssAnon

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/test/API/commands/target/basic/TestTargetCommand.py:343 +def test_target_create_unowned_core_file(self): +self.expect("target create -c ~root", error=True, +substrs=[

[Lldb-commits] [lldb] f512b97 - [lldb/Utility] Improve error_code->Status conversion

Author: Pavel Labath Date: 2020-04-23T16:12:41+02:00 New Revision: f512b978b0ebd09be08d879acb4feb7846370cd5 URL: https://github.com/llvm/llvm-project/commit/f512b978b0ebd09be08d879acb4feb7846370cd5 DIFF: https://github.com/llvm/llvm-project/commit/f512b978b0ebd09be08d879acb4feb7846370cd5.diff

[Lldb-commits] [lldb] 7cfa74f - [lldb/DWARF] Trust CU DW_AT_low/high_pc information when building address tables

Author: Pavel Labath Date: 2020-04-23T16:12:41+02:00 New Revision: 7cfa74fc6948cc1969244a4e800de6a728951897 URL: https://github.com/llvm/llvm-project/commit/7cfa74fc6948cc1969244a4e800de6a728951897 DIFF: https://github.com/llvm/llvm-project/commit/7cfa74fc6948cc1969244a4e800de6a728951897.diff

[Lldb-commits] [lldb] c9e6b70 - [lldb/Host] Modernize some socket functions

Author: Pavel Labath Date: 2020-04-23T14:20:26+02:00 New Revision: c9e6b7010c6998b6df50ff376425d1d4e4937bea URL: https://github.com/llvm/llvm-project/commit/c9e6b7010c6998b6df50ff376425d1d4e4937bea DIFF: https://github.com/llvm/llvm-project/commit/c9e6b7010c6998b6df50ff376425d1d4e4937bea.diff

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov updated this revision to Diff 259509. aleksandr.urakov added reviewers: labath, leonid.mashinskiy. aleksandr.urakov added a comment. Hello, Pavel! Thanks for the review. Yes, this method looks like a better fit, I just didn't notice it before. Repository: rG LLVM Github Monor

[Lldb-commits] [lldb] e327ea4 - [lldb] Fix typo in breakpoint set -r description

Author: Raphael Isemann Date: 2020-04-23T12:06:27+02:00 New Revision: e327ea4a82874f535b6ea93e39ea58643aef88bd URL: https://github.com/llvm/llvm-project/commit/e327ea4a82874f535b6ea93e39ea58643aef88bd DIFF: https://github.com/llvm/llvm-project/commit/e327ea4a82874f535b6ea93e39ea58643aef88bd.dif

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid added a comment. In D77043#1996983 , @labath wrote: > Where does the option which I proposed fit in? It sounds like it would be > something like 1a), where we don't actually modify the "invalidate" numbers > stored within lldb-server, but we jus

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

labath added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:540 +static QualType desugarType(QualType type) { + while (const clang::ElaboratedType *elaboratedType = The name of this function is fairly misleading as it onl

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: aprantl, teemperor. aleksandr.urakov added a project: LLDB. Herald added a subscriber: lldb-commits. Sometimes a result variable of some expression can be presented as an elaborated type. In this case the methods `IsTypedef