[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

emrekultursay added a comment. In D79757#2031186 , @labath wrote: > ... > Where do the addresses that we're connecting to come from (the user or lldb > code)? If it's lldb code, maybe we could just replace the relevant > "localhost" names with an explic

[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

emrekultursay updated this revision to Diff 263599. emrekultursay added a comment. Enforce IPv4 usage only in Android code, revert non-Android changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ https://reviews.llvm.org/D79757 Files:

[Lldb-commits] [lldb] 67087a7 - [LLDB] Fix typo in xfail decorator assert.test

Author: Muhammad Omair Javaid Date: 2020-05-13T08:53:56+05:00 New Revision: 67087a7b76599ea783c1d930f0c2047deaa8fbae URL: https://github.com/llvm/llvm-project/commit/67087a7b76599ea783c1d930f0c2047deaa8fbae DIFF: https://github.com/llvm/llvm-project/commit/67087a7b76599ea783c1d930f0c2047deaa8fb

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py:250-251 def cleanup(): -self.vscode.request_disconnect(terminateDebuggee=True) +if disco

[Lldb-commits] [lldb] 6805a77 - [LLDB] Mark some xfails for arm-linux

Author: Muhammad Omair Javaid Date: 2020-05-13T08:05:27+05:00 New Revision: 6805a77eb66e2e4c9f308bc49c77297f790a5e7b URL: https://github.com/llvm/llvm-project/commit/6805a77eb66e2e4c9f308bc49c77297f790a5e7b DIFF: https://github.com/llvm/llvm-project/commit/6805a77eb66e2e4c9f308bc49c77297f790a5e

[Lldb-commits] [lldb] 302c492 - [LLDB] Fix minidebuginfo-set-and-hit-breakpoint.test for arm 32-bit

Author: Muhammad Omair Javaid Date: 2020-05-13T07:17:40+05:00 New Revision: 302c492cc5d97cf10837e71e4ee5872c01bc3682 URL: https://github.com/llvm/llvm-project/commit/302c492cc5d97cf10837e71e4ee5872c01bc3682 DIFF: https://github.com/llvm/llvm-project/commit/302c492cc5d97cf10837e71e4ee5872c01bc36

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

labath added inline comments. Comment at: llvm/cmake/config-ix.cmake:514 + if(ZLIB_FOUND) +set(LLVM_ENABLE_ZLIB "YES" CACHE STRING + "Use zlib for compression/decompression if available. Can be ON, OFF, or FORCE_ON" JDevlieghere wrote: > phosek wrote:

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

xiaobai added a comment. In D79823#2032827 , @davide wrote: > I'm curious what happens if you end up here with something like `_T`. Did you > check? I assume you're talking about swift, which should be handled by a `SwiftLanguage` plugin. Can Objective

[Lldb-commits] [PATCH] D79777: Fix error in TestNumThreads.py when frame.GetFunctionName returns none

This revision was automatically updated to reflect the committed changes. Closed by commit rG0796b170fb3b: Fix error in TestNumThreads.py when frame.GetFunctionName returns none (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

davide added a comment. I'm curious what happens if you end up here with something like `_T`. Did you check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79823/new/ https://reviews.llvm.org/D79823 __

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Presumably. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79823/new/ https://reviews.llvm.org/D79823

[Lldb-commits] [lldb] 0796b17 - Fix error in TestNumThreads.py when frame.GetFunctionName returns none

Author: Muhammad Omair Javaid Date: 2020-05-13T05:13:46+05:00 New Revision: 0796b170fb3bf38e6cc4e59746120b37c9a9cd9f URL: https://github.com/llvm/llvm-project/commit/0796b170fb3bf38e6cc4e59746120b37c9a9cd9f DIFF: https://github.com/llvm/llvm-project/commit/0796b170fb3bf38e6cc4e59746120b37c9a9cd

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

clayborg added a comment. In D79614#2030692 , @jasonmolenda wrote: > Thanks for the feedback. > > In D79614#2029157 , @labath wrote: > > > I think that "piggy-backing" on the `qSupported` packet for communicating

[Lldb-commits] [PATCH] D79825: [lldb/Reproducers] Add test-specific API to set the test CWD

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, friss. The reproducers' working directory is set to the current working directory when they are initialized. While this is not optimal, as the cwd can change during a debug session, it has been sufficient so far.

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

xiaobai created this revision. xiaobai added reviewers: friss, JDevlieghere, shafik. Herald added a project: LLDB. Objective-C names are stored in m_demangled, not in m_mangled. The method in the condition will never return true. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D7

[Lldb-commits] [lldb] ab22f71 - [lldb/Reproducers] Also record directories FileSystem::Collect.

Author: Jonas Devlieghere Date: 2020-05-12T15:59:24-07:00 New Revision: ab22f71dd75895fbde1cd1a515b2164227d5dfd2 URL: https://github.com/llvm/llvm-project/commit/ab22f71dd75895fbde1cd1a515b2164227d5dfd2 DIFF: https://github.com/llvm/llvm-project/commit/ab22f71dd75895fbde1cd1a515b2164227d5dfd2.d

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

shafik created this revision. shafik added reviewers: clayborg, jingham, aprantl, teemperor. Herald added subscribers: kbarton, nemanjai. shafik planned changes to this revision. Herald added a subscriber: wuzish. shafik requested review of this revision. shafik retitled this revision from "Reenabl

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

shafik added a comment. I labeled this as WIP in progress since I expect some discussion and maybe a test case for which the change fails. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79811/new/ https://reviews.llvm.org/D79811 ___ lldb-co

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9166ad27284: [lldb/Driver] Support terminal resizing (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79654/new/ https://reviews.llvm.org

[Lldb-commits] [lldb] d9166ad - [lldb/Driver] Support terminal resizing

Author: Fred Riss Date: 2020-05-12T11:55:25-07:00 New Revision: d9166ad272847e246799afbb5e0c71874f83aa12 URL: https://github.com/llvm/llvm-project/commit/d9166ad272847e246799afbb5e0c71874f83aa12 DIFF: https://github.com/llvm/llvm-project/commit/d9166ad272847e246799afbb5e0c71874f83aa12.diff LOG

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py:250-251 def cleanup(): -self.vscode.request_disconnect(terminateDebuggee=True) +if disco

[Lldb-commits] [PATCH] D79789: [lldb] Don't dissasemble large functions by default

jingham added a comment. Instead of just printing out the range, can we print out the disassemble command you would run to actually disassemble the range? Also, I think we should add a --force option since if you were using this in a script you wouldn't get a chance to respond to the error. R

[Lldb-commits] [PATCH] D79646: [Reproducers] Serialize process arguments in ProcessInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGbad61548b207: [Reproducers] Serialize process arguments in ProcessInfo (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 updated this revision to Diff 263477. Geod24 added a comment. Merge whitespace-removing commit into the main one Since I can't seem to get arc to comply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79559/new/ https://reviews.llvm.org/D795

[Lldb-commits] [PATCH] D79789: [lldb] Don't dissasemble large functions by default

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: lldb/source/Commands/CommandObjectDisassemble.cpp:225 + Address::DumpStyleFileAddress); + msg << ". To disassemble, spe

[Lldb-commits] [lldb] bad6154 - [Reproducers] Serialize process arguments in ProcessInfo

Author: Jonas Devlieghere Date: 2020-05-12T11:12:37-07:00 New Revision: bad61548b2074cf3bf7be2cb4c0d75646e001a73 URL: https://github.com/llvm/llvm-project/commit/bad61548b2074cf3bf7be2cb4c0d75646e001a73 DIFF: https://github.com/llvm/llvm-project/commit/bad61548b2074cf3bf7be2cb4c0d75646e001a73.d

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py:250-251 def cleanup(): -self.vscode.request_disconnect(terminateDebuggee=True) +if disconnect: +self.vscode.req

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 updated this revision to Diff 263463. Geod24 added a comment. Add missing commit See previous diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79559/new/ https://reviews.llvm.org/D79559 Files: lldb/source/Plugins/TypeSystem/Clang/Type

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm marked 2 inline comments as done. aadsm added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py:250-251 def cleanup(): -self.vscode.request_disconnect(terminateDebuggee=True) +if disco

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 updated this revision to Diff 263462. Geod24 added a comment. Remove a trailing whitespace in TypeSystemClang.cpp The pre-merge checks are apparently failing, and from what I can gather from the logs, it seems to be because of a whitespace issue: [2020-05-12T16:19:00.309Z] + clang-tidy

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm added a comment. > I gotta say I don't understand the difference between "exit" and "terminate" > commands, as both seem to happen pretty at once. Is the difference that > "exit" commands are run only when the inferior exits freely on its own, and > not when we forcefully kill it? And tha

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

aganea reopened this revision. aganea added a comment. This revision is now accepted and ready to land. Could you please take another look? Thank you in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79447/new/ https://reviews.llvm.org/D794

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

aganea updated this revision to Diff 263450. aganea added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Reopening because I had to revert. - Fix lldb's variables.test - Fix type lowering, as described here: D79512 - Added asser

[Lldb-commits] [PATCH] D79789: [lldb] Don't dissasemble large functions by default

labath created this revision. labath added reviewers: JDevlieghere, jasonmolenda. Herald added a project: LLDB. If we have a binary without symbol information (and without LC_FUNCTION_STARTS, if on a mac), then we have to resort to using heuristics to determine the function boundaries. However, th

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 updated this revision to Diff 263442. Geod24 added a comment. Remove un-needed main & use x86_64-pc-gnu as target instead of host Since we're not running the program anymore, we no longer need a main. The comment, build step, and IR of the test were updated accordingly. Repository: rG

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks great now, just a small tweak to the test case. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_TAG_basic_type_DW_ATE_UTF_nonC.ll:19 +; +; RUN: %clang_host -g -o %t %s

[Lldb-commits] [PATCH] D79623: [LLDB] Add Linux SVE Ptrace macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d7f5ca0e385: Add Linux SVE Ptrace macros. (authored by kristof.beyls). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79623/new/ https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

labath added a comment. The invalidate_regs part looks as I would expect. I think it ought to be implemented a bit differently, but that can wait until the bigger issue is resolved. The bigger issue being the fact that this patch now renumbers all numbers going in/out of the stub (qRegisterInf

[Lldb-commits] [lldb] 5d7f5ca - Add Linux SVE Ptrace macros.

Author: Kristof Beyls Date: 2020-05-12T15:24:24+02:00 New Revision: 5d7f5ca0e385ebc05231997a66cdd5f18b9d2f72 URL: https://github.com/llvm/llvm-project/commit/5d7f5ca0e385ebc05231997a66cdd5f18b9d2f72 DIFF: https://github.com/llvm/llvm-project/commit/5d7f5ca0e385ebc05231997a66cdd5f18b9d2f72.diff

[Lldb-commits] [PATCH] D79777: Fix error in TestNumThreads.py when frame.GetFunctionName returns none

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. This patch fixes an error happening in TestNumThreads.py when it encounters frame.GetFunctionName none for address only locations in stripped libc. This error was showing up on arm-linux

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 updated this revision to Diff 263401. Geod24 added a comment. Changed the test from running to 'type lookup string' Due to bug https://bugs.llvm.org/show_bug.cgi?id=45856 the test was originally runnable, but a non-runnable alternative was suggested during review. Repository: rG LLVM

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

labath added a comment. (sorry about all the editing -- I'm trying to figure out the order of these patches) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

labath added a comment. Getaddrinfo documentation says: Normally, the application should try using the addresses in the order in which they are returned. The sorting function used within getaddrinfo() is defined in RFC 3484; the order can be tweaked for a particular system by e

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

labath added a comment. Yes, you're right that the current implementation of Editline::Interrupt is not correct. It's kind of my fault since I added that locking code (in my defense, the code was pretty messy to begin with). The implementation could indeed deadlock if the signal is delivered on

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

labath added a comment. I gotta say I don't understand the difference between "exit" and "terminate" commands, as both seem to happen pretty at once. Is the difference that "exit" commands are run only when the inferior exits freely on its own, and not when we forcefully kill it? And that "term