[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm updated this revision to Diff 264143. aadsm added a comment. Updated README.md, package.json to document the new option. Also refactored the test support a bit to allow easier testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79726/new/

[Lldb-commits] [lldb] bf02bcf - [lldb/Test] Modify more tests for API replay

Author: Jonas Devlieghere Date: 2020-05-14T17:58:27-07:00 New Revision: bf02bcffcfd7dc965e930c6a3035895823d2d78b URL: https://github.com/llvm/llvm-project/commit/bf02bcffcfd7dc965e930c6a3035895823d2d78b DIFF:

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

dblaikie added a comment. In D79811#2036112 , @labath wrote: > Here's another interesting use of aritificial functions: inherited > constructors. > > struct A { A(int); }; > struct B:A { using A::A; }; > B b(2); > > > The constructor B::B(int) will

[Lldb-commits] [lldb] 9fde516 - [lldb/Test] Replace assertTrue with more specific checks (NFC)

Author: Jonas Devlieghere Date: 2020-05-14T15:48:48-07:00 New Revision: 9fde516032d71c325f156cb4b878cf6b12280de8 URL: https://github.com/llvm/llvm-project/commit/9fde516032d71c325f156cb4b878cf6b12280de8 DIFF:

[Lldb-commits] [PATCH] D79789: [lldb] Don't dissasemble large functions by default

shafik added a comment. I reverted this it breaks `TestFoundationDisassembly.py`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79789/new/ https://reviews.llvm.org/D79789 ___ lldb-commits mailing list

Re: [Lldb-commits] [lldb] 1cbd1b8 - Revert "[lldb] Don't dissasemble large functions by default"

I’m pretty sure all you need to do is add a —force to the disassemble command in TestFoundationDisassembly.py. Jim > On May 14, 2020, at 2:16 PM, via lldb-commits > wrote: > > > Author: shafik > Date: 2020-05-14T14:15:51-07:00 > New Revision: 1cbd1b8f692df7742efb9114510688045d901f96 > >

[Lldb-commits] [lldb] 1cbd1b8 - Revert "[lldb] Don't dissasemble large functions by default"

Author: shafik Date: 2020-05-14T14:15:51-07:00 New Revision: 1cbd1b8f692df7742efb9114510688045d901f96 URL: https://github.com/llvm/llvm-project/commit/1cbd1b8f692df7742efb9114510688045d901f96 DIFF: https://github.com/llvm/llvm-project/commit/1cbd1b8f692df7742efb9114510688045d901f96.diff LOG:

[Lldb-commits] [PATCH] D79953: [lldb] Update stop info override callback comment.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5144e48c1497: [lldb] Update stop info override callback comment. (authored by rmansfield, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 5144e48 - [lldb] Update stop info override callback comment.

Author: Ryan Mansfield Date: 2020-05-14T13:08:56-07:00 New Revision: 5144e48c1497e154961f22a7ac1de36c0d3e3f5d URL: https://github.com/llvm/llvm-project/commit/5144e48c1497e154961f22a7ac1de36c0d3e3f5d DIFF:

[Lldb-commits] [lldb] 2d6f4fe - [lldb/Test] Skip test using files to synchronize.

Author: Jonas Devlieghere Date: 2020-05-14T13:08:56-07:00 New Revision: 2d6f4fec07292f1d2f77cbbf5188de3838a70b78 URL: https://github.com/llvm/llvm-project/commit/2d6f4fec07292f1d2f77cbbf5188de3838a70b78 DIFF:

[Lldb-commits] [PATCH] D79953: [lldb] Update stop info override callback comment.

rmansfield added a comment. Yes, if you can commit it I'd appreciate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79953/new/ https://reviews.llvm.org/D79953 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, modulo ifdef adjustment Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3125-3126 } else { // FIXME: Currently this only emits the global variables in the

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

clayborg added a comment. I really worry enabling this will make the expression parser start to emit errors if we change this. The best fix would be to ensure that the AST importer can correctly ignore implicit functions when comparing types. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D79953: [lldb] Update stop info override callback comment.

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79953/new/ https://reviews.llvm.org/D79953

[Lldb-commits] [PATCH] D79953: [lldb] Update stop info override callback comment.

JDevlieghere added a comment. Please let me know if you need me to commit this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79953/new/ https://reviews.llvm.org/D79953 ___ lldb-commits

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

clayborg added a comment. In D79757#2036618 , @aadsm wrote: > @clayborg the support we added was for the lldb-server. ok, phew! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/

[Lldb-commits] [PATCH] D79953: [lldb] Update stop info override callback comment.

rmansfield created this revision. rmansfield added a reviewer: LLDB. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In https://reviews.llvm.org/D31172 GetStopInfoOverrideCallback was moved and renamed. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

mib updated this revision to Diff 264038. mib edited the summary of this revision. mib added a comment. Instead of creating a new empty struct type, this new implementation will use the opaque pointer's pointee type to create the new `ValueObjectChild`. This makes the previously introduced

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

jingham added a comment. For expression evaluation in a REPL (which we only have for Swift, but if somebody wants to make such a thing for C++ we wouldn't be displeased) the model is compiling into a single translation unit. I think that's the only thing that makes sense. You don't want to

[Lldb-commits] [lldb] e29cae1 - [lldb/Test] Skip TestExpressionInSyscall with reproducers

Author: Jonas Devlieghere Date: 2020-05-14T10:38:56-07:00 New Revision: e29cae1e5340dc4c1c16c6c16af297bb69c3cef6 URL: https://github.com/llvm/llvm-project/commit/e29cae1e5340dc4c1c16c6c16af297bb69c3cef6 DIFF:

[Lldb-commits] [lldb] e7c91e3 - [lldb/Test] Skip remaining 'side_effect' tests with reproducers.

Author: Jonas Devlieghere Date: 2020-05-14T10:38:56-07:00 New Revision: e7c91e3124b66cb1454a45dfd75c0a350852d6a6 URL: https://github.com/llvm/llvm-project/commit/e7c91e3124b66cb1454a45dfd75c0a350852d6a6 DIFF:

[Lldb-commits] [PATCH] D79789: [lldb] Don't dissasemble large functions by default

shafik added a comment. Pavel, I think this broke the green dragon bots: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/18207/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79789/new/ https://reviews.llvm.org/D79789

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

aadsm added a comment. @clayborg the support we added was for the lldb-server. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ https://reviews.llvm.org/D79757 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 631048e - Moving executable module symbols parsing to target creation method.

Author: Levon Ter-Grigoryan Date: 2020-05-14T16:54:14+02:00 New Revision: 631048e8117864c09672e33eb7b6fcc4efe5f749 URL: https://github.com/llvm/llvm-project/commit/631048e8117864c09672e33eb7b6fcc4efe5f749 DIFF:

[Lldb-commits] [lldb] eb50b64 - [lldb/PDB] Make "native" pdb tests host-independent

Author: Pavel Labath Date: 2020-05-14T16:01:23+02:00 New Revision: eb50b643fe00171823e055f7801e6610ee7bdef7 URL: https://github.com/llvm/llvm-project/commit/eb50b643fe00171823e055f7801e6610ee7bdef7 DIFF: https://github.com/llvm/llvm-project/commit/eb50b643fe00171823e055f7801e6610ee7bdef7.diff

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

labath added a subscriber: dblaikie. labath added a comment. Here's another interesting use of aritificial functions: inherited constructors. struct A { A(int); }; struct B:A { using A::A; }; B b(2); The constructor B::B(int) will be marked artificial, but it is also not reconstructible

[Lldb-commits] [PATCH] D75607: [lldb] Use llvm::MC for register numbers in AArch64 ABIs

This revision was automatically updated to reflect the committed changes. Closed by commit rG638efe3929cd: [lldb] Use llvm::MC for register numbers in AArch64 ABIs (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75607/new/

[Lldb-commits] [lldb] dac6e9c - [lldb] Fix a "missing return" warning in XcodeSDK

Author: Pavel Labath Date: 2020-05-14T13:31:49+02:00 New Revision: dac6e9ca2190b7ece67ab7b62ea113d3ade5067a URL: https://github.com/llvm/llvm-project/commit/dac6e9ca2190b7ece67ab7b62ea113d3ade5067a DIFF: https://github.com/llvm/llvm-project/commit/dac6e9ca2190b7ece67ab7b62ea113d3ade5067a.diff

[Lldb-commits] [lldb] 638efe3 - [lldb] Use llvm::MC for register numbers in AArch64 ABIs

Author: Pavel Labath Date: 2020-05-14T13:31:48+02:00 New Revision: 638efe3929cd3f62590462434d6397c150ad78ed URL: https://github.com/llvm/llvm-project/commit/638efe3929cd3f62590462434d6397c150ad78ed DIFF: https://github.com/llvm/llvm-project/commit/638efe3929cd3f62590462434d6397c150ad78ed.diff

[Lldb-commits] [lldb] deea174 - [lldb/gdb-remote] Change default value of use-libraries-svr4 to true

Author: Pavel Labath Date: 2020-05-14T12:17:37+02:00 New Revision: deea174ee508c84652785e55f54c81fd1fba492c URL: https://github.com/llvm/llvm-project/commit/deea174ee508c84652785e55f54c81fd1fba492c DIFF: https://github.com/llvm/llvm-project/commit/deea174ee508c84652785e55f54c81fd1fba492c.diff

[Lldb-commits] [PATCH] D79789: [lldb] Don't dissasemble large functions by default

This revision was automatically updated to reflect the committed changes. Closed by commit rGf665e80c023e: [lldb] Dont dissasemble large functions by default (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79789/new/

[Lldb-commits] [lldb] 3a16829 - [lldb] Switch Section-dumping code to raw_ostream

Author: Pavel Labath Date: 2020-05-14T11:59:18+02:00 New Revision: 3a16829748a1ed208a37c719d3a3bcca50dcbd0f URL: https://github.com/llvm/llvm-project/commit/3a16829748a1ed208a37c719d3a3bcca50dcbd0f DIFF: https://github.com/llvm/llvm-project/commit/3a16829748a1ed208a37c719d3a3bcca50dcbd0f.diff

[Lldb-commits] [lldb] f665e80 - [lldb] Don't dissasemble large functions by default

Author: Pavel Labath Date: 2020-05-14T11:52:54+02:00 New Revision: f665e80c023ec52557f55d7eeaf34471e4c6fa0d URL: https://github.com/llvm/llvm-project/commit/f665e80c023ec52557f55d7eeaf34471e4c6fa0d DIFF: https://github.com/llvm/llvm-project/commit/f665e80c023ec52557f55d7eeaf34471e4c6fa0d.diff

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

labath added a comment. In D79811#2035631 , @clayborg wrote: > In D79811#2035078 , @shafik wrote: > > > In D79811#2034842 , @clayborg > > wrote: > > > > > The error where

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

labath added a comment. In D78972#2035420 , @compnerd wrote: > WeakODR requires that the symbol actually be discarded if not referenced. > This will preserve the symbol even if unreferenced will it not? One approach > might be to just create a

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid updated this revision to Diff 263937. omjavaid added a comment. This updated diff reduces impact of register numbering correction on LLGS code by removing UserRegIndexToRegInfosIndex out of the code and instead overriding GetRegisterInfoAtIndex in NativeRegisterContextLinux_arm64.

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 263934. omjavaid added a comment. New update contains minor update needed to accommodate SVE PTrace macros header from ARM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files:

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 263935. omjavaid added a comment. This new updated patch overrides GetRegisterInfoAtIndex in NativeRegisterContextLinux_arm64 to reduce the impacts of register numbering conversion on the generic LLGS code. CHANGES SINCE LAST ACTION