[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

jackoalan marked 4 inline comments as done. jackoalan added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7324-7331 + // If the variable is an enum type, take the underlying integer type as + // the type of the integer literal. + if (con

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

jackoalan updated this revision to Diff 272597. jackoalan added a comment. - Added a test for scoped enums (works as-is but still worth testing). - Less frivolous use of `auto` - Made the floating point vars constexpr to maintain validity in clang's internals. - AstRestoreTest CLASS tests run for

[Lldb-commits] [PATCH] D82273: [lldb/Lua] Use the debugger's output and error file for Lua's I/O library.

JDevlieghere updated this revision to Diff 272579. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82273/new/ https://reviews.llvm.org/D82273 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h lldb/source/Plugins/ScriptInterpreter

[Lldb-commits] [PATCH] D82273: [lldb/Lua] Use the debugger's output and error file for Lua's I/O library.

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:64 + + if (out) { +lua_pushstring(m_lua_state, "stdout"); labath wrote: > What should be the behavior if this is

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 updated this revision to Diff 272479. gedatsu217 added a comment. Change the name and return of the function( bool UseAutosuggestion() -> void SetShowAutosuggestion (bool) ) (ll. 1447 in Editline.cpp and ll.194 in Editline.h). int -> size_t (ll. 1009 in Editline.cpp). Fix for normal s

[Lldb-commits] [PATCH] D82272: [lldb/Lua] Recognize "quit" as a way to exit the interactive script interpreter.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1728dec255a5: [lldb/Lua] Recognize "quit" as a way to exit the script interpreter. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D82272: [lldb/Lua] Recognize "quit" as a way to exit the interactive script interpreter.

JDevlieghere added a comment. In D82272#2106402 , @labath wrote: > It seems reasonable. Btw, have you figured out how the embedded python does > it? -- I haven't been able to find the code for handling that. No, I couldn't find the code either. > The p

[Lldb-commits] [lldb] 1728dec - [lldb/Lua] Recognize "quit" as a way to exit the script interpreter.

Author: Jonas Devlieghere Date: 2020-06-22T09:27:12-07:00 New Revision: 1728dec255a5336303b301e26ec22eca2000b593 URL: https://github.com/llvm/llvm-project/commit/1728dec255a5336303b301e26ec22eca2000b593 DIFF: https://github.com/llvm/llvm-project/commit/1728dec255a5336303b301e26ec22eca2000b593.d

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. This is already looking quite reasonable, I think we're getting closer to something we can merge. In D81001#2096702 , @gedatsu217 wrote: > Implementation all ascii characters for TypedCharacter. > Making m_use_autosuggestion i

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

teemperor added a comment. The only remaining issue with the LLDB expression part is that now that `SetFloatingInitializerForVariable` is based on the D81471 version it no longer makes the member variable a `constexpr`. Int/Enum members with initialisers can ju

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

labath accepted this revision. labath added a comment. Yes, this looks better, though I am mildly worried about the use of timeouts. There probably isn't anything better we can do for the "launch" case, but we could definitely come up with something better for the "attach" case. I think we can

[Lldb-commits] [lldb] 7960837 - [lldb][NFC] Add more test for builtin formats

Author: Raphael Isemann Date: 2020-06-22T15:13:41+02:00 New Revision: 79608371f1fd7f5aa6f8c05d007845e2e1cb7841 URL: https://github.com/llvm/llvm-project/commit/79608371f1fd7f5aa6f8c05d007845e2e1cb7841 DIFF: https://github.com/llvm/llvm-project/commit/79608371f1fd7f5aa6f8c05d007845e2e1cb7841.dif

[Lldb-commits] [PATCH] D82297: [lldb] Replace StringConvert with llvm::to_integer when parsing integer values in CommandObjects

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: JDevlieghere, abidh. This replaces the current use of LLDB's own `StringConvert` with LLVM's `to_integer` which has a less error-prone API and doesn't use special 'error values' to designate parsing prob

[Lldb-commits] [PATCH] D82273: [lldb/Lua] Use the debugger's output and error file for Lua's I/O library.

labath added a comment. I have some questions (but no definitive answers) inline... Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:64 + + if (out) { +lua_pushstring(m_lua_state, "stdout"); What should be the behavior if this is null? Can it

[Lldb-commits] [PATCH] D82272: [lldb/Lua] Recognize "quit" as a way to exit the interactive script interpreter.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. It seems reasonable. Btw, have you figured out how the embedded python does it? -- I haven't been able to find the code for handling that. The python interpreter also intercepts `os.exit()` to

[Lldb-commits] [PATCH] D82155: [WIP][lldb/interpreter] Add ability to save lldb session to a file

labath added a comment. This seems like it could be useful in some circumstances, though for the use cases I am imagining (bug reporting) it would be easier to just copy-paste the terminal contents. As for the implementation, if the intention is for this to eventually capture all debugger outp

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

aleksandr.urakov added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7324-7331 + // If the variable is an enum type, take the underlying integer type as + // the type of the integer literal. + if (const EnumType *enum_type = llvm::dyn_ca

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

aleksandr.urakov added a comment. Hello! Thanks for the patch, generally it looks good to me, the only thing I worry about is scoped enums (please, see the comment below). Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7324-7331 + // If the variable is a