[Lldb-commits] [lldb] 1f780c9 - [LLDB] Disable flaky lldb-vscode tests on arm

Author: Muhammad Omair Javaid Date: 2020-07-08T07:07:10+05:00 New Revision: 1f780c997c3616465a4180ffb20a5db4ec9d7776 URL: https://github.com/llvm/llvm-project/commit/1f780c997c3616465a4180ffb20a5db4ec9d7776 DIFF:

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. F12311388: image.png Hi, so I think I got the fix working. Attached is a screenshot of the new output, with title "Build Command Stdout Ouput". Should I submit a new pull request for this? Also just wondering, it seems you guys have

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276294. aelitashen added a comment. Add Path Verification in Test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files:

[Lldb-commits] [PATCH] D83359: [SymbolFileDWARF] Lock the module when parsing call site info

vsk updated this revision to Diff 276280. vsk added a comment. Move locking up into lldb::Function, and leave a comment in SymbolFileDWARF explaining why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83359/new/ https://reviews.llvm.org/D83359

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just test for paths and this will be good to go! Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:35 +

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276274. aelitashen added a comment. Fix messy diff stack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files:

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Could you include some comparative data in the description/commit message demonstrating this generally ends up emitting all the same types for a clang build before/after (& explanations

[Lldb-commits] [PATCH] D83359: [SymbolFileDWARF] Lock the module when parsing call site info

vsk planned changes to this revision. vsk added a comment. Hm, this doesn't totally fix the race. If the mutex is contested, the Function instance may overwrite its m_call_edges vector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83359/new/

[Lldb-commits] [PATCH] D83359: [SymbolFileDWARF] Lock the module when parsing call site info

vsk created this revision. vsk added reviewers: jasonmolenda, friss, jingham. Herald added a subscriber: aprantl. Herald added a project: LLDB. DWARF-parsing methods in SymbolFileDWARF which update module state should take the module lock. Have ParseCallEdgesInFunction do this. This could

[Lldb-commits] [PATCH] D79147: [WIP] Merge -debug-info-kind=constructor into -debug-info-kind=limited

akhuang updated this revision to Diff 276252. akhuang added a comment. Herald added a subscriber: fedor.sergeev. Instead of merging =constructor and =limited, change the default to use =constructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

This revision was automatically updated to reflect the committed changes. davide marked an inline comment as done. Closed by commit rG5832473dcf4e: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed. (authored by davide). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

shafik updated this revision to Diff 276229. shafik marked 5 inline comments as done. shafik added a comment. - Removing spurious local variables in test - Simplifying the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 Files:

[Lldb-commits] [lldb] 4dba3f4 - [dotest] Log a warning when --server and --out-of-tree-debugserver are set

Author: Davide Italiano Date: 2020-07-07T15:03:08-07:00 New Revision: 4dba3f4e030a906f9ec7e940dfc4a57b94374154 URL: https://github.com/llvm/llvm-project/commit/4dba3f4e030a906f9ec7e940dfc4a57b94374154 DIFF:

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

This revision was automatically updated to reflect the committed changes. davide marked an inline comment as done. Closed by commit rG5832473dcf4e: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed. (authored by davide). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [lldb] 5832473 - Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

Author: Davide Italiano Date: 2020-07-07T15:01:21-07:00 New Revision: 5832473dcf4e5b22c9eb6381fb291be92f431208 URL: https://github.com/llvm/llvm-project/commit/5832473dcf4e5b22c9eb6381fb291be92f431208 DIFF:

[Lldb-commits] [PATCH] D83343: [lldb/api] Add checks for StackFrame::GetRegisterContext calls (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d7401cf9d5c: [lldb/api] Add checks for StackFrame::GetRegisterContext calls (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0d7401c - [lldb/api] Add checks for StackFrame::GetRegisterContext calls (NFC)

Author: Med Ismail Bennani Date: 2020-07-07T23:30:24+02:00 New Revision: 0d7401cf9d5cc0db3de9a8ddb8ea2362d5412d2f URL: https://github.com/llvm/llvm-project/commit/0d7401cf9d5cc0db3de9a8ddb8ea2362d5412d2f DIFF:

[Lldb-commits] [PATCH] D83343: [lldb/api] Add checks for StackFrame::GetRegisterContext calls (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A test would be great but since we can't repro this is strictly better than the current state. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D83343: [lldb/api] Add checks for StackFrame::GetRegisterContext calls (NFC)

mib updated this revision to Diff 276209. mib added a comment. Changed style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83343/new/ https://reviews.llvm.org/D83343 Files: lldb/source/API/SBFrame.cpp Index: lldb/source/API/SBFrame.cpp

[Lldb-commits] [PATCH] D77045: Minor fixups to LLDB AArch64 register infos macros for SVE register infos

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bf6c50c7fe2: Minor fixups to LLDB AArch64 register infos macros for SVE register infos (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D83343: [lldb/api] Add checks for StackFrame::GetRegisterContext calls (NFC)

mib created this revision. mib added reviewers: teemperor, JDevlieghere. mib added a project: LLDB. Herald added a subscriber: lldb-commits. This patch fixes a crash that is happening because of a null pointer dereference in SBFrame. StackFrame::GetRegisterContext says explicitly that you might

[Lldb-commits] [PATCH] D77045: Minor fixups to LLDB AArch64 register infos macros for SVE register infos

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bf6c50c7fe2: Minor fixups to LLDB AArch64 register infos macros for SVE register infos (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 2bf6c50 - Minor fixups to LLDB AArch64 register infos macros for SVE register infos

Author: Muhammad Omair Javaid Date: 2020-07-08T01:07:17+05:00 New Revision: 2bf6c50c7fe2a68b0cf61568bc31c9966bbf1c3e URL: https://github.com/llvm/llvm-project/commit/2bf6c50c7fe2a68b0cf61568bc31c9966bbf1c3e DIFF:

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So looks like you didn't use "git commit --amend -a" again here. These changes are incremental changes on your patch which hasn't been submitted yet? Comment

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276172. aelitashen added a comment. Add test for loading symbols, other module info and Add version to module info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

mib closed this revision. mib added a comment. Patch landed in 7177e63fb554 ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83327/new/ https://reviews.llvm.org/D83327

[Lldb-commits] [lldb] 7177e63 - [lldb/Core] Fix crash in ValueObject::CreateChildAtIndex

Author: Med Ismail Bennani Date: 2020-07-07T20:37:13+02:00 New Revision: 7177e63fb554cfac3c252327e344fb5a17d6bd65 URL: https://github.com/llvm/llvm-project/commit/7177e63fb554cfac3c252327e344fb5a17d6bd65 DIFF:

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

mib updated this revision to Diff 276157. mib added a comment. - Addressed Jim's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83327/new/ https://reviews.llvm.org/D83327 Files: lldb/source/Core/ValueObject.cpp

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Other than a quibble about using _sp suffix, this is fine. Comment at: lldb/source/Core/ValueObject.cpp:693 + if (!valobj && synthetic_array_member) { +if

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

mib added a comment. In D83327#2136863 , @davide wrote: > In D83327#2136842 , @jingham wrote: > > > In D83327#2136814 , @davide wrote: > > > > > Aside from cosmetics, I'm

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

mib updated this revision to Diff 276152. mib added a comment. - Addressed style comment. - Added a comment to give more context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83327/new/ https://reviews.llvm.org/D83327 Files:

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

davide added a comment. In D83327#2136842 , @jingham wrote: > In D83327#2136814 , @davide wrote: > > > Aside from cosmetics, I'm not entirely sure this is the correct fix. Why > > are we calling this code _at all_

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

JDevlieghere added a comment. It sounds like that would be worth adding as a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83327/new/ https://reviews.llvm.org/D83327 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

mib added a comment. In D83327#2136814 , @davide wrote: > Aside from cosmetics, I'm not entirely sure this is the correct fix. Why are > we calling this code _at all_ if the type is incomplete? The code is called because some incomplete types can

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

jingham added a comment. In D83327#2136814 , @davide wrote: > Aside from cosmetics, I'm not entirely sure this is the correct fix. Why are > we calling this code _at all_ if the type is incomplete? Doing so allows one to write a synthetic child

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

davide added a comment. Aside from cosmetics, I'm not entirely sure this is the correct fix. Why are we calling this code _at all_ if the type is incomplete? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83327/new/ https://reviews.llvm.org/D83327

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

JDevlieghere added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:691 + if (!valobj && synthetic_array_member) { +auto synth_valobj = GetSyntheticValue(); +if (!synth_valobj) Style-nit: I think few people love early returns a much as I

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

mib added a comment. @labath Thanks for reporting that crash. D83327 should fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79554/new/ https://reviews.llvm.org/D79554

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

mib created this revision. mib added reviewers: jingham, labath. mib added a project: LLDB. Herald added a subscriber: lldb-commits. The patch fixes a crash in ValueObject::CreateChildAtIndex caused by a null pointer dereferencing. This is a corner case that is happening when trying to

[Lldb-commits] [PATCH] D83256: [lldb] Fix unaligned load in DataExtractor

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5e9b16b67f5b: [lldb] Fix unaligned load in DataExtractor (authored by JDevlieghere). Herald added a project: LLDB.

[Lldb-commits] [lldb] 5e9b16b - [lldb] Fix unaligned load in DataExtractor

Author: Jonas Devlieghere Date: 2020-07-07T10:13:41-07:00 New Revision: 5e9b16b67f5b9543e8d22b5b0f22cc0980c310bd URL: https://github.com/llvm/llvm-project/commit/5e9b16b67f5b9543e8d22b5b0f22cc0980c310bd DIFF:

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Host/Editline.h:381 void *m_completion_callback_baton = nullptr; - + std::string m_current_autosuggestion = ""; + bool m_use_autosuggestion = false; Strings are empty by default, so you can

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

shafik added a comment. In D83008#2136303 , @teemperor wrote: > I think we are talking about different things. My question was why is this a > 'Shell' test (like, a test in the `Shell` directory that uses FileCheck) and > not a test in the `API`

[Lldb-commits] [PATCH] D83306: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)

jingham accepted this revision. jingham added a comment. This is fine. If there were a universal convention (e.g. : separated lists) for environment variables, it would be reasonable for "append" behavior to extend rather than replace extant variables, but in the absence of the universality

[Lldb-commits] [PATCH] D83256: [lldb] Fix unaligned load in DataExtractor

JDevlieghere updated this revision to Diff 276100. JDevlieghere marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83256/new/ https://reviews.llvm.org/D83256 Files: lldb/include/lldb/Utility/DataExtractor.h lldb/source/Utility/DataExtractor.cpp

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

labath added a comment. In D81697#2131004 , @bbli wrote: > > Ideally this error should include the actual command line > > So to clarify, you want to also print out the exact clang command/what flags > were passed to clang whenever compile errors happen?

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7fa7b81bcbd0: Combine multiple defs of arm64 register sets (authored by omjavaid). Herald added a project: LLDB. Changed

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

teemperor added a comment. I think we are talking about different things. My question was why is this a 'Shell' test (like, a test in the `Shell` directory that uses FileCheck) and not a test in the `API` directory (using Python). An 'API' test could use the proper expression testing tools.

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fa7b81bcbd0: Combine multiple defs of arm64 register sets (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 7fa7b81 - Combine multiple defs of arm64 register sets

Author: Muhammad Omair Javaid Date: 2020-07-07T20:25:02+05:00 New Revision: 7fa7b81bcbd040d036f9a4155486ccebc3c13be7 URL: https://github.com/llvm/llvm-project/commit/7fa7b81bcbd040d036f9a4155486ccebc3c13be7 DIFF:

[Lldb-commits] [PATCH] D83306: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83306/new/ https://reviews.llvm.org/D83306

[Lldb-commits] [lldb] 52495b9 - [lldb/Utility] Fix float->integral conversions in Scalar APInt getters

Author: Pavel Labath Date: 2020-07-07T16:59:06+02:00 New Revision: 52495b98eecefcbaea2e30edec6816e43653d175 URL: https://github.com/llvm/llvm-project/commit/52495b98eecefcbaea2e30edec6816e43653d175 DIFF: https://github.com/llvm/llvm-project/commit/52495b98eecefcbaea2e30edec6816e43653d175.diff

[Lldb-commits] [PATCH] D83306: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)

labath added a comment. this is the line that motivated this patch -- if one has a LD_LIBRARY_PATH environment variable already set (as I happen to do), then that line will not overwrite it

[Lldb-commits] [PATCH] D83306: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)

labath created this revision. labath added reviewers: clayborg, wallace, jingham. Herald added a project: LLDB. This function was documented to overwrite entries with D76111 , which was adding a couple of similar functions. However, this function (unlike the

[Lldb-commits] [lldb] 72ae700 - [lldb/test] Fix lldbutil.run_to_***_breakpoint for shared libraries

Author: Pavel Labath Date: 2020-07-07T16:07:35+02:00 New Revision: 72ae70032ca3fa3e3bd9a3524bf245d5978c0467 URL: https://github.com/llvm/llvm-project/commit/72ae70032ca3fa3e3bd9a3524bf245d5978c0467 DIFF: https://github.com/llvm/llvm-project/commit/72ae70032ca3fa3e3bd9a3524bf245d5978c0467.diff

[Lldb-commits] [PATCH] D83302: [lldb/DWARF] Don't treat class declarations with children as definitions

labath created this revision. labath added reviewers: clayborg, aprantl, JDevlieghere. Herald added a reviewer: shafik. Herald added a project: LLDB. This effectively reverts r188124, which added code to handle (DW_AT_)declarations of structures with some kinds of children as definitions. The

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

labath added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:690-694 + if (!valobj && synthetic_array_member) +valobj = GetSyntheticValue() + ->GetChildAtIndex(synthetic_index, synthetic_array_member) + .get(); +

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. ship it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80105/new/ https://reviews.llvm.org/D80105 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid updated this revision to Diff 276015. omjavaid added a comment. This revision fixed issues highlighted in last review. LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80105/new/ https://reviews.llvm.org/D80105 Files:

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid marked 3 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp:46 +: lldb_private::RegisterContext(thread, 0) { + m_register_info_up = std::move(register_info);

[Lldb-commits] [lldb] de0175d - [lldb] Make TestIOHandlerResizeNoEditline pass with Python 2

Author: Raphael Isemann Date: 2020-07-07T13:54:14+02:00 New Revision: de0175d04bc3679c7bd8dc64520e790bf38f30b0 URL: https://github.com/llvm/llvm-project/commit/de0175d04bc3679c7bd8dc64520e790bf38f30b0 DIFF:

[Lldb-commits] [lldb] 2cdf108 - [lldb/DWARF] Add a utility function for (forceful) completion of types

Author: Pavel Labath Date: 2020-07-07T11:37:55+02:00 New Revision: 2cdf108d329bda280948ad634aa0a070337a5f88 URL: https://github.com/llvm/llvm-project/commit/2cdf108d329bda280948ad634aa0a070337a5f88 DIFF: https://github.com/llvm/llvm-project/commit/2cdf108d329bda280948ad634aa0a070337a5f88.diff

[Lldb-commits] [PATCH] D83199: [lldb/DWARF] Add a utility function for (forceful) completion of types

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rG2cdf108d329b: [lldb/DWARF] Add a utility function for (forceful) completion of types (authored by labath). Changed prior to commit:

[Lldb-commits] [PATCH] D83199: [lldb/DWARF] Add a utility function for (forceful) completion of types

labath marked 3 inline comments as done. labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1339 + TypeSystemClang::CompleteTagDeclarationDefinition(type); + const auto *td =

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

labath marked an inline comment as done. labath added a comment. This looks great. I just have a quick question about the GPR vs GPRegSet thingy... Comment at: lldb/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp:167 assert(target_arch.GetTriple().getOS() ==

[Lldb-commits] [PATCH] D83256: [lldb] Fix unaligned load in DataExtractor

labath added a comment. The approach is right, but can be simplified. I'd also remove the sizeof checks in the tests. We have a lot of code depending on the fact that floats and doubles are consistent across targets (e.g. the swapByteOrder function I mention). If that ever becomes untrue it

[Lldb-commits] [PATCH] D83256: [lldb] Fix unaligned load in DataExtractor

JDevlieghere updated this revision to Diff 275915. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83256/new/ https://reviews.llvm.org/D83256 Files: lldb/include/lldb/Utility/DataExtractor.h lldb/source/Utility/DataExtractor.cpp lldb/unittests/Utility/DataExtractorTest.cpp Index:

[Lldb-commits] [PATCH] D83256: [lldb] Fix unaligned load in DataExtractor

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. sizeof(double) instead of sizeof(float) for the double tests. Comment at: lldb/unittests/Utility/DataExtractorTest.cpp:358 +TEST(DataExtractorTest, GetDouble)