[Lldb-commits] [lldb] 8ee2257 - [lldb/Test] Fix missing yaml2obj in Xcode standalone build.

Author: Jonas Devlieghere Date: 2020-07-10T21:34:56-07:00 New Revision: 8ee225744f109b19e7d2412cbc50d4586991d8cf URL: https://github.com/llvm/llvm-project/commit/8ee225744f109b19e7d2412cbc50d4586991d8cf DIFF:

[Lldb-commits] [PATCH] D83600: Add a decorator to skip tests when running under Rosetta

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Good, one minor suggestion. Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:560 +return False +return platform.uname()[5] == "arm" and

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk

[Lldb-commits] [PATCH] D83600: Add a decorator to skip tests when running under Rosetta

aprantl created this revision. aprantl added reviewers: davide, friss. This allows skipping a test when running the testsuite on macOS under the Rosetta translation layer. https://reviews.llvm.org/D83600 Files: lldb/packages/Python/lldbsuite/test/decorators.py Index:

[Lldb-commits] [PATCH] D83582: Fix nesting of #ifdef

This revision was automatically updated to reflect the committed changes. Closed by commit rG851cc2f8f60a: Fix nesting of #ifdef (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83582/new/

[Lldb-commits] [lldb] 851cc2f - Fix nesting of #ifdef

Author: Adrian Prantl Date: 2020-07-10T17:13:46-07:00 New Revision: 851cc2f8f60ad86a8af4f57d23df0c930efdc4da URL: https://github.com/llvm/llvm-project/commit/851cc2f8f60ad86a8af4f57d23df0c930efdc4da DIFF: https://github.com/llvm/llvm-project/commit/851cc2f8f60ad86a8af4f57d23df0c930efdc4da.diff

[Lldb-commits] [lldb] c60216d - Revert "[lldb-vscode] Fix TestVSCode_module"

Author: Walter Erquinigo Date: 2020-07-10T17:07:07-07:00 New Revision: c60216db15132401ff60c08ccef899321f63b6b6 URL: https://github.com/llvm/llvm-project/commit/c60216db15132401ff60c08ccef899321f63b6b6 DIFF:

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7f80159753b: [lldb-vscode] Add Support for Module Event (authored by aelitashen, committed by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D83072: [lldb-vscode] Add Compile Unit List to Modules View

This revision was automatically updated to reflect the committed changes. Closed by commit rG03ef61033ff5: [lldb-vscode] Add Compile Unit List to Modules View (authored by aelitashen, committed by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] f7f8015 - [lldb-vscode] Add Support for Module Event

Author: Yifan Shen Date: 2020-07-10T16:50:59-07:00 New Revision: f7f80159753ba725f7e32529fcc369bc358efbb3 URL: https://github.com/llvm/llvm-project/commit/f7f80159753ba725f7e32529fcc369bc358efbb3 DIFF: https://github.com/llvm/llvm-project/commit/f7f80159753ba725f7e32529fcc369bc358efbb3.diff

[Lldb-commits] [lldb] 881af6e - [lldb-vscode] Fix TestVSCode_module

Author: Walter Erquinigo Date: 2020-07-10T16:50:59-07:00 New Revision: 881af6eb0030986876d3b80668193e5c3c04a87c URL: https://github.com/llvm/llvm-project/commit/881af6eb0030986876d3b80668193e5c3c04a87c DIFF:

[Lldb-commits] [lldb] 03ef610 - [lldb-vscode] Add Compile Unit List to Modules View

Author: Yifan Shen Date: 2020-07-10T16:50:59-07:00 New Revision: 03ef61033ff5e1e40518f14f642e4ad8d686974c URL: https://github.com/llvm/llvm-project/commit/03ef61033ff5e1e40518f14f642e4ad8d686974c DIFF: https://github.com/llvm/llvm-project/commit/03ef61033ff5e1e40518f14f642e4ad8d686974c.diff

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

akhuang updated this revision to Diff 276778. akhuang added a comment. fix one more test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79147/new/ https://reviews.llvm.org/D79147 Files: clang/lib/Driver/ToolChains/Clang.cpp

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

This revision was automatically updated to reflect the committed changes. Closed by commit rG227db86a1b7d: Switch to using -debug-info-kind=constructor as default (from =limited) (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

michele.scandale added a comment. In D83454#2144386 , @JDevlieghere wrote: > In D83454#2142719 , > @michele.scandale wrote: > > > I tested locally the standalone build of Clang with D83426 > >

[Lldb-commits] [lldb] 169c832 - [ldb/Reproducers] Add YamlRecorder and MultiProvider

Author: Jonas Devlieghere Date: 2020-07-10T12:48:22-07:00 New Revision: 169c83208f37f8e5539b1386030d9f3e4b15f16a URL: https://github.com/llvm/llvm-project/commit/169c83208f37f8e5539b1386030d9f3e4b15f16a DIFF:

[Lldb-commits] [PATCH] D83441: [ldb/Reproducers] Add YamlRecorder and MultiProvider

This revision was automatically updated to reflect the committed changes. JDevlieghere marked 5 inline comments as done. Closed by commit rG169c83208f37: [ldb/Reproducers] Add YamlRecorder and MultiProvider (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D83582: Fix nesting of #ifdef

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83582/new/ https://reviews.llvm.org/D83582 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D83545: [lldb/dotest] Remove the "xunit" result formatter

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Yup, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83545/new/ https://reviews.llvm.org/D83545

[Lldb-commits] [PATCH] D83582: Fix nesting of #ifdef

aprantl updated this revision to Diff 277122. aprantl added a comment. Also move comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83582/new/ https://reviews.llvm.org/D83582 Files: lldb/tools/debugserver/source/MacOSX/MachProcess.mm Index:

[Lldb-commits] [PATCH] D83582: Fix nesting of #ifdef

aprantl created this revision. aprantl added a reviewer: friss. Herald added a subscriber: kristof.beyls. This fixes a compile error when building for an arm64 host. https://reviews.llvm.org/D83582 Files: lldb/tools/debugserver/source/MacOSX/MachProcess.mm Index:

[Lldb-commits] [lldb] ecfa01e - [lldb] on s390x fix override issue

Author: Konrad Kleine Date: 2020-07-10T15:11:49-04:00 New Revision: ecfa01e956a49ed349683f1cfcfbbec423114b68 URL: https://github.com/llvm/llvm-project/commit/ecfa01e956a49ed349683f1cfcfbbec423114b68 DIFF: https://github.com/llvm/llvm-project/commit/ecfa01e956a49ed349683f1cfcfbbec423114b68.diff

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

This revision was automatically updated to reflect the committed changes. Closed by commit rGecfa01e956a4: [lldb] on s390x fix override issue (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83580/new/

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

kwk added a comment. In D83580#2144871 , @serge-sans-paille wrote: > Possible followup: shouldn't all the other `Get*` be flagged as `const` too? Thank you @serge-sans-paille . You're right but I'm unsure if all getters are actually const or not. And

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

serge-sans-paille added a comment. Possible followup: shouldn't all the other `Get*` be flagged as `const` too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83580/new/ https://reviews.llvm.org/D83580

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Looks obviously good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83580/new/ https://reviews.llvm.org/D83580

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes an override issue by marking a function as const so that the signature maps to the signature of the function in the base class. This is the original error: In file included from

[Lldb-commits] [PATCH] D83450: Delegate UpdateChildrenPointerType to the Root ValueObject

This revision was automatically updated to reflect the committed changes. Closed by commit rGe337350be9d6: This is a refinement on 96601ec28b7efe5abf3479a1aa91bcedb235bbbd. The intent of… (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e337350 - This is a refinement on 96601ec28b7efe5abf3479a1aa91bcedb235bbbd. The intent of that change was to do the same work for the computation of the locations of the children

Author: Jim Ingham Date: 2020-07-10T11:11:59-07:00 New Revision: e337350be9d6efd72027c331f95ef33df61fdc43 URL: https://github.com/llvm/llvm-project/commit/e337350be9d6efd72027c331f95ef33df61fdc43 DIFF: https://github.com/llvm/llvm-project/commit/e337350be9d6efd72027c331f95ef33df61fdc43.diff

[Lldb-commits] [PATCH] D83450: Delegate UpdateChildrenPointerType to the Root ValueObject

jingham added a comment. In D83450#2143631 , @labath wrote: > Right. It does bug me a little that this has no test, but I don't think it's > the worst that could happen. And you're the one who's going to have to debug > this all over again if the next

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

JDevlieghere added a comment. In D83454#2142719 , @michele.scandale wrote: > I tested locally the standalone build of Clang with D83426 > . > I just want to make sure that we all agree this is right way moving forward.

[Lldb-commits] [PATCH] D83446: [WIP][lldb/Reproducers] Synchronize the command interpreter with asynchronous events

jingham added a comment. In D83446#2143464 , @labath wrote: > In D83446#2142564 , @JDevlieghere > wrote: > > > Seems like my thoughts got lost a bit with all the inline replies: we can > > solve this particular

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

teemperor added a comment. (Also the commit description should be updated again). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83433/new/ https://reviews.llvm.org/D83433 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

teemperor added a comment. So for the test case that this fixes I get: x i 8 f1 b15 12 (DWARF 0x0) f2 b4 13 (DWARF 0x7) f3 b4 14 (DWARF 0x3) For the 2/4/4 bitfield case I get: x i 8 f1 b2 12 (DWARF 0x0) f2 b4 12 (DWARF 0x2) f3 b4 12 (DWARF 0x6) Anyway, Adrian's and Jim's point

[Lldb-commits] [PATCH] D83306: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)

labath added a comment. Thanks. It was fairly easy to reproduce the problem. I have a proposed fix in D83552 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83306/new/ https://reviews.llvm.org/D83306

[Lldb-commits] [PATCH] D83552: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH

labath created this revision. labath added reviewers: davide, jingham. Herald added a project: LLDB. registerSharedLibrariesWithTarget was setting the library path environment variable to the process build directory, but the function is also accepting libraries in other directories (in which case

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

labath added a comment. PS: Don't worry about the harbormaster failures too much. It's very picky these days... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83425/new/ https://reviews.llvm.org/D83425

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test_event/build_exception.py:8 self.build_error = called_process_error.lldb_extensions.get( -"stderr_content", "") +"stderr_content", "").decode("utf-8") +

[Lldb-commits] [PATCH] D83545: [lldb/dotest] Remove the "xunit" result formatter

labath created this revision. labath added a reviewer: JDevlieghere. Herald added a project: LLDB. My understanding is that this was added to make dotest interact well with the GreenDragon bots, back when dotest was the main test driver. Now that everything goes through lit (which has its own

[Lldb-commits] [PATCH] D83441: [ldb/Reproducers] Add YamlRecorder and MultiProvider

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This seems fine. A bit more doxygen wouldn't hurt... Comment at: lldb/source/Utility/Reproducer.cpp:10 #include "lldb/Utility/Reproducer.h" +#include "lldb/Utility/Event.h"

[Lldb-commits] [PATCH] D83450: Delegate UpdateChildrenPointerType to the Root ValueObject

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Right. It does bug me a little that this has no test, but I don't think it's the worst that could happen. And you're the one who's going to have to debug this all over again if the next value

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

labath added a comment. I like this. The coff thingy is unfortunate, but it's not a hard limitation. It's just that nobody cared about making this work from memory (until now), and (re)loading the file from disk was the easiest solution. If my d372a8e8

[Lldb-commits] [lldb] d372a8e - [lldb/pecoff] Use a different llvm createBinary overload for parsing

Author: Pavel Labath Date: 2020-07-10T11:57:11+02:00 New Revision: d372a8e8bce266bb4043e6a0bfd76c7e5bf457a5 URL: https://github.com/llvm/llvm-project/commit/d372a8e8bce266bb4043e6a0bfd76c7e5bf457a5 DIFF: https://github.com/llvm/llvm-project/commit/d372a8e8bce266bb4043e6a0bfd76c7e5bf457a5.diff

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 276964. omjavaid added a comment. This update incorporates suggestion from last iteration and also rebases after merger of register sets and register infos in RegisterInfosPOSIX_arm64. Also I have posted a separate patch D83541

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 276963. omjavaid added a comment. This update incorporates suggestion from last iteration and also rebases after merger to registersets and register infos in RegisterInfosPOSIX_arm64. Also I have posted a separate patch D83541

[Lldb-commits] [PATCH] D83541: Remove Linux sysroot dependencies of SVE PT macros

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: kristof.beyls, tschuett. Herald added a reviewer: rengolin. SVE elf note data requires SVE PT macros for reading writing data. Same macros are used by Linux ptrace SVE register access. This patch makes

[Lldb-commits] [PATCH] D83446: [WIP][lldb/Reproducers] Synchronize the command interpreter with asynchronous events

labath added a comment. In D83446#2142564 , @JDevlieghere wrote: > Seems like my thoughts got lost a bit with all the inline replies: we can > solve this particular issue by making `process connect` block in synchronous > mode. The fact that that's not

[Lldb-commits] [lldb] a65da5f - [LLDB] Update AArch64 Dwarf and EH frame register numbers

Author: Muhammad Omair Javaid Date: 2020-07-10T11:45:39+05:00 New Revision: a65da5f5924fbb7bad28bbb397e3e9a94959df4c URL: https://github.com/llvm/llvm-project/commit/a65da5f5924fbb7bad28bbb397e3e9a94959df4c DIFF: