[Lldb-commits] [PATCH] D83772: [Windows] Fix limit on command line size

This revision was automatically updated to reflect the committed changes. Closed by commit rGdab898f9ab62: [Windows] Fix limit on command line size (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/

[Lldb-commits] [lldb] dab898f - [Windows] Fix limit on command line size

Author: Serge Pavlov Date: 2020-07-23T11:39:42+07:00 New Revision: dab898f9ab62275f55eb2a7e76ea0cd01696f68e URL: https://github.com/llvm/llvm-project/commit/dab898f9ab62275f55eb2a7e76ea0cd01696f68e DIFF: https://github.com/llvm/llvm-project/commit/dab898f9ab62275f55eb2a7e76ea0cd01696f68e.diff

[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

shafik added a comment. In D84272#2168172 , @davide wrote: > why? Do you have a testcase? There are already tests but we have a crash report w/o a reproducer, these are obviously correct checks. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h:22 +#define INCLUDE_LINUX_PTRACE_DEFINITIONS_FOR_SVE_ARM64 +#include

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing added inline comments. Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml:743 +# RUN: llvm-readelf --hex-dump=.debug_info %t13.o | \ +# RUN: FileCheck %s --check-prefix=LENGTH + jhenderson wrote: > Should this be INFER-LENGTH? (The test

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing updated this revision to Diff 280020. Higuoxing marked 3 inline comments as done. Higuoxing added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84008/new/ https://reviews.llvm.org/D84008 Files:

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid marked 3 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:240 + // Update SVE registers in case there is change in configuration. + ConfigureRegisterContext(); +

[Lldb-commits] [lldb] 77e0e9e - Reapply "Try enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories."

Author: Logan Smith Date: 2020-07-22T17:50:19-07:00 New Revision: 77e0e9e17daf0865620abcd41f692ab0642367c4 URL: https://github.com/llvm/llvm-project/commit/77e0e9e17daf0865620abcd41f692ab0642367c4 DIFF: https://github.com/llvm/llvm-project/commit/77e0e9e17daf0865620abcd41f692ab0642367c4.diff

[Lldb-commits] [lldb] 8acaceb - [lldb] Fix LLDB_DEFAULT_TEST_ARCH for standalone builds

Author: Jonas Devlieghere Date: 2020-07-22T17:04:42-07:00 New Revision: 8acaceb14c6c6f91996beb27742119844c04292f URL: https://github.com/llvm/llvm-project/commit/8acaceb14c6c6f91996beb27742119844c04292f DIFF:

[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. why? Do you have a testcase? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84272/new/ https://reviews.llvm.org/D84272 ___

[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

shafik updated this revision to Diff 279965. shafik added a comment. Removing `text->GetValueAsUnsigned(0) == 0` check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84272/new/ https://reviews.llvm.org/D84272 Files: lldb/source/Plugins/Language/ObjC/Cocoa.cpp Index:

[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

shafik added a comment. I was testing out how `NSStringSummaryProvider` deals w/ `NULL` using `NSString *foo = nullptr` and we filter out `NULL` values in `ValueObjectPrinter::GetValueSummaryError(...)` : if (IsNil()) summary.assign("nil"); That should mean that the

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Looks like there is an indentation issue in the test. See inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:55-61 +

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

jingham added inline comments. Comment at: lldb/source/Breakpoint/BreakpointLocation.cpp:73 + if (m_bp_site_sp) +return m_bp_site_sp->IsHardware(); + tatyana-krasnukha wrote: > JDevlieghere wrote: > > Should we sanity check that this is true when

[Lldb-commits] [lldb] 388c9fb - Try enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories.

Author: Logan Smith Date: 2020-07-22T14:19:34-07:00 New Revision: 388c9fb1af48b059d8b65cb2e002e0992d147aa5 URL: https://github.com/llvm/llvm-project/commit/388c9fb1af48b059d8b65cb2e002e0992d147aa5 DIFF: https://github.com/llvm/llvm-project/commit/388c9fb1af48b059d8b65cb2e002e0992d147aa5.diff

[Lldb-commits] [lldb] 0d5fc82 - [lldb] Eliminate unneeded value parameters in Utility (NFC)

Author: Jonas Devlieghere Date: 2020-07-22T13:56:23-07:00 New Revision: 0d5fc82245352eb6ed4cf11d85a508a8a03e23bb URL: https://github.com/llvm/llvm-project/commit/0d5fc82245352eb6ed4cf11d85a508a8a03e23bb DIFF:

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279936. aelitashen added a comment. Fix the accidentally removed test contents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[Lldb-commits] [lldb] fdb45f5 - lldb fix for b198de67e0bab462217db50814b1434796fa7caf (PCH/modular codegen refactor)

Author: David Blaikie Date: 2020-07-22T13:12:00-07:00 New Revision: fdb45f54b6c0de00ba3bfa5dd157161ebb12799d URL: https://github.com/llvm/llvm-project/commit/fdb45f54b6c0de00ba3bfa5dd157161ebb12799d DIFF: https://github.com/llvm/llvm-project/commit/fdb45f54b6c0de00ba3bfa5dd157161ebb12799d.diff

[Lldb-commits] [PATCH] D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

davide added a comment. yeah, I think it's reasonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84263/new/ https://reviews.llvm.org/D84263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D84307: [lldb/interpreter] Move the history subcommand to session (NFCI)

jingham added a comment. The current lldb behavior is that when you start up lldb, it reads the editline command-history file (so the history of the previous session), and loads it into it's internal command history, which you can get to by up and down arrows or ^R searches. But it doesn't

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 updated this revision to Diff 279906. gedatsu217 added a comment. Add the test content. Change return from void to llvm::Optional in several functions to make the code cleaner. Revise the details. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/

[Lldb-commits] [lldb] d2ec918 - [lldb] Use std::make_unique (NFC)

Author: Jonas Devlieghere Date: 2020-07-22T11:32:48-07:00 New Revision: d2ec91845c6711a2ea57ce2b0012f960f0e119f0 URL: https://github.com/llvm/llvm-project/commit/d2ec91845c6711a2ea57ce2b0012f960f0e119f0 DIFF:

[Lldb-commits] [PATCH] D83772: [Windows] Fix limit on command line size

max-kudr accepted this revision. max-kudr added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llvm.org/D83772 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 3eec657 - Revert "Enable -Wsuggest-override in the LLVM build" and the follow-ups.

Author: Hans Wennborg Date: 2020-07-22T20:23:58+02:00 New Revision: 3eec65782575a1284391e447142fd004dd5de4a9 URL: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9 DIFF: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9.diff

[Lldb-commits] [lldb] 6dbd477 - Fix Windows build

Author: Adrian Prantl Date: 2020-07-22T11:01:25-07:00 New Revision: 6dbd4775bf7ab92befb6d359d3bdf82fee285462 URL: https://github.com/llvm/llvm-project/commit/6dbd4775bf7ab92befb6d359d3bdf82fee285462 DIFF: https://github.com/llvm/llvm-project/commit/6dbd4775bf7ab92befb6d359d3bdf82fee285462.diff

[Lldb-commits] [PATCH] D84336: [lldb] Cleanup CommandObject registration (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2419ded61d97: [lldb] Cleanup CommandObject registration (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D84336?vs=279849=279860#toc

[Lldb-commits] [lldb] 2419ded - [lldb] Cleanup CommandObject registration (NFC)

Author: Jonas Devlieghere Date: 2020-07-22T09:52:20-07:00 New Revision: 2419ded61d977c043be945f004e6324812a5a3e2 URL: https://github.com/llvm/llvm-project/commit/2419ded61d977c043be945f004e6324812a5a3e2 DIFF:

[Lldb-commits] [PATCH] D84336: [lldb] Cleanup CommandObject registration (NFC)

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. I find the macro cleaner than my changes in D84305 . LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84336/new/

[Lldb-commits] [PATCH] D84305: [lldb/interpreter] Update CommandObject instanciation to use make_shared (NFC)

JDevlieghere added a comment. Oops, I was still going through my e-mails and didn't see this. Damnit, I could've just suggested the macro here ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84305/new/ https://reviews.llvm.org/D84305

[Lldb-commits] [PATCH] D84305: [lldb/interpreter] Update CommandObject instanciation to use make_shared (NFC)

mib abandoned this revision. mib added a comment. Abandoning this revision in favour of D84336 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84305/new/ https://reviews.llvm.org/D84305

[Lldb-commits] [PATCH] D82155: [lldb/interpreter] Add ability to save lldb session to a file

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:506-519 m_command_dict["register"] = CommandObjectSP(new CommandObjectRegister(*this)); m_command_dict["reproducer"] = CommandObjectSP(new

[Lldb-commits] [PATCH] D84336: [lldb] Cleanup CommandObject registration (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, mib. - Remove the spurious argument to `CommandObjectScript` - Use make_shared instead of bare `new`. - Hide code duplication behind a macro. Repository: rLLDB LLDB https://reviews.llvm.org/D84336 Files:

[Lldb-commits] [lldb] 02f5837 - Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

Author: Adrian Prantl Date: 2020-07-22T08:56:29-07:00 New Revision: 02f58373634fb87c728eb289a35b0819d7aafeee URL: https://github.com/llvm/llvm-project/commit/02f58373634fb87c728eb289a35b0819d7aafeee DIFF: https://github.com/llvm/llvm-project/commit/02f58373634fb87c728eb289a35b0819d7aafeee.diff

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

This revision was automatically updated to reflect the committed changes. aprantl marked an inline comment as done. Closed by commit rG02f58373634f: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish) (authored by aprantl). Changed prior to commit:

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. In D81001#2162743 , @gedatsu217 wrote: > In addition to it, I tried the below code, but it did not go well. ("\x1b[nD" > moves the cursor n steps to the left.) > > self.child.send("hel") > self.child.expect_exact(faint_color +

[Lldb-commits] [PATCH] D84307: [lldb/interpreter] Move the history subcommand to session (NFCI)

teemperor added a subscriber: jingham. teemperor added a comment. Isn't `session` just concerned with the *current* LLDB session? LLDB's command history is only spanning the current session at the moment, but I always thought that's more of a bug and not a feature (In fact one of my GSoC

[Lldb-commits] [PATCH] D84307: [lldb/interpreter] Move the history subcommand to session (NFCI)

teemperor added a reviewer: jingham. teemperor removed a subscriber: jingham. teemperor added a comment. (Phab send the whole thing when I pressed enter) I added Jim who might have more insights on the design rationale here, but IMHO this seems like an improvement. Repository: rG LLVM

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9d5a3058fcd: [lldb] add printing of stdout compile errors to lldbsuite (authored by bbli, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c9d5a30 - [lldb] add printing of stdout compile errors to lldbsuite

Author: Benson Li Date: 2020-07-22T16:38:20+02:00 New Revision: c9d5a3058fcde50c2fe40a5eaaa939d0995d3cd2 URL: https://github.com/llvm/llvm-project/commit/c9d5a3058fcde50c2fe40a5eaaa939d0995d3cd2 DIFF: https://github.com/llvm/llvm-project/commit/c9d5a3058fcde50c2fe40a5eaaa939d0995d3cd2.diff

[Lldb-commits] [Differential] D83425: [lldb] add printing of stdout compile errors to lldbsuite

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc9d5a3058fcd: [lldb] add printing of stdout compile errors to lldbsuite (authored by bbli, committed by labath). Changed

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

jhenderson added inline comments. Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml:743 +# RUN: llvm-readelf --hex-dump=.debug_info %t13.o | \ +# RUN: FileCheck %s --check-prefix=LENGTH + Should this be INFER-LENGTH? (The test is currently

[Lldb-commits] [PATCH] D84307: [lldb/interpreter] Move the history subcommand to session (NFCI)

labath added a comment. I don't have any strong opinions about this either way. The `history` alias is kind of nice because it matches the bash builtin, but I don't use either of them often enough to care. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84311: [lldb/test] Put hardware breakpoint tests together, NFC

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, labath. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. Create a common base class for them to re-use supports_hw_breakpoints function in decorators. This is a preparatory

[Lldb-commits] [PATCH] D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory

tatyana-krasnukha updated this revision to Diff 279777. tatyana-krasnukha added a comment. `BreakpointSite::IntersectsRange` returns `false` for hardware breakpoints, that's why the assertion fails. Since my bare-metal target loads process's memory via Process::WriteMemory, I have 200+

[Lldb-commits] [PATCH] D84307: [lldb/interpreter] Move the history subcommand to session (NFCI)

mib created this revision. mib added reviewers: labath, teemperor. mib added a project: LLDB. Herald added a subscriber: lldb-commits. This patch moves the `history` subcommand from the `command` to `session`. I think it makes more sense to have it there because as the `command` usage suggests,

[Lldb-commits] [PATCH] D84305: [lldb/interpreter] Update CommandObject instanciation to use make_shared (NFC)

mib created this revision. mib added reviewers: labath, JDevlieghere. mib added a project: LLDB. Herald added a subscriber: lldb-commits. As @labath put it a in D82155 , let's make_shared-ify some the command interpreter CommandObject instantiation.

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing updated this revision to Diff 279756. Higuoxing added a comment. Herald added subscribers: sstefan1, ormris, emaste. Herald added a reviewer: espindola. Herald added a reviewer: jdoerfert. Address comments & Rebase & Add one test. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha added a comment. Comment at: lldb/source/Breakpoint/BreakpointLocation.cpp:73 + if (m_bp_site_sp) +return m_bp_site_sp->IsHardware(); + JDevlieghere wrote: > Should we sanity check that this is true when `m_hardware_index != >

[Lldb-commits] [lldb] e00645c - [lldb/test] Delete result formatter machinery entirely

Author: Pavel Labath Date: 2020-07-22T11:53:41+02:00 New Revision: e00645cc7878da13c86339fd50a4fb78d8a698ad URL: https://github.com/llvm/llvm-project/commit/e00645cc7878da13c86339fd50a4fb78d8a698ad DIFF: https://github.com/llvm/llvm-project/commit/e00645cc7878da13c86339fd50a4fb78d8a698ad.diff

[Lldb-commits] [lldb] 33981c6 - [lldb/interpreter] Fix formatting in CommandInterpreter.cpp (NFC)

Author: Med Ismail Bennani Date: 2020-07-22T11:48:07+02:00 New Revision: 33981c672405979c15e57c8662cad79410b0752b URL: https://github.com/llvm/llvm-project/commit/33981c672405979c15e57c8662cad79410b0752b DIFF:

[Lldb-commits] [lldb] 5bb742b - [lldb/interpreter] Add ability to save lldb session to a file

Author: Med Ismail Bennani Date: 2020-07-22T11:43:16+02:00 New Revision: 5bb742b10dafd595223172ae985687765934ebe9 URL: https://github.com/llvm/llvm-project/commit/5bb742b10dafd595223172ae985687765934ebe9 DIFF:

[Lldb-commits] [Differential] D82155: [WIP][lldb/interpreter] Add ability to save lldb session to a file

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bb742b10daf: [lldb/interpreter] Add ability to save lldb session

[Lldb-commits] [PATCH] D82155: [lldb/interpreter] Add ability to save lldb session to a file

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bb742b10daf: [lldb/interpreter] Add ability to save lldb session to a file (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82155/new/

[Lldb-commits] [PATCH] D82155: [lldb/interpreter] Add ability to save lldb session to a file

mib updated this revision to Diff 279737. mib added a comment. Address @labath comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82155/new/ https://reviews.llvm.org/D82155 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h

[Lldb-commits] [PATCH] D83552: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f4c850e7b4f: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83552/new/

[Lldb-commits] [Differential] D83552: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5f4c850e7b4f: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH (authored by labath). Repository: rG LLVM

[Lldb-commits] [lldb] 5f4c850 - [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH

Author: Pavel Labath Date: 2020-07-22T11:37:02+02:00 New Revision: 5f4c850e7b4f100a8c779ea52b492c87af076136 URL: https://github.com/llvm/llvm-project/commit/5f4c850e7b4f100a8c779ea52b492c87af076136 DIFF: https://github.com/llvm/llvm-project/commit/5f4c850e7b4f100a8c779ea52b492c87af076136.diff

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

labath added a comment. I haven't looked at all the sve details, but they seem very similar to the core file stuff, so I think they should be fine. I have some other comments though... Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:240 +

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

labath added a subscriber: omjavaid. labath added a comment. In D84257#2164967 , @tatyana-krasnukha wrote: > Probably fixes llvm.org/PR44659, though I cannot check on arm/aarch64. @omjavaid might be interested in checking that. Repository: rG LLVM

[Lldb-commits] [PATCH] D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory

labath added a comment. When does this assertion fire? Is this breaking an existing test? Should we be adding a new one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84254/new/ https://reviews.llvm.org/D84254

[Lldb-commits] [PATCH] D82155: [lldb/interpreter] Add ability to save lldb session to a file

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Commands/CommandObjectQuit.cpp:75-80 + if (m_interpreter.GetSaveSessionOnQuit()) { +if (!m_interpreter.SaveTranscript(result)) { + result.SetStatus(eReturnStatusFailed); +

[Lldb-commits] [PATCH] D84269: [lldb] Add some example type anotations to python.swig

labath added a comment. IIUC, this would make the file incompatible with python2, which we still kind of support (though hopefully not for long). This seems like a good idea, but we first need to sort out our py2 story. Given that we've just branched for the 11.0 release, this may actually be

[Lldb-commits] [lldb] 074b121 - Reland [lldb] Unify type name matching in FormattersContainer

Author: Raphael Isemann Date: 2020-07-22T09:32:28+02:00 New Revision: 074b121642b286afb16adeebda5ec8236f7b8ea9 URL: https://github.com/llvm/llvm-project/commit/074b121642b286afb16adeebda5ec8236f7b8ea9 DIFF:

[Lldb-commits] [PATCH] D83772: [Windows] Fix limit on command line size

sepavloff added reviewers: k8stone, max-kudr. sepavloff added subscribers: max-kudr, k8stone. sepavloff added a comment. @k8stone @max-kudr Could you please review the changes for LLDB? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

JDevlieghere added inline comments. Comment at: lldb/source/Breakpoint/BreakpointLocation.cpp:73 + if (m_bp_site_sp) +return m_bp_site_sp->IsHardware(); + Should we sanity check that this is true when `m_hardware_index != LLDB_INVALID_INDEX32`?

[Lldb-commits] [PATCH] D83772: [Windows] Fix limit on command line size

sepavloff updated this revision to Diff 279709. sepavloff added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Added changes for LLDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/

[Lldb-commits] [PATCH] D82155: [lldb/interpreter] Add ability to save lldb session to a file

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2941 + + GetDebugger().GetOutputStreamSP()->Printf( + "Session's transcripts saved to

[Lldb-commits] [lldb] e9f5ca0 - [lldb] Adjust for getIntegerConstantExpression refactor

Author: Jonas Devlieghere Date: 2020-07-21T23:04:22-07:00 New Revision: e9f5ca0b7977bb3886feae0d35617a0ea9349a2a URL: https://github.com/llvm/llvm-project/commit/e9f5ca0b7977bb3886feae0d35617a0ea9349a2a DIFF: