[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

JDevlieghere planned changes to this revision. JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectScript.cpp:50-51 + + std::tie(head, tail) = tail.split(' '); + if (head != "-l" && head !=

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectScript.cpp:50-51 + + std::tie(head, tail) = tail.split(' '); + if (head != "-l" && head != "--language") +return CommandParsed(command); generally, lldb supports more than

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectScript.cpp:65 + + return CommandParsed(command); +} this is missing error handling for unsupported languages, such as `script -l swift` Comment at:

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mib, l.frisken, jingham. JDevlieghere requested review of this revision. Make it possible to run the `script` command with a different language than currently selected. $ ./bin/lldb -l python (lldb) script -l lua

[Lldb-commits] [lldb] 9390b34 - [lldb] Move ScriptCommand and RegexCommand under Commands (NFC)

Author: Jonas Devlieghere Date: 2020-09-01T17:33:39-07:00 New Revision: 9390b346fc207c3edabbca9665e77260b030cfe0 URL: https://github.com/llvm/llvm-project/commit/9390b346fc207c3edabbca9665e77260b030cfe0 DIFF:

[Lldb-commits] [PATCH] D86662: Simplify Symbol Status Message to Only Debug Info Size

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82139b8770ee: Simplify Symbol Status Message to Only Debug Info

[Lldb-commits] [lldb] 82139b8 - Simplify Symbol Status Message to Only Debug Info Size

Author: Yifan Shen Date: 2020-09-01T16:25:20-07:00 New Revision: 82139b8770ee07f0b778be7af22c529098ef12ec URL: https://github.com/llvm/llvm-project/commit/82139b8770ee07f0b778be7af22c529098ef12ec DIFF: https://github.com/llvm/llvm-project/commit/82139b8770ee07f0b778be7af22c529098ef12ec.diff

[Lldb-commits] [PATCH] D86987: [lldb/interpreter] Improve REPL init file compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0224738c1abd: [lldb/interpreter] Improve REPL init file compatibility (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 0224738 - [lldb/interpreter] Improve REPL init file compatibility

Author: Med Ismail Bennani Date: 2020-09-02T01:21:22+02:00 New Revision: 0224738c1abdee59923a539204f12c4c99621506 URL: https://github.com/llvm/llvm-project/commit/0224738c1abdee59923a539204f12c4c99621506 DIFF:

[Lldb-commits] [PATCH] D86987: [lldb/interpreter] Improve REPL init file compatibility

mib updated this revision to Diff 289307. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86987/new/ https://reviews.llvm.org/D86987 Files: lldb/docs/man/lldb.rst lldb/source/Interpreter/CommandInterpreter.cpp lldb/tools/driver/Driver.cpp

[Lldb-commits] [PATCH] D86987: [lldb/interpreter] Improve REPL init file compatibility

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a subscriber: lldb-commits. mib requested review of this revision. This patch changes the command interpreter sourcing logic for the REPL init file. Instead of looking for a arbitrary file name,

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

wallace updated this revision to Diff 289301. wallace added a comment. fix header c++ declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85705/new/ https://reviews.llvm.org/D85705 Files: lldb/include/lldb/Core/PluginManager.h

[Lldb-commits] [PATCH] D86670: [intel-pt] Add a basic implementation of the dump command

wallace updated this revision to Diff 289300. wallace added a comment. - Now using the TraceDumpOptions struct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86670/new/ https://reviews.llvm.org/D86670 Files: lldb/include/lldb/Target/Target.h

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

aprantl added inline comments. Comment at: lldb/source/Commands/CommandObjectTrace.h:1 +//===-- CommandObjectTrace.h --===// +// Can you add `-*- C++ -*-` markers the the `.h` files you are adding? Otherwise tools

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

wallace updated this revision to Diff 289285. wallace added a comment. fix nit. Waiting for an additional approval Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85705/new/ https://reviews.llvm.org/D85705 Files:

[Lldb-commits] [PATCH] D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface

omjavaid updated this revision to Diff 289218. omjavaid added a comment. Fixed last diff it contained an invalid change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86962/new/ https://reviews.llvm.org/D86962 Files:

[Lldb-commits] [PATCH] D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface

omjavaid added a comment. NativeRegisterContextLinux_arm still uses "Plugins/Process/Utility/lldb-arm-register-enums.h" which I intend to deal in a later patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86962/new/ https://reviews.llvm.org/D86962

[Lldb-commits] [PATCH] D86962: [LLDB] Move NativeRegisterContextLinux/RegisterContextPOSIX*_arm to RegisterInfoAndSetInterface

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: llvm-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: LLVM. omjavaid requested review of this revision. This patch removes register set definitions and other redundant code from

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere added a comment. In D86497#2248934 , @davezarzycki wrote: > Hello. I have an auto-bisecting multi-stage bot that has identified this > change as breaking release (without assertions) testing on Fedora 33 x86-64. > Can we get a quick fix or

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. Don't see an obvious fix, so I reverted for Jonas in 7c80f2da812e45bbdfa3c8f9ab24440f8ef3362a Repository: rG

[Lldb-commits] [lldb] 7c80f2d - Revert "[lldb] Add reproducer verifier"

Author: Raphael Isemann Date: 2020-09-01T12:21:44+02:00 New Revision: 7c80f2da812e45bbdfa3c8f9ab24440f8ef3362a URL: https://github.com/llvm/llvm-project/commit/7c80f2da812e45bbdfa3c8f9ab24440f8ef3362a DIFF:

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

davezarzycki added a comment. Hello. I have an auto-bisecting multi-stage bot that has identified this change as breaking release (without assertions) testing on Fedora 33 x86-64. Can we get a quick fix or revert this change for now? FAIL: lldb-shell ::