Author: Jonas Devlieghere
Date: 2020-09-11T17:37:14-07:00
New Revision: 33eb64704292dc2fc8585b8aa7459f96482c6cf9
URL:
https://github.com/llvm/llvm-project/commit/33eb64704292dc2fc8585b8aa7459f96482c6cf9
DIFF:
This revision was automatically updated to reflect the committed changes.
Closed by commit rG33eb64704292: [lldb] Use GetNonKVOClassDescriptor to get the
NSDictionary class descriptor (authored by JDevlieghere).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
LGTM. The KVO decorated class name is almost never useful, and certainly not
here...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87545/new/
https://reviews.llvm.org/D87545
Author: Jonas Devlieghere
Date: 2020-09-11T16:11:25-07:00
New Revision: 76e3a27c16d2a8171454cf12a33e35e3ae6f9dc2
URL:
https://github.com/llvm/llvm-project/commit/76e3a27c16d2a8171454cf12a33e35e3ae6f9dc2
DIFF:
mati865 added a comment.
`-DLLVM_ENABLE_PROJECTS="clang;lldb" -DLLVM_BUILD_LLVM_DYLIB=1` with only this
patch applied (`<` is before, `>` is after):
$ diff <(cd ../build && find ./ | sort) <(cd ../build2/ && find ./ | sort)
38a39,41
> ./bin/libLLVM.dll
> ./bin/libLTO.dll
>
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
This looks good to me! I can push it later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87517/new/
https://reviews.llvm.org/D87517
JDevlieghere updated this revision to Diff 291325.
JDevlieghere added a comment.
Remove spurious change
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87545/new/
https://reviews.llvm.org/D87545
Files:
lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
Index:
mati865 added a comment.
I haven't tried ` BUILD_SHARED_LIBS=TRUE` TBH.
Effects visible at first glance:
bin/LLVM.dll -> bin/libLLVM.dll
bin/LTO.dll -> bin/libLTO.dll
lib/liblibclang.a -> lib/libclang.a
lib/liblibclang.dll.a -> lib/libclang.a
JDevlieghere created this revision.
JDevlieghere added a reviewer: jingham.
JDevlieghere requested review of this revision.
On macOS Big Sur the class descriptor contains the `NSKVONotifying_` prefix.
This is covered by `TestDataFormatterObjCKVO`.
https://reviews.llvm.org/D87545
Files:
mstorsjo added a comment.
Herald added a reviewer: JDevlieghere.
What's the practical effect of this? I see that a number of libraries already
have a lib prefix prepended, like libclang/liblldb - I presume this changes the
name of the individual libs (for BUILD_SHARED_LIBS=TRUE configurations)?
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4da8fa45a096: [lldb/API] Add
Breakpoint::SerializeToStructuredData to SBAPI (authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
Author: Med Ismail Bennani
Date: 2020-09-11T20:09:55+02:00
New Revision: 4da8fa45a0968a1f98010777d3731a921431ee55
URL:
https://github.com/llvm/llvm-project/commit/4da8fa45a0968a1f98010777d3731a921431ee55
DIFF:
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: JDevlieghere.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87491/new/
https://reviews.llvm.org/D87491
JDevlieghere added a comment.
The reproducer instrumentation part LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87491/new/
https://reviews.llvm.org/D87491
___
lldb-commits mailing list
DavidSpickett added a comment.
This LGTM but I don't know the API standards very well. Some else should give a
final review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87491/new/
https://reviews.llvm.org/D87491
aprantl added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:83
+
+AttributeValue(const DWARFUnit *_cu, dw_offset_t _die_offset,
+ dw_attr_t _attr, dw_form_t _form)
We usually don't prefix constructor
mati865 created this revision.
mati865 added a reviewer: LLVM.
mati865 added projects: LLVM, clang, LLDB.
Herald added subscribers: llvm-commits, lldb-commits, cfe-commits,
JDevlieghere, mgorny.
mati865 requested review of this revision.
In MinGW world, UNIX like `lib` prefix is preferred. This
mib marked an inline comment as done.
mib added inline comments.
Comment at:
lldb/test/API/functionalities/breakpoint/serialize/TestBreakpointSerialization.py:77
+
self.assertEqual(serialized_data["Breakpoint"]["BKPTResolver"]["Options"]["FileName"],
"foo")
+
mib updated this revision to Diff 291209.
mib added a comment.
Add invalid breakpoint test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87491/new/
https://reviews.llvm.org/D87491
Files:
lldb/bindings/interface/SBBreakpoint.i
DavidSpickett added inline comments.
Comment at:
lldb/test/API/functionalities/breakpoint/serialize/TestBreakpointSerialization.py:77
+
self.assertEqual(serialized_data["Breakpoint"]["BKPTResolver"]["Options"]["FileName"],
"foo")
+
20 matches
Mail list logo
