[Lldb-commits] [lldb] 0fcacef - [lldb] Format unix signal table (NFC)

Author: Jonas Devlieghere Date: 2020-10-06T23:36:56-07:00 New Revision: 0fcacefd160494280dc040f4f055db6df695ac12 URL: https://github.com/llvm/llvm-project/commit/0fcacefd160494280dc040f4f055db6df695ac12 DIFF: https://github.com/llvm/llvm-project/commit/0fcacefd160494280dc040f4f055db6df695ac12.d

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione added inline comments. Comment at: lldb/source/lldb.cpp:22 #ifdef LLDB_REVISION return LLDB_REVISION; #else this won't expand to a string as is, does this indicate it's unused? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296579. kastiglione added a comment. switch NULL to "" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index: lldb/source/lldb.cpp =

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296578. kastiglione added a comment. Unbreak code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index: lldb/source/lldb.cpp ==

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Small cleanup to `lldb_private::GetVersion()`. In parti

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:54 +if (sc_list.GetContextAtIndex(i, sc) && +(sc.symbol->IsExternal() || sc.symbol->IsWeak())) { const uint32_t range_scope = labath wrote: >

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Trace/ProcessTrace.h:18 + +class ProcessTrace : public lldb_private::Process { +public: tatyana-krasnukha wrote: > clayborg wrote: > > So one issue is how do we eventually deal with debugging

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Worth mentioning that this will be in POSIX issue 8 https://www.austingroupbugs.net/bug_view_page.php?bug_id=508 Comment at: lldb/source/Host/common/PseudoTerminal.c

[Lldb-commits] [PATCH] D88841: [intel pt] Refactor parsing

wallace updated this revision to Diff 296562. wallace marked 10 inline comments as done. wallace added a comment. Address issues based on this diff's comments and from conversations with Greg. - I'm still keeping the TraceSessionFile name instead of TraceSettings, as later there'll be actual tra

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Nice changes. Just a few changes and should be good to go. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:675 + /// + /// \param[in] target + /// Targ

[Lldb-commits] [PATCH] D88866: [lldb] Add another fallback to GetXcodeSDK

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3b0414b0ea3: [lldb] Change the xcrun (fallback) logic in GetXcodeSDK (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D88866?vs=296553&id=2965

[Lldb-commits] [lldb] e3b0414 - [lldb] Change the xcrun (fallback) logic in GetXcodeSDK

Author: Jonas Devlieghere Date: 2020-10-06T15:55:06-07:00 New Revision: e3b0414b0ea305396a1fcfb2821ad643b0731880 URL: https://github.com/llvm/llvm-project/commit/e3b0414b0ea305396a1fcfb2821ad643b0731880 DIFF: https://github.com/llvm/llvm-project/commit/e3b0414b0ea305396a1fcfb2821ad643b0731880.d

[Lldb-commits] [PATCH] D88866: [lldb] Add another fallback to GetXcodeSDK

aprantl added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:378 + auto xcrun = [](std::string sdk, + std::string developer_dir = "") -> std::string { +std::string xcrun_cmd = "xcrun --show-sdk-path --sdk " + sdk; -

[Lldb-commits] [PATCH] D88866: [lldb] Add another fallback to GetXcodeSDK

JDevlieghere updated this revision to Diff 296553. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88866/new/ https://reviews.llvm.org/D88866 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm Index: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm

[Lldb-commits] [PATCH] D88866: [lldb] Add another fallback to GetXcodeSDK

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Apart from a cosmetic detail (inline) this LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88866/new/ https://reviews.llvm.org/D88866 __

[Lldb-commits] [PATCH] D88866: [lldb] Add another fallback to GetXcodeSDK

aprantl added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:423 +if (path.RemoveLastPathComponent()) { + developer_dir = path.GetPath(); + std::string sdk = xcrun(developer_dir, sdk_name); Can you use a fr

[Lldb-commits] [PATCH] D88866: [lldb] Add another fallback to GetXcodeSDK

JDevlieghere updated this revision to Diff 296552. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88866/new/ https://reviews.llvm.org/D88866 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm Index: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

jasonmolenda added a subscriber: DavidSpickett. jasonmolenda added a comment. Thinking about process save-core and how it will default to a skinny corefile on macOS but a full corefile elsewhere, I'd like to surface some notification to the user about the type of corefile that was created to the

[Lldb-commits] [PATCH] D88866: [lldb] Add another fallback to GetXcodeSDK

aprantl added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:405 + auto find_sdk = [&](std::string sdk_name) -> std::string { +std::string developer_dir = GetEnvDeveloperDir(); +if (developer_dir.empty()) perhaps add ```

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 296517. DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Fix unit test failures due to dereferncing an empty optional when smaps parsing failed. To prevent this happening again pass an Optional to the callback and let it de

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

tatyana-krasnukha added inline comments. Comment at: lldb/source/Plugins/Process/Trace/ProcessTrace.h:18 + +class ProcessTrace : public lldb_private::Process { +public: clayborg wrote: > So one issue is how do we eventually deal with debugging a live process that

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

JDevlieghere added a comment. In D88840#2314883 , @labath wrote: > In D88840#2314860 , @JDevlieghere > wrote: > >> In D88840#2314594 , @labath wrote: >> >>> One way this cou

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

labath added a comment. In D88840#2314860 , @JDevlieghere wrote: > In D88840#2314594 , @labath wrote: > >> One way this could be simplified further is to ditch `-P` and pass down the >> appropriate value from cmak

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

shafik added a comment. I am happy this was not hiding any regressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://reviews.llvm.org/D88792 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D88870: [lldb][NFC] remove unused local variable uuid

zequanwu abandoned this revision. zequanwu added a comment. sorry, I didn't notice that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88870/new/ https://reviews.llvm.org/D88870 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

JDevlieghere added a comment. In D88840#2314594 , @labath wrote: > In D88840#2314587 , @rupprecht wrote: > >> In D88840#2313331 , @kastiglione >> wrote: >> >>> About `-P`, t

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett marked 11 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1319 + // Linux kernel since 2.6.14 has /proc/{pid}/smaps + // if CONFIG_PROC_PAGE_MONITOR is enabled + auto BufferOrError

Re: [Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

> On Oct 6, 2020, at 8:40 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In D88840#2314587 , @rupprecht wrote: > >> In D88840#2313331 , @kastiglione >> wrote: >> >>

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 296495. DavidSpickett added a comment. - reset flags in MemoryRegionInfo Clear() - add Linux specific memory region flags test - address comments from labath (doing this before any change of approach, to prevent any confusion) Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D88906: [lldb/docs] Clarify python/swig version incompatibility

amccarth accepted this revision. amccarth added a comment. Yes, I also (independently) discovered this problem. I probably have notes somewhere with sources for details about the incompatibility. I believe I also brought it up on the lldb-dev list. Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D88906: [lldb/docs] Clarify python/swig version incompatibility

JDevlieghere added subscribers: stella.stamenova, compnerd. JDevlieghere added a comment. In D88906#2314615 , @labath wrote: > Jonas, the notion that 3.7 is incompatible comes from ae7389116 >

[Lldb-commits] [PATCH] D88906: [lldb/docs] Clarify python/swig version incompatibility

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. I used Swig 3.0.12 + cherry-picked commit that fixes that bug (https://github.com/swig/swig/issues/1321) on Windows. It worked well with both Python 3.7 and 3.8. The on

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

labath added inline comments. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:54 +if (sc_list.GetContextAtIndex(i, sc) && +(sc.symbol->IsExternal() || sc.symbol->IsWeak())) { const uint32_t range_scope = aadsm wrote: > lab

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:36 bool lldb_private::InferiorCallMmap(Process *process, addr_t &allocated_addr, addr_t addr, addr_t length, unsigned prot,

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:54 +if (sc_list.GetContextAtIndex(i, sc) && +(sc.symbol->IsExternal() || sc.symbol->IsWeak())) { const uint32_t range_scope = labath wrote: > cla

[Lldb-commits] [PATCH] D88906: [lldb/docs] Clarify python/swig version incompatibility

labath added a comment. Jonas, the notion that 3.7 is incompatible comes from ae7389116 . Do you happen to remember what was the issue you ran into? I find it unlikely that 3.7 is incompatible but 3.8 is ok, and I think you p

[Lldb-commits] [PATCH] D88906: [lldb/docs] Clarify python/swig version incompatibility

labath created this revision. labath added reviewers: JDevlieghere, tatyana-krasnukha, amccarth. Herald added a project: LLDB. labath requested review of this revision. The problematic combo is a debug python>=3.7 && swig<4.0. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D8890

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

labath added a comment. In D88840#2314587 , @rupprecht wrote: > In D88840#2313331 , @kastiglione > wrote: > >> About `-P`, the man page for `lldb` and the driver's `Options.td` say it: >> >>> Prints out the path to

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

rupprecht added a comment. In D88840#2313331 , @kastiglione wrote: > About `-P`, the man page for `lldb` and the driver's `Options.td` say it: > >> Prints out the path to the lldb.py file for this version of lldb. > > Should it do just that? If so this can

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

labath added inline comments. Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:269-375 + Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_PLATFORM)); + LLDB_LOG(log, "target {0}", target); + + // If we're a remote host, use standard behavior from parent class.

[Lldb-commits] [PATCH] D88841: [intel pt] Refactor parsing

labath added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/ThreadIntelPT.cpp:20 + +ThreadIntelPT::~ThreadIntelPT() {} + just `=default`, or even don't declare it all (as explained in the other thread, these declarations are completely redundant

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny updated this revision to Diff 296439. mgorny added a comment. Removed now-redundant DebugProcess. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88796/new/ https://reviews.llvm.org/D88796 Files: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp lldb/source/Plugins/Plat

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

labath added a comment. In D88769#2314164 , @labath wrote: > In D88769#2312482 , @wallace wrote: > >> - Comments on the architecture of classes are in that diff > > Where would that be? I couldn't find anything that

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

labath added a comment. In D88769#2312482 , @wallace wrote: > - Comments on the architecture of classes are in that diff Where would that be? I couldn't find anything that would answer my question from the previous comment? The reason I want to know tha

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

labath added a comment. In D87868#2309260 , @clayborg wrote: > In D87868#2308515 , @labath wrote: > >> That sounds like a plan. FWIW, here's the implementation I hacked up today: >> >> Status NativeProcessLinux::A

[Lldb-commits] [PATCH] D88852: [lldb] [Platform] Move common ::DebugProcess() to PlatformPOSIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa825eaa90e24: [lldb] [Platform] Move common ::DebugProcess() to PlatformPOSIX (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [lldb] a825eaa - [lldb] [Platform] Move common ::DebugProcess() to PlatformPOSIX

Author: Michał Górny Date: 2020-10-06T14:38:54+02:00 New Revision: a825eaa90e2419e3e9ae64ec047440ce98e7bacb URL: https://github.com/llvm/llvm-project/commit/a825eaa90e2419e3e9ae64ec047440ce98e7bacb DIFF: https://github.com/llvm/llvm-project/commit/a825eaa90e2419e3e9ae64ec047440ce98e7bacb.diff

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

labath added a comment. Regardless of the future of the syscall approach, I think limiting ourselves to external mmap symbols is a good idea. And if it fixes your problem -- great. It would be good to have a test for that, though. Maybe something like this would do? static void *mmap() { ret

[Lldb-commits] [PATCH] D88870: [lldb][NFC] remove unused local variable uuid

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This variable is definitely used. The `uuid` reference points into the module_spec object, which is then appended to the specs array, and returned. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D88852: [lldb] [Platform] Move common ::DebugProcess() to PlatformPOSIX

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good, thanks. I don't think we need to do any special kind of testing on macos for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

jasonmolenda added a comment. Hey all, got distracted while reading the patch and jotted a few notes, but I know that's not as much what Pavel wanted to discuss. We already have some target specific goop in these ProcessGDBRemote type classes for registers and such, this doesn't cause my great

[Lldb-commits] [lldb] 3dffec0 - [LLDB] Add QEMU testing environment setup guide for SVE testing

Author: Muhammad Omair Javaid Date: 2020-10-06T12:35:08+05:00 New Revision: 3dffec03b0f68be8d77b0545a0eef795a6662cd3 URL: https://github.com/llvm/llvm-project/commit/3dffec03b0f68be8d77b0545a0eef795a6662cd3 DIFF: https://github.com/llvm/llvm-project/commit/3dffec03b0f68be8d77b0545a0eef795a6662c

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

This revision was automatically updated to reflect the committed changes. Closed by commit rG3dffec03b0f6: [LLDB] Add QEMU testing environment setup guide for SVE testing (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82064/new

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Hello everyone, The staging buildbot was up and running for 6 days now, and looks good. Tomorrow at 12:00 PM PDT we will switch the production buildbot to the new version. If you are a bot owner, you do not need to do anything at this point, unless I'll ask you to help. The buildbot will go down

[Lldb-commits] [PATCH] D88581: [lldb] Symlink the Clang resource directory to the LLDB build directory in standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rGce4d15fe142e: [lldb] Symlink the Clang resource directory to the LLDB build directory in… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG L

[Lldb-commits] [lldb] ce4d15f - [lldb] Symlink the Clang resource directory to the LLDB build directory in standalone builds

Author: Raphael Isemann Date: 2020-10-06T09:28:39+02:00 New Revision: ce4d15fe142eb0e0ed7c998a73b13e7bee45d99e URL: https://github.com/llvm/llvm-project/commit/ce4d15fe142eb0e0ed7c998a73b13e7bee45d99e DIFF: https://github.com/llvm/llvm-project/commit/ce4d15fe142eb0e0ed7c998a73b13e7bee45d99e.dif