[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70885/new/ https://reviews.llvm.org/D70885 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D90557: [LLDB/Lua] call lua_close() on Lua dtor

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90557/new/ https://reviews.llvm.org/D90557

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

aadsm updated this revision to Diff 302180. aadsm added a comment. Herald added a subscriber: JDevlieghere. Herald added a reviewer: JDevlieghere. Use set and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70885/new/

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm updated this revision to Diff 302178. aadsm added a comment. Herald added subscribers: MaskRay, emaste. Herald added a reviewer: espindola. Also set the symbol as external when it is weak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D90557: [LLDB/Lua] call lua_close() on Lua dtor

tammela created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. tammela requested review of this revision. Herald added a subscriber: JDevlieghere. This patch calls `lua_close()` on Lua dtor. This guarantees that the Lua GC finalizers are honored, aside from

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:503-505 + if (section_list) { +InitializeFirstCodeAddress(*section_list); + } labath wrote: > clayborg wrote: > > remove braces > or even fold the declaration

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm updated this revision to Diff 302150. aadsm added a comment. Used -s to feed commands and disabled errors when interpreting them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87173/new/ https://reviews.llvm.org/D87173 Files:

[Lldb-commits] [PATCH] D90556: [LLDB][NFC] treat Lua error codes in a more explicit manner

tammela created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. tammela requested review of this revision. Herald added a subscriber: JDevlieghere. This patch is a minor suggestion to not rely on the fact that the `LUA_OK` macro is 0. This assumption could

[Lldb-commits] [lldb] ba447f3 - [NFC][lldb] Silence unused variable warning

Author: Nathan James Date: 2020-11-01T14:37:06Z New Revision: ba447f38f6e53e5de68fa264797690b74cb750c0 URL: https://github.com/llvm/llvm-project/commit/ba447f38f6e53e5de68fa264797690b74cb750c0 DIFF: https://github.com/llvm/llvm-project/commit/ba447f38f6e53e5de68fa264797690b74cb750c0.diff LOG:

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. Refactored test according to recommendations given during review 1267bb2e416e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/

[Lldb-commits] [lldb] 1267bb2 - [lldb] TestTypeGetModule.py review improvements

Author: Ilya Bukonkin Date: 2020-11-01T13:55:57+03:00 New Revision: 1267bb2e416e42f9c3bbfa7b6cbf4975fa7aa546 URL: https://github.com/llvm/llvm-project/commit/1267bb2e416e42f9c3bbfa7b6cbf4975fa7aa546 DIFF: https://github.com/llvm/llvm-project/commit/1267bb2e416e42f9c3bbfa7b6cbf4975fa7aa546.diff