[Lldb-commits] [lldb] dd2054d - [lldb] Treat remote macOS debugging like any other remote darwin platform

Author: Jonas Devlieghere Date: 2020-12-02T17:03:22-08:00 New Revision: dd2054d38a848a75fe84fb68d9c3a97e5ade6753 URL: https://github.com/llvm/llvm-project/commit/dd2054d38a848a75fe84fb68d9c3a97e5ade6753 DIFF:

[Lldb-commits] [PATCH] D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGdd2054d38a84: [lldb] Treat remote macOS debugging like any other remote darwin platform (authored by JDevlieghere). Changed prior to commit:

[Lldb-commits] [PATCH] D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:98-99 +PlatformSP PlatformMacOSX::CreateInstance(bool force, const ArchSpec *arch) { + // The only time we create an instance is

[Lldb-commits] [PATCH] D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform

clayborg added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:98-99 +PlatformSP PlatformMacOSX::CreateInstance(bool force, const ArchSpec *arch) { + // The only time we create an instance is when we are creating a remote + // macosx

[Lldb-commits] [PATCH] D92513: [lldb] Return the original path when tilde expansion fails.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcdd231df6c7: [lldb] Return the original path when tilde expansion fails. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] dcdd231 - [lldb] Return the original path when tilde expansion fails.

Author: Jonas Devlieghere Date: 2020-12-02T16:01:30-08:00 New Revision: dcdd231df6c7b6f4a635fe7941c1f87955328183 URL: https://github.com/llvm/llvm-project/commit/dcdd231df6c7b6f4a635fe7941c1f87955328183 DIFF:

[Lldb-commits] [PATCH] D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/test/API/commands/platform/sdk/TestPlatformSDK.py:20 +# The port used by debugserver. +PORT = 54637 + aprantl wrote: > What happens if two tests run at

[Lldb-commits] [PATCH] D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform

JDevlieghere updated this revision to Diff 309087. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Address @aprantl's feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92452/new/ https://reviews.llvm.org/D92452 Files:

[Lldb-commits] [lldb] 640567d - [lldb] X-FAIL class template parameter pack tests on Windows

Author: Raphael Isemann Date: 2020-12-03T00:38:05+01:00 New Revision: 640567d4646292f77e87e77b8710ebf1bde1f390 URL: https://github.com/llvm/llvm-project/commit/640567d4646292f77e87e77b8710ebf1bde1f390 DIFF:

[Lldb-commits] [PATCH] D92513: [lldb] Return the original path when tilde expansion fails.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks, I do féél this ameliorates the current behavióúr CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92513/new/ https://reviews.llvm.org/D92513

[Lldb-commits] [PATCH] D92513: [lldb] Return the original path when tilde expansion fails.

JDevlieghere updated this revision to Diff 309078. JDevlieghere added a comment. Update the unittest CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92513/new/ https://reviews.llvm.org/D92513 Files: lldb/source/Utility/TildeExpressionResolver.cpp

[Lldb-commits] [PATCH] D92513: [lldb] Return the original path when tilde expansion fails.

JDevlieghere updated this revision to Diff 309073. JDevlieghere added a comment. Use `SmallVector::assign` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92513/new/ https://reviews.llvm.org/D92513 Files: lldb/source/Utility/TildeExpressionResolver.cpp Index:

[Lldb-commits] [lldb] c49e718 - [lldb][NFC] Make DeclOrigin::Valid() const

Author: Raphael Isemann Date: 2020-12-03T00:08:19+01:00 New Revision: c49e71805142ac3a27a5567ce516890e9243b34e URL: https://github.com/llvm/llvm-project/commit/c49e71805142ac3a27a5567ce516890e9243b34e DIFF:

[Lldb-commits] [PATCH] D92513: [lldb] Return the original path when tilde expansion fails.

JDevlieghere created this revision. JDevlieghere added a reviewer: teemperor. JDevlieghere requested review of this revision. I was playing around with changing the $HOME directory and when I provided a non-existing path LLDB would crash. I traced it down to the TildeExpressionResolver which

[Lldb-commits] [PATCH] D92425: [lldb] Don't reject empty or unnamed template parameter packs

stella.stamenova added a comment. In D92425#2428952 , @teemperor wrote: > In D92425#2428844 , > @stella.stamenova wrote: > >> This caused failures on the Windows lldb buildbot: >> >>

[Lldb-commits] [PATCH] D92510: [lldb] set created function decl to public access in TypeSystemClang

shafik added a comment. +1 to what @teemperor said Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92510/new/ https://reviews.llvm.org/D92510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D92510: [lldb] set created function decl to public access in TypeSystemClang

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. D85993 was trying to do the same thing and contains some explanation why I think this isn't a good solution. TL;DR is that functions in a

[Lldb-commits] [PATCH] D92510: [lldb] set created function decl to public access in TypeSystemClang

zequanwu created this revision. zequanwu added reviewers: teemperor, shafik. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. zequanwu requested review of this revision. Herald added a subscriber: JDevlieghere. Test case stack_unwinding01.cpp crashed in Debug build of lldb

[Lldb-commits] [PATCH] D92425: [lldb] Don't reject empty or unnamed template parameter packs

teemperor added a comment. In D92425#2428844 , @stella.stamenova wrote: > This caused failures on the Windows lldb buildbot: > > http://lab.llvm.org:8011/#/builders/83/builds/1294 > > Tests have to have unique names, so the two new added tests that use

[Lldb-commits] [lldb] 291cc1b - [lldb][NFC] Give class template pack test files unique class names

Author: Raphael Isemann Date: 2020-12-02T19:19:35+01:00 New Revision: 291cc1bbea1f4a6cab829509e95b3efe40af908f URL: https://github.com/llvm/llvm-project/commit/291cc1bbea1f4a6cab829509e95b3efe40af908f DIFF:

[Lldb-commits] [PATCH] D92425: [lldb] Don't reject empty or unnamed template parameter packs

stella.stamenova added a comment. This caused failures on the Windows lldb buildbot: http://lab.llvm.org:8011/#/builders/83/builds/1294 Tests have to have unique names, so the two new added tests that use TestCase as the class name are both trying to write to the same log file and failing to

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 308932. omjavaid added a comment. Added copy constructor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd055e3a0eb4e: [LLDB/Python] Fix segfault on Python scripted entrypoints (authored by tammela). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] d055e3a - [LLDB/Python] Fix segfault on Python scripted entrypoints

Author: Pedro Tammela Date: 2020-12-02T11:25:31Z New Revision: d055e3a0eb4e957159b075c0937a960beb75c975 URL: https://github.com/llvm/llvm-project/commit/d055e3a0eb4e957159b075c0937a960beb75c975 DIFF: https://github.com/llvm/llvm-project/commit/d055e3a0eb4e957159b075c0937a960beb75c975.diff

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

teemperor added a comment. In D92103#2428139 , @martong wrote: > Hey Raphael, thanks for looking into the CTU crash! > > I also had a look and I could reproduce that on Linux Ubuntu 18.04 with GCC > 7. I think the discrepancy stems from GCC's libstdc++

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

martong added a subscriber: balazske. martong added a comment. Hey Raphael, thanks for looking into the CTU crash! I also had a look and I could reproduce that on Linux Ubuntu 18.04 with GCC 7. I think the discrepancy stems from GCC's libstdc++ and MacOS's libc++ implementation differences of

[Lldb-commits] [PATCH] D92425: [lldb] Don't reject empty or unnamed template parameter packs

This revision was automatically updated to reflect the committed changes. Closed by commit rGc526426f5cba: [lldb] Dont reject empty or unnamed template parameter packs (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [lldb] c526426 - [lldb] Don't reject empty or unnamed template parameter packs

Author: Raphael Isemann Date: 2020-12-02T10:50:41+01:00 New Revision: c526426f5cba5308782ea4f86822047ee2ee3818 URL: https://github.com/llvm/llvm-project/commit/c526426f5cba5308782ea4f86822047ee2ee3818 DIFF: