Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On Fri, Jan 22, 2021 at 9:42 AM Jim Ingham wrote: > If you are just loading an object file and the looking at the line table > or something like that, would a UnitTest be more suitable? > Maybe, though for what it's worth, this isn't an issue with the line table (well, not the .debug_line

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On Fri, Jan 22, 2021 at 5:37 AM Pavel Labath wrote: > On 19/01/2021 23:23, David Blaikie wrote: > > On Tue, Jan 19, 2021 at 1:12 AM Pavel Labath wrote: > > Yeah - I have mixed feelings about debugger testing here - it is nice > > to have end-to-end tests which makes for handy debugger testing >

[Lldb-commits] [PATCH] D94064: lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78d41a1295d9: lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms (authored by dblaikie). Repository: rG LLVM Github

[Lldb-commits] [lldb] 78d41a1 - lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms

Author: David Blaikie Date: 2021-01-24T18:39:06-08:00 New Revision: 78d41a1295d9d40c37758230d0218c61eaffad88 URL: https://github.com/llvm/llvm-project/commit/78d41a1295d9d40c37758230d0218c61eaffad88 DIFF: https://github.com/llvm/llvm-project/commit/78d41a1295d9d40c37758230d0218c61eaffad88.diff

[Lldb-commits] [PATCH] D94064: lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms

dblaikie added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/subprogram_ranges.test:22 +# initialization/no prologue instructions, so the location of "var" is valid +# at the start of the function, so 'image lookup -v -s main' will include it. +#

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

labath updated this revision to Diff 318862. labath added a comment. Keep dsymutil, fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95261/new/ https://reviews.llvm.org/D95261 Files: lldb/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [lldb] 2afaf07 - Implement vAttachOrWait

Author: Augusto Noronha Date: 2021-01-24T21:30:09+01:00 New Revision: 2afaf072f5c1467767081571f2a3747b3ba91354 URL: https://github.com/llvm/llvm-project/commit/2afaf072f5c1467767081571f2a3747b3ba91354 DIFF:

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2afaf072f5c1: Implement vAttachOrWait (authored by augusto2112, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

labath added inline comments. Comment at: lldb/test/API/CMakeLists.txt:59 set(LLDB_TEST_COMPILER "${LLDB_DEFAULT_TEST_COMPILER}" CACHE PATH "C Compiler to use for building LLDB test inferiors") -set(LLDB_TEST_DSYMUTIL "${LLDB_DEFAULT_TEST_DSYMUTIL}" CACHE PATH "dsymutil used

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On 22/01/2021 18:42, Jim Ingham wrote: If you are just loading an object file and the looking at the line table or something like that, would a UnitTest be more suitable? Jim It depends on who you're talking to. :) I, for one, think we should be writing more unit tests, however, this is

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

This revision was automatically updated to reflect the committed changes. Closed by commit rG50830e50031b: [lldb] Add -Wl,-rpath to make tests run with fresh built libc++ (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 50830e5 - [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

Author: Fangrui Song Date: 2021-01-24T20:21:57Z New Revision: 50830e50031b5420f09f79e82cf6ec984fb8328d URL: https://github.com/llvm/llvm-project/commit/50830e50031b5420f09f79e82cf6ec984fb8328d DIFF: https://github.com/llvm/llvm-project/commit/50830e50031b5420f09f79e82cf6ec984fb8328d.diff LOG:

[Lldb-commits] [PATCH] D94064: lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D94064#2516883 , @dblaikie wrote: > Ah, thanks - think I figured out a representative test & understand better. > I ended up with this: > >

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Let's give this a shot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94888/new/ https://reviews.llvm.org/D94888