[Lldb-commits] [PATCH] D96368: Document the "extra_args" parameter to scripted breakpoint callbacks

jingham added inline comments. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:127 + +def breakpoint_callback(frame, bp_loc, extra_args, dict): + # Your code goes here kastiglione wrote: > How about `internal_dict`, the name used elsewhere,

[Lldb-commits] [lldb] 483ec13 - Use internal_dict everywhere we refer to the python session dict in docs.

Author: Jim Ingham Date: 2021-02-09T17:48:47-08:00 New Revision: 483ec136da7193de781a5284f1c37929cc27c05c URL: https://github.com/llvm/llvm-project/commit/483ec136da7193de781a5284f1c37929cc27c05c DIFF: https://github.com/llvm/llvm-project/commit/483ec136da7193de781a5284f1c37929cc27c05c.diff

[Lldb-commits] [PATCH] D96368: Document the "extra_args" parameter to scripted breakpoint callbacks

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:127 + +def breakpoint_callback(frame, bp_loc, extra_args, dict): + # Your code goes here How about `internal_dict`, the name used elsewhere, and since in this

[Lldb-commits] [PATCH] D96366: Remove uneeded CopyType from BlockPointerSyntheticFrontEnd

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f14c17df709: [LLDB] Remove uneeded CopyType from BlockPointerSyntheticFrontEnd (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4f14c17 - [LLDB] Remove uneeded CopyType from BlockPointerSyntheticFrontEnd

Author: Shafik Yaghmour Date: 2021-02-09T16:11:28-08:00 New Revision: 4f14c17df70916913d71914343dd4f6c709e218d URL: https://github.com/llvm/llvm-project/commit/4f14c17df70916913d71914343dd4f6c709e218d DIFF:

[Lldb-commits] [lldb] ffd7be6 - Remove trailing spaces after \ in comments.

Author: Jim Ingham Date: 2021-02-09T16:06:47-08:00 New Revision: ffd7be65d0efbe8448b8fa051ad213be51e8c367 URL: https://github.com/llvm/llvm-project/commit/ffd7be65d0efbe8448b8fa051ad213be51e8c367 DIFF: https://github.com/llvm/llvm-project/commit/ffd7be65d0efbe8448b8fa051ad213be51e8c367.diff

[Lldb-commits] [PATCH] D96368: Document the "extra_args" parameter to scripted breakpoint callbacks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG365b186c242b: Add documentation for the extra_args parameter to breakpoint commands. (authored by jingham). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 365b186 - Add documentation for the extra_args parameter to breakpoint commands.

Author: Jim Ingham Date: 2021-02-09T15:33:36-08:00 New Revision: 365b186c242b0c3516d7dbb174f3a258c1c8361c URL: https://github.com/llvm/llvm-project/commit/365b186c242b0c3516d7dbb174f3a258c1c8361c DIFF: https://github.com/llvm/llvm-project/commit/365b186c242b0c3516d7dbb174f3a258c1c8361c.diff

[Lldb-commits] [PATCH] D96370: Pass enviroment variables to python scripts.

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Modifying the target environment in order to add something to the host lldb's PYTHONPATH seems very counterintuitive to me. It is misusing the purpose of the target environment

[Lldb-commits] [PATCH] D96370: Pass enviroment variables to python scripts.

rdhindsa updated this revision to Diff 322510. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96370/new/ https://reviews.llvm.org/D96370 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

[Lldb-commits] [PATCH] D96368: Document the "extra_args" parameter to scripted breakpoint callbacks

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96368/new/ https://reviews.llvm.org/D96368

[Lldb-commits] [PATCH] D96370: Pass enviroment variables to python scripts.

rdhindsa created this revision. rdhindsa added a reviewer: labath. rdhindsa requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It enables environment variables set for lldb targets to be passed to python scripts. This allows the user to put

[Lldb-commits] [PATCH] D96368: Document the "extra_args" parameter to scripted breakpoint callbacks

jingham created this revision. jingham added a reviewer: JDevlieghere. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I forgot to document this when adding the feature. Added docs here in both the python-reference.rst and in the

[Lldb-commits] [PATCH] D96366: Remove uneeded CopyType from BlockPointerSyntheticFrontEnd

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: lldb/test/API/lang/c/blocks/main.c:10 + + return z; +} 4 spaces indentation instead of 3 (2 would probably be better,

[Lldb-commits] [PATCH] D96366: Remove uneeded CopyType from BlockPointerSyntheticFrontEnd

shafik created this revision. shafik added reviewers: teemperor, aprantl. shafik requested review of this revision. `BlockPointerSyntheticFrontEnd` does a `CopyType` which results in it copying the type back into its own context. This will result in a call to `ASTImporterDelegate::setOrigin`

[Lldb-commits] [lldb] bd03f6d - [lldb] [Process/FreeBSDRemote] Introduce powerpc support

Author: Michał Górny Date: 2021-02-09T21:10:45+01:00 New Revision: bd03f6df51d161551a0439d8f51e2640a218048f URL: https://github.com/llvm/llvm-project/commit/bd03f6df51d161551a0439d8f51e2640a218048f DIFF: https://github.com/llvm/llvm-project/commit/bd03f6df51d161551a0439d8f51e2640a218048f.diff

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd03f6df51d1: [lldb] [Process/FreeBSDRemote] Introduce powerpc support (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

labath accepted this revision. labath added a comment. Seems legit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95947/new/ https://reviews.llvm.org/D95947 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D95100: [lldb/Commands] Fix short option collision for `process launch`

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, since nobody raised any concerns I think this is fine to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

JDevlieghere added a comment. In D96202#2550712 , @labath wrote: > In D96202#2549497 , @JDevlieghere > wrote: > >> This will break my "run the tests against an Xcode install", but it seems >> like I should be

[Lldb-commits] [lldb] 2309392 - [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

Author: Dave Lee Date: 2021-02-09T08:03:51-08:00 New Revision: 2309392449376295a70354273500730be0f28510 URL: https://github.com/llvm/llvm-project/commit/2309392449376295a70354273500730be0f28510 DIFF: https://github.com/llvm/llvm-project/commit/2309392449376295a70354273500730be0f28510.diff

[Lldb-commits] [PATCH] D96276: [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG230939244937: [lldb] Inline invariant params to

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

labath added a comment. In D96202#2549497 , @JDevlieghere wrote: > This will break my "run the tests against an Xcode install", but it seems > like I should be able to work around that looking for debugserver in the > LLDB.framework in

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

mgorny added a comment. In D95947#2549602 , @jrtc27 wrote: > In D95947#2549599 , @mgorny wrote: > >> @jrtc27 , does this look good? > > Yep, assuming it still works. Yes, it does. @labath, do you have any

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3162 +case DW_AT_decl_file: + decl.SetFile(sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex( + form_value.Unsigned())); jankratochvil wrote: >

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat updated this revision to Diff 322309. werat added a comment. Change DW_AT_decl_file handling as per @jankratochvil comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92643/new/ https://reviews.llvm.org/D92643 Files: