[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

clayborg added inline comments. Comment at: lldb/test/API/functionalities/module_load_attach/TestModuleLoadAttach.py:28 +def test_x(self): +process = self.build_launch_and_attach() +thread = process.GetSelectedThread() Is this racy? What

[Lldb-commits] [PATCH] D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue

jingham added inline comments. Comment at: lldb/include/lldb/Target/ThreadPlan.h:354-359 + /// Returns whether this thread plan overrides the `ShouldStop` of previous + /// plans. + /// + /// When processing the thread plan stack, this function gives plans the + /// ability

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm updated this revision to Diff 325118. aadsm added a comment. Removed unnecessary comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96680/new/ https://reviews.llvm.org/D96680 Files:

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm updated this revision to Diff 325117. aadsm added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96680/new/ https://reviews.llvm.org/D96680 Files: lldb/test/API/tools/lldb-vscode/breakpoint-events/Makefile

[Lldb-commits] [PATCH] D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue

kastiglione added a comment. Good call on calling ShouldAutoContinue before Pop. Comment at: lldb/include/lldb/Target/ThreadPlan.h:354-359 + /// Returns whether this thread plan overrides the `ShouldStop` of previous + /// plans. + /// + /// When processing the thread plan

[Lldb-commits] [PATCH] D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue

jingham added a comment. This seems like a fine improvement. One little nit, I would ask the current plan ShouldAutoContinue before popping it. Popping the plan does call WillPop, so the plan does have a chance to react to being popped, and you don't know what it will do. So to be on the

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik updated this revision to Diff 325100. shafik added a comment. Herald added subscribers: usaxena95, kadircet. Fixing tests that I missed before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm.org/D96807 Files:

[Lldb-commits] [PATCH] D96947: [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandReturnObject.cpp:93 return; - GetOutputStream() << in_string << "\n"; + GetOutputStream() << in_string; + if (!in_string.endswith("\n")) How about rstripping any trailing `\n`

[Lldb-commits] [PATCH] D96917: [lldb] Rename {stop, run}_vote to report_{stop, run}_vote (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d3b9e5799f6: [lldb] Rename {stop,run}_vote to report_{stop,run}_vote (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 9d3b9e5 - [lldb] Rename {stop, run}_vote to report_{stop, run}_vote

Author: Dave Lee Date: 2021-02-19T13:04:53-08:00 New Revision: 9d3b9e5799f6b1ac3869df977c82304e0121d256 URL: https://github.com/llvm/llvm-project/commit/9d3b9e5799f6b1ac3869df977c82304e0121d256 DIFF: https://github.com/llvm/llvm-project/commit/9d3b9e5799f6b1ac3869df977c82304e0121d256.diff

[Lldb-commits] [PATCH] D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue

kastiglione added inline comments. Comment at: lldb/include/lldb/Target/ThreadPlan.h:354-359 + /// Returns whether this thread plan overrides the `ShouldStop` of previous + /// plans. + /// + /// When processing the thread plan stack, this function gives plans the + ///

[Lldb-commits] [PATCH] D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adjust `ShouldAutoContinue` to be available to any thread plan previous to the plan that

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

clayborg added a comment. In D96637#2573758 , @aadsm wrote: >> I don't think this does what you think it does. The $() doesn't give you the >> process id of anything -- it substitutes a string by the result of running >> that string as a shell command.

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

mgorny updated this revision to Diff 325021. mgorny added a comment. - fixed broken FreeBSD release check in lldb - fixed UB in FreeBSD's bp/wp impl - implemented changes requested in comments - refactored bp/wp code to use a few helper constants and utility functions Please let me know if you

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

mgorny marked 5 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextBreakWatchpoint_arm64.cpp:248 + // non 8-byte aligned addresses as well. + if (addr & 0x07) { +uint8_t watch_mask = (addr & 0x07) +

[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

amccarth added a comment. I'm in no position to evaluate the functionality of lldb on Windows. I've spent the last few months trying to understand why 900+ tests spontaneously started failing on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96840/new/

[Lldb-commits] [lldb] 0833128 - [lldb/Commands] Fix help text typo for 'breakpoint set' -a|--address.

Author: Jan Kratochvil Date: 2021-02-19T14:33:42+01:00 New Revision: 08331281af7bebf76d541cfb33d01dca22ed4d79 URL: https://github.com/llvm/llvm-project/commit/08331281af7bebf76d541cfb33d01dca22ed4d79 DIFF:

[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

mstorsjo added a comment. Ping, does this form look acceptable? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96840/new/ https://reviews.llvm.org/D96840 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

mgorny added a comment. In D96548#2571489 , @mhorne wrote: > I should also note that it is my intention to merge the FreeBSD watchpoint > patches into the 13.0 branch, in about a week's time. So your > `__FreeBSD_version` checks will need to be updated

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

mgorny added a comment. In D96548#2573954 , @omjavaid wrote: > In D96548#2573245 , @mgorny wrote: > >> In D96548#2572770 , @omjavaid wrote: >> >>> I am wondering Whats the

[Lldb-commits] [PATCH] D97017: [lldb-server] Exit the DataAvailableCallback loop when `done` or `interrupt` are set

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:950 // We are ready to exit the debug monitor. m_exit_now = true; m_mainloop.RequestTermination(); May be we can set m_exit_now