[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

jasonmolenda added subscribers: jingham, clayborg. jasonmolenda added a comment. Trying to reword my thinking a little more clearly. Process::ReadMemory - only works when you have a Process. Always reads directly from memory. Target::ReadMemory - can be used with or without a Process. 1. If

[Lldb-commits] [lldb] 7dbb427 - [lldb] Fix replaying TestMemoryRead.py from reproducer

Author: Jonas Devlieghere Date: 2021-04-12T21:10:09-07:00 New Revision: 7dbb4274ef92c32b02c427d4844f3ddfdd05ef58 URL: https://github.com/llvm/llvm-project/commit/7dbb4274ef92c32b02c427d4844f3ddfdd05ef58 DIFF:

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 PAC elf-core stack unwinder support

jasonmolenda added a comment. I think this will come down to, who wants to implement a patch that can set/get either form through Process API. The mask might be a more general format, so if Justin is willing to update his patch to that we can add Omair's test case to his patch? CHANGES

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 PAC elf-core stack unwinder support

justincohen added a comment. In D99944#2684280 , @jasonmolenda wrote: > Omair, Justin, what do you think here? I don't think it's especially hard to > accept this in terms of # of bits OR a mask, and we should use the more > general internal rep in

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

jasonmolenda added a comment. Hm, a little more thinking. Target::ReadMemory prefers a file cache if it is available. Process::ReadMemory only uses live memory. But Process::ReadMemory doesn't work when we have run lldb on a file and not run yet. e.g. % lldb (lldb) tar cr -d /tmp/b.out

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

jasonmolenda added a comment. I'm not super convinced on the setting. It seems like something you'd add some people could work around a mistake we've made here. I think we have two cases: Someone calls Target::ReadMemory prefer_file_cache=true on a writable section. This is an easy mistake

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

jasonmolenda added a comment. In D100338#2684550 , @aprantl wrote: > Another question for @jasonmolenda: Do you happen to know if the existing > `prefer_file_cache` mechanism applies relocations? We can test it to make sure like % cat >a.c char

[Lldb-commits] [lldb] 30f591c - [lldb] Disable TestLaunchProcessPosixSpawn.py with reproducers

Author: Jonas Devlieghere Date: 2021-04-12T18:32:10-07:00 New Revision: 30f591c3869f3bbe6eca1249dcef1b8337312de6 URL: https://github.com/llvm/llvm-project/commit/30f591c3869f3bbe6eca1249dcef1b8337312de6 DIFF:

[Lldb-commits] [lldb] 6c4f250 - Revert "[lldb] [gdb-remote client] Refactor handling qSupported"

Author: Ahmed Bougacha Date: 2021-04-12T18:06:09-07:00 New Revision: 6c4f2508e4278ac789230cb05f2bb56a8a7297dc URL: https://github.com/llvm/llvm-project/commit/6c4f2508e4278ac789230cb05f2bb56a8a7297dc DIFF:

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

aprantl added a comment. Another question for @jasonmolenda: Do you happen to know if the existing `prefer_file_cache` mechanism applies relocations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100338/new/ https://reviews.llvm.org/D100338

[Lldb-commits] [lldb] 3842de4 - [lldb] [gdb-remote client] Refactor handling qSupported

Author: Michał Górny Date: 2021-04-13T00:23:07+02:00 New Revision: 3842de49f6551f597b4c7c78caa8ba7003755cec URL: https://github.com/llvm/llvm-project/commit/3842de49f6551f597b4c7c78caa8ba7003755cec DIFF: https://github.com/llvm/llvm-project/commit/3842de49f6551f597b4c7c78caa8ba7003755cec.diff

[Lldb-commits] [PATCH] D100146: [lldb] [gdb-remote client] Refactor handling qSupported

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3842de49f655: [lldb] [gdb-remote client] Refactor handling qSupported (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D100140: [lldb] [gdb-remote server] Refactor handling qSupported

mgorny updated this revision to Diff 336977. mgorny added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100140/new/ https://reviews.llvm.org/D100140 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 PAC elf-core stack unwinder support

jasonmolenda added a comment. Hi Omair, sorry for the delay in looking at this. It seems like we have two overlapping patches here, @justincohen patch in https://reviews.llvm.org/D98886 and this one. I'm not convinced that we'll see a target where we have noncontiguous bits used for

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. I simplified the description at the top in light of feedback (some harder issues we are just punting on for now). @compnerd does this now look good to you then? Does anyone want to approve the libunwind said of things? Anything else this is waiting on?

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

aprantl added inline comments. Comment at: lldb/source/Target/Target.cpp:1760 + auto permissions = section_sp->GetPermissions(); + prefer_file_cache |= (permissions & ePermissionsWritable) == 0 && + (permissions & ePermissionsReadable) == 1;

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

aprantl added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Target/TargetProperties.td:180 +DefaultTrue, +Desc<"Enables reading bytes from the file cache instead of process when the address LLDB is reading from falls in a readable but

[Lldb-commits] [lldb] ba62ebc - [lldb] Disable Shell/Subporcess with reproducers

Author: Jonas Devlieghere Date: 2021-04-12T13:08:14-07:00 New Revision: ba62ebc48e8c424ce3a78ba01acda679d536dd47 URL: https://github.com/llvm/llvm-project/commit/ba62ebc48e8c424ce3a78ba01acda679d536dd47 DIFF:

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

wallace created this revision. wallace added reviewers: clayborg, aadsm. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff ass postRunCommands, which are the counterpart of the preRunCommands. TThey will be executed right

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jasonmolenda. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100338 Files:

[Lldb-commits] [PATCH] D100193: [lldb] Require x86 backend for a bunch of DWARF tests

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100193/new/ https://reviews.llvm.org/D100193

[Lldb-commits] [lldb] 5a5a94e - [lldb] Delete dead StackFrameList::Merge

Author: Raphael Isemann Date: 2021-04-12T14:49:20+02:00 New Revision: 5a5a94ed34b07079046ac81e7e97d980ce2c834f URL: https://github.com/llvm/llvm-project/commit/5a5a94ed34b07079046ac81e7e97d980ce2c834f DIFF:

[Lldb-commits] [PATCH] D100212: [lldb] Delete dead StackFrameList::Merge

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a5a94ed34b0: [lldb] Delete dead StackFrameList::Merge (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D100180: [lldb] Don't recursively load types of static member variables in the DWARF AST parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34c697c85e9d: [lldb] Dont recursively load types of static member variables in the DWARF AST… (authored by teemperor). Herald added a subscriber:

[Lldb-commits] [lldb] 34c697c - [lldb] Don't recursively load types of static member variables in the DWARF AST parser

Author: Raphael Isemann Date: 2021-04-12T14:37:07+02:00 New Revision: 34c697c85e9d0af11a72ac4df5578aac94a627b3 URL: https://github.com/llvm/llvm-project/commit/34c697c85e9d0af11a72ac4df5578aac94a627b3 DIFF:

[Lldb-commits] [PATCH] D100140: [lldb] [gdb-remote server] Refactor handling qSupported

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:843 - response.PutCString(";QThreadSuffixSupported+"); - response.PutCString(";QListThreadsInStopReply+"); - response.PutCString(";qEcho+");

[Lldb-commits] [PATCH] D100140: [lldb] [gdb-remote server] Refactor handling qSupported

mgorny updated this revision to Diff 336808. mgorny marked an inline comment as done. mgorny added a comment. Fix missing `QListThreadsInStopReply+`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100140/new/ https://reviews.llvm.org/D100140 Files:

[Lldb-commits] [PATCH] D100146: [lldb] [gdb-remote client] Refactor handling qSupported

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100146/new/ https://reviews.llvm.org/D100146 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D100140: [lldb] [gdb-remote server] Refactor handling qSupported

rovka added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:843 - response.PutCString(";QThreadSuffixSupported+"); - response.PutCString(";QListThreadsInStopReply+"); - response.PutCString(";qEcho+");

[Lldb-commits] [lldb] 428b17c - [LLDB] Fix buildbots breakage due to TestGuessLanguage.py

Author: Muhammad Omair Javaid Date: 2021-04-12T15:10:46+05:00 New Revision: 428b17ce70523b1c54cb89095fed39e84f5ca8fc URL: https://github.com/llvm/llvm-project/commit/428b17ce70523b1c54cb89095fed39e84f5ca8fc DIFF:

[Lldb-commits] [lldb] e3d3327 - [lldb] Remove reproducer from previous test run

Author: Jonas Devlieghere Date: 2021-03-30T10:11:20-07:00 New Revision: e3d3327edbf133da6ed50767eed4560a541a751d URL: https://github.com/llvm/llvm-project/commit/e3d3327edbf133da6ed50767eed4560a541a751d DIFF:

[Lldb-commits] [lldb] c62ef12 - [lldb] [test] Mark more lldb-server tests xfail on Windows

Author: Michał Górny Date: 2021-03-30T18:49:04+02:00 New Revision: c62ef12079bcc7ce72040dddaae13408b120d995 URL: https://github.com/llvm/llvm-project/commit/c62ef12079bcc7ce72040dddaae13408b120d995 DIFF: https://github.com/llvm/llvm-project/commit/c62ef12079bcc7ce72040dddaae13408b120d995.diff