[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

wallace added a comment. Btw, thanks for the conversation. This is being really helpful. > I'm not convinced that retaining only 1 decoded instruction in memory at a > time (under a TraverseInstructions callback) will be sufficient for the use > cases you've outlined. Let's say the user sets a

[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

vsk added a comment. In D103588#2806894 , @wallace wrote: > I've been thinking about what you said and I'm having second thoughts on my > implementation. I'll share more context: > > - I want to work in the short term on reverse debugging and

[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

JDevlieghere added a comment. In D103575#2804151 , @aprantl wrote: > I'm not sure I fully understand the suggestion: > >> I think we should just remove the functionality form the timer class again. >> I only added it there because of the macro. > > ...

Re: [Lldb-commits] [lldb] e05b03c - [lldb] Set return status to failed when adding a command error

Thanks! Jim > On Jun 9, 2021, at 1:44 AM, David Spickett wrote: > > I figured something would fail. I've reverted and will reland with fixed > tests. > > On Tue, 8 Jun 2021 at 22:17, Jim Ingham wrote: >> >> Hey, David, >> >> This commit seems to have caused a new failure in

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil updated this revision to Diff 350900. jankratochvil edited the summary of this revision. jankratochvil added a comment. This patch now requires: D101236 , D103910 and D103966 .

Re: [Lldb-commits] [lldb] e05b03c - [lldb] Set return status to failed when adding a command error

I figured something would fail. I've reverted and will reland with fixed tests. On Tue, 8 Jun 2021 at 22:17, Jim Ingham wrote: > > Hey, David, > > This commit seems to have caused a new failure in TestRegisters.py, e.g.: > >

[Lldb-commits] [PATCH] D103842: NFC: .clang-tidy: Inherit configs from parents to improve maintainability

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103842/new/ https://reviews.llvm.org/D103842 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D103842: NFC: .clang-tidy: Inherit configs from parents to improve maintainability

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5d56fec502f: NFC: .clang-tidy: Inherit configs from parents to improve maintainability (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103842: NFC: .clang-tidy: Inherit configs from parents to improve maintainability

dblaikie created this revision. dblaikie added reviewers: hokein, aaron.ballman, jyknight, mehdi_amini, kuhnel. Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob,

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:62 +// FIXME: Move it to ReservedBit4? +HANDLE_DI_FLAG((1 << 30), IsZeroSize) This would need to be handled better if approved. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil updated this revision to Diff 350361. jankratochvil added a comment. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, sstefan1, martong, hiraditya. Herald added a reviewer: shafik. Herald added a reviewer: jdoerfert. Herald added a reviewer: shafik. Herald added

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil added a comment. [Dwarf-Discuss] How to map [[no_unique_address]] into DWARF: http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2021-June/004825.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101237/new/

[Lldb-commits] [PATCH] D103483: [lldb] Convert the default constructor’s member initializers into default member initializers

teemperor accepted this revision. teemperor added a comment. This doesn't compile for me (on Linux): In file included from /home/teemperor/work/ci/llvm-project/lldb/unittests/Platform/PlatformAppleSimulatorTest.cpp:11: In file included from

[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

DavidSpickett added a comment. 1 failure on MacOS "lldb-api :: commands/register/register/register_command/TestRegisters.py", http://green.lab.llvm.org/green/blue/organizations/jenkins/lldb-cmake/detail/lldb-cmake/32693/pipeline/, hence the revert. Should be easy enough to fix the test logic.

[Lldb-commits] [lldb] db93e4e - Revert "[lldb] Set return status to failed when adding a command error"

Author: David Spickett Date: 2021-06-09T09:41:59+01:00 New Revision: db93e4e70aa453e5ba04ba0d9e01f581882b6c81 URL: https://github.com/llvm/llvm-project/commit/db93e4e70aa453e5ba04ba0d9e01f581882b6c81 DIFF: