[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:402-403 case DW_AT_type: - type = form_value; + if (!type.IsValid()) +type = form_value; break; What's the purpose of this?

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

jrtc27 added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:118 + + // Previous frames pc is in ra + row->SetRegisterLocationToRegister(pc_reg_num, ra_reg_num, true); Comment at: lldb/source/Plugins/ABI/RISCV/AB

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

kasper81 added a comment. > I think the main blocker for merging was testing. If it helps, I now have the > RISC-V server in my hands and I should be able to set up a buildbot soon. It certainly will help. Thank you! :) On July 27, 13.x will be branched out. If we can squeeze it in that would b

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2875107 , @kasper81 wrote: > Hi, I have my fingers crossed since this request was opened in 2019. It seems > like it compiles and usable to certain degree. Can this patch be merged and > included in llvm 13 as initi

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

kasper81 added a comment. Hi, I have my fingers crossed since this request was opened in 2019. It seems like it compiles and usable to certain degree. Can this patch be merged and included in llvm 13 as initial riscv64 support? We can then improve it subsequently if bugs show up. Otherwise it w

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 357643. Ericson2314 added a comment. Herald added a subscriber: whisperity. rebased, fixed some new DESTINATION Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 File

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 357642. Ericson2314 added a comment. Rebased, fixed unintersting conflicts, organized docs better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/t

[Lldb-commits] [PATCH] D105134: [jenkins] Update script to use cross-project lit test suite

This revision was automatically updated to reflect the committed changes. Closed by commit rZORGe48da4b7b382: [jenkins] Update script to use cross project lit test suite (authored by mib). Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105134/new/ htt

[Lldb-commits] [PATCH] D105134: [jenkins] Update script to use cross-project lit test suite

mib updated this revision to Diff 355494. mib added a comment. Address @jhenderson comment. Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105134/new/ https://reviews.llvm.org/D105134 Files: zorg/jenkins/jobs/jobs/lldb-cmake zorg/jenkins/jobs/jo

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I like the new detach/kill dialog as it incorporates many of your features that you added to the forms! Very close, just a few minor issues and this will be good to go. ==

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I guess Phabricator just sent this back to review automatically when you updated the diff? Just mark this as 'needs review' again when this is ready for review. I'll send this

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

rdhindsa updated this revision to Diff 358429. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732 Files: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp Index: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace dump ctf -f ` command

wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:31 +public: + HTRBlockMetadata(Thread &thread, TraceInstruction curr_instruction, + llvm::Optional next_instruction); const TraceInstruction &curr_instruction to a

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

wallace added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:2195-2197 +LoadSubCommand( +"stats", CommandObjectSP(new CommandObjectTraceDumpStats(interpreter))); } clayborg wrote: > Since we are iterating on this new com

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev added a comment. Two actions with an option: F17916215: 20210713-214929.png <https://reviews.llvm.org/F17916215> Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1838 + + FieldDelegateUP &GetField(int field_index) { return m_fields[f

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev updated this revision to Diff 358399. OmarEmaraDev marked 10 inline comments as done. OmarEmaraDev added a comment. - Return raw pointers instead of unique ones. - Add Show Advance Settings option. - Allow detaching and killing at the same time. - Allow detaching while keeping process

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:406 + virtual lldb::TypeSP + FindTypeForAutoReturnForDIE(const DWARFDIE &die, teemperor wrote: > If this is virtual then I guess `SymbolFileDWARFDwo` should overl

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

clayborg added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:155 + /// If \b false, print compact stats + virtual void DumpTraceStats(Thread &thread, Stream &s, bool verbose) = 0; + Are any statistics being dumped here? Maybe DumpTraceSummar

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1838 + + FieldDelegateUP &GetField(int field_index) { return m_fields[field_index]; } ---

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik updated this revision to Diff 358373. shafik added a comment. - Modified `FindTypeForAutoReturnForDIE` to take into account if we have multiple symbols with the same name. - Modified `ParseSubroutine` to take into account that case we get the definition first, this can happen when we set

[Lldb-commits] [PATCH] D105914: [lldb] Make TargetList iterable

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere requested review of this revision. Make it possible to iterate over the TargetList. https://reviews.llvm.org/D105914 Files: lldb/include/lldb/Target/TargetList.h Index: lldb/include/lldb/Target/TargetLi

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:118 + } + s.Printf("\nraw trace size %zu\n", *raw_size); + return; the presentation of this line could be better. Something like this would look nicer thread 1:

[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

DavidSpickett updated this revision to Diff 358277. DavidSpickett added a comment. clang-format the test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105178/new/ https://reviews.llvm.org/D105178 Files: lldb/source/Plugins/Process/Linux/Na

[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

DavidSpickett marked an inline comment as done. DavidSpickett added a comment. > This is actually independent of the tagged address ABI. Thanks for the info, I keep thinking I need to enable it but never do. Updated the test case and commit msg. Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

DavidSpickett updated this revision to Diff 358276. DavidSpickett added a comment. - Removed use of tagged address ABI - Set pointer tags with a function instead of generator intrinsic - Add a memory access to confirm mapping was done properly - Add a few more comments about mmap and others Repo

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev added a comment. Updated UI: F17912164: 20210713-170719.png <https://reviews.llvm.org/F17912164> Kill/Detach form. F17912163: 20210713-170734.png <https://reviews.llvm.org/F17912163> Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev updated this revision to Diff 358268. OmarEmaraDev added a comment. - Add kill/detach form. - Fix forms with no fields. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105655/new/ https://reviews.llvm.org/D105655 Files: lldb/source/Co

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev planned changes to this revision. OmarEmaraDev added a comment. Currently working on the detach/kill form. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2346 + return; + +if (process->GetShouldDetach()) { clayborg wrote: > We might w

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev updated this revision to Diff 358228. OmarEmaraDev marked 10 inline comments as done. OmarEmaraDev added a comment. - Use unique pointers for field delegates. - Fix typos in Select methods. - Set the process name to the main executable name by default. - Turn plugin name into a choice

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rG72748488addd: [lldb] Fix editline unicode on Linux (authored by jankratochvil). Repository: rG LLV

[Lldb-commits] [lldb] 7274848 - [lldb] Fix editline unicode on Linux

Author: Jan Kratochvil Date: 2021-07-13T12:37:53+02:00 New Revision: 72748488addd651beb7b60da462c721f3e175357 URL: https://github.com/llvm/llvm-project/commit/72748488addd651beb7b60da462c721f3e175357 DIFF: https://github.com/llvm/llvm-project/commit/72748488addd651beb7b60da462c721f3e175357.diff

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/tools/driver/Driver.cpp:872 + ::setlocale(LC_ALL, ""); + ::setlocale(LC_CTYPE, ""); + jankratochvil wrote: > teemperor