[Lldb-commits] [PATCH] D107015: Add "current" token for the -t option to "break set/modify"

JDevlieghere added a comment. Instead of using the token `current`, wouldn't it feel more natural to allow an empty value more natural? Would we reject that before we get to the option parsing code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, teemperor. JDevlieghere requested review of this revision. As I was trying to understand what `IRExecutionUnit::FindInSymbols` was doing, I couldn't help myself but refactor the code a little bit: - No else after return.

[Lldb-commits] [lldb] dfb6f7b - Revert "[lldb] [DWARF-5] Be lazier about loading .dwo files"

Author: Stella Stamenova Date: 2021-07-30T18:33:13-07:00 New Revision: dfb6f7b01595a0f4684615ed867c6c76e8ea51b3 URL: https://github.com/llvm/llvm-project/commit/dfb6f7b01595a0f4684615ed867c6c76e8ea51b3 DIFF:

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

stella.stamenova added a comment. In D100299#2917598 , @jankratochvil wrote: > In D100299#2917467 , @Eric wrote: > >> Is arm hardware necessary to test this, > > In this case it is not as it does not require

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

jankratochvil added a comment. In D100299#2917467 , @Eric wrote: > Is arm hardware necessary to test this, In this case it is not as it does not require linking. Usually I find easier to run it natively than to setup all the cross-compilation libraries

[Lldb-commits] [lldb] 8dfd6ca - [lldb] [DWARF-5] Be lazier about loading .dwo files

Author: Eric Leese Date: 2021-07-30T23:17:06+02:00 New Revision: 8dfd6cae9bd62ae5ef056b994ece2e98f1558830 URL: https://github.com/llvm/llvm-project/commit/8dfd6cae9bd62ae5ef056b994ece2e98f1558830 DIFF: https://github.com/llvm/llvm-project/commit/8dfd6cae9bd62ae5ef056b994ece2e98f1558830.diff

[Lldb-commits] [lldb] 7ad854c - [lldb] Fix remote macOS debugging on Apple Silicon

Author: Jonas Devlieghere Date: 2021-07-30T13:14:10-07:00 New Revision: 7ad854c41e2b08b8cd6aae1d3b6f22125512585b URL: https://github.com/llvm/llvm-project/commit/7ad854c41e2b08b8cd6aae1d3b6f22125512585b DIFF:

[Lldb-commits] [PATCH] D107179: [lldb] Fix remote macOS debugging on Apple Silicon

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ad854c41e2b: [lldb] Fix remote macOS debugging on Apple Silicon (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D107179: [lldb] Fix remote macOS debugging on Apple Silicon

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Nice fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107179/new/ https://reviews.llvm.org/D107179 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

Eric added a comment. Is arm hardware necessary to test this, or can the test be modified to cross-compile to arm to see what is going on? Is there a way to determine what build target the test bot is using? In any case the broken test doesn't exercise lldb at all so it could be separated

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

jankratochvil added a comment. In D100299#2917250 , @Eric wrote: > Would it make sense to turn the split-optimized test back into an x86 only > test, or just leave it out of the change as it's not actually testing a code > path that this changed? The

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

Eric added a comment. Would it make sense to turn the split-optimized test back into an x86 only test, or just leave it out of the change as it's not actually testing a code path that this changed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] fe23f0c - [lldb] Always codesign binaries on macOS

Author: Jonas Devlieghere Date: 2021-07-30T11:19:40-07:00 New Revision: fe23f0c73ab774e8765d221bdef3060c59294a02 URL: https://github.com/llvm/llvm-project/commit/fe23f0c73ab774e8765d221bdef3060c59294a02 DIFF:

[Lldb-commits] [lldb] c9308cc - [nfc] improve a simple call

Author: Walter Erquinigo Date: 2021-07-30T10:55:48-07:00 New Revision: c9308cc219066bcca0b320b1bc64fa4d5f3aa193 URL: https://github.com/llvm/llvm-project/commit/c9308cc219066bcca0b320b1bc64fa4d5f3aa193 DIFF:

[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new method SubSurface to the Surface class. The

Re: [Lldb-commits] [lldb] 5839976 - [nfc][trace] use formatv instead of the old Printf

It would be cleaner to use CommandReturnObject::AppendErrorWithFormatv. Jim > On Jul 29, 2021, at 7:05 PM, Walter Erquinigo via lldb-commits > wrote: > > > Author: Walter Erquinigo > Date: 2021-07-29T19:04:59-07:00 > New Revision: 5839976976bc018b674f45f56f8a13707b870443 > > URL: >

[Lldb-commits] [PATCH] D107179: [lldb] Fix remote macOS debugging on Apple Silicon

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a subscriber: kristof.beyls. JDevlieghere requested review of this revision. Update ARMGetSupportedArchitectureAtIndex to consider remote macOS debugging. Currently, it defaults to an iOS triple when

[Lldb-commits] [PATCH] D107161: [lldb] Fix lookup of .debug_loclists with split-dwarf

kimanh created this revision. kimanh edited the summary of this revision. kimanh added reviewers: labath, jankratochvil. kimanh published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch fixes the lookup of locations in .debug_loclists,

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

jankratochvil added a comment. In D100299#2916203 , @omjavaid wrote: > This fails on 32 bit Arm > https://lab.llvm.org/buildbot/#/builders/17/builds/9595 I have reverted it as it takes some time to build on arm32 to investigate it. Repository: rG

[Lldb-commits] [lldb] d0e6d94 - Revert "[lldb] [DWARF-5] Be lazier about loading .dwo files"

Author: Jan Kratochvil Date: 2021-07-30T14:54:27+02:00 New Revision: d0e6d946b6db87a6310c43aac1788345c8990182 URL: https://github.com/llvm/llvm-project/commit/d0e6d946b6db87a6310c43aac1788345c8990182 DIFF:

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

omjavaid added a comment. Herald added a subscriber: JDevlieghere. This fails on 32 bit Arm https://lab.llvm.org/buildbot/#/builders/17/builds/9595 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100299/new/ https://reviews.llvm.org/D100299

[Lldb-commits] [PATCH] D107153: [nfc] [osx] [lldb] Simplify code using GetDebugMapSymfile()

jankratochvil created this revision. jankratochvil added reviewers: clayborg, Eric, dblaikie. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. In D100299 I was not sure what can happen

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7b8ba103a84: [lldb] [DWARF-5] Be lazier about loading .dwo files (authored by Eric, committed by jankratochvil). Herald added a project: LLDB.

[Lldb-commits] [lldb] e7b8ba1 - [lldb] [DWARF-5] Be lazier about loading .dwo files

Author: Eric Leese Date: 2021-07-30T13:34:51+02:00 New Revision: e7b8ba103a8411fb25237727c3822d4c431e4814 URL: https://github.com/llvm/llvm-project/commit/e7b8ba103a8411fb25237727c3822d4c431e4814 DIFF: https://github.com/llvm/llvm-project/commit/e7b8ba103a8411fb25237727c3822d4c431e4814.diff

[Lldb-commits] [lldb] 98b5659 - [lldb][AArch64] Mark mismatched tags in tag read output

Author: David Spickett Date: 2021-07-30T11:47:58+01:00 New Revision: 98b5659b53ff93f3b68e48ea28ec54081196ae3b URL: https://github.com/llvm/llvm-project/commit/98b5659b53ff93f3b68e48ea28ec54081196ae3b DIFF:

[Lldb-commits] [PATCH] D106880: [lldb][AArch64] Mark mismatched tags in tag read output

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98b5659b53ff: [lldb][AArch64] Mark mismatched tags in tag read output (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG555cd03193c9: [lldb] Correct format of qMemTags type field (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 555cd03 - [lldb] Correct format of qMemTags type field

Author: David Spickett Date: 2021-07-30T11:06:57+01:00 New Revision: 555cd03193c9c098d787bec93eadfe43b179db9c URL: https://github.com/llvm/llvm-project/commit/555cd03193c9c098d787bec93eadfe43b179db9c DIFF:

[Lldb-commits] [PATCH] D107140: [lldb] Show memory tags in memory read output

DavidSpickett added a comment. Also Omair we talked about 13 backports to get MTE support to a good place. This is one that I think would be ok to not do so, given that tag reading can be done manually as needed and it has some complexity to be considered. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D107140: [lldb] Show memory tags in memory read output

DavidSpickett added reviewers: omjavaid, pcc. DavidSpickett added a subscriber: pcc. DavidSpickett added a comment. DumpDataExtractor has formatting unittests. Due to memory tags being read from the execution context there are no new unittests. (the existing ones pass) Also since this code

[Lldb-commits] [PATCH] D107140: [lldb] Show memory tags in memory read output

DavidSpickett created this revision. Herald added subscribers: mgrang, mgorny. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This extends DumpDataExtractor to also print memory tags if called with an execution context on a

[Lldb-commits] [PATCH] D106880: [lldb][AArch64] Mark mismatched tags in tag read output

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106880/new/ https://reviews.llvm.org/D106880

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

omjavaid added a comment. I suspect this change as culprit behind failure of various GUI tests randomly on various LLDB buildbots. I have reverted this change to see if its the real culprit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] fd18f0e - Revert "[LLDB][GUI] Expand selected thread tree item by default"

Author: Muhammad Omair Javaid Date: 2021-07-30T13:40:05+05:00 New Revision: fd18f0e84cca023df6cb19e88c07c0e2059f659b URL: https://github.com/llvm/llvm-project/commit/fd18f0e84cca023df6cb19e88c07c0e2059f659b DIFF:

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young updated this revision to Diff 362990. siger-young added a comment. Add integrated pages (Lua + Python) for scripting docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104281/new/ https://reviews.llvm.org/D104281 Files:

[Lldb-commits] [lldb] 577220e - [OpenCL] Add std flag aliases clc++1.0 and CLC++1.0

Author: Anastasia Stulova Date: 2021-07-30T09:19:26+01:00 New Revision: 577220e89866608e0706e3a2b9f8f48215e4e811 URL: https://github.com/llvm/llvm-project/commit/577220e89866608e0706e3a2b9f8f48215e4e811 DIFF:

[Lldb-commits] [PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG577220e89866: [OpenCL] Add std flag aliases clc++1.0 and CLC++1.0 (authored by Anastasia). Changed prior to commit:

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh added a comment. In D106355#2913605 , @jankratochvil wrote: > You can also consider coding `lldb-add-index` for better performance as that > is too much for my available time. I don't think that I'll get to it either. But we'll also evaluate