[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

mib updated this revision to Diff 364318. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107521/new/ https://reviews.llvm.org/D107521 Files: lldb/bindings/python/python-wrapper.swig lldb/include/lldb/Interpreter/ScriptedInterface.h

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

mib created this revision. mib added reviewers: JDevlieghere, teemperor. mib added a project: LLDB. Herald added a subscriber: mgorny. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch splits the previous `ScriptedProcessPythonInterface` into multiple

[Lldb-commits] [PATCH] D105182: [lldb] Add "memory tag write" command

jrtc27 added a comment. I'm concerned by the generality of the command "memory tag". Many different types of memory tagging exist, MTE is but one. CHERI uses memory tagging for something completely different (tracking valid capability, ie pointer provenance), and its tags make sense to read

[Lldb-commits] [PATCH] D106984: [lldb] [gdb-remote] Add eOpenOptionReadWrite for future gdb compat

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah sorry I missed this patch, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106984/new/ https://reviews.llvm.org/D106984

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM, thanks for updating the docs too. I have a separate platform implementation ("lldb-platform") that I wrote but it's not in wide use outside the apple lldb team, I'm not

[Lldb-commits] [PATCH] D107485: [nfc] [lldb] Prevent needless copies of DataExtractor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14f443030c1a: [nfc] [lldb] Prevent needless copies of DataExtractor (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 14f4430 - [nfc] [lldb] Prevent needless copies of DataExtractor

Author: Jan Kratochvil Date: 2021-08-04T20:35:53+02:00 New Revision: 14f443030c1acc4346589aee3c1c532dc00eae3a URL: https://github.com/llvm/llvm-project/commit/14f443030c1acc4346589aee3c1c532dc00eae3a DIFF:

[Lldb-commits] [PATCH] D106466: 3/3: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 364190. jankratochvil marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106466/new/ https://reviews.llvm.org/D106466 Files:

[Lldb-commits] [PATCH] D106466: 3/3: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil marked an inline comment as done. jankratochvil added a comment. In D106466#2922549 , @ikudrin wrote: > As far as I understand it, you need a specially constructed > `llvm::DWARFDebugRnglistTable` object so that >

[Lldb-commits] [PATCH] D107485: [nfc] [lldb] Prevent needless copies of DataExtractor

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, teemperor. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. This patch was created accidentally but I find it useful when I already

[Lldb-commits] [PATCH] D107434: fix D103172

clayborg added a comment. In D107434#2924761 , @teemperor wrote: > I think this part of the patch can just be reverted. Thanks for tracking this > down! Reverted the respective changes in > e4977f9cb58ff7820d0287ba309490af57787749 >

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance

emaste added a comment. LGTM, although in FreeBSD we don't have any backwards- or cross-compatibility issues to worry about. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107475/new/ https://reviews.llvm.org/D107475 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packats for GDB compliance

mgorny created this revision. mgorny added reviewers: krytarowski, labath, emaste, jasonmolenda, JDevlieghere, clayborg. Herald added a subscriber: delcypher. mgorny requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Use hexadecimal numbers

[Lldb-commits] [PATCH] D107434: fix D103172

wallace abandoned this revision. wallace added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107434/new/ https://reviews.llvm.org/D107434 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

jarin added a comment. Thanks for getting back to this, Raphael! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73191/new/ https://reviews.llvm.org/D73191 ___ lldb-commits mailing list

[Lldb-commits] [lldb] f2128ab - [LLDB] Skip flaky tests on Arm/AArch64 Linux bots

Author: Muhammad Omair Javaid Date: 2021-08-04T16:57:36+05:00 New Revision: f2128abec2030f6534d46f877e3ab2bcc3b5af4c URL: https://github.com/llvm/llvm-project/commit/f2128abec2030f6534d46f877e3ab2bcc3b5af4c DIFF:

[Lldb-commits] [PATCH] D107446: [lldb] Stop referencing "host_lib" in cmake files

thakis created this revision. thakis added reviewers: teemperor, JDevlieghere. thakis added a project: LLDB. Herald added a subscriber: mgorny. thakis requested review of this revision. lldb/tools/driver/CMakeLists.txt used to set host_lib to something until https://reviews.llvm.org/rG7b968969db

[Lldb-commits] [PATCH] D107444: [lldb] Remove a few unused .exports files

thakis created this revision. thakis added reviewers: teemperor, JDevlieghere. thakis added a project: LLDB. thakis requested review of this revision. They used to be referenced from the .xcodeproj files, but those are long gone. No behavior change. https://reviews.llvm.org/D107444 Files:

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

teemperor added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:43 + // In case of a full match, we insert functions with a matching mangled name. + if (name_type_mask & eFunctionNameTypeFull && die.GetMangledName() == name) {

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

This revision was automatically updated to reflect the committed changes. Closed by commit rGf968bd77bbcf: Reland [lldb/DWARF] Only match mangled name in full-name function lookup (with… (authored by jarin, committed by teemperor). Changed prior to commit:

[Lldb-commits] [lldb] f968bd7 - Reland "[lldb/DWARF] Only match mangled name in full-name function lookup (with accelerators)"

Author: Jaroslav Sevcik Date: 2021-08-04T12:50:13+02:00 New Revision: f968bd77bbcf142afdb74750e53485b044de3e5f URL: https://github.com/llvm/llvm-project/commit/f968bd77bbcf142afdb74750e53485b044de3e5f DIFF:

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

teemperor accepted this revision. teemperor added a comment. Herald added a subscriber: JDevlieghere. From what I can see the underlying problem with the import-std-module tests has been fixed at some point in the past (at least it doesn't reproduce anymore). I don't recall seeing a fix for the

[Lldb-commits] [PATCH] D107161: [lldb] Fix lookup of .debug_loclists with split-dwarf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0092dbcd80f2: [lldb] Fix lookup of .debug_loclists with split-dwarf (authored by kimanh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 0092dbc - [lldb] Fix lookup of .debug_loclists with split-dwarf

Author: Kim-Anh Tran Date: 2021-08-04T11:36:44+02:00 New Revision: 0092dbcd80f208f7becec002e70bad5b35a081cd URL: https://github.com/llvm/llvm-project/commit/0092dbcd80f208f7becec002e70bad5b35a081cd DIFF: https://github.com/llvm/llvm-project/commit/0092dbcd80f208f7becec002e70bad5b35a081cd.diff

[Lldb-commits] [PATCH] D107213: Disassemble AArch64 pc-relative address calculations & symbolicate

DavidSpickett added a comment. > Yeah, this is a very aarch64 specific thing in the generic symbolizer, but > it's not an especially large function so I didn't feel too bad about it. If > we started needing to handle multi-instruction sequences like this in the > symbolizer (where we save

[Lldb-commits] [PATCH] D107434: fix D103172

teemperor added a comment. I think this part of the patch can just be reverted. Thanks for tracking this down! Reverted the respective changes in e4977f9cb58ff7820d0287ba309490af57787749 Feel free to close this. I'll see

[Lldb-commits] [lldb] e4977f9 - [lldb] Partly revert "Allow range-based for loops over DWARFDIE's children"

Author: Raphael Isemann Date: 2021-08-04T11:05:08+02:00 New Revision: e4977f9cb58ff7820d0287ba309490af57787749 URL: https://github.com/llvm/llvm-project/commit/e4977f9cb58ff7820d0287ba309490af57787749 DIFF:

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

wallace added a comment. I found the issue: https://reviews.llvm.org/D107434 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103172/new/ https://reviews.llvm.org/D103172 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D107434: fix D103172

wallace created this revision. wallace added reviewers: teemperor, clayborg. Herald added a reviewer: shafik. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D103172 has a couple of mistakes when

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

wallace added subscribers: clayborg, wallace. wallace added a comment. This breaks debugging in many cases :( Many of my users started reporting crashes in LLDB when setting source line breakpoints. For example, a simple command like `(lldb) b TransAttr.cpp:758` causes a crash and has the

[Lldb-commits] [PATCH] D107213: Disassemble AArch64 pc-relative address calculations & symbolicate

jasonmolenda added a comment. Thanks so much for taking the time to read the patch over and make suggestions David. I cribbed the bit masking / manip from MachODump.cpp's SymbolizerSymbolLookUp but you're right about it being better with at least a little bit of comments about what is going on