[Lldb-commits] [PATCH] D107669: [trace] [intel pt] Create a "process trace save" command

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. discussed offline of some improvements to make CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107669/new/ https://reviews.llvm.org/D107669

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef28c78350db: [tests] [trace] Add a more comprehensive test for `thread trace export ctf`… (authored by Walter Erquinigo wall...@fb.com).

[Lldb-commits] [lldb] ef28c78 - [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

Author: Walter Erquinigo Date: 2021-08-11T20:50:10-07:00 New Revision: ef28c78350dbf2a5dff23ac7e5f2dc0a7c24e184 URL: https://github.com/llvm/llvm-project/commit/ef28c78350dbf2a5dff23ac7e5f2dc0a7c24e184 DIFF:

[Lldb-commits] [PATCH] D107669: [trace] [intel pt] Create a "process trace save" command

hanbingwang added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileSaver.cpp:87 +llvm::Expected +TraceIntelPTSessionFileSaver::BuildProcessesSection(lldb::ProcessSP _sp, +TraceIntelPT

[Lldb-commits] [PATCH] D107669: [trace] [intel pt] Create a "process trace save" command

hanbingwang updated this revision to Diff 365883. hanbingwang marked an inline comment as done. hanbingwang added a comment. *trace.h: -rename SaveToDisk() to SaveLiveTraceToDisk() *IntelPTDecoder.h, IntelPTDecoder.cpp: -removed GetRawTrace() *TraceIntelPT.h, TraceIntelPT.cpp: -removed

[Lldb-commits] [lldb] 7ce739a - Update gdbremote_testcase.py to allow new k-v pair in qMemoryRegionInfo

Author: Jason Molenda Date: 2021-08-11T17:34:52-07:00 New Revision: 7ce739a87834785e2ddbc893fc833346413d360f URL: https://github.com/llvm/llvm-project/commit/7ce739a87834785e2ddbc893fc833346413d360f DIFF: https://github.com/llvm/llvm-project/commit/7ce739a87834785e2ddbc893fc833346413d360f.diff

[Lldb-commits] [lldb] 2b30fc2 - Fix two bugs with stack corefiles patch, restrict test built debugserver

Author: Jason Molenda Date: 2021-08-11T17:19:31-07:00 New Revision: 2b30fc2ff3cadd085f7103cb953cd9cf091ee9b9 URL: https://github.com/llvm/llvm-project/commit/2b30fc2ff3cadd085f7103cb953cd9cf091ee9b9 DIFF: https://github.com/llvm/llvm-project/commit/2b30fc2ff3cadd085f7103cb953cd9cf091ee9b9.diff

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

jingham added a comment. In D107869#2940428 , @clayborg wrote: > In D107869#2940016 , @OmarEmaraDev > wrote: > >> @jingham I wasn't arguing that we should remove those environment variables, >> on the contrary.

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

clayborg added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3223 + +const Environment _environment = target->GetEnvironment(); +m_enviroment_field->AddEnvironmentVariables(target_environment); Does this currently get all target

[Lldb-commits] [lldb] f899445 - [lldb] Fix TestFormattersBoolRefPtr on AS

Author: Jonas Devlieghere Date: 2021-08-11T14:55:39-07:00 New Revision: f89944530726f7b315b30670a7e1f93d0cd926f0 URL: https://github.com/llvm/llvm-project/commit/f89944530726f7b315b30670a7e1f93d0cd926f0 DIFF:

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

clayborg added a comment. In D107869#2940016 , @OmarEmaraDev wrote: > @jingham I wasn't arguing that we should remove those environment variables, > on the contrary. Greg was suggesting that we populate the environment field > with the target

[Lldb-commits] [lldb] 9f4b130 - [lldb] Replace assertTrue(foo in bar) with assertIn(foo, bar)

Author: Jonas Devlieghere Date: 2021-08-11T14:40:21-07:00 New Revision: 9f4b130defc17cbb107ca2186ef6b0f0ff649fd3 URL: https://github.com/llvm/llvm-project/commit/9f4b130defc17cbb107ca2186ef6b0f0ff649fd3 DIFF:

[Lldb-commits] [lldb] 3f96438 - [lldb] Skip TestConcurrent.* watchpoint tests for Darwin on ARM

Author: Jonas Devlieghere Date: 2021-08-11T14:26:31-07:00 New Revision: 3f96438c201e933809fabc39368686884b98f057 URL: https://github.com/llvm/llvm-project/commit/3f96438c201e933809fabc39368686884b98f057 DIFF:

[Lldb-commits] [lldb] b97afc9 - [lldb] Update MemoryRegionInfo ctors in unit tests

Author: Jonas Devlieghere Date: 2021-08-11T14:13:41-07:00 New Revision: b97afc9dc0e96116b1369e4dbbcf9ada698b8802 URL: https://github.com/llvm/llvm-project/commit/b97afc9dc0e96116b1369e4dbbcf9ada698b8802 DIFF:

[Lldb-commits] [PATCH] D107931: [lldb] [gdb-remote] Implement vRun packet [WIP]

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jasonmolenda, JDevlieghere. mgorny requested review of this revision. Implement the simpler vRun packet and prefer it over the A packet. Unlike the latter, it tranmits command-line arguments without redundant

[Lldb-commits] [lldb] 767496d - [lldb] Skip TestStepOverWatchpoint on AS

Author: Jonas Devlieghere Date: 2021-08-11T13:43:12-07:00 New Revision: 767496d19cb9a1fbba57ff08095faa161998ee36 URL: https://github.com/llvm/llvm-project/commit/767496d19cb9a1fbba57ff08095faa161998ee36 DIFF:

[Lldb-commits] [PATCH] D107625: Add a stack-memory-only style for Darwin process save-core

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8c31efeed600: Add the ability to process save-core

[Lldb-commits] [lldb] 8c31efe - Add the ability to process save-core stack-memory-only corefiles

Author: Jason Molenda Date: 2021-08-11T13:37:31-07:00 New Revision: 8c31efeed6007bade1e4ddda2ceccab311661cbc URL: https://github.com/llvm/llvm-project/commit/8c31efeed6007bade1e4ddda2ceccab311661cbc DIFF: https://github.com/llvm/llvm-project/commit/8c31efeed6007bade1e4ddda2ceccab311661cbc.diff

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

don't > think we should show those to the user, we should transparently add them > instead and let the user add additional variables as needed. We can then look > into adding other settings to exclude them if necessary. > > F18486746: 20210811-210121.png <https://reviews.llvm.or

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev updated this revision to Diff 365825. OmarEmaraDev added a comment. - Address review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107869/new/ https://reviews.llvm.org/D107869 Files: lldb/source/Core/IOHandlerCursesGUI.cpp Index:

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

variables as needed. We can then look into adding other settings to exclude them if necessary. F18486746: 20210811-210121.png <https://reviews.llvm.org/F18486746> Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107869/new/ https://reviews.ll

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

jingham added a comment. In D107869#2939922 , @OmarEmaraDev wrote: > One thing to note as well is that the target environment seem to include many > environment variables like PATH and HOME, I don't think those should be > included. If I am debugging

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev added a comment. One thing to note as well is that the target environment seem to include many environment variables like PATH and HOME, I don't think those should be included. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D106743: [lldb][NFC] Define DWARFDIE::children out-of-line instead of using template magic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2c262cfb12f: [lldb][NFC] Define DWARFDIE::children out-of-line instead of using template… (authored by teemperor). Herald added a subscriber:

[Lldb-commits] [lldb] b2c262c - [lldb][NFC] Define DWARFDIE::children out-of-line instead of using template magic

Author: Raphael Isemann Date: 2021-08-11T19:19:41+02:00 New Revision: b2c262cfb12f4fb43177759426b1c6128d4236e4 URL: https://github.com/llvm/llvm-project/commit/b2c262cfb12f4fb43177759426b1c6128d4236e4 DIFF:

[Lldb-commits] [lldb] be556d5 - [lldb/Commands] Fix heap-use-after-free error in CommandObjectProcess

Author: Med Ismail Bennani Date: 2021-08-11T17:03:20+01:00 New Revision: be556d5131d56f285e55b0548f3b953d55d055c4 URL: https://github.com/llvm/llvm-project/commit/be556d5131d56f285e55b0548f3b953d55d055c4 DIFF:

[Lldb-commits] [PATCH] D106466: 3/3: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

ikudrin added a comment. In D106466#2926185 , @jankratochvil wrote: > In D106466#2922549 , @ikudrin wrote: > >> As far as I understand it, you need a specially constructed >> `llvm::DWARFDebugRnglistTable`

[Lldb-commits] [PATCH] D107470: 2/3: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

ikudrin added inline comments. Comment at: llvm/unittests/DebugInfo/DWARF/DWARFListTableTest.cpp:128 + EXPECT_EQ(Table.getAddrSize(), 8U); + Extractor.setAddressSize(Table.getAddrSize()); + Expected List = Table.findList(Extractor, Offset); This looks odd.

[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

teemperor added a comment. In D107079#2914111 , @aprantl wrote: > More a comment than anything else: One thing I always wanted to explore was > to implement LLDB's logging on Darwin on top of os_log >

[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

teemperor added a comment. In D107079#2918185 , @jasonmolenda wrote: > Sorry for not commenting on this on earlier, I wanted to think about it a bit. > > I think the usefulness of this can depend on the type of logging. l often > turn on gdb-remote

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:519 +contribution->Length); +return DWARFDataExtractor(); + } Here could be an error message. Comment at:

[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

teemperor updated this revision to Diff 365737. teemperor retitled this revision from "[lldb] Change the log format to JSON instead of plain text" to "[lldb] Add an option for emitting LLDB logs as JSON". teemperor edited the summary of this revision. teemperor added a comment. Herald added

[Lldb-commits] [lldb] b136290 - [lldb][docs] Remove index entry to removed StructuredDataPlugins

Author: Raphael Isemann Date: 2021-08-11T13:47:04+02:00 New Revision: b136290bc46c6751ea59acfa97d7ac5ca044ded1 URL: https://github.com/llvm/llvm-project/commit/b136290bc46c6751ea59acfa97d7ac5ca044ded1 DIFF:

[Lldb-commits] [lldb] f6748b2 - [lldb][NFC] Fix small format error in TestCppVirtualFunctions

Author: Raphael Isemann Date: 2021-08-11T12:26:56+02:00 New Revision: f6748b24d4d731b3b60d97c20a1a29e66472ce66 URL: https://github.com/llvm/llvm-project/commit/f6748b24d4d731b3b60d97c20a1a29e66472ce66 DIFF:

[Lldb-commits] [lldb] 7377997 - [lldb] Rework 'lldb' substitution workaround in dwarf5-lazy-dwo.c

Author: Raphael Isemann Date: 2021-08-11T12:12:25+02:00 New Revision: 737799713451a59ec2c2a84ea2daeceaf32ff1d5 URL: https://github.com/llvm/llvm-project/commit/737799713451a59ec2c2a84ea2daeceaf32ff1d5 DIFF:

[Lldb-commits] [PATCH] D100206: [lldb] [llgs client] Support minimal fork/vfork handling

mgorny added a comment. @JDevlieghere, any chance you could look at this, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100206/new/ https://reviews.llvm.org/D100206 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3237-3240 +} else { + action.Open(STDIN_FILENO, dev_null, true, false); + launch_info.AppendFileAction(action); +} clayborg wrote: > We don't need to do