[Lldb-commits] [lldb] 5a95ff2 - [lldb] Fix -Wunused-but-set-variable

Author: Fangrui Song Date: 2021-08-16T16:41:17-07:00 New Revision: 5a95ff2bfcc191f3ffecb69ac1d762a93b149eee URL: https://github.com/llvm/llvm-project/commit/5a95ff2bfcc191f3ffecb69ac1d762a93b149eee DIFF: https://github.com/llvm/llvm-project/commit/5a95ff2bfcc191f3ffecb69ac1d762a93b149eee.diff

[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

clayborg added a comment. Everyone uses this for any assembly in their code. Should we get rid of this warning? I find it is useless and would like to see it go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101406/new/

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. In D108061#2947526 , @rdhindsa wrote: > Reverted code changes from ObjectFileELF as suggested and added directly to >

[Lldb-commits] [PATCH] D107669: [trace] [intel pt] Create a "process trace save" command

wallace accepted this revision. wallace added a comment. good job CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107669/new/ https://reviews.llvm.org/D107669 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] aa575ed - Ah, fix formatting, I didn't notice lldb-instr's code

Author: Jason Molenda Date: 2021-08-16T13:46:54-07:00 New Revision: aa575ed918632358b65da3e161d55254092b7416 URL: https://github.com/llvm/llvm-project/commit/aa575ed918632358b65da3e161d55254092b7416 DIFF: https://github.com/llvm/llvm-project/commit/aa575ed918632358b65da3e161d55254092b7416.diff

[Lldb-commits] [lldb] 65bc8ba - Correctly update reproducer hooks for SB API I added

Author: Jason Molenda Date: 2021-08-16T13:41:18-07:00 New Revision: 65bc8ba1a2d434ba72f6f476bfd4a9ae69cb16b2 URL: https://github.com/llvm/llvm-project/commit/65bc8ba1a2d434ba72f6f476bfd4a9ae69cb16b2 DIFF: https://github.com/llvm/llvm-project/commit/65bc8ba1a2d434ba72f6f476bfd4a9ae69cb16b2.diff

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

dblaikie added a comment. I assume there's already test coverage for rnglistx in debug_info.dwo/split unit? (because in that case there's no rnglists_base, but rnglistx is usable) - could you explain how this code avoids treating the split unit rnglists_base == 0 case as "there is no

[Lldb-commits] [PATCH] D107669: [trace] [intel pt] Create a "process trace save" command

hanbingwang updated this revision to Diff 366713. hanbingwang marked an inline comment as not done. hanbingwang added a comment. merge into one line: "json_module["loadAddress"] = oss.str();" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107669/new/ https://reviews.llvm.org/D107669

[Lldb-commits] [PATCH] D107761: [LLDB][GUI] Refactor form drawing using subsurfaces

OmarEmaraDev added a comment. @clayborg Perhaps you missed this, it is essential the same as D107182 but without the unsupported function. It would be good to have this committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa updated this revision to Diff 366692. rdhindsa added a comment. Reverted code changes from ObjectFileELF as suggested and added directly to DYLDRendezvous.cpp. Is there a better place to place the test, or is it okay to keep under ObjectFile. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D107669: [trace] [intel pt] Create a "process trace save" command

hanbingwang updated this revision to Diff 366690. hanbingwang added a comment. *TraceIntelPT.h, TraceIntelPT.cpp: -add new function GetLiveProcess() *TraceIntelPTSessionSaver.h, TraceIntelPTSessionSaver.cpp - the function SaveToDisk() no longer requires "m_live_process" as input param.

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil updated this revision to Diff 366684. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107470/new/ https://reviews.llvm.org/D107470 Files: lldb/unittests/SymbolFile/DWARF/DWARFUnitTest.cpp

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil marked 3 inline comments as done. jankratochvil added a comment. In D107470#2946689 , @ikudrin wrote: > `DWARFDebugInfo.TestRnglistsAddressSize`, > `DWARFListTableHeader.AddressSize64Offset`, and >

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 366676. jankratochvil edited the summary of this revision. jankratochvil added a comment. @dblaikie do you think it is OK for check-in now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106466/new/

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Thanks for getting to this. I had a diff going a few weeks ago, but never got things fully working! Comment at: lldb/include/lldb/Symbol/ObjectFile.h:465-479

[Lldb-commits] [PATCH] D108148: [lldb] [gdb-remote] Use standardized GDB errno values

mgorny created this revision. mgorny added reviewers: krytarowski, emaste, JDevlieghere, labath, jasonmolenda. mgorny requested review of this revision. GDB uses normalized errno values for vFile errors. Implement the translation between them and system errno values in the gdb-remote plugin.

[Lldb-commits] [PATCH] D108121: [lldb] Add tests for TypeSystemMap::GetTypeSystemForLanguage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf521e78dfd2: [lldb] Add tests for TypeSystemMap::GetTypeSystemForLanguage (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [lldb] cf521e7 - [lldb] Add tests for TypeSystemMap::GetTypeSystemForLanguage

Author: Raphael Isemann Date: 2021-08-16T18:00:01+02:00 New Revision: cf521e78dfd2a418970358e5d55dcc9a862664e5 URL: https://github.com/llvm/llvm-project/commit/cf521e78dfd2a418970358e5d55dcc9a862664e5 DIFF:

[Lldb-commits] [PATCH] D108088: [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5033f0793fe6: [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage (authored by dim). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 5033f07 - [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage

Author: Dimitry Andric Date: 2021-08-16T17:34:42+02:00 New Revision: 5033f0793fe6e8b36990e6ce9f9ec2bf2ff79923 URL: https://github.com/llvm/llvm-project/commit/5033f0793fe6e8b36990e6ce9f9ec2bf2ff79923 DIFF:

[Lldb-commits] [PATCH] D108078: [lldb] Support gdbserver signals

mgorny updated this revision to Diff 366621. mgorny retitled this revision from "[lldb] Support gdbserver signals [WIP]" to "[lldb] Support gdbserver signals". mgorny edited the summary of this revision. mgorny added a comment. Included all signals from `include/gdb/signals.def`. CHANGES SINCE

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

ikudrin added a comment. `DWARFDebugInfo.TestRnglistsAddressSize`, `DWARFListTableHeader.AddressSize64Offset`, and `DWARFListTableHeader.AddressSize32Offset` pass without applying the patch. Why adding them? Comment at:

[Lldb-commits] [PATCH] D108088: [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks for fixing this (and cleaning up the code), LGTM. I wrote some regression tests for this in D108121 that I'll land as a follow-up.

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

tammela requested changes to this revision. tammela added a comment. This revision now requires changes to proceed. Missing test cases! Either a script that test it all, individual unit tests or a combination of both. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

tammela added inline comments. Comment at: lldb/bindings/lua/lua-typemaps.swig:198 + size_t size = lua_rawlen(L, $input); + $1 = (char **)malloc((size + 1) * sizeof(char *)); + int i = 0, j = 0; This seems it could leak. Are you sure it doesn't?

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

ikudrin added a comment. The code looks good, but please improve the comments and wait for approval from a more LLDB-knowledgeable person than me, Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:441 + if (offset == 0) { +// Caller must not use this default