[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa updated this revision to Diff 367715. rdhindsa added a comment. Updated to extract executable file name using GetMemoryRegionInfo since ld.so returns empty file name for executable file name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367688. saschwartz marked an inline comment as done. saschwartz added a comment. Fix one missed return nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files:

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367685. saschwartz added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files:

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz added a comment. Responded to comments - will tidy up the nits. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:289 fprintf(stderr, "failed to create acceptor: %s", error.AsCString()); -exit(socket_error); +return -1; }

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

clayborg added a comment. The code to get a memory region is on the process: virtual Status Process::GetMemoryRegionInfo(lldb::addr_t load_addr, MemoryRegionInfo _info); Then the memory region info might have a valid name: ConstString region_name = range_info.GetName(); My guess in that

[Lldb-commits] [PATCH] D108414: [LLDB][GUI] Handle extra navigation keys in forms

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch handles the up and down keys if they weren't handled

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9c5613e856c: Update logic to close inherited file descriptors. (authored by rdhindsa). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D108410: [LLDB][GUI] Add submit form key combination

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new key ALt+Enter key combination to form

[Lldb-commits] [PATCH] D100206: [lldb] [llgs client] Support minimal fork/vfork handling

mgorny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100206/new/ https://reviews.llvm.org/D100206 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. Looking further as to why executable symbols are not loaded, it looks like when we read the link_map in lldb, AddSOEntries() is called for all the entries in link_map read from ld.so. The first entry's name(which corresponds to executable) is empty, which seems to be

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:289 fprintf(stderr, "failed to create acceptor: %s", error.AsCString()); -exit(socket_error); +return -1; } clayborg wrote: > Should we return error.GetError()

[Lldb-commits] [PATCH] D108331: [LLDB][GUI] Handle return key for compound fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28a76049c66f: [LLDB][GUI] Handle return key for compound fields (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github

[Lldb-commits] [lldb] 28a7604 - [LLDB][GUI] Handle return key for compound fields

Author: Omar Emara Date: 2021-08-19T11:46:30-07:00 New Revision: 28a76049c66f7a09ab6d34e59ccc3532dae965dc URL: https://github.com/llvm/llvm-project/commit/28a76049c66f7a09ab6d34e59ccc3532dae965dc DIFF: https://github.com/llvm/llvm-project/commit/28a76049c66f7a09ab6d34e59ccc3532dae965dc.diff

[Lldb-commits] [PATCH] D108331: [LLDB][GUI] Handle return key for compound fields

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just tried this out! Very nice. Improves the usability of the forms a lot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108331/new/

[Lldb-commits] [PATCH] D108395: [lldb] Delete IRExecutionUnit::CollectCandidateCPlusPlusNames

bulbazord created this revision. bulbazord added reviewers: clayborg, jingham, teemperor, JDevlieghere. Herald added a subscriber: mgorny. bulbazord requested review of this revision. Herald added a project: LLDB. My goal is to remove lldbExpression's dependence on lldbPluginCPlusPlusLanguage. I

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

clayborg added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:289 fprintf(stderr, "failed to create acceptor: %s", error.AsCString()); -exit(socket_error); +return -1; } Should we return error.GetError() if it is non zero?

[Lldb-commits] [lldb] 4947f6d - [lldb][NFC] Remove unused header include

Author: Alex Langford Date: 2021-08-19T11:06:56-07:00 New Revision: 4947f6d8bca1e33a663b01e3027e11d654c418fc URL: https://github.com/llvm/llvm-project/commit/4947f6d8bca1e33a663b01e3027e11d654c418fc DIFF: https://github.com/llvm/llvm-project/commit/4947f6d8bca1e33a663b01e3027e11d654c418fc.diff

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Eh, I didn't want to accept this now. Just marking this as 'request changes' so it goes back to you for the last few things. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Some nits but this LGTM, thanks! I'll accept & land this for you once the last few things are addressed :) Comment at: lldb/tools/lldb-server/lldb-server.cpp:59

[Lldb-commits] [PATCH] D108385: [LLDB][GUI] Add extra keys to text field

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds many new keys to the text field and implements

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367508. saschwartz added a comment. Fix lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files: lldb/test/Shell/lldb-server/TestErrorMessages.test

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:324 WithColor::error() << error.AsCString() << '\n'; - exit(socket_error); + return socket_error; } teemperor wrote: > FWIW, `socket_error` seems to be

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367498. saschwartz added a comment. Use `make_scope_exit` to avoid superfluous return variable declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files:

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Sorry for the delay on this! Feel free to ping sooner if this gets stuck again. I think just passing a string here seems fine, but maybe we could let the function just take a

[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

dim added a comment. In D101406#2950731 , @aprantl wrote: >> This can't have been the intention of this commit? As far as I can see, >> there *is* no plugin for plain assembler? ... > Yes, there is no plugin for the language assembler. But that hasn't

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for the patch (and tests!), this LGTM for the most part. I'm maybe being nitpicky here, but could we replace all the `ret = ...` stuff and `exit(...)` with just `return

[Lldb-commits] [PATCH] D108078: [lldb] Support gdbserver signals

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1344 "qEcho+", + "native-signals+", }; JDevlieghere wrote: > What about

[Lldb-commits] [PATCH] D108078: [lldb] Support gdbserver signals

mgorny updated this revision to Diff 367414. mgorny added a comment. Advertise `native-signals+` in debugserver too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108078/new/ https://reviews.llvm.org/D108078 Files: