[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Thanks for moving over into object file. See inlined comments, we should be able to get this down to just the SaveCore and other static functions that just return nothing. Let

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

clayborg added a comment. In D108545#2962017 , @OmarEmaraDev wrote: > @clayborg I was planning on getting to field completion later as part of a > global "context window" feature. There are reasons why I need this as a full > separate window for now.

[Lldb-commits] [lldb] 120d97b - Revert "[lldb] Add support for debugging via the dynamic linker."

Author: Rumeet Dhindsa Date: 2021-08-24T15:20:52-07:00 New Revision: 120d97b1a7a81561bb02fc7cd5dc304ef5cbe1cf URL: https://github.com/llvm/llvm-project/commit/120d97b1a7a81561bb02fc7cd5dc304ef5cbe1cf DIFF:

[Lldb-commits] [lldb] d7e2e97 - [LLDB] Remove typos from NativeRegisterContextLinux_arm*

Author: Muhammad Omair Javaid Date: 2021-08-25T02:55:38+05:00 New Revision: d7e2e9794a3e353e60a956140dcab93980a2a989 URL: https://github.com/llvm/llvm-project/commit/d7e2e9794a3e353e60a956140dcab93980a2a989 DIFF:

[Lldb-commits] [lldb] ce512d5 - Revert "[lldb] Refactor Module::LookupInfo constructor"

Author: Alex Langford Date: 2021-08-24T14:52:17-07:00 New Revision: ce512d5c2af58515378f5ecd989cdc0ccea8c997 URL: https://github.com/llvm/llvm-project/commit/ce512d5c2af58515378f5ecd989cdc0ccea8c997 DIFF: https://github.com/llvm/llvm-project/commit/ce512d5c2af58515378f5ecd989cdc0ccea8c997.diff

[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd2134e42aa7: [lldb] Refactor Module::LookupInfo constructor (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] cd2134e - [lldb] Refactor Module::LookupInfo constructor

Author: Alex Langford Date: 2021-08-24T13:53:49-07:00 New Revision: cd2134e42aa7d1168a3ed54e41793b022f961b1f URL: https://github.com/llvm/llvm-project/commit/cd2134e42aa7d1168a3ed54e41793b022f961b1f DIFF: https://github.com/llvm/llvm-project/commit/cd2134e42aa7d1168a3ed54e41793b022f961b1f.diff

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cbdc07ec015: [lldb] Add support for debugging via the dynamic linker. (authored by rdhindsa). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 1cbdc07 - [lldb] Add support for debugging via the dynamic linker.

Author: Rumeet Dhindsa Date: 2021-08-24T13:41:22-07:00 New Revision: 1cbdc07ec015d83038c08dc562d55eccfd808591 URL: https://github.com/llvm/llvm-project/commit/1cbdc07ec015d83038c08dc562d55eccfd808591 DIFF:

Re: [Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

> On Aug 24, 2021, at 11:57 AM, Roman Podoliaka via Phabricator > wrote: > > malor added a comment. > > In D108510#2961332 , @jingham wrote: > >> One of the key reasons to use "frame recognizers" is to provide argument >> values to functions that

[Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

malor added a comment. In D108510#2961332 , @jingham wrote: > One of the key reasons to use "frame recognizers" is to provide argument > values to functions that don't have debug information. That generally only > works when stopped at the first

[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:73 + llvm::StringRef basename = method.GetBasename(); + if (basename.empty()) { +if (CPlusPlusLanguage::ExtractContextAndIdentifier( jingham wrote: >

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. Thank you for the review and suggestion to check memory region. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108061/new/ https://reviews.llvm.org/D108061 ___ lldb-commits

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3592 +m_selected_match(0), m_first_visible_match(0) { +; + } OmarEmaraDev wrote: > clayborg wrote: > > Should we be doing just like any other dialog that we have

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev added a comment. @clayborg I was planning on getting to field completion later as part of a global "context window" feature. There are reasons why I need this as a full separate window for now. Imminently, I am creating an operator that changes the file in the sources window so

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

clayborg added a comment. I like the look of this. It seems we would want this kind of auto complete in many fields that we already have, like the file or directory dialogs to start with. My main question is do we need a full window for this, or can be paint a window that is just the search