[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Move best-practices.txt contain to resources/test.rst

xgupta added a comment. I will ask for commit access and commit it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO

JDevlieghere added a comment. Nice catch, LGTM but I'll defer to Greg to accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108889/new/ https://reviews.llvm.org/D108889 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Move best-practices.txt contain to resources/test.rst

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks for the quick turnaround! This LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369376. xgupta added a comment. restore a blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/resources/test.rst

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369375. xgupta added a comment. remove best-practice.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/index.rst lldb/docs/resources/test.rst

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added a comment. In D108812#2971657 , @JDevlieghere wrote: > I'm not convinced this warrants a whole new section. Especially since this is > focussed on lldb developers rather than end users. Could we move this under > the resources/test page?

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369374. xgupta added a comment. Move testsuite/best-practice comtain to resources/test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/index.rst

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. I'm not convinced this warrants a whole new section. Especially since this is focussed on lldb developers rather than end users. Could we move this under the

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added inline comments. Comment at: lldb/docs/testsuite/best-practices.rst:53 + +Cleanup after yourself +-- teemperor wrote: > This section here seems very outdated, can we just delete it? sure Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369328. xgupta added a comment. Remove an outdated paragraph Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/index.rst

[Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54c496dad6f2: [lldb] Allow to register frame recognizers applied beyond the first instruction (authored by malor, committed by mib). Repository:

[Lldb-commits] [lldb] 54c496d - [lldb] Allow to register frame recognizers applied beyond the first instruction

Author: Roman Podoliaka Date: 2021-08-29T17:28:46+02:00 New Revision: 54c496dad6f28f1ab663f1b30401fe460709d50d URL: https://github.com/llvm/llvm-project/commit/54c496dad6f28f1ab663f1b30401fe460709d50d DIFF:

[Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

mib added a comment. Hi Roman, thanks for your patch. It also looks good to me, so I'll land it for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108510/new/ https://reviews.llvm.org/D108510 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

malor added a comment. Thank you, Jim! Would you be able to submit this change? The clang-tidy premerge check has failed, but I don't think it's actionable: it's complaining about an #include in the file that I'm not modifying -- I saw it failing in the same way (although, on different files)

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:549 +bool is_interesting = false; +for (size_t interesting_address : interesting_addresses) + if (interesting_address >= addr && interesting_address < addr +

[Lldb-commits] [PATCH] D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO

jasonmolenda added a comment. I should note two more things. First, I make this code which was previously checking if the ObjectFile was a memory image unconditional if the dSYM's segment file address differs from the ObjectFile's segment file address. I can't see how this is possible in any

[Lldb-commits] [PATCH] D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO

jasonmolenda created this revision. jasonmolenda added a reviewer: clayborg. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. This is addressing a regression introduced by Greg's change in https://reviews.llvm.org/D86122

[Lldb-commits] [PATCH] D108888: Improve error messaging on process connect errors

jasonmolenda created this revision. jasonmolenda added a reviewer: clayborg. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. process connect (aka `gdb-remote`) isn't the clearest in its error messaging. We have