[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

clayborg added a comment. The changes look fine from a quick read. See inline comments Comment at: lldb/source/Commands/CommandObjectCommands.cpp:1817 + : CommandObjectParsed( +interpreter, "command multiword add", +"Add a multiword command to

[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

JDevlieghere added a comment. I did a quick pass as I was reading through the patch to understand it. I'll do another one tomorrow. Comment at: lldb/include/lldb/Interpreter/CommandCompletions.h:156-159 + // This completer works for commands whose only arguments are a

[Lldb-commits] [PATCH] D110601: Add -relative-to-command-file to "command source"

jingham added a comment. The one thing that makes me sad about this is that "command script import" chose "-c" as the short letter for this option, but "-c" was already taken for "command source", so I used -C for "command source". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D110601: Add -relative-to-command-file to "command source"

jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added a subscriber: dang. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This option was recently added to "command script import" so that an

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

shafik added a comment. Just a nitpick. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3564 + // If we start a new block, compute a new block context and recurse. + Block *block = sc.function->GetBlock(true).FindBlockByID(die.GetID()); + if

[Lldb-commits] [PATCH] D110553: [lldb] Remove non-stop mode code

krytarowski accepted this revision. krytarowski added a comment. NetBSD and FreeBSD do not support non-stop in the kernel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110553/new/ https://reviews.llvm.org/D110553

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. Hi, could you take a look at this change? Some discussion points: - In the ParseVariablesInFunctionContext method, we are using a lambda for the recursive parser. We could also use a function-local class or inner class of SymbolFileDWARF. Would any of these be

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

jingham added a comment. I'm fine with this, but I'll defer to Jonas since he had the last significant comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110115/new/ https://reviews.llvm.org/D110115

[Lldb-commits] [PATCH] D110553: [lldb] Remove non-stop mode code

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I don't think this patch added all that much value, and pretty much only worked if the non-stop threads never stopped... I think we'd have to start deeper in lldb to if we really want to

Re: [Lldb-commits] [lldb] 92b475f - [lldb] silence -Wsometimes-uninitialized warnings

Maybe this isn't the right fix - msbit and lsbit probably shouldn't be printed if to_integer returns false in the diagnostic on line 195. If that diagnostic didn't use the variables, then I don't think this'd warn? On Mon, Sep 27, 2021 at 12:38 AM Krasimir Georgiev via lldb-commits <

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: JDevlieghere. jarin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. This change fixes a problem introduced

[Lldb-commits] [PATCH] D110569: [lldb] [Process/FreeBSD] Rework arm64 register access

mgorny requested changes to this revision. mgorny added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp:73 -Status

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin added a comment. Hi, could you possibly take a look at this change? The main motivation for this patch is to move the setup of the variable list for parsing children to the DIE node that corresponds to the block containing the children. This will be particularly important for

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

bulbazord added a comment. friendly ping! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110115/new/ https://reviews.llvm.org/D110115 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: JDevlieghere. jarin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. This is in preparation for a fix of

[Lldb-commits] [PATCH] D110569: [lldb] [Process/FreeBSD] Rework arm64 register access

andrew created this revision. andrew added a reviewer: mgorny. Herald added subscribers: omjavaid, kristof.beyls, krytarowski, arichardson, emaste. andrew requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To simplify future register access

[Lldb-commits] [PATCH] D96243: [lldb] DWZ 17/17: Fix symlinked /usr/lib/debug/.build-id/**.debug files

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96243/new/ https://reviews.llvm.org/D96243

[Lldb-commits] [PATCH] D96242: [lldb] DWZ 16/17: New testcases

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96242/new/ https://reviews.llvm.org/D96242

[Lldb-commits] [PATCH] D96241: [lldb] DWZ 15/17: New testsuite category 'dwz'

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96241/new/ https://reviews.llvm.org/D96241

[Lldb-commits] [PATCH] D98826: [lldb] DWZ 14/17: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98826/new/ https://reviews.llvm.org/D98826

[Lldb-commits] [PATCH] D96240: [lldb] DWZ 13/17: Main functionality

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96240/new/ https://reviews.llvm.org/D96240

[Lldb-commits] [PATCH] D96239: [lldb] DWZ 12/17: DIERef support

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96239/new/ https://reviews.llvm.org/D96239

[Lldb-commits] [PATCH] D96238: [nfc] [lldb] DWZ 11/17: Rename TypeUnitSupportFiles -> SharedUnitSupportFiles

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96238/new/ https://reviews.llvm.org/D96238

[Lldb-commits] [PATCH] D96237: [lldb] DWZ 10/17: More support for .gnu_debugaltlink

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96237/new/ https://reviews.llvm.org/D96237

[Lldb-commits] [PATCH] D110404: [nfc] [lldb] DWZ 08/17: Use DIERef for DIEToClangType m_forward_decl_die_to_clang_type and GetForwardDeclDieToClangType()

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110404/new/ https://reviews.llvm.org/D110404

[Lldb-commits] [PATCH] D110403: [nfc] [lldb] DWZ 07/17: Use DIERef for DIEToVariableSP m_die_to_variable_sp and GetDIEToVariable()

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110403/new/ https://reviews.llvm.org/D110403

[Lldb-commits] [PATCH] D110402: [nfc] [lldb] DWZ 06/17: Use DIERef for DIEToTypePtr m_die_to_type and GetDIEToType()

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110402/new/ https://reviews.llvm.org/D110402

[Lldb-commits] [PATCH] D110401: [nfc] [lldb] DWZ 05/17: Use DIERef for DIEToDeclMap m_die_to_decl

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110401/new/ https://reviews.llvm.org/D110401

[Lldb-commits] [PATCH] D110400: [nfc] [lldb] DWZ 04/17: Use DIERef for DIEToModuleMap m_die_to_module

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110400/new/ https://reviews.llvm.org/D110400

[Lldb-commits] [PATCH] D110399: [nfc] [lldb] DWZ 03/17: Use DIERef for DIEToDeclContextMap m_die_to_decl_ctx

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110399/new/ https://reviews.llvm.org/D110399

[Lldb-commits] [PATCH] D110397: [nfc] [lldb] DWZ 02/17: Refactor DIERef for a key in llvm::DenseMap

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110397/new/ https://reviews.llvm.org/D110397

[Lldb-commits] [PATCH] D110396: [nfc] [lldb] DWZ 01/17: Remove DWARFDIE from DeclContextToDIEMap m_decl_ctx_to_die

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110396/new/ https://reviews.llvm.org/D110396

[Lldb-commits] [PATCH] D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test

andrew added a comment. Yes, I found it by trying to build the tests on FreeBSD/arm64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110545/new/ https://reviews.llvm.org/D110545 ___ lldb-commits mailing

[Lldb-commits] [lldb] 3dbf27e - [lldb] A different fix for Domain Socket tests

Author: Pavel Labath Date: 2021-09-27T18:00:27+02:00 New Revision: 3dbf27e762008757c0de7034c778d941bfeb0388 URL: https://github.com/llvm/llvm-project/commit/3dbf27e762008757c0de7034c778d941bfeb0388 DIFF: https://github.com/llvm/llvm-project/commit/3dbf27e762008757c0de7034c778d941bfeb0388.diff

[Lldb-commits] [PATCH] D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM now, thanks. I don't have an arm64 cross env handy at the time, so I'm assuming you've tested it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test

andrew updated this revision to Diff 375293. andrew added a comment. Set opt_regsets to eRegsetMaskDefault Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110545/new/ https://reviews.llvm.org/D110545 Files:

[Lldb-commits] [lldb] be2a421 - [lldb] Fix SocketTest.DomainGetConnectURI on macOS by stripping more zeroes from getpeername result

Author: Raphael Isemann Date: 2021-09-27T17:34:45+02:00 New Revision: be2a4216fc5664ae465ec3dcc32fc3d40cecfdcd URL: https://github.com/llvm/llvm-project/commit/be2a4216fc5664ae465ec3dcc32fc3d40cecfdcd DIFF:

[Lldb-commits] [PATCH] D110553: [lldb] Remove non-stop mode code

labath created this revision. labath added reviewers: jingham, JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. We added some support for this mode back in 2015, but the feature was never productionized. It is completely untested, and there are known major

[Lldb-commits] [PATCH] D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test

mgorny added inline comments. Comment at: lldb/unittests/Process/Utility/RegisterContextFreeBSDTest.cpp:328 TEST(RegisterContextFreeBSDTest, arm64) { + Flags opt_regsets; ArchSpec arch{"aarch64-unknown-freebsd"}; Maybe set it to `eRegsetMaskDefault`

[Lldb-commits] [PATCH] D110023: [lldb] [DynamicRegisterInfo] Add a convenience method to add suppl. registers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mgorny marked 3 inline comments as done. Closed by commit rG33031545bf4d: [lldb] [DynamicRegisterInfo] Add a convenience method to add suppl. registers (authored by

[Lldb-commits] [lldb] 3303154 - [lldb] [DynamicRegisterInfo] Add a convenience method to add suppl. registers

Author: Michał Górny Date: 2021-09-27T16:01:30+02:00 New Revision: 33031545bf4d8264af98e3f0ca72dbe09bc57496 URL: https://github.com/llvm/llvm-project/commit/33031545bf4d8264af98e3f0ca72dbe09bc57496 DIFF: https://github.com/llvm/llvm-project/commit/33031545bf4d8264af98e3f0ca72dbe09bc57496.diff

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young updated this revision to Diff 375240. siger-young added a comment. Add assertion functions and error status detection to remove "luaunit" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108090/new/ https://reviews.llvm.org/D108090

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

mgorny updated this revision to Diff 375238. mgorny marked an inline comment as done. mgorny added a comment. Herald added a subscriber: hiraditya. Make the function lowercase. I had to modify `IR/DataLayout.cpp` to call its own static `split()` via `::split()`. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: llvm/include/llvm/ADT/StringExtras.h:544 /// of the iterators. -class Split { - StringRef Str; - std::string SeparatorStr; - -public: - Split(StringRef NewStr, StringRef Separator) - :

[Lldb-commits] [PATCH] D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test

andrew created this revision. Herald added subscribers: omjavaid, kristof.beyls, emaste. andrew requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110545 Files:

[Lldb-commits] [PATCH] D110478: [lldb] Move StringConvert inside debugserver

This revision was automatically updated to reflect the committed changes. Closed by commit rG9da2fa277e81: [lldb] Move StringConvert inside debugserver (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 9da2fa2 - [lldb] Move StringConvert inside debugserver

Author: Michał Górny Date: 2021-09-27T14:32:42+02:00 New Revision: 9da2fa277e818e94e45b836a3d416623c838e02a URL: https://github.com/llvm/llvm-project/commit/9da2fa277e818e94e45b836a3d416623c838e02a DIFF: https://github.com/llvm/llvm-project/commit/9da2fa277e818e94e45b836a3d416623c838e02a.diff

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young added inline comments. Comment at: lldb/test/API/lua_api/lua_lldb_test.lua:3 +EXPORT_ASSERT_TO_GLOBALS = true +require('luaunit') + tammela wrote: > siger-young wrote: > > tammela wrote: > > > Could we not use an external dependency? > > > For

[Lldb-commits] [PATCH] D110410: [lldb] [Host] Refactor XML converting getters

This revision was automatically updated to reflect the committed changes. Closed by commit rG93b82f45bc3e: [lldb] [Host] Refactor XML converting getters (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D110410?vs=374829=375212#toc

[Lldb-commits] [lldb] 93b82f4 - [lldb] [Host] Refactor XML converting getters

Author: Michał Górny Date: 2021-09-27T14:26:33+02:00 New Revision: 93b82f45bc3e58a526d2486841ea6d96b407807e URL: https://github.com/llvm/llvm-project/commit/93b82f45bc3e58a526d2486841ea6d96b407807e DIFF: https://github.com/llvm/llvm-project/commit/93b82f45bc3e58a526d2486841ea6d96b407807e.diff

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

labath added inline comments. Comment at: llvm/include/llvm/ADT/StringExtras.h:544 /// of the iterators. -class Split { - StringRef Str; - std::string SeparatorStr; - -public: - Split(StringRef NewStr, StringRef Separator) - : Str(NewStr), SeparatorStr(Separator) {} -

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

tammela added inline comments. Comment at: lldb/test/API/lua_api/lua_lldb_test.lua:3 +EXPORT_ASSERT_TO_GLOBALS = true +require('luaunit') + siger-young wrote: > tammela wrote: > > Could we not use an external dependency? > > For instance in my setup it fails

[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based Split()

mgorny marked 3 inline comments as done. mgorny added a comment. Filed D110535 for suggested changes. Comment at: llvm/include/llvm/ADT/StringExtras.h:527-529 +std::pair Res = Next.split(Separator); +Current = Res.first; +Next =

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, lattner. Herald added a subscriber: dexonsmith. mgorny requested review of this revision. Herald added a project: LLVM. Optimize the iterator comparison logic to compare Current.data() pointers. Use std::tie for

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5629b5d4d41: Fix rendezvous for rebase_exec=true case (authored by emrekultursay, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d5629b5 - Fix rendezvous for rebase_exec=true case

Author: Emre Kultursay Date: 2021-09-27T13:27:27+02:00 New Revision: d5629b5d4d41ce71703105362f58dfcdbb6cc175 URL: https://github.com/llvm/llvm-project/commit/d5629b5d4d41ce71703105362f58dfcdbb6cc175 DIFF:

[Lldb-commits] [PATCH] D110023: [lldb] [DynamicRegisterInfo] Add a convenience method to add suppl. registers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is fine. The tricky thing will be deciding what to do with the x86 and arm registers which start at non-zero offsets (`ah` et al.) One thing I was considering was doing this

[Lldb-commits] [PATCH] D110410: [lldb] [Host] Refactor XML converting getters

mgorny added inline comments. Comment at: lldb/source/Host/common/XML.cpp:299-304 + std::string text; + if (GetElementText(text) && llvm::to_integer(text,value, base)) +return true; + + value = fail_value; + return false; labath wrote: > /me wonders if

[Lldb-commits] [PATCH] D110410: [lldb] [Host] Refactor XML converting getters

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Host/common/XML.cpp:299-304 + std::string text; + if (GetElementText(text) && llvm::to_integer(text,value, base)) +return true; + + value

[Lldb-commits] [PATCH] D110510: [lldb] Remove "0x" prefix from hex values in dirty-pages

labath added a reviewer: jasonmolenda. labath added a comment. Jason, I'm not sure how this came to be, but I think it's more common to not send the 0x for hex numbers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110510/new/ https://reviews.llvm.org/D110510

[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based Split()

labath added a comment. I like it as well :) Comment at: llvm/include/llvm/ADT/StringExtras.h:519 + bool operator==(const SplittingIterator ) const { +return Current == R.Current && Next == R.Next && Separator == R.Separator; + } This compares the

[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based Split()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4b71e3479bf: [llvm] [ADT] Add a range/iterator-based Split() (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [lldb] f4b71e3 - [llvm] [ADT] Add a range/iterator-based Split()

Author: Michał Górny Date: 2021-09-27T10:43:09+02:00 New Revision: f4b71e3479bfaec71ba5f4bb56c6a34357a7f938 URL: https://github.com/llvm/llvm-project/commit/f4b71e3479bfaec71ba5f4bb56c6a34357a7f938 DIFF: https://github.com/llvm/llvm-project/commit/f4b71e3479bfaec71ba5f4bb56c6a34357a7f938.diff

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young added inline comments. Comment at: lldb/test/API/lua_api/lua_lldb_test.lua:3 +EXPORT_ASSERT_TO_GLOBALS = true +require('luaunit') + tammela wrote: > Could we not use an external dependency? > For instance in my setup it fails because it couldn't find

[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based Split()

mgorny updated this revision to Diff 375162. mgorny retitled this revision from "[llvm] [ADT] Add a range/iterator-based split()" to "[llvm] [ADT] Add a range/iterator-based Split()". mgorny edited the summary of this revision. mgorny added a comment. Attempt to fix linter issues. CHANGES

[Lldb-commits] [lldb] 92b475f - [lldb] silence -Wsometimes-uninitialized warnings

Author: Krasimir Georgiev Date: 2021-09-27T09:35:58+02:00 New Revision: 92b475f0b079e125c588b121dc50116ea5d6d9f2 URL: https://github.com/llvm/llvm-project/commit/92b475f0b079e125c588b121dc50116ea5d6d9f2 DIFF: