[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

mgorny added a comment. In D110535#3028450 , @joerg wrote: > Why are all the changes from separator character to separator string > necessary or desirable? Because otherwise we'd have to resort to hacks to extend the separator's lifetime. CHANGES

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

joerg added a comment. Why are all the changes from separator character to separator string necessary or desirable? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110535/new/ https://reviews.llvm.org/D110535 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with a followup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110115/new/ https://reviews.llvm.org/D110115

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

teemperor added a comment. In D110578#3027707 , @ljmf00 wrote: > In D110578#3027692 , @teemperor > wrote: > >> Do you have commit access or should someone land this for you? > > I don't have commit access,

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

ljmf00 added a comment. In D110578#3027692 , @teemperor wrote: > Do you have commit access or should someone land this for you? I don't have commit access, although this is a stacked revision, so there are some dependent patches. Repository: rG

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

teemperor accepted this revision. teemperor added a comment. Do you have commit access or should someone land this for you? Comment at: lldb/include/lldb/Core/Mangled.h:48 +eManglingSchemeRustV0, +eManglingSchemeD }; Nit which can be fixed when

[Lldb-commits] [PATCH] D110601: Add -relative-to-command-file to "command source"

JDevlieghere added a comment. In D110601#3026363 , @jingham wrote: > The one thing that makes me sad about this is that "command script import" > chose "-c" as the short letter for this option, but "-c" was already taken > for "command source", so I

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110578/new/ https://reviews.llvm.org/D110578

[Lldb-commits] [PATCH] D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test

This revision was automatically updated to reflect the committed changes. Closed by commit rG993ada05f5a0: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test (authored by andrew, committed by emaste). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 993ada0 - [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test

Author: Andrew Turner Date: 2021-09-28T10:51:06-04:00 New Revision: 993ada05f5a05615ec16da4a69bd368529a7e5d1 URL: https://github.com/llvm/llvm-project/commit/993ada05f5a05615ec16da4a69bd368529a7e5d1 DIFF: https://github.com/llvm/llvm-project/commit/993ada05f5a05615ec16da4a69bd368529a7e5d1.diff

[Lldb-commits] [PATCH] D110619: [lldb] [DynamicRegisterInfo] Refactor SetRegisterInfo()

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rG86cd2369b6cd: [lldb] [DynamicRegisterInfo] Refactor SetRegisterInfo() (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 86cd236 - [lldb] [DynamicRegisterInfo] Refactor SetRegisterInfo()

Author: Michał Górny Date: 2021-09-28T16:47:58+02:00 New Revision: 86cd2369b6cd7eb17374fb31bccac7895fe34658 URL: https://github.com/llvm/llvm-project/commit/86cd2369b6cd7eb17374fb31bccac7895fe34658 DIFF: https://github.com/llvm/llvm-project/commit/86cd2369b6cd7eb17374fb31bccac7895fe34658.diff

[Lldb-commits] [PATCH] D110619: [lldb] [DynamicRegisterInfo] Refactor SetRegisterInfo()

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp:244 + ? ByteOffsetFromSlice(i, slice_str, byte_order) + : reg_info_dict->GetValueForKeyAsArray("composite", +

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. Just a few replies below; I am hoping to put the relevant code changes together tomorrow. In D110571#3027173 , @labath wrote: > I haven't looked at the actual code yet, so I could be off, but here are some > thoughts. > > In

[Lldb-commits] [lldb] 7866dbb - [lldb/test] Remove a check from TestLoadAfterAttach

Author: Pavel Labath Date: 2021-09-28T14:47:46+02:00 New Revision: 7866dbb261240f71c79e70d2ed52351846f795cd URL: https://github.com/llvm/llvm-project/commit/7866dbb261240f71c79e70d2ed52351846f795cd DIFF: https://github.com/llvm/llvm-project/commit/7866dbb261240f71c79e70d2ed52351846f795cd.diff

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin added a comment. Thank you for the review! Does the separate method look more reasonable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/ https://reviews.llvm.org/D110570 ___

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin updated this revision to Diff 375538. jarin added a comment. Added the `/*can_create=*/` comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/ https://reviews.llvm.org/D110570 Files:

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin updated this revision to Diff 375535. jarin added a comment. Separated ParseVariablesInFunctionContext's lambda into a method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/ https://reviews.llvm.org/D110570 Files:

[Lldb-commits] [PATCH] D110553: [lldb] Remove non-stop mode code

This revision was automatically updated to reflect the committed changes. Closed by commit rG156cb4cc64be: [lldb] Remove non-stop mode code (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110553/new/

[Lldb-commits] [lldb] 9413ead - [lldb/test] Add ability to specify environment when spawning processes

Author: Pavel Labath Date: 2021-09-28T14:13:50+02:00 New Revision: 9413ead7bcbaf5d8876ee484256df65c2846c5c9 URL: https://github.com/llvm/llvm-project/commit/9413ead7bcbaf5d8876ee484256df65c2846c5c9 DIFF: https://github.com/llvm/llvm-project/commit/9413ead7bcbaf5d8876ee484256df65c2846c5c9.diff

[Lldb-commits] [lldb] 156cb4c - [lldb] Remove non-stop mode code

Author: Pavel Labath Date: 2021-09-28T14:13:50+02:00 New Revision: 156cb4cc64bec2b72aad9848f8181b338ff19ebc URL: https://github.com/llvm/llvm-project/commit/156cb4cc64bec2b72aad9848f8181b338ff19ebc DIFF: https://github.com/llvm/llvm-project/commit/156cb4cc64bec2b72aad9848f8181b338ff19ebc.diff

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

labath added a comment. (It would also make it easier to understand the code if you could paste some dwarfdump output which illustrates the kind of debug info we're dealing with.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110571/new/

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

labath added a comment. I haven't looked at the actual code yet, so I could be off, but here are some thoughts. In D110571#3025527 , @jarin wrote: > Hi, could you take a look at this change? > > Some discussion points: > > - In the

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

labath added a comment. The patch seems reasonable to me, and is an improvement over the status quo. The thing I'm left wondering is the lambda in `ParseVariablesInFunctionContext`. It covers like 95% of the enclosing function. Could we just make a separate method for that? Repository: rG

[Lldb-commits] [PATCH] D110619: [lldb] [DynamicRegisterInfo] Refactor SetRegisterInfo()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. wow Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp:244 + ? ByteOffsetFromSlice(i, slice_str, byte_order) + :

[Lldb-commits] [PATCH] D110569: [lldb] [Process/FreeBSD] Rework arm64 register access

andrew added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp:73 -Status NativeRegisterContextFreeBSD_arm64::ReadRegisterSet(uint32_t set) { - switch (set) { - case RegisterInfoPOSIX_arm64::GPRegSet: -return

[Lldb-commits] [PATCH] D110619: [lldb] [DynamicRegisterInfo] Refactor SetRegisterInfo()

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp:244 + ? ByteOffsetFromSlice(i, slice_str, byte_order) + : reg_info_dict->GetValueForKeyAsArray("composite", +

[Lldb-commits] [PATCH] D110619: [lldb] [DynamicRegisterInfo] Refactor SetRegisterInfo()

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, teemperor, krasimir, dblaikie. mgorny requested review of this revision. Move the "slice" and "composite" handling into separate methods to avoid if/else hell. Use more LLVM types whenever possible. Replace

Re: [Lldb-commits] [lldb] 92b475f - [lldb] silence -Wsometimes-uninitialized warnings

On Tue, 2021-09-28 at 09:37 +0200, Krasimir Georgiev wrote: > Thank you David. I just initialized these variables as suggested by > the warnings, without considering this case. > Michał, could you please double check this case? Hmm, you're probably right. The diagnostic should probably print

Re: [Lldb-commits] [lldb] 92b475f - [lldb] silence -Wsometimes-uninitialized warnings

Thank you David. I just initialized these variables as suggested by the warnings, without considering this case. Michał, could you please double check this case? On Mon, Sep 27, 2021 at 9:09 PM David Blaikie wrote: > Maybe this isn't the right fix - msbit and lsbit probably shouldn't be >

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin added a comment. Thank you for taking a look, shafik@. I hope you don't mind if I address your comments later, once a full review arrives from Pavel (or Johannes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/