[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3545 + +DIEVector MergeBlockAbstractParameters(const DWARFDIE _die, + DIEVector &_dies) { labath wrote: > In llvm, we prefer

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin updated this revision to Diff 377020. jarin marked 4 inline comments as done. jarin added a comment. Addressed Pavel's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110571/new/ https://reviews.llvm.org/D110571 Files:

[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

keith updated this revision to Diff 377010. keith marked an inline comment as done. keith added a comment. Update text about resolving paths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110981/new/ https://reviews.llvm.org/D110981 Files:

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

JDevlieghere added a comment. I'm slightly worried about the switch from a unique pointer to a shared pointer. It seems like a memory region is a simple enough object that it's warranted to make a copy to avoid this change. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with a few nits that don't require re-review if they're fixed or turn out to be not relevant. Comment at:

[Lldb-commits] [PATCH] D110696: [lldb][import-std-module] Prefer the non-module diagnostics when in fallback mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fcb857746c1: [lldb][import-std-module] Prefer the non-module diagnostics when in fallback… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 6fcb857 - [lldb][import-std-module] Prefer the non-module diagnostics when in fallback mode

Author: Raphael Isemann Date: 2021-10-04T19:16:03+02:00 New Revision: 6fcb857746c19b5ed46afdf732b839082326f9d4 URL: https://github.com/llvm/llvm-project/commit/6fcb857746c19b5ed46afdf732b839082326f9d4 DIFF:

[Lldb-commits] [PATCH] D110477: [LLDB] Fix objc_clsopt_v16_t struct

JDevlieghere added a comment. In D110477#3038298 , @gAlfonso-bit wrote: > In D110477#3034438 , @JDevlieghere > wrote: > >> In D110477#3034393 , @gAlfonso-bit >> wrote:

[Lldb-commits] [PATCH] D110477: [LLDB] Fix objc_clsopt_v16_t struct

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fe771bf02d0: [LLDB] Fix objc_clsopt_v16_t struct (authored by gAlfonso-bit, committed by JDevlieghere). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 3fe771b - [LLDB] Fix objc_clsopt_v16_t struct

Author: Alfsonso Gregory Date: 2021-10-04T08:55:09-07:00 New Revision: 3fe771bf02d0318bfa12befd0be235383744439f URL: https://github.com/llvm/llvm-project/commit/3fe771bf02d0318bfa12befd0be235383744439f DIFF:

[Lldb-commits] [PATCH] D111052: [lldb] [gdb-remote] Correct st_dev values in vFile:fstat packet

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. Could you maybe add a `FIXME:` at the end of that comment to point out that the whole 'console' thing isn't implemented/supported. Probably wait and see if Pavel has any

[Lldb-commits] [PATCH] D111052: [lldb] [gdb-remote] Correct st_dev values in vFile:fstat packet

mgorny created this revision. mgorny added reviewers: teemperor, labath, krytarowski, emaste. mgorny requested review of this revision. Correct the st_dev values used by vFile:fstat packet to conform to the GDB protocol. Thanks to Raphael Isemann for noticing. https://reviews.llvm.org/D111052

[Lldb-commits] [lldb] fd9bc13 - [lldb] Fix a stray array access in Editline

Author: Pavel Labath Date: 2021-10-04T14:26:02+02:00 New Revision: fd9bc13803ee24bfa674311584126b83e059d756 URL: https://github.com/llvm/llvm-project/commit/fd9bc13803ee24bfa674311584126b83e059d756 DIFF: https://github.com/llvm/llvm-project/commit/fd9bc13803ee24bfa674311584126b83e059d756.diff

[Lldb-commits] [PATCH] D108228: Fix error handling in the libcxx std::string formatter

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D108228#2961132 , @jingham wrote: > Raphael's analysis of what the test needs is right. We always check pointers > for validity before we

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rGe77959cba777: [lldb] Add unit tests for Terminal API (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] e77959c - [lldb] Add unit tests for Terminal API

Author: Michał Górny Date: 2021-10-04T14:19:34+02:00 New Revision: e77959cba777baa6c5fba528a6f97406b43f8b64 URL: https://github.com/llvm/llvm-project/commit/e77959cba777baa6c5fba528a6f97406b43f8b64 DIFF: https://github.com/llvm/llvm-project/commit/e77959cba777baa6c5fba528a6f97406b43f8b64.diff

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/unittests/Host/CMakeLists.txt:27 +if (LLDB_ENABLE_TERMIOS AND +CMAKE_SYSTEM_NAME MATCHES "Darwin|FreeBSD|Linux|NetBSD|OpenBSD") + list(APPEND FILES labath wrote: >

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/unittests/Host/CMakeLists.txt:27 +if (LLDB_ENABLE_TERMIOS AND +CMAKE_SYSTEM_NAME MATCHES "Darwin|FreeBSD|Linux|NetBSD|OpenBSD") + list(APPEND FILES

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

labath accepted this revision. labath added a comment. Looks good, apart from some stylistic comments inline. Thank you for taking the time to do this right. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3545 + +DIEVector

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

mgorny updated this revision to Diff 376861. mgorny marked an inline comment as done. mgorny added a comment. Use `PseudoTerminal` class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110962/new/ https://reviews.llvm.org/D110962 Files: lldb/unittests/Host/CMakeLists.txt

[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

mgorny added a comment. In D110997#3039540 , @labath wrote: > Why is it important to restore the tty settings? (just asking, I have no clue > about how this is supposed to work) Well, maybe my logic is wrong but the idea is that since LLDB overrides

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

mgorny marked an inline comment as done. mgorny added a comment. In D110962#3039428 , @labath wrote: > Have you considered using the PseudoTerminal class to create the ptys ? That's really stupid of me but for some reason I've assumed that if LLDB had

[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

labath added a comment. Why is it important to restore the tty settings? (just asking, I have no clue about how this is supposed to work) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110997/new/ https://reviews.llvm.org/D110997 ___

[Lldb-commits] [lldb] 45f9795 - [lldb] [test] Terminate "process connect" connections via kill

Author: Michał Górny Date: 2021-10-04T12:29:06+02:00 New Revision: 45f9795085ee0fe6fd23129d80aad5a2ea5026a0 URL: https://github.com/llvm/llvm-project/commit/45f9795085ee0fe6fd23129d80aad5a2ea5026a0 DIFF: https://github.com/llvm/llvm-project/commit/45f9795085ee0fe6fd23129d80aad5a2ea5026a0.diff

[Lldb-commits] [PATCH] D110996: [lldb] [test] Terminate "process connect" connections via kill

This revision was automatically updated to reflect the committed changes. Closed by commit rG45f9795085ee: [lldb] [test] Terminate process connect connections via kill (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D110996: [lldb] [test] Terminate "process connect" connections via kill

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yeah, I'm not sure how this came to be. Disconnecting the platform makes no sense here, as it was never connected. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110996/new/

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

labath added a comment. Have you considered using the PseudoTerminal class to create the ptys ? Comment at: lldb/unittests/Host/CMakeLists.txt:27 +if (LLDB_ENABLE_TERMIOS AND +CMAKE_SYSTEM_NAME MATCHES "Darwin|FreeBSD|Linux|NetBSD|OpenBSD") + list(APPEND FILES

[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1079 + +Omitting the destination places the file in the debuggers current working directory.)"); } It would be more correct to say "the platform working directory"

[Lldb-commits] [lldb] 71ad0f9 - [LLDB] Skip TestClangREPL.py on Arm/AArch64 Linux

Author: Muhammad Omair Javaid Date: 2021-10-04T11:50:17+05:00 New Revision: 71ad0f9d4e5b63ccee1ee4146525940849d2c962 URL: https://github.com/llvm/llvm-project/commit/71ad0f9d4e5b63ccee1ee4146525940849d2c962 DIFF:

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

This revision was automatically updated to reflect the committed changes. Closed by commit rG601168e42037: [lldb] Refactor variable parsing (authored by jarin, committed by Jaroslav Sevcik ja...@chromium.org). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 601168e - [lldb] Refactor variable parsing

Author: Jaroslav Sevcik Date: 2021-10-04T07:58:20+02:00 New Revision: 601168e42037ac4433e74b920bb22f76d59ba420 URL: https://github.com/llvm/llvm-project/commit/601168e42037ac4433e74b920bb22f76d59ba420 DIFF: