[Lldb-commits] [PATCH] D110510: [lldb] Remove "0x" prefix from hex values in dirty-pages

This revision was automatically updated to reflect the committed changes. Closed by commit rGec2d0ded1b3f: [lldb] Remove 0x prefix from hex values in dirty-pages (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ec2d0de - [lldb] Remove "0x" prefix from hex values in dirty-pages

Author: Michał Górny Date: 2021-10-11T21:04:11+02:00 New Revision: ec2d0ded1b3fc941119935c66576329b9f43a9f1 URL: https://github.com/llvm/llvm-project/commit/ec2d0ded1b3fc941119935c66576329b9f43a9f1 DIFF: https://github.com/llvm/llvm-project/commit/ec2d0ded1b3fc941119935c66576329b9f43a9f1.diff

[Lldb-commits] [lldb] 070315d - Revert "Allow signposts to take advantage of deferred string substitution"

Author: Jonas Devlieghere Date: 2021-10-11T11:09:36-07:00 New Revision: 070315d04c6bb259ab058bd15a851124a7c7f6e6 URL: https://github.com/llvm/llvm-project/commit/070315d04c6bb259ab058bd15a851124a7c7f6e6 DIFF:

[Lldb-commits] [PATCH] D110510: [lldb] Remove "0x" prefix from hex values in dirty-pages

jasonmolenda added a comment. I'm fine with the change, it's true it's inconsistent but I also hate how we don't prefix base16 numbers in gdb RSP - so many bugs and mistakes are introduced because of it. So I'm always trying to sneak in some 0x prefixes when no one is looking. A fun one I

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

jingham added a comment. In D109738#3054058 , @vadimcn wrote: >> Is it possible to get your IDE to record the module & the address? > > I don't control the definition of the protocol (FWIW it's Microsoft's Debug > Adapter Protocol), but I'll look into

[Lldb-commits] [PATCH] D110510: [lldb] Remove "0x" prefix from hex values in dirty-pages

mgorny added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110510/new/ https://reviews.llvm.org/D110510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 6606327 - [lldb] [DynamicRegisterInfo] Support setting from vector

Author: Michał Górny Date: 2021-10-11T17:02:27+02:00 New Revision: 660632778f308e101c5c168912ed423934aa8b21 URL: https://github.com/llvm/llvm-project/commit/660632778f308e101c5c168912ed423934aa8b21 DIFF: https://github.com/llvm/llvm-project/commit/660632778f308e101c5c168912ed423934aa8b21.diff

[Lldb-commits] [lldb] 583f67c - [lldb] [ABI/AArch64] Add pseudo-regs if missing

Author: Michał Górny Date: 2021-10-11T17:02:27+02:00 New Revision: 583f67cb4eef6171326d72da8bbb3001c846bbfb URL: https://github.com/llvm/llvm-project/commit/583f67cb4eef6171326d72da8bbb3001c846bbfb DIFF: https://github.com/llvm/llvm-project/commit/583f67cb4eef6171326d72da8bbb3001c846bbfb.diff

[Lldb-commits] [lldb] 1afda54 - [lldb] [Target] Make addSupplementaryRegister() work on Register vector

Author: Michał Górny Date: 2021-10-11T17:02:27+02:00 New Revision: 1afda54f199327b3391f2b32cf4cd785cedfd94c URL: https://github.com/llvm/llvm-project/commit/1afda54f199327b3391f2b32cf4cd785cedfd94c DIFF: https://github.com/llvm/llvm-project/commit/1afda54f199327b3391f2b32cf4cd785cedfd94c.diff

[Lldb-commits] [lldb] 5849219 - [lldb] [ABI] Apply AugmentRegisterInfo() to DynamicRegisterInfo::Registers

Author: Michał Górny Date: 2021-10-11T17:02:26+02:00 New Revision: 58492191265759e952a032c0de48a9231c526b55 URL: https://github.com/llvm/llvm-project/commit/58492191265759e952a032c0de48a9231c526b55 DIFF: https://github.com/llvm/llvm-project/commit/58492191265759e952a032c0de48a9231c526b55.diff

[Lldb-commits] [PATCH] D111435: [lldb] [DynamicRegisterInfo] Support setting from vector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG660632778f30: [lldb] [DynamicRegisterInfo] Support setting from vectorRegister (authored by mgorny). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add pseudo-regs if missing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG583f67cb4eef: [lldb] [ABI/AArch64] Add pseudo-regs if missing (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D111295: [lldb] [Target] Make addSupplementaryRegister() work on Register vector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1afda54f1993: [lldb] [Target] Make addSupplementaryRegister() work on Register vector (authored by mgorny). Herald added a project: LLDB. Changed

[Lldb-commits] [PATCH] D111142: [lldb] [ABI] Apply AugmentRegisterInfo() to DynamicRegisterInfo::Registers

This revision was automatically updated to reflect the committed changes. Closed by commit rG584921912657: [lldb] [ABI] Apply AugmentRegisterInfo() to DynamicRegisterInfo::Registers (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add pseudo-regs if missing

mgorny marked 3 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp:112-118 + for (int i = 0; i < 32; i++) { +x_regs[i] = LLDB_INVALID_REGNUM; +v_regs[i] = LLDB_INVALID_REGNUM; +have_w_regs[i] = false; +

[Lldb-commits] [lldb] 8249e50 - [lldb][NFC] Remove unnecessary reference from ParseChildMembers's default_accessibility parameter

Author: Raphael Isemann Date: 2021-10-11T15:43:49+02:00 New Revision: 8249e50bf4286deee314e36ce7e67f38bcd79db2 URL: https://github.com/llvm/llvm-project/commit/8249e50bf4286deee314e36ce7e67f38bcd79db2 DIFF:

[Lldb-commits] [PATCH] D111494: [lldb][NFCI] Refactor out attribute parsing from DWARFASTParserClang::ParseSingleMember

This revision was automatically updated to reflect the committed changes. Closed by commit rGf110999bf6b5: [lldb][NFCI] Refactor out attribute parsing from DWARFASTParserClang… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] f110999 - [lldb][NFCI] Refactor out attribute parsing from DWARFASTParserClang::ParseSingleMember

Author: Raphael Isemann Date: 2021-10-11T14:41:20+02:00 New Revision: f110999bf6b5fe1b5e2b945ea462003655f034d0 URL: https://github.com/llvm/llvm-project/commit/f110999bf6b5fe1b5e2b945ea462003655f034d0 DIFF:

[Lldb-commits] [PATCH] D111496: [lldb] [test] Rewrite g/p/G/P tests not to rely on hardcoded ARM regs

This revision was automatically updated to reflect the committed changes. Closed by commit rG270c989f6fef: [lldb] [test] Rewrite g/p/G/P tests not to rely on hardcoded ARM regs (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 270c989 - [lldb] [test] Rewrite g/p/G/P tests not to rely on hardcoded ARM regs

Author: Michał Górny Date: 2021-10-11T14:07:28+02:00 New Revision: 270c989f6fef3bc336f7a4238754faa7c5993d3d URL: https://github.com/llvm/llvm-project/commit/270c989f6fef3bc336f7a4238754faa7c5993d3d DIFF: https://github.com/llvm/llvm-project/commit/270c989f6fef3bc336f7a4238754faa7c5993d3d.diff

[Lldb-commits] [PATCH] D111435: [lldb] [DynamicRegisterInfo] Support setting from vector

mgorny updated this revision to Diff 378626. mgorny marked 2 inline comments as done. mgorny added a comment. Use fancy move semantics and `ASSERT_NE`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111435/new/ https://reviews.llvm.org/D111435 Files:

[Lldb-commits] [PATCH] D111489: [lldb] [DynamicRegisterInfo] Support value_regs with offset

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/unittests/Target/DynamicRegisterInfoTest.cpp:203-214 + ASSERT_REG(rax, {}, {eax, ax, ah, al}); + ASSERT_REG(eax, {rax}, {rax, ax, ah, al}); +

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add pseudo-regs if missing

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp:112-118 + for (int i = 0; i < 32; i++) { +x_regs[i] = LLDB_INVALID_REGNUM; +v_regs[i] =

[Lldb-commits] [PATCH] D108629: [lldb] Add support for DW_AT_calling_convention to the DWARF parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3256aa8fe6fd: [lldb] Add support for DW_AT_calling_convention to the DWARF parser (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [lldb] 3256aa8 - [lldb] Add support for DW_AT_calling_convention to the DWARF parser

Author: Raphael Isemann Date: 2021-10-11T13:44:10+02:00 New Revision: 3256aa8fe6fd785df12cc39f95e55bef0bc371c2 URL: https://github.com/llvm/llvm-project/commit/3256aa8fe6fd785df12cc39f95e55bef0bc371c2 DIFF:

[Lldb-commits] [PATCH] D111149: [lldb] Don't print to stderr in TypeSystemClang::GetBuiltinTypeForDWARFEncodingAndBitSize

This revision was automatically updated to reflect the committed changes. Closed by commit rG592e89cc4e9a: [lldb] Dont print to stderr in TypeSystemClang… (authored by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [lldb] 592e89c - [lldb] Don't print to stderr in TypeSystemClang::GetBuiltinTypeForDWARFEncodingAndBitSize

Author: Raphael Isemann Date: 2021-10-11T13:33:47+02:00 New Revision: 592e89cc4e9a7d184e16d4c61abcbcb62cf7e6ed URL: https://github.com/llvm/llvm-project/commit/592e89cc4e9a7d184e16d4c61abcbcb62cf7e6ed DIFF:

[Lldb-commits] [PATCH] D111498: [lldb] [DynamicRegisterInfo] Remove AddRegister() and make Finalize() protected

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM (assuming parent diffs are merged) :P CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111498/new/ https://reviews.llvm.org/D111498 ___

[Lldb-commits] [PATCH] D111435: [lldb] [DynamicRegisterInfo] Support setting from vector

labath added inline comments. Comment at: lldb/unittests/Target/DynamicRegisterInfoTest.cpp:176-178 +EXPECT_NE(reg, nullptr); +if (!reg) + return; mgorny wrote: > labath wrote: > > ASSERT_NE(reg, nullptr); > Actually, the idea was to test all

[Lldb-commits] [PATCH] D111435: [lldb] [DynamicRegisterInfo] Support setting from vector

mgorny added inline comments. Comment at: lldb/unittests/Target/DynamicRegisterInfoTest.cpp:176-178 +EXPECT_NE(reg, nullptr); +if (!reg) + return; labath wrote: > ASSERT_NE(reg, nullptr); Actually, the idea was to test all registers even if one

[Lldb-commits] [PATCH] D111399: [lldb] Make char[N] formatters respect the end of the array (PR44649)

This revision was automatically updated to reflect the committed changes. Closed by commit rG8093c2ea574b: [lldb] Make char[N] formatters respect the end of the array (PR44649) (authored by labath). Changed prior to commit: https://reviews.llvm.org/D111399?vs=378162=378616#toc Repository:

[Lldb-commits] [PATCH] D111399: [lldb] Make char[N] formatters respect the end of the array (PR44649)

labath added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:39 + //% self.expect_var_path('constcharstar', summary='"Hello\t\tWorld\nI am here\t\tto say hello\n"') //%

[Lldb-commits] [lldb] 8093c2e - [lldb] Make char[N] formatters respect the end of the array (PR44649)

Author: Pavel Labath Date: 2021-10-11T12:47:11+02:00 New Revision: 8093c2ea574b9f7cbeb6c150f6584446cfd93517 URL: https://github.com/llvm/llvm-project/commit/8093c2ea574b9f7cbeb6c150f6584446cfd93517 DIFF: https://github.com/llvm/llvm-project/commit/8093c2ea574b9f7cbeb6c150f6584446cfd93517.diff

[Lldb-commits] [PATCH] D111435: [lldb] [DynamicRegisterInfo] Support setting from vector

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Target/DynamicRegisterInfo.cpp:394-395 + +for (uint32_t value_reg : reg.value_regs) +

[Lldb-commits] [PATCH] D111408: [lldb] [DynamicRegisterInfo] Remove non-const GetRegisterInfoAtIndex()

This revision was automatically updated to reflect the committed changes. Closed by commit rG36195d7d80e3: [lldb] [DynamicRegisterInfo] Remove non-const GetRegisterInfoAtIndex() (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D111396: [lldb] [ConnectionFileDescriptorPosix] Combine m_read_sp & m_write_sp

This revision was automatically updated to reflect the committed changes. Closed by commit rGfee461b1d830: [lldb] [ConnectionFileDescriptorPosix] Combine m_read_sp m_write_sp (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] fee461b - [lldb] [ConnectionFileDescriptorPosix] Combine m_read_sp & m_write_sp

Author: Michał Górny Date: 2021-10-11T12:08:08+02:00 New Revision: fee461b1d830564048c09aef90631b1d4be4e450 URL: https://github.com/llvm/llvm-project/commit/fee461b1d830564048c09aef90631b1d4be4e450 DIFF: https://github.com/llvm/llvm-project/commit/fee461b1d830564048c09aef90631b1d4be4e450.diff

[Lldb-commits] [lldb] 36195d7 - [lldb] [DynamicRegisterInfo] Remove non-const GetRegisterInfoAtIndex()

Author: Michał Górny Date: 2021-10-11T12:08:38+02:00 New Revision: 36195d7d80e37063ef7f1fbc6c1970e515bb502c URL: https://github.com/llvm/llvm-project/commit/36195d7d80e37063ef7f1fbc6c1970e515bb502c DIFF: https://github.com/llvm/llvm-project/commit/36195d7d80e37063ef7f1fbc6c1970e515bb502c.diff

[Lldb-commits] [PATCH] D111408: [lldb] [DynamicRegisterInfo] Remove non-const GetRegisterInfoAtIndex()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111408/new/ https://reviews.llvm.org/D111408 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D111396: [lldb] [ConnectionFileDescriptorPosix] Combine m_read_sp & m_write_sp

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. seems like a nice cleanup CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111396/new/ https://reviews.llvm.org/D111396 ___ lldb-commits

[Lldb-commits] [lldb] 483db1c - [LLDB] Remove xfail decorator TestInferiorAssert.py AArch64/Linux

Author: Muhammad Omair Javaid Date: 2021-10-11T14:41:30+05:00 New Revision: 483db1c706864d0940206228dfe64bdcd17faa4e URL: https://github.com/llvm/llvm-project/commit/483db1c706864d0940206228dfe64bdcd17faa4e DIFF:

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:203 + +m_register_info_sp = std::make_shared( +*reg_info, m_scripted_process.GetTarget().GetArchitecture()); Hi This fails on arm and aarch64 linux

[Lldb-commits] [lldb] c63cb0c - [LLDB] Skip TestScriptedProcess on Arm/AArch64 Linux

Author: Muhammad Omair Javaid Date: 2021-10-11T12:58:21+05:00 New Revision: c63cb0c80ec7eb2dedad6e89fb9a3042b71d3b0f URL: https://github.com/llvm/llvm-project/commit/c63cb0c80ec7eb2dedad6e89fb9a3042b71d3b0f DIFF:

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

serhiy.redko updated this revision to Diff 378575. serhiy.redko added a comment. - added printing of unused target related fields from launch.json in case launchCommands/attachCommands fields are provided. - updated help info in for launch/attach fields according to review request. CHANGES