[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size,

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size, record->Name);

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size,

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size,

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size, record->Name);

[Lldb-commits] [PATCH] D113174: [lldb] Summary provider for char flexible array members

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Regex Type summary matching happens after all the ConstString format matching. Enrico did it that way because the ConstString matching is so much quicker, so if we can find a match there

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size,

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu updated this revision to Diff 384815. zequanwu marked an inline comment as done. zequanwu added a comment. Add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113163/new/ https://reviews.llvm.org/D113163 Files:

[Lldb-commits] [lldb] 3120cad - [debugserver] Fix typo in DNBArchImplARM64

Author: Jonas Devlieghere Date: 2021-11-04T09:43:50-07:00 New Revision: 3120cadac782cd51f88f52dd2e88a20a6aa77b4b URL: https://github.com/llvm/llvm-project/commit/3120cadac782cd51f88f52dd2e88a20a6aa77b4b DIFF:

[Lldb-commits] [PATCH] D113184: [lldb] Fix cross-platform kills

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/functionalities/gdb_remote_client/TestPlatformKill.py:17-27 +class MyResponder(MockGDBServerResponder): +def

[Lldb-commits] [PATCH] D113186: [NFC] Inclusive language: Remove instances of master in URLs

quinnp created this revision. Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, usaxena95,

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added a comment. @nib Sorry for not catching this myself. I must admit the error does confuse me. I have an macOS machine I can ssh to, and yes, if if you had some tips on how to reproduce there I would greatly appreciate them. Thanks. Comment at:

[Lldb-commits] [lldb] f6b7bcc - [lldb][NFC] StringRef-ify name param in CreateClassTemplateDecl

Author: Raphael Isemann Date: 2021-11-04T15:28:02+01:00 New Revision: f6b7bcc64a6a3f4008839777f71d2f132f74ec85 URL: https://github.com/llvm/llvm-project/commit/f6b7bcc64a6a3f4008839777f71d2f132f74ec85 DIFF:

[Lldb-commits] [PATCH] D113175: [lldb][NFC] Remove a bunch of unnecessary nullptr checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG7323d07483f2: [lldb][NFC] Remove a bunch of unnecessary nullptr checks (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 7323d07 - [lldb][NFC] Remove a bunch of unnecessary nullptr checks

Author: Raphael Isemann Date: 2021-11-04T15:21:03+01:00 New Revision: 7323d07483f201b2d73009deef45d2eff4dcd856 URL: https://github.com/llvm/llvm-project/commit/7323d07483f201b2d73009deef45d2eff4dcd856 DIFF:

[Lldb-commits] [PATCH] D113176: [lldb][NFC] StringRef-ify the name parameter in CreateEnumerationType

This revision was automatically updated to reflect the committed changes. Closed by commit rGb738a69ab8e3: [lldb][NFC] StringRef-ify the name parameter in CreateEnumerationType (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] b738a69 - [lldb][NFC] StringRef-ify the name parameter in CreateEnumerationType

Author: Raphael Isemann Date: 2021-11-04T14:49:16+01:00 New Revision: b738a69ab8e3da2d48fdf41aa1fa5a5673a7d3a1 URL: https://github.com/llvm/llvm-project/commit/b738a69ab8e3da2d48fdf41aa1fa5a5673a7d3a1 DIFF:

[Lldb-commits] [PATCH] D113165: [LIT] Add win32 PLATFORM env var to test config

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbd215dfe51d: [LIT] Add win32 PLATFORM env var to test config (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112471: [LLDB] Fix Cpsr size for WoA64 target

This revision was automatically updated to reflect the committed changes. Closed by commit rGb595137fe1c0: [LLDB] Fix Cpsr size for WoA64 target (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] b595137 - [LLDB] Fix Cpsr size for WoA64 target

Author: Muhammad Omair Javaid Date: 2021-11-04T17:43:31+05:00 New Revision: b595137fe1c06c6fd72ad3c5b30a7750eeca07c1 URL: https://github.com/llvm/llvm-project/commit/b595137fe1c06c6fd72ad3c5b30a7750eeca07c1 DIFF:

[Lldb-commits] [lldb] cbd215d - [LIT] Add win32 PLATFORM env var to test config

Author: Muhammad Omair Javaid Date: 2021-11-04T17:42:43+05:00 New Revision: cbd215dfe51df47e020c676a32c2672c573641a8 URL: https://github.com/llvm/llvm-project/commit/cbd215dfe51df47e020c676a32c2672c573641a8 DIFF:

[Lldb-commits] [PATCH] D113184: [lldb] Fix cross-platform kills

labath created this revision. labath added reviewers: JDevlieghere, jingham. labath requested review of this revision. Herald added a project: LLDB. This patch fixes an amusing bug where a Platform::Kill operation would happily terminate a proces on a completely different platform, as long as

[Lldb-commits] [PATCH] D113174: [lldb] Summary provider for char flexible array members

labath created this revision. labath added reviewers: teemperor, shafik. labath requested review of this revision. Herald added a project: LLDB. Add a summary provider which can print char[] members at the ends of structs. Depends on D112709 . Repository: rG

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/test/API/python_api/file_handle/TestFileHandle.py:920 +self.assertTrue(re.search(r'Show a list of all debugger commands',

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

lawrence_danna added a comment. @stella.stamenova fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/ https://reviews.llvm.org/D113047 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 531d877 - [lldb] Fix TestEchoCommands.test again

Author: Lawrence D'Anna Date: 2021-11-04T01:24:25-07:00 New Revision: 531d877ee6410a94f5b4cb888d3c785d6ef0552c URL: https://github.com/llvm/llvm-project/commit/531d877ee6410a94f5b4cb888d3c785d6ef0552c DIFF:

[Lldb-commits] [PATCH] D113165: [LIT] Add win32 PLATFORM env var to test config

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113165/new/ https://reviews.llvm.org/D113165 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size, record->Name);

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

labath added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:558 +struct CompatibleArchs { + const char **archs = nullptr; Is this any different from an `ArrayRef`? Comment at:

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Nice cleanup of this table that's been growing over the years. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113155/new/ https://reviews.llvm.org/D113155

[Lldb-commits] [PATCH] D113159: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yep, looks good, we can't hardcode the OS in this triple, we might be getting iOS or macOS binaries and should accept any OS these days. CHANGES SINCE LAST ACTION