[Lldb-commits] [PATCH] D114967: [lldb] [Process/elf-core] Disable for FreeBSD vmcores

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp:67 if (elf_header.Parse(data, _offset)) { +// Check whether we're dealing with a FreeBSD vmcore that needs +// to be handled via FreeBSDKernel plugin instead.

[Lldb-commits] [PATCH] D114967: [lldb] [Process/elf-core] Disable for FreeBSD vmcores

mgorny updated this revision to Diff 391809. mgorny marked an inline comment as done. mgorny added a comment. Fix thinko. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114967/new/ https://reviews.llvm.org/D114967 Files: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp

[Lldb-commits] [PATCH] D114967: [lldb] [Process/elf-core] Disable for FreeBSD vmcores

mgorny updated this revision to Diff 391808. mgorny added a comment. Try making the comment more precise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114967/new/ https://reviews.llvm.org/D114967 Files: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp Index:

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 391777. zequanwu added a comment. Fix stale comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://reviews.llvm.org/D113930 Files:

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/find-functions.cpp:89 +// FIND-OVERLOAD: FuncType: id = {{.*}}, compiler_type = "int (void)" +// FIND-OVERLOAD: FuncType: id = {{.*}}, compiler_type = "int

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 391775. zequanwu added a comment. Deduplicate method decls in a class/struct by method's name and CompilerType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://reviews.llvm.org/D113930

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

clayborg updated this revision to Diff 391772. clayborg added a comment. Fixed "DataEncoder::Append*" methods so they return false correctly when used on caller owned buffer objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115073/new/

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

clayborg updated this revision to Diff 391768. clayborg added a comment. Update headerdoc comments and enable clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115073/new/ https://reviews.llvm.org/D115073 Files:

[Lldb-commits] [lldb] fddedca - [NFC] const-ify some methods on CommandReturnObject

Author: Jordan Rupprecht Date: 2021-12-03T14:54:03-08:00 New Revision: fddedcaeb8de067d2e349c7001ccd28061eacc5e URL: https://github.com/llvm/llvm-project/commit/fddedcaeb8de067d2e349c7001ccd28061eacc5e DIFF:

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1356 +clang::AccessSpecifier previous_access = clang::AccessSpecifier::AS_none; +for (DeclContext::decl_iterator I =

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

zequanwu updated this revision to Diff 391740. zequanwu added a comment. Use a map to keep CXXRecordDecl to last added AccessSpecifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115062/new/ https://reviews.llvm.org/D115062 Files:

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

zequanwu updated this revision to Diff 391734. zequanwu added a comment. Add tests for alternating access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115062/new/ https://reviews.llvm.org/D115062 Files:

[Lldb-commits] [PATCH] D114967: [lldb] [Process/elf-core] Disable for FreeBSD vmcores

emaste added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp:67 if (elf_header.Parse(data, _offset)) { +// Check whether we're dealing with a FreeBSD vmcore that needs +// to be handled via FreeBSDKernel plugin instead.

[Lldb-commits] [PATCH] D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests

emaste accepted this revision. emaste added a comment. Fine with me, or maybe "A test for Darwin- (and prehaps Windows-)specific behavior." CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90876/new/ https://reviews.llvm.org/D90876 ___

[Lldb-commits] [PATCH] D115074: [lldb/lua] Suppress warnings about C-linkage in generated wrapper

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. We should move this from the wrapper to the header block, similar to what Pavel did for Python: https://reviews.llvm.org/rG9a14adeae00015798843ff5cad987e5fdbdddb34

[Lldb-commits] [PATCH] D115074: [lldb/lua] Suppress warnings about C-linkage in generated wrapper

dim created this revision. dim added reviewers: tammela, siger-young, emaste. dim requested review of this revision. Herald added a project: LLDB. When lldb Lua bindings are enabled, the generated `LLDBWrapLua.cpp` file generates a compiler warning about C-linkage:

[Lldb-commits] [PATCH] D115073: Modify DataEncoder to be able to encode data in an object owned buffer.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, aadsm, wallace. Herald added a subscriber: mgorny. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DataEncoder was previously made to modify data

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

shafik added a comment. I would like to see more extensive test cases, for example alternating `public` and `private` specifiers for both `class` and `struct` case. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1356 +clang::AccessSpecifier

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

zequanwu created this revision. zequanwu added reviewers: shafik, labath, teemperor. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This allows access type be printed when running `lldb-test -dump-ast` and `lldb-test

Re: [Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

Thanks for doing that! I was able to successfully run the test on linux, and then I added extra context to the stop. It seems that the two breakpoints are set correctly, but the second breakpoint is not hit and the program exits. So all is good from the symbol table changes as far as I have

[Lldb-commits] [PATCH] D115017: Fix error reporting for "process load" and add a test for it.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115017/new/ https://reviews.llvm.org/D115017

Re: [Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

On Fri, 3 Dec 2021 at 04:50, Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg added a comment. > > In D114288#3165212 , @clayborg > wrote: > > > In D114288#3163808 , > @omjavaid wrote: >

[Lldb-commits] [lldb] 8079236 - [LLDB] XFAIL on Arm/Linux minidebuginfo-set-and-hit-breakpoint.test

Author: Muhammad Omair Javaid Date: 2021-12-03T21:52:21+05:00 New Revision: 80792368bb87eeb9e2042e37337e0f5b1e5abc4b URL: https://github.com/llvm/llvm-project/commit/80792368bb87eeb9e2042e37337e0f5b1e5abc4b DIFF:

[Lldb-commits] [PATCH] D115033: [lldb-vscode] Report supportsModulesRequest=true

This revision was automatically updated to reflect the committed changes. Closed by commit rG049530129326: [lldb-vscode] Report supportsModulesRequest=true (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115033/new/

[Lldb-commits] [lldb] 0495301 - [lldb-vscode] Report supportsModulesRequest=true

Author: Andy Yankovsky Date: 2021-12-03T16:07:48+01:00 New Revision: 049530129326f9b0bfa9ce6a762c6cb180974ac5 URL: https://github.com/llvm/llvm-project/commit/049530129326f9b0bfa9ce6a762c6cb180974ac5 DIFF:

[Lldb-commits] [PATCH] D115033: [lldb-vscode] Report supportsModulesRequest=true

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115033/new/ https://reviews.llvm.org/D115033

[Lldb-commits] [PATCH] D114911: [lldb] Introduce a FreeBSDKernel plugin for vmcores

mgorny updated this revision to Diff 391613. mgorny retitled this revision from "[lldb] Introduce absolutely minimal FreeBSDKernel plugin" to "[lldb] Introduce a FreeBSDKernel plugin for vmcores". mgorny edited the summary of this revision. mgorny added a comment. Herald added a subscriber:

[Lldb-commits] [PATCH] D115033: [lldb-vscode] Report supportsModulesRequest=true

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The adapter does support `Modules` request, implemented in 39239f9 . Repository:

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. @shafik ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org