[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

thakis added a comment. Thanks for this change! I always wondered why this strange lldbBase target existed in lldb/source instead of what's now done in this patch. Comment at: lldb/source/CMakeLists.txt:4 -set(lldbBase_SOURCES -lldb.cpp - ) should lldb.cp

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

This revision was automatically updated to reflect the committed changes. Closed by commit rGedf410e48f5b: [lldb/Target] Slide source display for artificial locations at function start (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] edf410e - [lldb/Target] Slide source display for artificial locations at function start

Author: Med Ismail Bennani Date: 2021-12-08T15:25:29-08:00 New Revision: edf410e48f5b5ec8e5f7b4cb6c9b578c1e0a067f URL: https://github.com/llvm/llvm-project/commit/edf410e48f5b5ec8e5f7b4cb6c9b578c1e0a067f DIFF: https://github.com/llvm/llvm-project/commit/edf410e48f5b5ec8e5f7b4cb6c9b578c1e0a067f.

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib updated this revision to Diff 392949. mib marked an inline comment as done. mib added a comment. Address @JDevlieghere comment regarding test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115313 Files: lldb/source/Target/StackFrame.cpp lld

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

JDevlieghere added inline comments. Comment at: lldb/test/API/source-manager/TestSourceManager.py:279 +substrs=['stop reason = breakpoint', '%s:%d' % (src_file,0), + 'Warning: the current PC is an artificial location']) +

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That looks right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115313

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib updated this revision to Diff 392947. mib added a comment. Dropping the `LLDB_INVALID_LINE_NUMBER` check as it should only occur when we have no debug info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

This revision was automatically updated to reflect the committed changes. Closed by commit rGccf1469a4cdb: [lldb] Make lldbVersion a full fledged library (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] ccf1469 - [lldb] Make lldbVersion a full fledged library

Author: Jonas Devlieghere Date: 2021-12-08T15:14:34-08:00 New Revision: ccf1469a4cdb03cb2bc7868f76164e85d90ebee1 URL: https://github.com/llvm/llvm-project/commit/ccf1469a4cdb03cb2bc7868f76164e85d90ebee1 DIFF: https://github.com/llvm/llvm-project/commit/ccf1469a4cdb03cb2bc7868f76164e85d90ebee1.d

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib updated this revision to Diff 392943. mib added a comment. Update the condition for printing the warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115313 Files: lldb/source/Target/StackFrame.cpp l

[Lldb-commits] [PATCH] D115308: [LLDB][DWARF] Fix duplicate TypeSP in type list

zequanwu updated this revision to Diff 392932. zequanwu added a comment. I found that is actually a problem in TypeList. We need to uniquify Type in TypeList. - Use an additional set of `Type*` to check if it exists or not. - Print number of types in TypeList. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib updated this revision to Diff 392915. mib marked an inline comment as done. mib added a comment. Address @jingham feedbacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115313 Files: lldb/source/Target/StackFrame.cpp lldb/test/API/source-

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/source/Target/StackFrame.cpp:1898 have_source = true; - // TODO: Give here a one time warning if source file is missing. + if (!num_lines || !m_sc.line_entry.line || +

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. Just giving this a gentle nudge again. As I said before, there's no rush, but if there's any action I can take to get this landed, please let me know. Many thanks again, ben. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D115126: [LLDB] Add unit tests for Editline keyboard shortcuts

nealsid added a comment. Thank you, Pavel - will address the specific code feedback in subsequent patch. In D115126#3178906 , @labath wrote: > Well.. I would say that the most user-facing aspect is the /action/ that > happens after the user pressed the

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I don't think the num_lines check is handled correctly. Comment at: lldb/source/Target/StackFrame.cpp:1898 have_source = true; - // TODO: Gi

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib updated this revision to Diff 392834. mib retitled this revision from "[lldb/Target] Slide source display for artificial location at function start" to "[lldb/Target] Slide source display for artificial locations at function start". mib added a comment. Change warning to specify function nam

[Lldb-commits] [lldb] 81f4874 - Silence format string warning harder.

Author: Benjamin Kramer Date: 2021-12-08T19:37:32+01:00 New Revision: 81f4874cbf35fcbd220cda4d4fafedffdb909e3a URL: https://github.com/llvm/llvm-project/commit/81f4874cbf35fcbd220cda4d4fafedffdb909e3a DIFF: https://github.com/llvm/llvm-project/commit/81f4874cbf35fcbd220cda4d4fafedffdb909e3a.dif

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial location at function start

mib added a subscriber: DavidSpickett. mib added a comment. In D115313#3178578 , @dblaikie wrote: > Side note: The src_file is not to be trusted/used either - once line 0 is > specified, nothing else in that line entry is valid. LLVM lets the previous >

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. great job! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D115178 ___

[Lldb-commits] [lldb] 906e60b - lldb: silence a warning on the Windows error path (NFCI)

Author: Saleem Abdulrasool Date: 2021-12-08T09:01:10-08:00 New Revision: 906e60b9f923464cba0f71a9205846550752162f URL: https://github.com/llvm/llvm-project/commit/906e60b9f923464cba0f71a9205846550752162f DIFF: https://github.com/llvm/llvm-project/commit/906e60b9f923464cba0f71a9205846550752162f.

[Lldb-commits] [lldb] ae316ac - [lldb/qemu] Sort entries in QEMU_(UN)SET_ENV

Author: Pavel Labath Date: 2021-12-08T15:56:32+01:00 New Revision: ae316ac66430997e342772fc4629c1acece0 URL: https://github.com/llvm/llvm-project/commit/ae316ac66430997e342772fc4629c1acece0 DIFF: https://github.com/llvm/llvm-project/commit/ae316ac66430997e342772fc4629c1acece0.diff

[Lldb-commits] [PATCH] D115277: [lldb] Workaround for type-like entities defined in a lexical block

krisb added a comment. In D115277#3178248 , @jingham wrote: > I worry this makes the case where a function has two definitions of the same > type in one function a more confusing error than the "can't find type" error > you would get without this patch.

[Lldb-commits] [PATCH] D114911: [lldb] Introduce a FreeBSDKernel plugin for vmcores

mgorny updated this revision to Diff 392723. mgorny added a comment. Add the tool to create sparse vmcores. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114911/new/ https://reviews.llvm.org/D114911 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/packages/Python/lldbsuite/test/lldb

[Lldb-commits] [lldb] 88c183e - [lldb] Fix TestDataFormatterGenericList

Author: Pavel Labath Date: 2021-12-08T13:38:35+01:00 New Revision: 88c183e978ed0aeaaf9d10d5b2554ba0244b372f URL: https://github.com/llvm/llvm-project/commit/88c183e978ed0aeaaf9d10d5b2554ba0244b372f DIFF: https://github.com/llvm/llvm-project/commit/88c183e978ed0aeaaf9d10d5b2554ba0244b372f.diff

[Lldb-commits] [lldb] 5ce0f87 - [lldb] Unify two versions of TestMemoryRead

Author: Pavel Labath Date: 2021-12-08T13:27:56+01:00 New Revision: 5ce0f876326168425eea37268721e7602094b6fc URL: https://github.com/llvm/llvm-project/commit/5ce0f876326168425eea37268721e7602094b6fc DIFF: https://github.com/llvm/llvm-project/commit/5ce0f876326168425eea37268721e7602094b6fc.diff

[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

This revision was automatically updated to reflect the committed changes. Closed by commit rG45aa435661d8: [lldb/qemu] Separate host and target environments (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115246/new/ https://revi

[Lldb-commits] [lldb] 45aa435 - [lldb/qemu] Separate host and target environments

Author: Pavel Labath Date: 2021-12-08T13:08:19+01:00 New Revision: 45aa435661d80843554d425156f300b207d8a0a0 URL: https://github.com/llvm/llvm-project/commit/45aa435661d80843554d425156f300b207d8a0a0 DIFF: https://github.com/llvm/llvm-project/commit/45aa435661d80843554d425156f300b207d8a0a0.diff

[Lldb-commits] [lldb] 3a870bf - [lldb] Add missing space in C string format memory read warning

Author: David Spickett Date: 2021-12-08T11:20:25Z New Revision: 3a870bffb108516bc1c09818538466db4f1a505d URL: https://github.com/llvm/llvm-project/commit/3a870bffb108516bc1c09818538466db4f1a505d DIFF: https://github.com/llvm/llvm-project/commit/3a870bffb108516bc1c09818538466db4f1a505d.diff LOG

[Lldb-commits] [PATCH] D114877: [lldb] Add missing space in C string format memory read warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a870bffb108: [lldb] Add missing space in C string format memory read warning (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1148

[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

labath added a comment. Thanks for all the reviews. I'll probably take a break with this now. I'll need to integrate the existing stuff into our internal infrastructure before adding more features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115

[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp:139 + // The actual QEMU_(UN)SET_ENV variables should not be forwarded to the + // target. + if (!set_env.empty()) { D

[Lldb-commits] [PATCH] D115126: [LLDB] Add unit tests for Editline keyboard shortcuts

labath added a comment. Well.. I would say that the most user-facing aspect is the /action/ that happens after the user pressed the appropriate key. But at the end of the day, that doesn't matter that much -- we can (and do) test non-user-facing interfaces as well. But those tests make most sen

[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM assuming that qemu passing on the SET/UNSET vars is what you've observed. Comment at: lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp:139 + //

[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

labath updated this revision to Diff 392680. labath marked an inline comment as done. labath added a comment. - add some explanatory comments - make the function return a new environment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115246/new/ htt

[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

labath marked 3 inline comments as done. labath added inline comments. Comment at: lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp:127 + for (const auto &KV : host) { +if (target.count(KV.first()) == 0) + unset_env.push_back(KV.first()); Davi

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.This is an updated version of the https://reviews.llvm.org/D113789 patc

clayborg created this revision. clayborg added reviewers: jingham, labath, wallace, JDevlieghere. Herald added a subscriber: mgorny. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ...cache files - Use LLVM caching and cache pruni